Re: wined3d: SetDepthStencilSurface is always called when AutoDepthStencil is enabled

2009-03-26 Thread Henri Verbeet
2009/3/27 David Adam : > Fixes bug 16846. > Could you include the test as well?

Re: SOC 2009: Application Test Suite

2009-03-26 Thread Austin English
On Thu, Mar 26, 2009 at 6:33 AM, Scott Ritchie wrote: > You don't need wget - just have autohotkey install the web browser, open a > webpage, and then download the files by point and click ;) That's got a large potential for breaking on different resolutions/setups. Vincent pointed out to me tha

Re: SOC 2009: Application Test Suite

2009-03-26 Thread Austin English
2009/3/26 Vít Hrachový : > Austin English wrote: >> >> I was more interested in a quick proof of concept. The flexibility of >> autohotkey allows for lots of different methods for doing such things, >> and a method that involves the majority of code being run under AHK >> itself (and therefore on w

Re: comctl32: Fix bitmap size calculation

2009-03-26 Thread Vitaliy Margolen
Aleksey Bragin wrote: > Fix bitmap size calculation in IMAGELIST_InternalExpandBitmaps and > remove unneded parameter. Memory requirements are greatly reduced after > this fix. > > The bug was an ambiguous meaning of a cx parameter, which was supposed > to be a width of an individual image inside

Re: shell32: Implement IDD_MAKENEWFOLDER.

2009-03-26 Thread Juan Lang
Hi John, a few problems with this one: -{ +{ This whitespace-only change isn't needed for your patch, please omit it. +if (info->pidlRet == NULL) +return FALSE; +{ This is poor style, IMHO. Surely an explicit else would be better than the implicit else block here? +

Re: IOCTL_DISK_GET_DRIVE_GEOMETRY in mountmgr.sys

2009-03-26 Thread Michael Ost
Michael Ost wrote: The ioctl handler for IOCTL_DISK_GET_DRIVE_GEOMETRY on .\\c: in mountmgr.sys doesn't work. The call returns incorrect values that change at random intervals. List, Never mind this one. It turns out that the bug happened due to another patch to Wine in our source tree.

Re: [6/10] wined3d: Simplify remove_vbos().

2009-03-26 Thread Henri Verbeet
2009/3/26 Stefan Dösinger : > Doesn't that mix up named and numbered attributes? > No, not really. The only reason the code had to use named attributes before was that there were more named attributes than could be indexed through the array.

Re: [5/10] wined3d: Remove unused attributes from WineDirect3DVertexStridedData.

2009-03-26 Thread Henri Verbeet
2009/3/26 Stefan Dösinger : > I think position2 and normal2 are used with fixed function tweening. Yes, but that's not actually implemented. If we ever do implement that in a shader we'll need to fit it into the existing 16 attributes. We'd probably have to make the mapping from fixed function attr

Re: [6/10] wined3d: Simplify remove_vbos().

2009-03-26 Thread Stefan Dösinger
Am Donnerstag, 26. März 2009 10:49:17 schrieb Henri Verbeet: Doesn't that mix up named and numbered attributes?

Re: winex11.drv: SetDIBits fails when startscan != 0

2009-03-26 Thread Massimo Del Fedele
Alexandre Julliard ha scritto: - descr.bits = bits; + descr.bits = (BYTE *)bits + widthBytes * (tmpheight > 0 ? (height - startscan - lines) : startscan); You shouldn't need to change the bits address. After a deeper look at it, I think there's no other (simple) way to do it. Us

Re: [5/10] wined3d: Remove unused attributes from WineDirect3DVertexStridedData.

2009-03-26 Thread Stefan Dösinger
Am Donnerstag, 26. März 2009 10:49:13 schrieb Henri Verbeet: I think position2 and normal2 are used with fixed function tweening. Should we remove it for now and readd it if we ever implement tweening in a vertex pipeline replacement?

Re: [try 2]winex11.drv/dib.c - fix SetDIBits() for startscan != 0

2009-03-26 Thread Massimo Del Fedele
Massimo Del Fedele ha scritto: Changes from previous one : bits shifting displaced from X11DRV_SetDIBits() to X11DRV_DIB_SetImageBits() Result is identical to former, the patch looks worse to me than before, but As a note, there's no way to leave 'descr->bits' untouched without adding at l

Re: SOC 2009: Application Test Suite

2009-03-26 Thread Scott Ritchie
Austin English wrote: On Wed, Mar 25, 2009 at 7:42 PM, Vincent Povirk wrote: On Wed, Mar 25, 2009 at 6:37 PM, Austin English wrote: From the looks of things, we could do just about everything in autohotkey with enough elbow grease. It would only take a small wrapper script to run it under win

Re: [PATCH 00/10] Support for dumb picture keychain

2009-03-26 Thread Michael Karcher
Am Donnerstag, den 26.03.2009, 10:08 +0100 schrieb Alexandre Julliard: > > 2. The FILE_NO_INTERMEDIATE_BUFFER flag seemed to require the O_DIRECT > > flag during the Unix open. This was proven by having standard Linux code > > access the device. #1/10 and #9/10 fixed this. > I don't see why you'd n

Re: [PATCH 00/10] Support for dumb picture keychain

2009-03-26 Thread Alexandre Julliard
Guy Albertelli writes: > 1. The initial problem was that the CreateFile above would not > successfully translate the volume id to the associated Unix file. #3/10 > fixed that. That should go in mountmgr, it already creates the volume symlinks and manages the devices. What is needed is a way to

Re: SOC 2009: Application Test Suite

2009-03-26 Thread Vít Hrachový
Austin English wrote: I was more interested in a quick proof of concept. The flexibility of autohotkey allows for lots of different methods for doing such things, and a method that involves the majority of code being run under AHK itself (and therefore on wine AND windows) is very possible with c