SOC 2009: Application Test Suite

2009-03-24 Thread Austin English
Howdy, I'm planning on applying for Google Summer of Code 2009. I'm pretty sure most people reading this list already know me, but for those that don't, I frequently triage bugs in Bugzilla, help users on the forum, and a few other things. I've also done quite a bit of work testing wine on more ob

Re: [PATCH 5/6] kernel32: Fix an off-by-one error.

2009-03-24 Thread James Hawkins
On Tue, Mar 24, 2009 at 3:50 PM, Alexandre Julliard wrote: > James Hawkins writes: > >>> This cannot be right. What happens to the original first_section then? >>> >> >> I don't really understand your question.  By original first_section, >> do you mean the first_section that we loaded from an ex

Re: [PATCH 5/6] kernel32: Fix an off-by-one error.

2009-03-24 Thread Alexandre Julliard
James Hawkins writes: >> This cannot be right. What happens to the original first_section then? >> > > I don't really understand your question. By original first_section, > do you mean the first_section that we loaded from an existing file or > that is in the cache? If so, then the answer is th

Re: Serial port conformance tests

2009-03-24 Thread Saulius Krasuckas
* On Mon, 23 Mar 2009, Chris Teague wrote: very useful tool would be a serial port loopback device. Rather than require conformance testers to attach a hardware loopback device (NULL modem) to a physical port, could we create some virtual ports in wine and connect them together? Maybe com98

iphlpapi patch - what does it need?

2009-03-24 Thread David Gerard
http://bugs.winehq.org/show_bug.cgi?id=14574 has a patch for iphlpapi that stubs GetAdaptersAddresses(). Just this stub is enough to get Safari 4 working. Patch is: http://bugs.winehq.org/attachment.cgi?id=19704 http://bugs.winehq.org/attachment.cgi?id=19705 Do these need anything done before the

Re: [PATCH 5/6] kernel32: Fix an off-by-one error.

2009-03-24 Thread James Hawkins
On Tue, Mar 24, 2009 at 3:42 AM, Alexandre Julliard wrote: > James Hawkins writes: > >> --- >>  dlls/kernel32/profile.c       |    2 +- >>  dlls/kernel32/tests/profile.c |   30 ++ >>  2 files changed, 7 insertions(+), 25 deletions(-) >> >> diff --git a/dlls/kernel32/pr

Re: setupapi: Initialization fix

2009-03-24 Thread Andrew Talbot
Andrew Talbot wrote: > The TRACE() potentially reporting the value of "newpath" must be placed > after where that variable is first set. > I suspect that this patch still doesn't fix the problem. Feedback or expert intervention is welcomed! Thanks. -- Andy.

Re: Serial port conformance tests

2009-03-24 Thread Damjan Jovanovic
On Tue, Mar 24, 2009 at 12:06 AM, Chris Teague wrote: > I'm new to wine, looking into serial communications.  I have a failing > scenario in a application, and I'd like to write a conformance test to > demonstrate/document the issue.  I looked in dlls/ntdll/tests but did > not see any serial port

Re: [PATCH 1/6] kernel32: Add tests for WritePrivateProfileString.

2009-03-24 Thread Paul Vriens
James Hawkins wrote: --- dlls/kernel32/tests/profile.c | 227 + 1 files changed, 227 insertions(+), 0 deletions(-) Two of these new tests crash on Windows (see attached patch fo

Re: SOC Project Idea: Winelib-aware scons

2009-03-24 Thread Chris Morgan
On Fri, Mar 20, 2009 at 7:50 PM, Scott Ritchie wrote: > For a while now I've been hoping someone would tackle a pet project of > mine.  It occurred to me that it would be a great summer of code project. > > Basically, I want a magic script that can convert a visual studio > project file into a win

Re: [PATCH 1/2] secur32: Change scan_free_handle to print an error, if the index (handle) is out of range.

2009-03-24 Thread Francois Gouget
On Tue, 24 Mar 2009, Florian Köberle wrote: [...] > +if (handle_idx < 0 || handle_idx >= schan_handle_count) > +{ > +ERR("Handle %ld is not in range [0,%ld]\n", handle_idx, > schan_handle_count-1); > +return NULL; > +} A conformance test to show that Windows has this c

Re: [PATCH 1/2] secur32: Change scan_free_handle to print an error, if the index (handle) is out of range.

2009-03-24 Thread Florian Köberle
> handle_idx can't be < 0 because it's unsigned. Printing an ERR if the > handle is out of range is probably ok, but I think crashing is better > than just returning NULL. > I hoped that you would have thought otherwise about returning null. You might still get a crash at some point later, but

Re: gdi32/path.c -- Allow PATH_ExtTextOut() handle nonprintablecharacters

2009-03-24 Thread Massimo Del Fedele
Massimo Del Fedele ha scritto: But then, I'm still not sure IF GetGlyphOutlineW does return GDI_ERROR when called with GGO_GLYPH_INDEX flag (msn is not clear about...) nor I know how to make a call to GetGlyphOutlineW() requesting a buffer size which simulates an error. I could do with a wron

Re: gdi32/path.c -- Allow PATH_ExtTextOut() handle nonprintablecharacters

2009-03-24 Thread Alexandre Julliard
Massimo Del Fedele writes: > But then, I'm still not sure IF GetGlyphOutlineW does return GDI_ERROR > when called with GGO_GLYPH_INDEX flag (msn is not clear about...) nor > I know how to make a call to GetGlyphOutlineW() requesting a buffer > size which simulates an error. I could do with a wron

Re: gdi32/path.c -- Allow PATH_ExtTextOut() handle nonprintablecharacters

2009-03-24 Thread Massimo Del Fedele
Alexandre Julliard ha scritto: GDI_ERROR is clearly not a valid buffer size, and must be checked for. Please write test cases like Dmitry suggested. Yep, right, GDI_ERROR is -1L, too large to be a buffer size. Uhmmm... the only non-graphical testcase that occours to me is one showing that Ge

Re: [1/3]msctf: ThreadMgr sink framework

2009-03-24 Thread Aric Stewart
Thanks, resent. -aric Alexandre Julliard wrote: Aric Stewart writes: typedef struct tagACLMulti { const ITfThreadMgrVtbl *ThreadMgrVtbl; const ITfSourceVtbl *SourceVtbl; LONG refCount; ITfDocumentMgr *focus; + +/* kept as separate lists to reduce unnecessary itera

Re: Unicode error

2009-03-24 Thread Alexandre Julliard
Robert Lunnon writes: > I get this error under solaris building wine. > Any clues would be welcome (Things have probably changed a lot since I > last hacked on Wine) > > make[2]: Entering directory `/export/home/src/wine2004/wine/dlls/kernel32' > ../../tools/wrc/wrc --nostdinc -I. -I. -I../../inc

Re: Unicode error

2009-03-24 Thread Rob Shearman
2009/3/22 Robert Lunnon : > I get this error under solaris building wine. > Any clues would be welcome (Things have probably changed a lot since I last > hacked on Wine) > > make[2]: Entering directory `/export/home/src/wine2004/wine/dlls/kernel32' > ../../tools/wrc/wrc --nostdinc -I. -I. -I../../i

Re: [1/3]msctf: ThreadMgr sink framework

2009-03-24 Thread Alexandre Julliard
Aric Stewart writes: > typedef struct tagACLMulti { > const ITfThreadMgrVtbl *ThreadMgrVtbl; > const ITfSourceVtbl *SourceVtbl; > LONG refCount; > > ITfDocumentMgr *focus; > + > +/* kept as separate lists to reduce unnecessary iterations */ > +struct list pActiv

Re: gdi32/path.c -- Allow PATH_ExtTextOut() handle nonprintablecharacters

2009-03-24 Thread Alexandre Julliard
Massimo Del Fedele writes: > Yep, of course, but we don't need to check for GetGlyphOutlineW() > correctness (well, not for this case, at least). It IS correct. > If you ask for buffer size (as done on first call) it returns 0 on > error AND on unprintable glyphs. The GDI_ERROR value is returned

Re: WineHQ.org Downtime

2009-03-24 Thread Paul Vriens
Jeremy Newman wrote: I didn't do any further OS updates since the Lenny upgrade over 2 weeks prior. This downtime was a full hardware migration. I copied the entire OS over to a new system. I can't see how that would effect any tests, unless they care about differences in chipset, CPU or NIC.

Re: [PATCH 1/2] secur32: Change scan_free_handle to print an error, if the index (handle) is out of range.

2009-03-24 Thread Henri Verbeet
2009/3/24 Florian Köberle : > +    if (handle_idx < 0 || handle_idx >= schan_handle_count) > handle_idx can't be < 0 because it's unsigned. Printing an ERR if the handle is out of range is probably ok, but I think crashing is better than just returning NULL.

Re: [PATCH 2/2] secur32: Use indices to link the free handles.

2009-03-24 Thread Henri Verbeet
2009/3/24 Florian Köberle : > Pointers can get invalid when the table gets moved in memory. > This can happen when the table grows. Did you actually see this happen? The table is only supposed to grow when there are no free handles.

Re: WineHQ.org Downtime

2009-03-24 Thread Jeremy Newman
I didn't do any further OS updates since the Lenny upgrade over 2 weeks prior. This downtime was a full hardware migration. I copied the entire OS over to a new system. I can't see how that would effect any tests, unless they care about differences in chipset, CPU or NIC. -Newman Paul Vriens

Re[1] user32/tests: Check effect of magic font height value 0x7fff in dialog template (try 2)

2009-03-24 Thread Koro
Why don't you add this to the resource file? Because this dialog template does not declare the weight, italic, charset and fontname members, due to the font size being 0x7fff and therefore interpreted "specially". AFAIK, wrc probably wouldn't be able to generate such a template, the MS RC com

Re: libwine: Only partially reserve memory beyond 0x80000000 on FreeBSD.

2009-03-24 Thread Francois Gouget
Tijl Coosemans a écrit : [...] Wine wants to allocate a few things in reserved areas, and because there were no reserved areas at all on FreeBSD it failed. That's bug 16023. My patch leaves enough reserved area for Wine to allocate these, but otherwise reservation isn't needed like it is on Linux

Office 2007 installer crash in msi - Backtrace on Solaris

2009-03-24 Thread Robert Lunnon
The cause might be a Null pointer into strlenW as below ::stack libwine.so.1.0`strlenW+0xf(0, 7bdef160, 7fbf8612, 7bdeef28) kernel32.dll.so`lstrlenW+0x34(0, 0, 1, 0, 80, 0) 0x7da74480(6a8c3648, 0, 0, 7da801d4, 7f09f998, 3) 0x7da65e08(2, 0, 0) msi.dll.so`ACTION_CallDllFunction+0x21c(6a8c090c, 7ffc

Re: How to enable font anti-aliasing in Wine?

2009-03-24 Thread Alexandre Julliard
"Dmitry Timoshkov" writes: > "Anssi Hannula" wrote: > >> Better if Wine would use fontconfig's configuration as set by desktop >> environment (~/.fonts.conf). > > That's not a very good idea, see http://bugs.winehq.org/show_bug.cgi?id=16745 > for details. The specific implementation may not be

Re: Serial port conformance tests

2009-03-24 Thread Alexandre Julliard
Chris Teague writes: > I'm new to wine, looking into serial communications. I have a failing > scenario in a application, and I'd like to write a conformance test to > demonstrate/document the issue. I looked in dlls/ntdll/tests but did > not see any serial port related tests - did I miss them

Re: [PATCH 5/6] kernel32: Fix an off-by-one error.

2009-03-24 Thread Alexandre Julliard
James Hawkins writes: > --- > dlls/kernel32/profile.c |2 +- > dlls/kernel32/tests/profile.c | 30 ++ > 2 files changed, 7 insertions(+), 25 deletions(-) > > diff --git a/dlls/kernel32/profile.c b/dlls/kernel32/profile.c > index 5d563a5..b6ad6d0 100644 > -

Re: [PATCH 00/10] Support for dumb picture keychain

2009-03-24 Thread Alexandre Julliard
Guy Albertelli writes: > 1/10 server: Implement FILE_NO_INTERMEDIATE_BUFFERING with O_DIRECT > 2/10 kernel32/tests: First test for CreateFile on NT unique volume name > 3/10 ntdll: Implement conversion of NT unique volume name to unix file > name > 4/10 ntdll: Implement internal aligned b

Re: [4] [wined3d] trigger constant reloading when RECT textures change

2009-03-24 Thread Henri Verbeet
2009/3/23 Tobias Jakobi : > +if (!use_ps(stateblock) || > (stateblock->wineD3DDevice->shader_backend != &glsl_shader_backend)) { Checking which backend is used is pretty ugly.

Re: [3] [wined3d] GLSL: implement texrect coord fixup

2009-03-24 Thread Henri Verbeet
2009/3/23 Tobias Jakobi : > > +if (prog->ps_args.texrect_fixup) { > +for (i = 0; i < MAX_FRAGMENT_SAMPLERS; ++i) { Using something like the following would avoid checking the entire prog->rectFixup_location array when only the first few samplers are used: DWORD fixup = pro

Re: [2/2] quartz: Add a libavformat based MPEG demuxer.

2009-03-24 Thread Sagar Mittal
On Mon, Mar 23, 2009 at 8:10 AM, Henri Verbeet wrote: > I'm not sure how much we should care about the ABI as long as the API > is reasonably stable, but my impression was that FFmpeg has stabilized > quite a bit in recent years. I implemented this for SoC 2006, and that code languished for the

Re: [scons-dev] SOC Project Idea: Winelib-aware scons

2009-03-24 Thread Greg Noel
On Mar 22, 2009, at 11:18 AM, Francois Gouget wrote: The Winelib tools (winebuild, winegcc, wrc, widl, etc) are actually used everyday [sic] and are under active development as they are used to build Wine itself. Ah, I didn't know that. I thought winelib was more like a replacement for t

Re: [scons-dev] SOC Project Idea: Winelib-aware scons

2009-03-24 Thread Greg Noel
On Mar 22, 2009, at 4:47 AM, King InuYasha wrote: Does SCons support the project-within-a-project build style that is used in Visual Studio? ... SCons is amazingly policy-neutral, and we work to keep it that way. (It has occasionally been a bone of contention, when people have wanted us

Re: WineHQ.org Downtime

2009-03-24 Thread Paul Vriens
Jeremy Newman wrote: Server is back on-line. -Newman Jeremy Newman wrote: WineHQ.org (websites [www,appdb,bugzilla,forums,source,test], git, mailing lists) will be off-line tomorrow starting at 10:00 CDT and lasting at least 2 hours. We will be putting up a temp website that will display a