Re: user32/tests: Check effect of magic font height value 0x7fff in dialog template (try 2)

2009-03-23 Thread Vitaliy Margolen
Koro wrote: > This is the second try for my testcase that shows a discrepancy between > Wine and Windows' handling of dialog templates in the specific case > where the font size member is set to 0x7fff. > > +static unsigned char dlgTemplate[] = > +{ > +/* Dialog header */ > +

Re: flattering words about winetricks

2009-03-23 Thread Scott Ritchie
Vincent Povirk wrote: Indeed, the other frontends I'm aware of overengineered it and/or tinkered with the prefix more than they should have. As far as I can tell, you're the first person to just write a self-contained shell script to simplify common work-arounds instead of trying to provide a fra

Re: Anything wrong with these patches ?

2009-03-23 Thread Ricardo Filipe
2009/3/23 Massimo Del Fedele > winex11.drv: SetDIBits fails when startscan != 0 > http://www.winehq.org/pipermail/wine-patches/2009-March/070788.html > (solves a bug on SetDIBits when transfer partial bitmap) > > gdi32/path.c -- Allow PATH_ExtTextOut() handle non printable characters > http://www

Serial port conformance tests

2009-03-23 Thread Chris Teague
I'm new to wine, looking into serial communications. I have a failing scenario in a application, and I'd like to write a conformance test to demonstrate/document the issue. I looked in dlls/ntdll/tests but did not see any serial port related tests - did I miss them or do none exist yet? Assuming

Re: flattering words about winetricks

2009-03-23 Thread Vincent Povirk
Indeed, the other frontends I'm aware of overengineered it and/or tinkered with the prefix more than they should have. As far as I can tell, you're the first person to just write a self-contained shell script to simplify common work-arounds instead of trying to provide a framework that could instal

Re: comctl32: implement TCM_REMOVEIMAGE (try2)

2009-03-23 Thread Nikolay Sivov
Vitaliy Margolen wrote: Nikolay Sivov wrote: Changelog: - try2: fix for several items with a same image case - implement TCM_REMOVEIMAGE What about this comment from msdn? - The tab control updates each tab's image index, so each tab remains associated with the same imag

Re: [2/2] quartz: Add a libavformat based MPEG demuxer.

2009-03-23 Thread Chris Robinson
On Monday 23 March 2009 5:10:54 am Henri Verbeet wrote: > I'm not sure how much we should care about the ABI as long as the API > is reasonably stable, but my impression was that FFmpeg has stabilized > quite a bit in recent years. It was actually just about a month or so ago where a project I was

Re: comctl32: implement TCM_REMOVEIMAGE (try2)

2009-03-23 Thread Nikolay Sivov
Vitaliy Margolen wrote: Nikolay Sivov wrote: Changelog: - try2: fix for several items with a same image case - implement TCM_REMOVEIMAGE What about this comment from msdn? - The tab control updates each tab's image index, so each tab remains associated with the same imag

Re: setupapi: Don't copy into a NULL PathBuffer, and remove an invalid check for size < MAX_PATH (Coverity 888).

2009-03-23 Thread Ricardo Filipe
2009/3/23 James Hawkins > On Mon, Mar 23, 2009 at 9:38 AM, Ricardo Filipe > wrote: > > i know it's not what it does, it's an alternative someone refered in irc. > i > > was wondering what you think would be the correct approach, since both > fix > > the problem, the alternative just goes against

Re: setupapi: Don't copy into a NULL PathBuffer, and remove an invalid check for size < MAX_PATH (Coverity 888).

2009-03-23 Thread James Hawkins
On Mon, Mar 23, 2009 at 9:38 AM, Ricardo Filipe wrote: > i know it's not what it does, it's an alternative someone refered in irc. i > was wondering what you think would be the correct approach, since both fix > the problem, the alternative just goes against the msdn documentation, which > has bee

Re: setupapi: Don't copy into a NULL PathBuffer, and remove an invalid check for size < MAX_PATH (Coverity 888).

2009-03-23 Thread Ricardo Filipe
i know it's not what it does, it's an alternative someone refered in irc. i was wondering what you think would be the correct approach, since both fix the problem, the alternative just goes against the msdn documentation, which has been refered as not reliable :D 2009/3/23 James Hawkins > On Sun

Re: setupapi: Don't copy into a NULL PathBuffer, and remove an invalid check for size < MAX_PATH (Coverity 888).

2009-03-23 Thread James Hawkins
On Sun, Mar 22, 2009 at 4:04 PM, Ricardo Filipe wrote: > my next task was to fix this eheh. > i think it would make more sense to just change > > if(!params->PathBuffer && !params->PathBufferSize) > > to > > if(!params->PathBuffer) > That's not what the patch does, but I did mistakenly leave an e

Re: [2/2] quartz: Add a libavformat based MPEG demuxer.

2009-03-23 Thread Henri Verbeet
2009/3/23 Chris Robinson : > I wouldn't recommend this patch as being very safe. Having dealt with ffmpeg, > my experience has been that it's ABI is not stable (the .so version number > increments often, forcing recompilations). And when trying to update to new > lib versions, things sometimes myst

Re: Unicode error

2009-03-23 Thread Robert Lunnon
Austin English wrote: On Sun, Mar 22, 2009 at 5:45 AM, Robert Lunnon wrote: I get this error under solaris building wine. Any clues would be welcome (Things have probably changed a lot since I last hacked on Wine) make[2]: Entering directory `/export/home/src/wine2004/wine/dlls/kernel32'

Re: [2/2] quartz: Add a libavformat based MPEG demuxer.

2009-03-23 Thread Reece Dunn
2009/3/23 Chris Robinson : > I wouldn't recommend this patch as being very safe. Having dealt with ffmpeg, > my experience has been that it's ABI is not stable (the .so version number > increments often, forcing recompilations). And when trying to update to new > lib versions, things sometimes myst

Re: [2/2] quartz: Add a libavformat based MPEG demuxer.

2009-03-23 Thread Chris Robinson
I wouldn't recommend this patch as being very safe. Having dealt with ffmpeg, my experience has been that it's ABI is not stable (the .so version number increments often, forcing recompilations). And when trying to update to new lib versions, things sometimes mysteriously break. Ultimately, FFm