Re: comctl32: implement TCM_REMOVEIMAGE (try2)

2009-03-22 Thread Vitaliy Margolen
Nikolay Sivov wrote: > Changelog: >- try2: fix for several items with a same image case >- implement TCM_REMOVEIMAGE What about this comment from msdn? - The tab control updates each tab's image index, so each tab remains associated with the same image as before. If a tab is using

Re: flattering words about winetricks

2009-03-22 Thread Ben Klein
2009/3/23 Dan Kegel : > http://www.vivaolinux.com.br/dica/Winetricks-turbinando-seu-wine-sem-dores-de-cabeca > says "created by Dan Kegel, who was in a state of grace when he had > this brilliant idea..." > :-) > > (In case anyone has forgotten, winetricks is about the sixth > in a long series of f

Re: comctl32: Implement TCM_REMOVEIMAGE message

2009-03-22 Thread Nikolay Sivov
>/From c419ca8f87ae3103e63604d9646d3851a5d959e7 Mon Sep 17 00:00:00 2001 /From: Nikolay Sivov http://www.winehq.org/mailman/listinfo/wine-patches>> Date: Sun, 22 Mar 2009 18:43:46 -0400 Subject: Implement TCM_REMOVEIMAGE It's wrong in case when several tabs use same image. Please ignore it.

flattering words about winetricks

2009-03-22 Thread Dan Kegel
http://www.vivaolinux.com.br/dica/Winetricks-turbinando-seu-wine-sem-dores-de-cabeca says "created by Dan Kegel, who was in a state of grace when he had this brilliant idea..." :-) (In case anyone has forgotten, winetricks is about the sixth in a long series of front-ends that try to make it easie

Re: setupapi: Don't copy into a NULL PathBuffer, and remove an invalid check for size < MAX_PATH (Coverity 888).

2009-03-22 Thread Ricardo Filipe
my next task was to fix this eheh. i think it would make more sense to just change if(!params->PathBuffer && !params->PathBufferSize) to if(!params->PathBuffer) as it was talked about in irc, it doesn't make much sense to check for pathbuffersize when pathbuffer is null... the max_path removal

Re: 16bit code generation

2009-03-22 Thread King InuYasha
On Sun, Mar 22, 2009 at 5:46 AM, Tijl Coosemans wrote: > On Sunday 22 March 2009 04:00:16 Austin English wrote: > > Wine supports 16 bit apps, just not as well as 32-bit. Dan had an > > intern work on a 16 bit test suite > > (http://code.google.com/p/win16test/), which can be used to test 16 > >

Re: wined3d: Document the correlation of gl_shaders and num_gl_shaders with an assertion (Coverity 905).

2009-03-22 Thread James Hawkins
On Sun, Mar 22, 2009 at 2:57 PM, Henri Verbeet wrote: > 2009/3/22 James Hawkins : >> --- >>  dlls/wined3d/vertexshader.c |    3 +++ >>  1 files changed, 3 insertions(+), 0 deletions(-) >> > I guess the nicer way to make Coverity shut up would be to replace > "if(shader->gl_shaders) {" with "if (sh

Re: 16bit code generation

2009-03-22 Thread David Laight
On Sun, Mar 22, 2009 at 11:34:03AM +1100, Ben Klein wrote: > Oops, missed reply-to-all. > > 2009/3/22 Tijl Coosemans : > > I was reading through binutils documentation and came across this. > > Maybe it can be used to compile 16 bit tests. > > > > 3.2.4. 16-bit mode > > Binutils (2.9.1.0.25+) now

Re: wined3d: Document the correlation of gl_shaders and num_gl_shaders with an assertion (Coverity 905).

2009-03-22 Thread Henri Verbeet
2009/3/22 James Hawkins : > --- >  dlls/wined3d/vertexshader.c |    3 +++ >  1 files changed, 3 insertions(+), 0 deletions(-) > I guess the nicer way to make Coverity shut up would be to replace "if(shader->gl_shaders) {" with "if (shader->num_gl_shaders)". Wouldn't the code in find_gl_pshader() in

Re: [scons-dev] SOC Project Idea: Winelib-aware scons

2009-03-22 Thread Francois Gouget
On Sat, 21 Mar 2009, Greg Noel wrote: [...] > On the other hand, I'd wonder about viability. It doesn't look like the basic > winelib information has been updated since January 2005, although there's > mention of a planned 0.9 release in September 2005. That's more than three > years of inactivit

Chromium unit test suite as source of Wine tests

2009-03-22 Thread Dan Kegel
Hey folks, the chromium project has a very nice unit test suite, and the chromium team pores over it with purify and now, on linux, valgrind to make sure everything is clean. This makes it a rather attractive test case for Wine even if Wine isn't really trying to run Chrome itself. I just filed th

Re: Single login for Wine sites?

2009-03-22 Thread David Gerard
2009/3/22 Austin English : > On Sun, Mar 22, 2009 at 9:18 AM, David Gerard wrote: >> What's standing in the way of unified login for the various Wine sites >> (appdb, wiki, Bugzilla)? > Someone to do the work to combine the logins and implement the infrastructure. Cool, so the only problem is

Re: Single login for Wine sites?

2009-03-22 Thread Kai Blin
On Sunday 22 March 2009 17:29:33 Igor Tarasov wrote: > Maybe add openid support and let users connect existing accouts to one > openid? We decided to go for a secure system, if at all. OpenID was discussed and quickly dropped at the last WineConf. Google for "openid security issues" to see what

Re: Single login for Wine sites?

2009-03-22 Thread Igor Tarasov
Maybe add openid support and let users connect existing accouts to one openid? -- Igor

Re: Unicode error

2009-03-22 Thread Austin English
On Sun, Mar 22, 2009 at 5:45 AM, Robert Lunnon wrote: > I get this error under solaris building wine. > Any clues would be welcome (Things have probably changed a lot since I last > hacked on Wine) > > make[2]: Entering directory `/export/home/src/wine2004/wine/dlls/kernel32' Are you really build

Re: Single login for Wine sites?

2009-03-22 Thread Austin English
On Sun, Mar 22, 2009 at 9:18 AM, David Gerard wrote: > What's standing in the way of unified login for the various Wine sites > (appdb, wiki, Bugzilla)? Someone to do the work to combine the logins and implement the infrastructure. > Is there anyone running any of these sites who doesn't conside

Single login for Wine sites?

2009-03-22 Thread David Gerard
What's standing in the way of unified login for the various Wine sites (appdb, wiki, Bugzilla)? Is there anyone running any of these sites who doesn't consider single unified login a good idea? - d.

Re: 16bit code generation

2009-03-22 Thread Michael Karcher
Am Sonntag, den 22.03.2009, 11:46 +0100 schrieb Tijl Coosemans: > On Sunday 22 March 2009 04:00:16 Austin English wrote: > > Wine supports 16 bit apps, just not as well as 32-bit. Dan had an > > intern work on a 16 bit test suite > > (http://code.google.com/p/win16test/), which can be used to test

Re: Unicode error

2009-03-22 Thread Marcus Meissner
On Sun, Mar 22, 2009 at 08:45:18PM +1000, Robert Lunnon wrote: > I get this error under solaris building wine. > Any clues would be welcome (Things have probably changed a lot since I last > hacked on Wine) > > make[2]: Entering directory `/export/home/src/wine2004/wine/dlls/kernel32' > ../../tool

Re: libwine: Only partially reserve memory beyond 0x80000000 on FreeBSD.

2009-03-22 Thread Tijl Coosemans
On Saturday 21 March 2009 11:42:12 Francois Gouget wrote: > Tijl Coosemans a écrit : >> I still would like to see this patch committed though, to fix bug >> 17718, but generally because the memory reservation doesn't fix >> anything and only causes problems. > > That's wrong. Memory reservation fi

Re: Unicode error

2009-03-22 Thread Robert Lunnon
Ben Klein wrote: 2009/3/22 Robert Lunnon : I get this error under solaris building wine. Any clues would be welcome (Things have probably changed a lot since I last hacked on Wine) make[2]: Entering directory `/export/home/src/wine2004/wine/dlls/kernel32' ../../tools/wrc/wrc --nostdinc -I. -

Re: Unicode error

2009-03-22 Thread Ben Klein
2009/3/22 Robert Lunnon : > I get this error under solaris building wine. > Any clues would be welcome (Things have probably changed a lot since I last > hacked on Wine) > > make[2]: Entering directory `/export/home/src/wine2004/wine/dlls/kernel32' > ../../tools/wrc/wrc --nostdinc -I. -I. -I../../i

Re: [scons-dev] SOC Project Idea: Winelib-aware scons

2009-03-22 Thread King InuYasha
On Sat, Mar 21, 2009 at 10:42 AM, Greg Noel wrote: > On Mar 20, 2009, at 4:50 PM, Scott Ritchie wrote: > > ... I want a magic script that can convert a visual studio project file >> into a winelib-aware, scons-powered, linux-compatible build system. ... >> I'm not sure whether this will functi

Re: GSoC 2009 Proposal - AppDB Assistant

2009-03-22 Thread André Hentschel
Ben Klein schrieb: Grabbing the version number of the application from the EXE metadata could prove to be unreliable. A lot of Windows apps don't include metadata, or include unusual values in the metadata. Then again, a lot of apps don't make it easy to see what the version you're using is in an

Re: 16bit code generation

2009-03-22 Thread Tijl Coosemans
On Sunday 22 March 2009 04:00:16 Austin English wrote: > Wine supports 16 bit apps, just not as well as 32-bit. Dan had an > intern work on a 16 bit test suite > (http://code.google.com/p/win16test/), which can be used to test 16 > bit support, fwiw. Yes, this is what I meant to refer to. AFAIK th

Unicode error

2009-03-22 Thread Robert Lunnon
I get this error under solaris building wine. Any clues would be welcome (Things have probably changed a lot since I last hacked on Wine) make[2]: Entering directory `/export/home/src/wine2004/wine/dlls/kernel32' ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -D__WINES