Re: Disabling File attachments on Wiki

2009-03-11 Thread Dmitry Timoshkov
"Vitaliy Margolen" wrote: Please disable file attachments on Wiki. There are no way to verify their validity and for the past week it's been a constant source of spam. IMHO file attachment does not belong on text only Wiki. If anyone needs to attach a patch a two - they can link it to the one

Re: Taking a break from Wine

2009-03-11 Thread Austin English
On Wed, Mar 11, 2009 at 6:33 PM, Dan Kegel wrote: > Every now and then, my wrists force me to take > a break from Wine development.  This time it's > also a matter of focus; I would like to spend more > time with my family while also focussing more > on my day job.  One of the three had to go, > f

Re: Taking a break from Wine

2009-03-11 Thread Scott Ritchie
Dan Kegel wrote: > Every now and then, my wrists force me to take > a break from Wine development. This time it's > also a matter of focus; I would like to spend more > time with my family while also focussing more > on my day job. One of the three had to go, > for a while at least. > Thank you

Re: Wine on Windows - wiki notes

2009-03-11 Thread David Gerard
2009/3/11 Steven Edwards : > On Wed, Mar 11, 2009 at 5:53 PM, David Gerard wrote: >> I thought Cygwin had long had sendmsg/recvmsg: > According to Microsofts documentation (thanks Thunderbird) > Vista/Windows Server 2008 and the Subsystem for Unix applications is > supposed to support this so we

Re: Wiki challenge question on user account creation

2009-03-11 Thread Ben Klein
2009/3/12 David Gerard : > Again, you appear to be reading things I didn't write at all, > even while quoting what I did. Your communications are > confusing, please make them less so. I apologise, I was getting you confused with King InuYasha. Serves me right for emailing while tired :D

Re: Taking a break from Wine

2009-03-11 Thread Dan Kegel
On Wed, Mar 11, 2009 at 4:50 PM, Ben Klein wrote: > What is involved in the maintenance of winetricks? I might be > available to do that :) Mostly just running its test suite every once in a while and updating the script when some URL or checksum changes, as well as watching the bug tracker and m

Re: Taking a break from Wine

2009-03-11 Thread Ben Klein
2009/3/12 Dan Kegel : > Every now and then, my wrists force me to take > a break from Wine development.  This time it's > also a matter of focus; I would like to spend more > time with my family while also focussing more > on my day job.  One of the three had to go, > for a while at least. Even th

Re: Wiki challenge question on user account creation

2009-03-11 Thread David Gerard
2009/3/11 Ben Klein : > 2009/3/12 David Gerard : >> Reasons for picking Moin are typically: >> Reasons for picking MediaWiki are typically: > Moin is sounding better to me so far. Less overhead is good. > Generally, people pick a Wiki that Just Works (TM). Unfortunately, > they pretty much all do

Taking a break from Wine

2009-03-11 Thread Dan Kegel
Every now and then, my wrists force me to take a break from Wine development. This time it's also a matter of focus; I would like to spend more time with my family while also focussing more on my day job. One of the three had to go, for a while at least. I will still try to update winetricks onc

Re: Wiki challenge question on user account creation

2009-03-11 Thread Ben Klein
2009/3/12 David Gerard : > 2009/3/11 Ben Klein : > >> Does what we have now work? Yes. Is there any reason why we should >> consider moving from Moin to some other Wiki system? Your turn to >> answer. > > At work, I use a ridiculous range of wiki engines. I've used Moin and > MediaWiki most heavily

Re: Wine on Windows - wiki notes

2009-03-11 Thread Ben Klein
2009/1/1 Steven Edwards : > Honestly though I think this is the wrong approach. If you want to > emulate an older windows environment you should look at something like > VMware's Thinapp. The Wine on Windows method is going to involve > either emulating Win32 on Cygwin on Win32 or Win32 on POSIX on

Re: Wine on Windows - wiki notes

2009-03-11 Thread Steven Edwards
On Wed, Mar 11, 2009 at 5:53 PM, David Gerard wrote: > I thought Cygwin had long had sendmsg/recvmsg: > > http://www.cygwin.com/ml/cygwin-patches/2002-q1/msg00111.html > > What do you mean here? It has an implementation but not one that supports doing a recvmsg with a file descriptor so I underst

Re: Wine on Windows - wiki notes

2009-03-11 Thread David Gerard
[reviving oldish thread] 2008/12/31 Steven Edwards : > I've poked at it off and on over the years Its been my experience > building on Cygwin was actually less trouble. Cygwin and SFU/Internix > both require the same basic lowlevel magic. Proper signal handling, > getting the thread management ri

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Roman Mindalev
>From 165aeb4aa1350b6d26be268ca7e4136058484069 Mon Sep 17 00:00:00 2001 From: Roman Mindalev Date: Wed, 11 Mar 2009 22:09:47 +0300 Subject: [ntdll] Move search for assemblyIdentity element Function for manifest parsing tried search for assemblyIdentity element only if it placed in begin of a man

Re: [ntdll] lookup_assembly function should returns STATUS_SUCCESS

2009-03-11 Thread André Hentschel
STATUS_SUCCESS is 0x0, see http://source.winehq.org/source/include/ntstatus.h#L30

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Roman Mindalev
>From c59dbc8de90398c03e7cc44124a5902b1b2d8fc7 Mon Sep 17 00:00:00 2001 From: Roman Mindalev Date: Wed, 11 Mar 2009 22:27:09 +0300 Subject: [ntdll] lookup_assembly function should returns STATUS_SUCCESS Expected result of function is STATUS_SUCCESS if no errors occurred, but it returned zero in

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Roman Mindalev
>From a7af98e6d2d185614d92c02c817ac74382c1b35c Mon Sep 17 00:00:00 2001 From: Roman Mindalev Date: Wed, 11 Mar 2009 21:32:42 +0300 Subject: [ntdll] Free memory for type field of an asembly_identity Memory for this field was allocated and never freed --- dlls/ntdll/actctx.c |1 + 1 files cha

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Roman Mindalev
>From 4f895878f85988c292454662ae07ba3e72d7e7ba Mon Sep 17 00:00:00 2001 From: Roman Mindalev Date: Wed, 11 Mar 2009 21:25:52 +0300 Subject: [ntdll] Care about arch and name fields in assembly_identity structure On parsing of a manifest is possible access to zero address and crash. It's happens

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Roman Mindalev
Austin English wrote: On Wed, Mar 11, 2009 at 2:40 PM, Roman Mindalev wrote: Jacek Caban wrote: Hi Roman, On parsing of manifest in PE module is possible access to zero address and crash. It's happens because not all manifest attributes can be specified and pointers in assembly_identity stru

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Austin English
On Wed, Mar 11, 2009 at 2:40 PM, Roman Mindalev wrote: > Jacek Caban wrote: >> >> Hi Roman, >> >>> On parsing of manifest in PE module is possible access to zero address >>> and crash. It's happens because not all manifest attributes can be >>> specified and pointers in assembly_identity structure

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Roman Mindalev
Jacek Caban wrote: Hi Roman, On parsing of manifest in PE module is possible access to zero address and crash. It's happens because not all manifest attributes can be specified and pointers in assembly_identity structure can be uninitialized. This patch adds function for setting empty strings i

Re: shlwapi: Correct AssocCreate and tests (try 2)

2009-03-11 Thread Jacek Caban
Hi Alistair, Alistair Leslie-Hughes wrote: Hi, Added check for IUnknown, thanks Jacek. It would be better to return correct error on QueryInterface failure. Otherwise you're duplicating the code. Jacek

Re: [ntdll] Care about empty fields of assembly_identity structure in actctx.c

2009-03-11 Thread Jacek Caban
Hi Roman, On parsing of manifest in PE module is possible access to zero address and crash. It's happens because not all manifest attributes can be specified and pointers in assembly_identity structure can be uninitialized. This patch adds function for setting empty strings in structure elements

Re: [PATCH] 0001-Fixed-tests-in-dlls-ws2_32-tests-sock.c-for-simple_s.patch

2009-03-11 Thread Juan Lang
Hi Andrew, diff --git a/dlls/dbghelp/type.c b/dlls/dbghelp/type.c index 947eb49..4e426e2 100644 --- a/dlls/dbghelp/type.c +++ b/dlls/dbghelp/type.c It seems rather unlikely that dbghelp is causing failures in the winsock tests. Perhaps dbghelp is getting invoked due to a crash? Besides, -

Re: LookupAccountSidW returns "unexpected" username

2009-03-11 Thread Rob Shearman
2009/3/10 Andreas Rosenberg : > While I did some experimenting with the proposals from Vitaliy Margolen > to get an accepted patch for GetUserProfileDirectoryW, I found this > behavior: > > OpenProcessToken(hProcess,TOKEN_QUERY,&hToken); > ... > GetTokenInformation( hToken, TokenUser, ptiUser, cbti

Re: qmgr test failures

2009-03-11 Thread Austin English
On Tue, Mar 10, 2009 at 6:59 PM, Rob Shearman wrote: > 2009/3/9 Austin English : >> Howdy Rob, >> >> Looks like one of your recent qmgr patches added failure to qmgr: >> http://test.winehq.org/data/1b9a6fb4e9f5a76f1ca352bef121689df02d9289/#group_Wine >> >> file.c:121: Test failed: GetRemoteName fa

Fwd: Disabling File attachments on Wiki

2009-03-11 Thread David Gerard
to list as well -- Forwarded message -- From: David Gerard Date: 2009/3/11 Subject: Re: Disabling File attachments on Wiki To: Dimi Paun 2009/3/11 Dimi Paun : > On Wed, 2009-03-11 at 08:02 -0600, Vitaliy Margolen wrote: >> Anyone? Also how about blocking this IP: 213.155.0.32

Re: Disabling File attachments on Wiki

2009-03-11 Thread Dimi Paun
On Wed, 2009-03-11 at 08:02 -0600, Vitaliy Margolen wrote: > Anyone? Also how about blocking this IP: 213.155.0.32 ? Not sure how we can block that IP easily. If it has to do with iptables, forget it. -- Dimi Paun Lattica, Inc.

Re: [3/6] wined3d: The adapters array should be owned by IWineD3DImpl.

2009-03-11 Thread Henri Verbeet
2009/3/11 Allan Tong : > On Wed, Mar 11, 2009 at 5:18 AM, Henri Verbeet > wrote: > >> @@ -4051,10 +4097,11 @@ static void WINE_GLAPI diffuse_d3dcolor(const void >> *data) >>  static void WINE_GLAPI specular_d3dcolor(const void *data) >>  { >>     DWORD specularColor = *((const DWORD *)data); >>

Re: Wiki challenge question on user account creation

2009-03-11 Thread David Gerard
2009/3/11 Ben Klein : > Does what we have now work? Yes. Is there any reason why we should > consider moving from Moin to some other Wiki system? Your turn to > answer. At work, I use a ridiculous range of wiki engines. I've used Moin and MediaWiki most heavily. Reasons for picking Moin are typ

Re: Disabling File attachments on Wiki

2009-03-11 Thread Vitaliy Margolen
Vitaliy Margolen wrote: > Please disable file attachments on Wiki. There are no way to verify their > validity and for the past week it's been a constant source of spam. > > IMHO file attachment does not belong on text only Wiki. If anyone needs to > attach a patch a two - they can link it to the

Re: [3/6] wined3d: The adapters array should be owned by IWineD3DImpl.

2009-03-11 Thread Allan Tong
On Wed, Mar 11, 2009 at 5:18 AM, Henri Verbeet wrote: > @@ -4051,10 +4097,11 @@ static void WINE_GLAPI diffuse_d3dcolor(const void > *data) >  static void WINE_GLAPI specular_d3dcolor(const void *data) >  { >     DWORD specularColor = *((const DWORD *)data); > +    GLbyte d[] = {D3DCOLOR_B_R(spe

Re: Wiki challenge question on user account creation

2009-03-11 Thread Ben Klein
2009/3/11 King InuYasha : > On Tue, Mar 10, 2009 at 9:17 PM, Ben Klein wrote: >> >> 2009/3/11 King InuYasha : >> > Why are we using Moin anyways? I know Fedora used to use Moin and they >> > moved >> > off of it for their wiki, and I honestly think that perhaps WineHQ needs >> > to >> > as well. >

Re: [ddraw/tests 1/2] Fix a few test failures on W2K (VMware?)

2009-03-11 Thread Paul Vriens
Paul Vriens wrote: Hi, As acknowledged by Stefan, there is no point in testing colors if something isn't drawn. I'm not sure if this is W2K specific or W2K in combination with VMware. Changelog Fix a few test failures on W2K (VMware?) Please ignore this series of 2. I'm first going to check

Re: [ddraw/tests 2/2] Mark some more tests are broken() on W2K

2009-03-11 Thread Henri Verbeet
2009/3/11 Stefan Dösinger : > Am Mittwoch, 11. März 2009 12:07:27 schrieb Paul Vriens: >> +    ok(hr == D3D_OK || >> +       broken(hr == D3DERR_SCENE_IN_SCENE), /* W2K */ >> +       "IDirect3DDevice7_BeginScene failed with %08x\n", hr); > I don't like that one. I think I wrote those tests on Win2K

Re: [ddraw/tests 2/2] Mark some more tests are broken() on W2K

2009-03-11 Thread Paul Vriens
Stefan Dösinger wrote: Am Mittwoch, 11. März 2009 12:07:27 schrieb Paul Vriens: +ok(hr == D3D_OK || + broken(hr == D3DERR_SCENE_IN_SCENE), /* W2K */ + "IDirect3DDevice7_BeginScene failed with %08x\n", hr); I don't like that one. I think I wrote those tests on Win2K partially, so

Re: [ddraw/tests 2/2] Mark some more tests are broken() on W2K

2009-03-11 Thread Stefan Dösinger
Am Mittwoch, 11. März 2009 12:07:27 schrieb Paul Vriens: > +    ok(hr == D3D_OK || > +       broken(hr == D3DERR_SCENE_IN_SCENE), /* W2K */ > +       "IDirect3DDevice7_BeginScene failed with %08x\n", hr); I don't like that one. I think I wrote those tests on Win2K partially, so I'd blame it on Vmw

Re: Wiki challenge question on user account creation

2009-03-11 Thread King InuYasha
On Wed, Mar 11, 2009 at 3:46 AM, David Gerard wrote: > 2009/3/5 King InuYasha : > > > A wiki shouldn't have users creating accounts every day, that is a bad > > indicator. > > > It is difficult to understand the thinking behind such a statement > unless you are literally aiming to close a project

Re: ddraw/visual tests

2009-03-11 Thread Stefan Dösinger
Am Mittwoch, 11. März 2009 11:03:59 schrieb Paul Vriens: > Hi Stefan, > > As you wrote most of the tests: > > I'm looking into some of the ddraw:visual failures (windows 2000 and I > guess only VMware). > > Several tests draw quads but only if _BeginScene succeeded. Is it useful at > all to check t

Re: Wiki challenge question on user account creation

2009-03-11 Thread King InuYasha
I didn't recommend MediaWiki. If anything, MediaWiki would put us in a _worse_ situation than before. On Wed, Mar 11, 2009 at 3:48 AM, David Gerard wrote: > 2009/3/11 King InuYasha : > > > Why are we using Moin anyways? I know Fedora used to use Moin and they > moved > > off of it for their wiki

ddraw/visual tests

2009-03-11 Thread Paul Vriens
Hi Stefan, As you wrote most of the tests: I'm looking into some of the ddraw:visual failures (windows 2000 and I guess only VMware). Several tests draw quads but only if _BeginScene succeeded. Is it useful at all to check the colors afterwards if the quads are not drawn in the first place?

Re: Wiki challenge question on user account creation

2009-03-11 Thread David Gerard
2009/3/11 King InuYasha : > Why are we using Moin anyways? I know Fedora used to use Moin and they moved > off of it for their wiki, and I honestly think that perhaps WineHQ needs to > as well. As someone who's done the Moin->MediaWiki thing, I heartily disrecommend it if avoidable: http://www.

Re: Wiki challenge question on user account creation

2009-03-11 Thread David Gerard
2009/3/5 King InuYasha : > A wiki shouldn't have users creating accounts every day, that is a bad > indicator. It is difficult to understand the thinking behind such a statement unless you are literally aiming to close a project to outside participation. - d.

Re: Wiki challenge question on user account creation

2009-03-11 Thread King InuYasha
On Wed, Mar 11, 2009 at 3:38 AM, King InuYasha wrote: > On Tue, Mar 10, 2009 at 9:17 PM, Ben Klein wrote: > >> 2009/3/11 King InuYasha : >> > Why are we using Moin anyways? I know Fedora used to use Moin and they >> moved >> > off of it for their wiki, and I honestly think that perhaps WineHQ ne

Re: Wiki challenge question on user account creation

2009-03-11 Thread King InuYasha
On Tue, Mar 10, 2009 at 9:17 PM, Ben Klein wrote: > 2009/3/11 King InuYasha : > > Why are we using Moin anyways? I know Fedora used to use Moin and they > moved > > off of it for their wiki, and I honestly think that perhaps WineHQ needs > to > > as well. > > If you're going to argue for a comple

Re: Fwd: [Wine] Re: The pros and cons of a wiki AppDB

2009-03-11 Thread Jerome Leclanche
You cannot compare AppDB to Wikipedia nor anything like that. You cannot compare wiki vandals to spambots either. That's outside the point, anyway. The real problem here is this, a wiki fits a need where most content can be added and changed by anyone and everyone. This is not the AppDB's goal. You