Re: [PATCH] [RFC] Make drive C always a "Local disk"

2009-03-09 Thread Scott Ritchie
Francois Gouget wrote: > On Sun, 8 Mar 2009, Ben Klein wrote: > >> This patch should fix 17619 for new wineprefixes and other cases where C: is >> created. The logic is that C: should never be registered as a network share, >> which is the issue in 17619. It was suggested as a response to a previo

Re: [PATCH 1/4] mshtml: Added IHTMLElement::put_innerHTML implementation.

2009-03-09 Thread Jacek Caban
Alistair Leslie-Hughes wrote: Hi Jacek, Jacek Caban wrote: --- dlls/mshtml/htmlelem.c | 33 +++-- dlls/mshtml/tests/dom.c | 42 ++ 2 files changed, 73 insertions(+), 2 deletions(-) static const WCHAR xW[] = {'x',0};

Re: [PATCH 1/4] mshtml: Added IHTMLElement::put_innerHTML implementation.

2009-03-09 Thread Alistair Leslie-Hughes
Hi Jacek, Jacek Caban wrote: --- dlls/mshtml/htmlelem.c | 33 +++-- dlls/mshtml/tests/dom.c | 42 ++ 2 files changed, 73 insertions(+), 2 deletions(-) static const WCHAR xW[] = {'x',0}; +static const WCHAR yW[] = {'

qmgr test failures

2009-03-09 Thread Austin English
Howdy Rob, Looks like one of your recent qmgr patches added failure to qmgr: http://test.winehq.org/data/1b9a6fb4e9f5a76f1ca352bef121689df02d9289/#group_Wine file.c:121: Test failed: GetRemoteName failed: 800706c6 file.c:124: Tests skipped: Unable to get remote name of test_file. file.c:138: Test

Re: shlwapi/shreg test: difference in results when crosscompiling just the test and the full winetest (Win95)

2009-03-09 Thread Paul Vriens
Reece Dunn wrote: 2009/3/9 Paul Vriens : Hi, I'm trying to fix the last remaining test failures for shlwapi/shreg on my Win95 box. When I crosscompile the full winetest and run "winetest shlwapi:shreg" on my Win95 box the test results are: shreg.c:248: Test failed: Expected ERROR_MORE_DATA, go

Re: Process elevation

2009-03-09 Thread Austin English
On Mon, Mar 9, 2009 at 10:44 AM, Luke Benstead wrote: > I was going to have a go at fixing it, but I'm not sure what is the > best value to set. Should Wine class a user as an admin and all > processes run elevated? If so, then some applications may refuse to > run as admin, and definitely the sam

Re: shlwapi/shreg test: difference in results when crosscompiling just the test and the full winetest (Win95)

2009-03-09 Thread Reece Dunn
2009/3/9 Paul Vriens : > Hi, > > I'm trying to fix the last remaining test failures for shlwapi/shreg on my > Win95 box. When I crosscompile the full winetest and run "winetest > shlwapi:shreg" on my Win95 box the test results are: > > shreg.c:248: Test failed: Expected ERROR_MORE_DATA, got (127) >

shlwapi/shreg test: difference in results when crosscompiling just the test and the full winetest (Win95)

2009-03-09 Thread Paul Vriens
Hi, I'm trying to fix the last remaining test failures for shlwapi/shreg on my Win95 box. When I crosscompile the full winetest and run "winetest shlwapi:shreg" on my Win95 box the test results are: shreg.c:248: Test failed: Expected ERROR_MORE_DATA, got (127) shreg.c:274: Test failed: Expect

Process elevation

2009-03-09 Thread Luke Benstead
Hi all, I was going to post this to #winehackers but it became too long so I'll post here instead :) When trying to run IE8 under Wine, you are greeted with the following error: err:ntdll:NtQueryInformationToken Unhandled Token Information class 18! In the TOKEN_INFORMATION_CLASS enum, 18 refer

Re: msi: Trace the username to help debug test failures on certain machines.

2009-03-09 Thread Paul Vriens
James Hawkins wrote: --- dlls/msi/tests/source.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Hi, The issue seems to be present on boxes that are part of a domain. I guess we have to check for domain a

Re: [1/6] wined3d: Buffer object ID's are supposed to be unsigned.

2009-03-09 Thread Henri Verbeet
2009/3/9 Stefan Dösinger : > Am Montag, 9. März 2009 14:36:57 schrieb Henri Verbeet: >> -    int VBO;            /* Vertex buffer object this data is in */ >> +    unsigned int VBO;   /* Vertex buffer object this data is in */ > Wouldn't the really correct type be GLuint? > Yes, but we can't use th

Re: [1/6] wined3d: Buffer object ID's are supposed to be unsigned.

2009-03-09 Thread Stefan Dösinger
Am Montag, 9. März 2009 14:36:57 schrieb Henri Verbeet: > -    int VBO;            /* Vertex buffer object this data is in */ > +    unsigned int VBO;   /* Vertex buffer object this data is in */ Wouldn't the really correct type be GLuint?

Re: Sufficient 1.2 release criterion: passing all tests on all platforms?

2009-03-09 Thread Alexandre Julliard
Dan Kegel writes: > Here's one possible set of definitions: > > For Windows conformance test validation: > 1st tier: Win XP 32 bit, Win 2003 32 bit, Win Vista 32 and 64 bit, > Win 2008 32 bit Having tests pass on all these platforms is of course a worthwhile goal, but it can't be made a require

Re: [PATCH] [RFC] Make drive C always a "Local disk"

2009-03-09 Thread Ben Klein
2009/3/9 Francois Gouget : > On Sun, 8 Mar 2009, Ben Klein wrote: > >> This patch should fix 17619 for new wineprefixes and other cases where C: is >> created. The logic is that C: should never be registered as a network share, >> which is the issue in 17619. It was suggested as a response to a pre

Re: [PATCH 1/4] gdi32/tests: Don't use bmType to skip tests on win9x - it's equal to 0 for monochrome bitmaps.

2009-03-09 Thread Alexandre Julliard
Huw Davies writes: > --- > dlls/gdi32/tests/bitmap.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) The is_win9x test is broken, that GetWindowLongPtrW call will return 0 on all platforms, so it breaks the tests on Wine: gcc -m32 -c -I. -I. -I../../../include -I../../../include

Re: shell32: szFullPath is needed even for SHGFI_PIDL and SHGFI_USEFILEATTRIBUTES flags combination (bug 17633)

2009-03-09 Thread Alexandre Julliard
Petr Sumbera writes: > dlls/shell32/shell32_main.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/shell32/shell32_main.c b/dlls/shell32/shell32_main.c > index 78a2d57..f2f5924 100644 > --- a/dlls/shell32/shell32_main.c > +++ b/dlls/shell32/shell32_main.c > @@

Re: [1/3] user32: Button should lose highlighting on focus loss (try2)

2009-03-09 Thread Alexandre Julliard
Nikolay Sivov writes: > You could easily reproduce this issue: > - highlight any checkbox with space key > - keep space pressed and changed focus (with arrows or tab) > After that checkbox will be unfocused but still highlighted wich is a bug. > The same applies of course to radiobuttons

Re: dlls/iphlpapi/ipstats.c: #ifdef __linux__

2009-03-09 Thread Austin English
On Sun, Mar 8, 2009 at 6:28 PM, Gerald Pfeifer wrote: > ChangeLog: > append_udp_row is only used on Linux. > > Index: dlls/iphlpapi/ipstats.c > === > RCS file: /home/wine/wine/dlls/iphlpapi/ipstats.c,v > retrieving revision 1.71 > dif

Re: [5/5] ws2_32/tests: Tests for invalid conditions in InetNtop

2009-03-09 Thread Paul Vriens
Paul Vriens wrote: Jeff Latimer wrote: Paul Vriens wrote: Jeff Latimer wrote: MSDN defines an number of conditions that inet_ntop will return errors. This patch tests for them. - Secondly you shouldn't use magic number if you no the name: WSASetLastError(0xc00d); In the tests you do:

Re: [5/5] ws2_32/tests: Tests for invalid conditions in InetNtop

2009-03-09 Thread Paul Vriens
Jeff Latimer wrote: Paul Vriens wrote: Jeff Latimer wrote: MSDN defines an number of conditions that inet_ntop will return errors. This patch tests for them. - Secondly you shouldn't use magic number if you no the name: WSASetLastError(0xc00d); In the tests you do: +ok(WSAGetL

Re: [PATCH] [RFC] Make drive C always a "Local disk"

2009-03-09 Thread Francois Gouget
On Sun, 8 Mar 2009, Ben Klein wrote: > This patch should fix 17619 for new wineprefixes and other cases where C: is > created. The logic is that C: should never be registered as a network share, > which is the issue in 17619. It was suggested as a response to a previous > patch > that this should

Re: [2/5] resend ws2_32/tests: add tests for Inet_Ntop and inet_ntoa

2009-03-09 Thread Jeff Latimer
Paul Vriens wrote: Hi, There is no need to have two if (pInetNtop) statements right after each other, this could be just one. You than don't need to indent the code anymore. You are right. I tidied up the code organising in IPV4 and IPV6 and did not notice I had removed the code between the

Re: [5/5] ws2_32/tests: Tests for invalid conditions in InetNtop

2009-03-09 Thread Jeff Latimer
Paul Vriens wrote: Jeff Latimer wrote: MSDN defines an number of conditions that inet_ntop will return errors. This patch tests for them. - Secondly you shouldn't use magic number if you no the name: WSASetLastError(0xc00d); In the tests you do: +ok(WSAGetLastError() == 0xC

Re: [2/5] resend ws2_32/tests: add tests for Inet_Ntop and inet_ntoa

2009-03-09 Thread Paul Vriens
Jeff Latimer wrote: Note that Inet_Ntop is only available in Vista and Windows 2008. This patch removes the version testing. This one removes the redundant test after GetModuleHandle and adds win_skip(). --- dlls/ws2_32/tests/sock.c | 68 ++ 1

Re: [5/5] ws2_32/tests: Tests for invalid conditions in InetNtop

2009-03-09 Thread Paul Vriens
Jeff Latimer wrote: MSDN defines an number of conditions that inet_ntop will return errors. This patch tests for them. --- dlls/ws2_32/socket.c | 30 +++- dlls/ws2_32/tests/sock.c | 83 - 2 files changed, 109 insertions(+), 4 de