Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (2nd try)

2009-03-05 Thread Vitaliy Margolen
Andreas Rosenberg wrote: > Conformance tests should verify, if the function works like documented. Not correct. If you look at lots of conformance tests they test things that are not documented. In some cases they test things that documentation is wrong about. Vitaliy.

Re: installing ie6 and directX

2009-03-05 Thread Ben Klein
2009/3/6 Rosanne DiMesio : > On Fri, 6 Mar 2009 10:48:15 +1100 > Ben Klein wrote: > >> >> I was going to say check the AppDB, but then I noticed that most of >> the reports had this as an instruction, using ies4linux or >> PlayOnLinux, neither of which Wine approves of. I've cleared out the >> App

Re: installing ie6 and directX

2009-03-05 Thread Rosanne DiMesio
On Fri, 6 Mar 2009 10:48:15 +1100 Ben Klein wrote: > > I was going to say check the AppDB, but then I noticed that most of > the reports had this as an instruction, using ies4linux or > PlayOnLinux, neither of which Wine approves of. I've cleared out the > AppDB of those entries and asked the pe

Re: [1/n] vbscript: Added stub dll

2009-03-05 Thread James Hawkins
On Thu, Mar 5, 2009 at 4:16 PM, Lei Zhang wrote: > On Thu, Mar 5, 2009 at 3:37 PM, Nikolay Sivov wrote: >> Robert Wilhelm wrote: >>> >>> Second try, now patch as attachment. >> >> 1) Please don't add autogenerated files to patch. >> >> >> >> configure                     |    9 >> confi

Re: [1/n] vbscript: Added stub dll

2009-03-05 Thread Lei Zhang
On Thu, Mar 5, 2009 at 3:37 PM, Nikolay Sivov wrote: > Robert Wilhelm wrote: >> >> Second try, now patch as attachment. > > 1) Please don't add autogenerated files to patch. > > > > configure                     |    9 > configure.ac                  |    1 + > I thought we're supp

Re: installing ie6 and directX

2009-03-05 Thread Ben Klein
2009/3/4 alice_wl : > hello I just installed wine and used winetricks to get IE > actualy I want to play combat arms I was going to say check the AppDB, but then I noticed that most of the reports had this as an instruction, using ies4linux or PlayOnLinux, neither of which Wine approves of. I've c

Re: [1/n] vbscript: Added stub dll

2009-03-05 Thread Nikolay Sivov
Robert Wilhelm wrote: Second try, now patch as attachment. 1) Please don't add autogenerated files to patch. configure |9 configure.ac |1 + 2) Patches [2/n] and [3/n]. Each patch should contain all related changes to be usefu

Re: [RFC] named pipe message-mode design

2009-03-05 Thread Ben Klein
2009/3/5 Luke Kenneth Casson Leighton : > On Thu, Mar 5, 2009 at 3:06 AM, Ben Klein wrote: >> 2009/3/5 Luke Kenneth Casson Leighton : >>> On Wed, Mar 4, 2009 at 6:10 PM, Alexandre Julliard >>> wrote: Luke Kenneth Casson Leighton writes: >  i would imagine that inefficient is the _

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (2nd try)

2009-03-05 Thread Vitaliy Margolen
Andreas Rosenberg wrote: > According to MSDN the error codes are not part of the API documentation: > > "The error codes returned by a function are not part of the Windows API But they are. MS just made their obligation to document all of their craft that much easer and that much more undefined.

Re: [sane.ds 4/4] More correctly detect an end of scan job from sane; this enables Acrobat to pull multiple pages in one scan.

2009-03-05 Thread Jeremy White
Sorry; I made a basic mistake (failed to check --without-sane). Resending hopefully corrected patch. Cheers, Jeremy

Re: winemaker: add project-parse function

2009-03-05 Thread Francois Gouget
Here are some quick comments: You cannot add functions that are not used. So this patch should include the following lines from patch 0004: +if (defined $opt_work_dir) { +# Now scan the directory tree looking for source files and, maybe, targets +print "Scanning the source

dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (5)

2009-03-05 Thread Andreas Rosenberg
From d59c1fe3e26e0cb41a3affe4034abc6dc9bd0556 Mon Sep 17 00:00:00 2001 From: Andreas.Rosenberg Date: Thu, 5 Mar 2009 18:41:37 +0100 Subject: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A --- dlls/userenv/Makefile.in |2 +- dlls/userenv/tests/userenv.c | 37 + dl

Re: Re: winemaker: fix 32-bit compiling and winresrc.h is the, right name

2009-03-05 Thread André Hentschel
It works great! So IMHO it can be used.

Re: WineHQ.org downtime

2009-03-05 Thread Jeremy Newman
Nothing exciting. Just an OS upgrade from Etch to Lenny. Hopefully, that will solve some hangs we have been seeing lately in apache. This is phase1 of my upgrade plan. In the next week or so, I will also be upgrading the hardware to a beefier setup. -Newman IneedAname wrote: On Tue, 03 Mar

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (4)

2009-03-05 Thread Francois Gouget
On Thu, 5 Mar 2009, Jeremy White wrote: > > Much less important but still: please remove trailing whitespaces. > > 'git apply' should not produce any warnings. > > I've discovered that if you use git-add to fully stage your commit, you > can then run: > git-diff-index --check HEAD > immediatel

Re: vbscript.dll stubs

2009-03-05 Thread Nikolay Sivov
Robert Wilhelm wrote: Initial vbscript stubs, similar to jscript. Diff looks corrupted by mailing application. Lines are wrapped.

Re: [PATCH 03/10] widl: Implement a more abstract way of representing basic types.

2009-03-05 Thread Alexandre Julliard
Rob Shearman writes: > Thanks for the info. Does the attached patch fix it? Not quite (static variables are zero anyway), but this does: diff --git a/tools/widl/typetree.c b/tools/widl/typetree.c index 57a5736..74cbd5f 100644 --- a/tools/widl/typetree.c +++ b/tools/widl/typetree.c @@ -102,7 +10

Re: msacm32: acmFormatEnum - implementing ACM_FORMATENUMF_SUGGEST (2nd try)

2009-03-05 Thread Stefano Guidoni
The fact is that the email service of my service provider is prone to screw up everything that seems plain text. I'll look for a solution. S. G.

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (2nd try)

2009-03-05 Thread Andreas Rosenberg
Nikolay Sivov wrote: > Andreas Rosenberg wrote: > > +    if ( !lpcchSize ) { > +        SetLastError(ERROR_INVALID_PARAMETER); > +        return FALSE; > > > +                    SetLastError(ERROR_MORE_DATA); > +                } > +            } > +        } > +        else > +            Set

Re: WineHQ.org downtime

2009-03-05 Thread IneedAname
On Tue, 03 Mar 2009 11:08:02 -0600 Jeremy Newman wrote: > Software upgrades complete. So whats new?

Re: Wiki challenge question on user account creation

2009-03-05 Thread Dimi Paun
On Thu, 2009-03-05 at 14:07 +0800, Dmitry Timoshkov wrote: > Actually if there are a lot of user account creation every day in the > Wine wiki then there is something wrong with it. There are not that > much Wine developers and probably some active testers/appdb > maintainers, who else could prete

Re: [PATCH 03/10] widl: Implement a more abstract way of representing basic types.

2009-03-05 Thread Rob Shearman
2009/3/5 Alexandre Julliard : > Rob Shearman writes: > >> --- >>  tools/widl/expr.c      |   18 >>  tools/widl/header.c    |   34 ++-- >>  tools/widl/parser.y    |  103 >> ++- >>  tools/widl/typelib.c   |   60 --

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (4)

2009-03-05 Thread Jeremy White
> Much less important but still: please remove trailing whitespaces. > 'git apply' should not produce any warnings. I've discovered that if you use git-add to fully stage your commit, you can then run: git-diff-index --check HEAD immediately prior to committing; that will catch such warnings wh

Re: [PATCH 03/10] widl: Implement a more abstract way of representing basic types.

2009-03-05 Thread Alexandre Julliard
Rob Shearman writes: > --- > tools/widl/expr.c | 18 > tools/widl/header.c| 34 ++-- > tools/widl/parser.y| 103 ++- > tools/widl/typelib.c | 60 > tools/widl/typetree.c | 31 ++

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (4)

2009-03-05 Thread Nikolay Sivov
Andreas Rosenberg wrote: Fails on XP SP2 with: --- userenv.c:308: Test failed: Expected 1, got 39 userenv: 92 tests executed (0 marked as todo, 1 failure), 0 skipped. --- Much less important but still: please remove trailing whitespaces. 'git apply' should not pro

RE: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (2nd try)

2009-03-05 Thread Andreas Rosenberg
>> I don't consider it helpful writing a conformance test, for something >> that is not specified. One could simply omit the error codes, but if >> this call should fail an app may log/present a more meaningfull error >> message than without it. If the error codes should be different from >> Windo

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (3rd try)

2009-03-05 Thread Nikolay Sivov
Andreas Rosenberg wrote: Test looks better but: +r = OpenProcessToken(GetCurrentProcess(), TOKEN_QUERY|TOKEN_DUPLICATE, &htoken); +expect(TRUE, r); + +r = GetUserProfileDirectoryW(htoken , NULL, NULL ); +lastError = GetLastError(); +expect(FALSE, r); +expect(last

Re: [programs/winetest] Show dll versions again for Win9x/WinME

2009-03-05 Thread Paul Vriens
Paul Vriens wrote: Hi, GetModuleFileNameA should not work on dlls loaded using LOAD_LIBRARY_AS_DATAFILE according to MSDN. This happens to be only true for Win9x/WinME (sigh) otherwise we probably would have noted this much earlier. As of Feb-3-2009 we didn't have version numbers for the dll

Re: Wiki challenge question on user account creation

2009-03-05 Thread King InuYasha
Oops... -- Forwarded message -- From: King InuYasha Date: Thu, Mar 5, 2009 at 4:34 AM Subject: Re: Wiki challenge question on user account creation To: Dmitry Timoshkov On Thu, Mar 5, 2009 at 12:07 AM, Dmitry Timoshkov wrote: > "Dimi Paun" wrote: > > On Wed, 2009-03-04 at

Re: [RFC] named pipe message-mode design

2009-03-05 Thread Luke Kenneth Casson Leighton
On Wed, Mar 4, 2009 at 10:14 PM, Alexandre Julliard wrote: > Luke Kenneth Casson Leighton writes: > how would you envisage doing client-side SMB named pipes? >>> >>> By doing the I/O through the wineserver. It has all the necessary >>> mechanisms already. >> >> ok - great. whereabouts? whi

Re: [RFC] named pipe message-mode design

2009-03-05 Thread Luke Kenneth Casson Leighton
>> sure you can. by redesigning. >> >> >> > Since I deal with that on a daily basis, I'll step in. A great design > is one that does EVERYTHING right the first time. have you heard of incremental improvements? > What you are > proposing goes counter to this and is unacceptable. have you hea

Re: [RFC] named pipe message-mode design

2009-03-05 Thread Luke Kenneth Casson Leighton
On Thu, Mar 5, 2009 at 3:06 AM, Ben Klein wrote: > 2009/3/5 Luke Kenneth Casson Leighton : >> On Wed, Mar 4, 2009 at 6:10 PM, Alexandre Julliard >> wrote: >>> Luke Kenneth Casson Leighton writes: >>> i would imagine that inefficient is the _last_ thing on the list of priorities. "te