Re: wintrust(3/3): Fix a couple tests on a variety of systems

2009-02-11 Thread Paul Vriens
Juan Lang wrote: > --Juan > > > > > This is of course on boxes where people dont' run winetest as a administrator. I'm not sure if ERROR_ACCESS_DENIED is thus actually an acceptable failure. In other tests we have used s

Re: Is the test.winehq.org front page too pessimistic?

2009-02-11 Thread Paul Vriens
Juan Lang wrote: > The front page of test.winehq.org shows statistics about failed tests, > but it doesn't seem to take into account the number of individual > tests that passed and failed, rather the number of files that had any > failures. > > So, for example, about a week ago I got a fix commit

Re: Error on CVS server: no space left on device

2009-02-11 Thread Jeremy Newman
Yep, the web server ran out of disk space. We are working on clearing things out a bit. Seems test.winehq.org is taking much more disk than we expected. Seems a hardware upgrade needs to be pushed out pretty darn soon. -Newman Paul Chitescu wrote: > Hi! > > The CVS server cvs.winehq.org is ou

Re: itss: Replace malloc() with HeapAlloc()

2009-02-11 Thread Francois Gouget
On Wed, 11 Feb 2009, Vitaliy Margolen wrote: [...] > Don't forget few places with strdup: Yes I've seen them too :-( Should we ban it too? What's the proper replacement? StrDupA() is only exported by slwapi.dll which means it's not a good choice... -- Francois Gouget http://fgoug

Re: itss: Replace malloc() with HeapAlloc()

2009-02-11 Thread Vitaliy Margolen
Francois Gouget wrote: > On Tue, 10 Feb 2009, Andrew Talbot wrote: > [...] >> There are also many calls to realloc() - a function with complexities of its >> own - and other functions with "realloc" in their name. > > Good point. Here are the ones I noticed: > > dlls/rsaenh/mpi.c:3668:if ((tm

Re: An idea for the appdb

2009-02-11 Thread Ben Klein
2009/2/12 Sparr : > On Wed, Feb 11, 2009 at 7:31 PM, Ben Klein wrote: >> 2009/2/12 Gert van den Berg : >>> It should rather be opt-in. Such as "Wine has detected that it is the >>> first time you run this application, do you want to check AppDb for >>> more information (Yes/No/Ask again/Never ask

Re: An idea for the appdb

2009-02-11 Thread Sparr
On Wed, Feb 11, 2009 at 7:31 PM, Ben Klein wrote: > 2009/2/12 Gert van den Berg : >> It should rather be opt-in. Such as "Wine has detected that it is the >> first time you run this application, do you want to check AppDb for >> more information (Yes/No/Ask again/Never ask for any application)" >

Re: Is the test.winehq.org front page too pessimistic?

2009-02-11 Thread Scott Ritchie
James Hawkins wrote: > On Wed, Feb 11, 2009 at 3:27 PM, Alexandre Julliard > wrote: >> James Hawkins writes: >> >>> We should leave the failing files percentage up (note the name change) >>> and add a failing tests percentage next to it. The failing tests >>> percentage should be total_test_fai

Re: How to get more info on timed out/crashed tests?

2009-02-11 Thread Ricardo Filipe
2009/2/11 Juan Lang > Hi all, > > there are a number of tests at test.winehq.org that indicate that > they're timed out or crashed. The difficulty is, I have no access to > machines running the version of Windows on which the test is timing > out or failing, and the data about the crash are not

Re: Is the test.winehq.org front page too pessimistic?

2009-02-11 Thread Ricardo Filipe
2009/2/11 Alexandre Julliard > > That's not a useful number, many files run a lot of tests, of which a > huge majority always succeeds. Having a single failure among 10,000 > tests means that the test failed, and it's something bad that should be > taken care of. Showing that as a 99.99% success

Re: An idea for the appdb

2009-02-11 Thread Ben Klein
2009/2/12 Gert van den Berg : > On Wed, Feb 11, 2009 at 2:24 PM, Luke Benstead wrote: >> I can also see what you mean about >> spyware, but other apps retrieve stuff from the web if there is a >> connection (CDDB, and album covers are two examples). >> > Wine transmitting every application I run t

Re: Error on CVS server: no space left on device

2009-02-11 Thread Ben Klein
2009/2/12 Paul Chitescu : > Hi! > > The CVS server cvs.winehq.org is out of disk space: > > $ cvs -z3 -q up -APd > can't create temporary directory /tmp/cvs-serv29410 > No space left on device Wine switched to git ages ago. I'm surprised the CVS server is still accepting requests.

Re: Is the test.winehq.org front page too pessimistic?

2009-02-11 Thread Ben Klein
2009/2/12 James Hawkins : > On Wed, Feb 11, 2009 at 3:27 PM, Alexandre Julliard > wrote: >> James Hawkins writes: >> >>> We should leave the failing files percentage up (note the name change) >>> and add a failing tests percentage next to it. The failing tests >>> percentage should be total_tes

Error on CVS server: no space left on device

2009-02-11 Thread Paul Chitescu
Hi! The CVS server cvs.winehq.org is out of disk space: $ cvs -z3 -q up -APd can't create temporary directory /tmp/cvs-serv29410 No space left on device Message is received from remote server. Anyone able to fix it? Regards, Paul Chitescu

Re: Wine64 : Trying to load PE image for unsupported architecture (I386)

2009-02-11 Thread Erik de Castro Lopo
Alexandre Julliard wrote: > Not really, you'll of course still need to build a full 32-bit version > of Wine, the 64-bit Wine will never be able to run 32-bit apps. Ok. > What > needs to be improved is that the 64-bit loader should be able to forward > automatically to the 32-bit one when encou

Re: Is the test.winehq.org front page too pessimistic?

2009-02-11 Thread James Hawkins
On Wed, Feb 11, 2009 at 3:27 PM, Alexandre Julliard wrote: > James Hawkins writes: > >> We should leave the failing files percentage up (note the name change) >> and add a failing tests percentage next to it. The failing tests >> percentage should be total_test_failures / total_tests_run. > > Th

Re: Is the test.winehq.org front page too pessimistic?

2009-02-11 Thread Alexandre Julliard
James Hawkins writes: > We should leave the failing files percentage up (note the name change) > and add a failing tests percentage next to it. The failing tests > percentage should be total_test_failures / total_tests_run. That's not a useful number, many files run a lot of tests, of which a h

Re: Wine64 : Trying to load PE image for unsupported architecture (I386)

2009-02-11 Thread Alexandre Julliard
Erik de Castro Lopo writes: > While I expected it to not work with my Win64 program I was a little > surprised that when running a WIn32 program I got: > > Trying to load PE image for unsupported architecture (I386) > > I realise that the Win64 stuff is experimental but I'm curions, in > the

Re: Is the test.winehq.org front page too pessimistic?

2009-02-11 Thread James Hawkins
On Wed, Feb 11, 2009 at 1:58 PM, Juan Lang wrote: > The front page of test.winehq.org shows statistics about failed tests, > but it doesn't seem to take into account the number of individual > tests that passed and failed, rather the number of files that had any > failures. > > So, for example, ab

Re: Is the test.winehq.org front page too pessimistic?

2009-02-11 Thread John Klehm
On Wed, Feb 11, 2009 at 3:58 PM, Juan Lang wrote: > My own feeling is that there are far fewer failing tests now than > there used to be, and I'd sure like to see that reflected somewhere at > a quick glance. Thoughts? Maybe a test.winehq.org/trends page showing some nice (hopefully upwards) tr

Re: An idea for the appdb

2009-02-11 Thread John Klehm
Please correct me if I'm wrong but before we go about collecting all this information wouldn't it be better to have some compatibility framework in Wine that could actually make use of it? Otherwise we're collecting a lot of information that is of little immediate use. In other words we'd have so

Is the test.winehq.org front page too pessimistic?

2009-02-11 Thread Juan Lang
The front page of test.winehq.org shows statistics about failed tests, but it doesn't seem to take into account the number of individual tests that passed and failed, rather the number of files that had any failures. So, for example, about a week ago I got a fix committed for some failing mapi32 t

Re: An idea for the appdb

2009-02-11 Thread Luke Benstead
2009/2/11 Matt 'Murph' Finnicum : > On Wed, Feb 11, 2009 at 2:33 PM, wrote: >> >> >> On Wed, 11 Feb 2009 13:03:21 -0700 (GMT-07:00), James Mckenzie >> wrote: Automatic submission of test data could be a very handy tool. >>> This would be great, but as previously discussed, who woul

Re: Wine64 : Trying to load PE image for unsupported architecture (I386)

2009-02-11 Thread David Gerard
2009/2/11 Erik de Castro Lopo : > I realise that the Win64 stuff is experimental but I'm curions, in > the longer term is it expected that one executable will be able to > run both Win32 and Win64 executables? Not yet. You're welcome to write it though ;-) - d.

Re: Wine64 : Trying to load PE image for unsupported architecture (I386)

2009-02-11 Thread Austin English
On Wed, Feb 11, 2009 at 3:00 PM, Erik de Castro Lopo wrote: > Hi all, > > I build Wine64 using the instructions here: > >http://wiki.winehq.org/Wine64 > > While I expected it to not work with my Win64 program I was a little > surprised that when running a WIn32 program I got: > >Trying to

Wine64 : Trying to load PE image for unsupported architecture (I386)

2009-02-11 Thread Erik de Castro Lopo
Hi all, I build Wine64 using the instructions here: http://wiki.winehq.org/Wine64 While I expected it to not work with my Win64 program I was a little surprised that when running a WIn32 program I got: Trying to load PE image for unsupported architecture (I386) I realise that the Win64

How to get more info on timed out/crashed tests?

2009-02-11 Thread Juan Lang
Hi all, there are a number of tests at test.winehq.org that indicate that they're timed out or crashed. The difficulty is, I have no access to machines running the version of Windows on which the test is timing out or failing, and the data about the crash are not helpful in pinpointing the failin

Re: winedos: Replace [c]alloc() with HeapAlloc()

2009-02-11 Thread Andrew Talbot
Andrew Talbot wrote: Sorry, title should be: winedos: Replace [m|c]alloc() with HeapAlloc() -- Andy.

Re: An idea for the appdb

2009-02-11 Thread Matt 'Murph' Finnicum
On Wed, Feb 11, 2009 at 2:33 PM, wrote: > > > On Wed, 11 Feb 2009 13:03:21 -0700 (GMT-07:00), James Mckenzie > wrote: >>> >>>Automatic submission of test data could be a very handy tool. >>> >> This would be great, but as previously discussed, who would maintain this >> information >> and verify

Re: An idea for the appdb

2009-02-11 Thread alex
On Wed, 11 Feb 2009 13:03:21 -0700 (GMT-07:00), James Mckenzie wrote: >> >>Automatic submission of test data could be a very handy tool. >> > This would be great, but as previously discussed, who would maintain this > information > and verify it is correct and proper? Although some features wou

Re: An idea for the appdb

2009-02-11 Thread James Mckenzie
-Original Message- >From: a...@centroidcafe.com >Sent: Feb 11, 2009 10:59 AM >To: wine-devel@winehq.org >Subject: Re: An idea for the appdb > >Sorry .. forgot to reply all. > >Automatic submission of test data could be a very handy tool. Scenario: >User A tries to run an application, it c

Re: An idea for the appdb

2009-02-11 Thread Austin English
This was discussed a couple months ago, nearly to death. It's a cool idea, sure, but a ton of work to do, and not really worth the effort. The data is quickly outdated with new wine versions. Some users may consider it spyware, developers would find it annoying, and overall, it would be a big mess.

Re: An idea for the appdb

2009-02-11 Thread alex
Sorry .. forgot to reply all. On Wed, 11 Feb 2009 18:08:47 +0200, Gert van den Berg wrote: > On Wed, Feb 11, 2009 at 2:24 PM, Luke Benstead wrote: >> I can also see what you mean about >> spyware, but other apps retrieve stuff from the web if there is a >> connection (CDDB, and album covers are t

Download page requires too much scrolling...

2009-02-11 Thread Dan Kegel
While I was generating screenshots for my presentation, I noticed that http://www.winehq.org/download/ has too much clutter at the top. I don't mind the Codeweavers ad, but it's not good that users have to scroll down to see the useful part of the page...

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread Austin English
On Wed, Feb 11, 2009 at 11:40 AM, Vincent Povirk wrote: >> $ wine setup.exe # program doesn't work/error about admin rights/etc. >> $ sudo wine setup.exe >> wine: '/home/user/.wine' is not owned by you, refusing to create a >> configuration directory there >> $ sudo su >> # wine setup.exe > > Ok,

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread Vincent Povirk
> $ wine setup.exe # program doesn't work/error about admin rights/etc. > $ sudo wine setup.exe > wine: '/home/user/.wine' is not owned by you, refusing to create a > configuration directory there > $ sudo su > # wine setup.exe Ok, if I understand you, one of the following things happens after th

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread Austin English
On Wed, Feb 11, 2009 at 11:02 AM, Vincent Povirk wrote: >> No we don't want Wine to function in those cases, and it is part of the >> ownership test already. > > wine: '/home/sudotest' is not owned by you, refusing to create a > configuration directory there > > So it is. Well then, there's no nee

Re: An idea for the appdb

2009-02-11 Thread Tim Schwartz
On Wed, Feb 11, 2009 at 8:58 AM, wrote: > Send wine-devel mailing list submissions to >wine-devel@winehq.org > > To subscribe or unsubscribe via the World Wide Web, visit >http://www.winehq.org/mailman/listinfo/wine-devel > or, via email, send a message with subject or body 'help'

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread Vincent Povirk
> No we don't want Wine to function in those cases, and it is part of the > ownership test already. wine: '/home/sudotest' is not owned by you, refusing to create a configuration directory there So it is. Well then, there's no need for an additional warning as far as I'm concerned. When was this

Re: An idea for the appdb

2009-02-11 Thread Gert van den Berg
On Wed, Feb 11, 2009 at 2:24 PM, Luke Benstead wrote: > I can also see what you mean about > spyware, but other apps retrieve stuff from the web if there is a > connection (CDDB, and album covers are two examples). > Wine transmitting every application I run to someone else would be rather worryin

Re: itss: Replace malloc() with HeapAlloc()

2009-02-11 Thread Francois Gouget
On Tue, 10 Feb 2009, Andrew Talbot wrote: [...] > There are also many calls to realloc() - a function with complexities of its > own - and other functions with "realloc" in their name. Good point. Here are the ones I noticed: dlls/rsaenh/mpi.c:3668:if ((tmp = realloc (a->dp, sizeof (mp_digit)

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread James Mckenzie
Steve Brown wrote: > >On Tue, 10 Feb 2009, Vitaliy Margolen wrote: > >> Ben Klein wrote: >>> This is not a problem with Wine, this is OpenSUSE breaking the >>> environment when sudo is called. Remember, Wine is not the only X11 >>> app out there. Others will need $DISPLAY working! >> This is somet

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread Marcus Meissner
On Wed, Feb 11, 2009 at 09:35:26AM -0500, Steve Brown wrote: > On Tue, 10 Feb 2009, Vitaliy Margolen wrote: > > > Ben Klein wrote: > >> This is not a problem with Wine, this is OpenSUSE breaking the > >> environment when sudo is called. Remember, Wine is not the only X11 > >> app out there. Others

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread Steve Brown
On Tue, 10 Feb 2009, Vitaliy Margolen wrote: > Ben Klein wrote: >> This is not a problem with Wine, this is OpenSUSE breaking the >> environment when sudo is called. Remember, Wine is not the only X11 >> app out there. Others will need $DISPLAY working! > This is something called security No,

Re: imm32: Make space for a 64bit pointer in the IMM window.

2009-02-11 Thread Aric Stewart
Ok digging into my IME documentation I see this: "The cbWndExtra of the UI class has to be 2 * sizeof(LONG). The purpose of this WndExtra is defined by the system (for example, IMMGWL_IMC and IMMGWL_PRIVATE)." So any IME developer is properly reserving 64 bits already. Which means my concern i

Re: imm32: Make space for a 64bit pointer in the IMM window.

2009-02-11 Thread Michael Stefaniuc
Aric Stewart wrote: > I am not a 64 bit expert but i do not think this is going to work. > > ddk/imm.h is a Microsoft header so IMEs and programs compiled with the > original header will not have the expanded space. They will as the Microsoft header has the exact same change as I did in this patch

Re: imm32: Make space for a 64bit pointer in the IMM window.

2009-02-11 Thread Aric Stewart
I am not a 64 bit expert but i do not think this is going to work. ddk/imm.h is a Microsoft header so IMEs and programs compiled with the original header will not have the expanded space. To fix this properly (I assume you are trying to support 64 bit) is that we will probibly have to store a h

Re: An idea for the appdb

2009-02-11 Thread Ben Klein
2009/2/11 Luke Benstead : > 2009/2/11 Ben Klein : >> 2009/2/11 Luke Benstead : >>> My idea is that the appdb should allow for people to associate a list >>> of checksums with an application version. For example, WoW might have >>> the checksum for the setup program and the game's executable, >>> as

Re: crypt32(1/4): Add chain debugging channel for debugging certificate chaining errors

2009-02-11 Thread Alexandre Julliard
Juan Lang writes: > +static void dump_element(PCCERT_CONTEXT cert) > +{ > +LPWSTR name = NULL; > +DWORD len, i; > + > +TRACE_(chain)("%p\n", cert); > +len = CertGetNameStringW(cert, CERT_NAME_SIMPLE_DISPLAY_TYPE, > + CERT_NAME_ISSUER_FLAG, NULL, NULL, 0); > +name = CryptMe

Re: An idea for the appdb

2009-02-11 Thread Luke Benstead
2009/2/11 Ben Klein : > 2009/2/11 Luke Benstead : >> Hi all, >> >> I was thinking earlier it would be quite nice if when I double clicked >> a Windows app in GNOME it would display a nice dialog saying something >> like "This Windows application may not run correctly as it is >> currently rated Sil

Re: Fully automated bisecting with "git bisect run" [LWN.net]

2009-02-11 Thread Darragh Bailey
On Wed, Feb 11, 2009 at 10:42:14AM +0100, Uwe Bonnes wrote: > > "Ben" == Ben Klein writes: > > Ben> 2009/2/11 nn : > >> Fully automated bisecting with "git bisect run" [LWN.net]: > >> http://lwn.net/SubscriberLink/317154/5dec0c8146e58b61/ > >> > >> Would this be useful to

Re: An idea for the appdb

2009-02-11 Thread Ben Klein
2009/2/11 Luke Benstead : > Hi all, > > I was thinking earlier it would be quite nice if when I double clicked > a Windows app in GNOME it would display a nice dialog saying something > like "This Windows application may not run correctly as it is > currently rated Silver. Please report any bugs to

An idea for the appdb

2009-02-11 Thread Luke Benstead
Hi all, I was thinking earlier it would be quite nice if when I double clicked a Windows app in GNOME it would display a nice dialog saying something like "This Windows application may not run correctly as it is currently rated Silver. Please report any bugs to the Wine project. Continue | Cancel"

Re: Fully automated bisecting with "git bisect run" [LWN.net]

2009-02-11 Thread Uwe Bonnes
> "Ben" == Ben Klein writes: Ben> 2009/2/11 nn : >> Fully automated bisecting with "git bisect run" [LWN.net]: >> http://lwn.net/SubscriberLink/317154/5dec0c8146e58b61/ >> >> Would this be useful to add to the instructions on the wine wiki. >> Ben> If I understan

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread Alexandre Julliard
Vincent Povirk writes: >> To abstract what you're saying here, you're suggesting to extend the >> wineprefix ownership test to include $HOME when $WINEPREFIX is not set >> and $HOME/.wine does not exist? >> >> That doesn't sounds like a bad idea to me. But I'm not so sure about >> specifically te