ioports.c change -> buffer overflow ... bug?

2009-02-08 Thread Marcus Meissner
Hi Florian, You are calling get_timer_val(3) in ioports.c (if (chan == 3) ... going down to get_timer_val(chan)) Howver, tmr_8253 is just a 3 element array, so [3] will run over the end, Is your code right? The change comes from this commit: commit edbd4885542e4545439906df950a68dc48e70

Re: EVE online losing its Linux Client

2009-02-08 Thread Ben Klein
2009/2/9 Zachary Goldberg : > 2009/2/8 Chris Robinson : >> Their "native Linux client" was the Windows client on top of Cedega. They're >> stopping support for the official client running on Cedega, and instead >> recommending Wine. >> > > Hm, interesting. Little room for sadness then, party all a

[Fwd: Re: [Wine] imagicos]

2009-02-08 Thread James McKenzie
Sent to wrong mailing list. Comment stands. Apple is almost as bad as Microsoft with trademark enforcement. James McKenzie Original Message Subject:Re: [Wine] imagicos Date: Sun, 08 Feb 2009 19:58:52 -0700 From: James McKenzie To: IneedAname CC: Wine R

Re: EVE online losing its Linux Client

2009-02-08 Thread Zachary Goldberg
2009/2/8 Chris Robinson : > Their "native Linux client" was the Windows client on top of Cedega. They're > stopping support for the official client running on Cedega, and instead > recommending Wine. > Hm, interesting. Little room for sadness then, party all around!

Re: EVE online losing its Linux Client

2009-02-08 Thread Chris Robinson
On Sunday 08 February 2009 6:17:38 pm Zachary Goldberg wrote: > http://games.slashdot.org/article.pl?sid=09/02/08/206252&from=rss > > It seems that a game studio found that Wine worked so well that they > have given up their efforts to maintain a native client. While > encouraging that Wine works

EVE online losing its Linux Client

2009-02-08 Thread Zachary Goldberg
http://games.slashdot.org/article.pl?sid=09/02/08/206252&from=rss It seems that a game studio found that Wine worked so well that they have given up their efforts to maintain a native client. While encouraging that Wine works so well, there is a very interesting debate which could be had as to wh

Re: imagicos

2009-02-08 Thread Ben Klein
2009/2/9 Remco : > On Sat, Feb 7, 2009 at 11:12 PM, Hin-Tak Leung > wrote: >> That's right - GPL allows you to charge for binaries, and any amount for >> that matter. GPL just means who ever received the binaries are also entitled >> to the source code, and *also* the right to sell both onward

Re: New coverity run Feb 7, 14 new warnings

2009-02-08 Thread Jacek Caban
Dan Kegel wrote: > Is it a bug? I don't know those flags well enough. It's not a bug, a constant 0 value is passed as flags to set_nsstyle_attr. I've marked it as FALSE in coverity. Jacek

Re: New coverity run Feb 7, 14 new warnings

2009-02-08 Thread Dan Kegel
Alistair wrote: >> 873 FORWARD_NULLHTMLStyle_put_fontWeight dlls/mshtml/htmlstyle.c > > NULL is a valid value to be passed though to gecko. Here's more of the error: dlls/mshtml/htmlstyle.c Event var_deref_model: Variable "v" tracked as NULL was passed to a function that dereferences i

Re: New coverity run Feb 7, 14 new warnings

2009-02-08 Thread Alistair Leslie-Hughes
Hi Dan, > 873 FORWARD_NULLHTMLStyle_put_fontWeight > dlls/mshtml/htmlstyle.c NULL is a valid value to be passed though to gecko. Best Regards Alistair Leslie-Hughes

Re: imagicos

2009-02-08 Thread Remco
On Sat, Feb 7, 2009 at 11:12 PM, Hin-Tak Leung wrote: > That's right - GPL allows you to charge for binaries, and any amount for that > matter. GPL just means who ever received the binaries are also entitled to > the source code, and *also* the right to sell both onward - and possibly as a > co

Re: Question about redirection handles in wcmd

2009-02-08 Thread Erich Hoover
On Sat, Feb 7, 2009 at 2:09 PM, Erich Hoover wrote: > I tracked down an issue where an application was running into a sharing > problem in WCMD_execute when it created redirects to the same file more than > once. I originally hacked around this issue by changing the sharing mode > for redirects,

Re: LookupIconIdFromDirectory16() is unused

2009-02-08 Thread Detlef Riekenberg
On So, 2009-02-08 at 01:23 +0800, Tom Wickline wrote: > Maybe this little util will come in handy. > > http://www.nirsoft.net/utils/dll_export_viewer.html > > Download is at the bottom of the page just after Feedback. As most other dll tools, this one also does not work with NE files -- By

New coverity run Feb 7, 14 new warnings

2009-02-08 Thread Dan Kegel
Congrats to everyone who's been cleaning up Coverity warnings, especially Marcus (http://marcusmeissner.livejournal.com/24466.html). Here are the yet-uninspected warnings that are in the Feb 7 run but not in the Jan 30 run: 884 REVERSE_INULL compile_file_regex dlls/dbghelp/symbol.c 883

Re: New Wine Gecko package

2009-02-08 Thread Jacek Caban
Vitaliy Margolen wrote: Jacek Caban wrote: Hi all, The last release of Wine Gecko caused a few regressions. Yes it did and some are still not fixed. Flash does not work anymore on all the pages. This really needs to be fixed. I've been looking on it for a while and I didn't find

Re: mshtml/tests: skip tests if gecko is not available

2009-02-08 Thread Jacek Caban
Hi Austin, Austin English wrote: -hres = IHTMLDocument2_get_body(doc, &body); -ok(hres == S_OK, "get_body failed: %08x\n", hres); - if(body) { +hres = IHTMLDocument2_get_body(doc, &body); +ok(hres == S_OK, "get_body failed: %08x\n", hres); You check body before get

Re: Bugzilla default assignment for secur32

2009-02-08 Thread Jan Zerebecki
On Sun, Feb 08, 2009 at 09:46:20AM +0100, Kai Blin wrote: > since SSL support sort of works, we're getting a large amount of SSL-related > bugs. As I don't deal with the SSL-implementation at all, could some Bugzilla > admin remove me as defauly assignee for secur32 bugs again? done.

Re: imagicos

2009-02-08 Thread Hin-Tak Leung
--- On Sat, 7/2/09, Peter Bortas wrote: > On Sat, Feb 7, 2009 at 4:57 PM, Ben Klein > wrote: > > > What it seems to me is that they are selling binaries, > not support. > > They could be selling licenses (for Crossover, mp3 > etc), but that's > > not a matter for us to resolve. If it is determi

Re: dinput: joydevs[id].name (EVIOCGNAME) is product name, joydevs[id].device is a path

2009-02-08 Thread Vincent Pelletier
Le Saturday 07 February 2009 19:25:56 Vitaliy Margolen, vous avez écrit : > So I'd suggest copying name into both places. Ok. > And append "evdev?" at the end so we can tell how it's handled. See attached patch. First version I locally wrote only stored an additional int in joydev, but: - maybe

Bugzilla default assignment for secur32

2009-02-08 Thread Kai Blin
Hi folks, since SSL support sort of works, we're getting a large amount of SSL-related bugs. As I don't deal with the SSL-implementation at all, could some Bugzilla admin remove me as defauly assignee for secur32 bugs again? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.o