RE: gdi32: Remove unneeded check. (Coverity)

2009-01-30 Thread EA Durbin
> From: kai.b...@gmail.com > To: robertshear...@gmail.com > Subject: Re: gdi32: Remove unneeded check. (Coverity) > Date: Wed, 28 Jan 2009 10:32:40 +0100 > CC: wine-devel@winehq.org > > On Tuesday 27 January 2009 18:29:10 Rob Shearman wrote: > > > It doesn't make much sense to leave the lcdfil

Re: msadp32.acm : block align and adpcm extra data

2009-01-30 Thread Vincent Pelletier
Le Thursday 22 January 2009 16:25:42 Stefano Guidoni, vous avez écrit : > This patch solves bug 7385: > Function ADPCM_StreamSize must return a > buffer size, which is a multiple of block align. > This buffer size is > calculated taking into account input-blockalign, output-blockalign and > adpcm-s

Re: request for windows test: GetPrivateProfileSectionNamesA

2009-01-30 Thread Austin English
On Fri, Jan 30, 2009 at 1:37 PM, Marcus Meissner wrote: > Hi, > > Could someone please test those, I want to see if > the second or third crash on Windows to handle those > borderline cases. > > Ciao & Thanks, Marcus > > > --- > dlls/kernel32/tests/profile.c |7 +++ > 1 files changed, 7 i

Re: [2/13]msctf: implement SetFocus and GetFocus

2009-01-30 Thread Aric Stewart
Humm, I thought so at first also, but then when I was testing with word 2007 (which is the only program I have found so far that uses this) I found that if i released here then the DocumentMgr was prematurely destroyed and caused Word to crash. With not releasing then everything lined up. Th

Re: [2/13]msctf: implement SetFocus and GetFocus

2009-01-30 Thread Jacek Caban
Hi Aric, Aric Stewart wrote: > --- > dlls/msctf/threadmgr.c | 28 > 1 files changed, 24 insertions(+), 4 deletions(-) > +if (!pdimFocus || FAILED(IUnknown_QueryInterface(pdimFocus,&IID_ITfDocumentMgr,(LPVOID*) &check))) +return E_INVALIDARG; + +Thi

Re: Highest commits per month (ever)

2009-01-30 Thread Paul Vriens
Paul Vriens wrote: > Hi, > > This month we hit the highest number of commits per month ever : 1307. > > It's a shame there is weekend coming ;) > Should be "Highest number of commits per month (ever)" and "It's a shame there is a weekend coming". Shouldn't be writing emails at the end of a wor

Highest commits per month (ever)

2009-01-30 Thread Paul Vriens
Hi, This month we hit the highest number of commits per month ever : 1307. It's a shame there is weekend coming ;) -- Cheers, Paul.

request for windows test: GetPrivateProfileSectionNamesA

2009-01-30 Thread Marcus Meissner
Hi, Could someone please test those, I want to see if the second or third crash on Windows to handle those borderline cases. Ciao & Thanks, Marcus --- dlls/kernel32/tests/profile.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/tests/profile.c b/d

Re: Reliable Datagram / Stream behaviour of NT Pipes

2009-01-30 Thread Luke Kenneth Casson Leighton
On Fri, Jan 30, 2009 at 6:41 PM, Juan Lang wrote: > Hi Luke, hi juan :) >> the issue with the implementation of nt named pipes on top of _just_ >> streams (unix sockets) is this: two packets sent get blatted into one >> read. > > You are correct. We've known about that bug for ages, but never

Re: Reliable Datagram / Stream behaviour of NT Pipes

2009-01-30 Thread Juan Lang
Hi Luke, On Fri, Jan 30, 2009 at 9:22 AM, Luke Kenneth Casson Leighton wrote: > i've encountered some bugs (thanks to python again :) ) in the wine > implementation of nt named pipes, and have raised it as a bug > http://bugs.winehq.org/show_bug.cgi?id=17195 but it started getting > complicated s

Re: http://wiki.winehq.org/NamedPipes

2009-01-30 Thread Luke Kenneth Casson Leighton
p.s. the win32 port of samba tng was originally done for wine - and reactos's - benefit. and because it'd just be utterly one-in-the-eye to be able to turn something like a P.O.S windows98 box into a Primary Domain Controller ha ha :)

http://wiki.winehq.org/NamedPipes

2009-01-30 Thread Luke Kenneth Casson Leighton
rob, hi, regarding the above wiki page - there is no "obstacle". you can use any of the code that i wrote for samba (about 100,000 lines of code), i released all of it into the public domain, on dec 16th, 2005. there's enough there so that you can do an entirely "hands off" approach, getting pack

Reliable Datagram / Stream behaviour of NT Pipes

2009-01-30 Thread Luke Kenneth Casson Leighton
folks, hi, if you recall, i implemented nt named pipes in samba tng, and also implemented the use of nt named pipes as a transport in freedce, for when i ported freedce to win32. so i have quite a bit of experience when it comes to nt named pipes. i've encountered some bugs (thanks to python again

SHGetFileInfo flag SHGFI_USEFILEATTRIBUTES together with SHGFI_PIDL (regression)

2009-01-30 Thread Petr Sumbera
Hi All, What is story behind following commit? This seems to broke Zoner Photo Studio (tested on OpenSolaris). According to some documentation combination of these flags is not allowed.. http://source.winehq.org/git/wine.git/?a=blobdiff;f=dlls/shell32/shell32_main.c;h=78a2d578cf28947451a8d8c281

Re: Quick and dirty testcases for MS-DOS API?

2009-01-30 Thread Dan Kegel
On Fri, Jan 30, 2009 at 7:51 AM, Austin English wrote: > How about we merge in the wine16 tests while we're at it? That would be great, if someone wants to do it, but it's kind of a pain because it currently requires the windows version of the open watcom c compiler.

Re: comctl32: Fix propsheet size calculation (resent)

2009-01-30 Thread Vitaliy Margolen
Alexandre Julliard wrote: > Vitaliy Margolen writes: > >> Alexandre Julliard wrote: >>> Vitaliy writes: >>> + /* Get non-client size */ + if (!psInfo->isModeless) + { +RECT rc1; + +GetWindowRect(hwndDlg, &rc); +GetClientRect(hwndDlg, &rc1);

Re: Quick and dirty testcases for MS-DOS API?

2009-01-30 Thread Austin English
On Thu, Jan 29, 2009 at 11:45 PM, Dan Kegel wrote: > On Thu, Jan 29, 2009 at 9:40 PM, Dmitry Timoshkov > wrote: >> The exception tests in ntdll is a nice example how to do that >> without hurting readability and maintainability. > > Sure, it's doable, but after a while one's fingers begin > to bl

Re: Quick and dirty testcases for MS-DOS API?

2009-01-30 Thread Dan Kegel
On Fri, Jan 30, 2009 at 1:37 AM, Henri Verbeet wrote: > Would gas work? Yeah, it's a little ugly, though. Alexandre's right, we can add the machinery if/when we have so much code that the array of hex approach sags.

RE: First complete test run passing on a Windows platform

2009-01-30 Thread Ge van Geldorp
> From: Ge van Geldorp [mailto:g...@gse.nl] On Behalf Of 'Florian Köberle' Sorry, I messed up the headers. The previous message containing: > BTW, this causes failures also with my own fix applied (althoug only a > single failure instead of a bunch), so my own fix wasn't correct either. was sent

RE: First complete test run passing on a Windows platform

2009-01-30 Thread 'Florian Köberle'
> From: Ge van Geldorp [mailto:g...@gse.nl] > I've done some more experimenting and can get the problem to > reproduce more consistently (like 95% of the time instead of > 25%) by launching my shortcut twice (so I have two test runs > going at the same time). Then both of the runs will usually

RE: First complete test run passing on a Windows platform

2009-01-30 Thread Ge van Geldorp
Florian, > From: Florian Köberle [mailto:flor...@fkoeberle.de] > How many cores do your processor have? > I have a dual core which might make the difference. I ran inside a VM that had 1 CPU assigned, so single core. > How exactly do you execute the tests? > I executed "../../../tools/runtest -

Re: comctl32: Fix propsheet size calculation (resent)

2009-01-30 Thread Alexandre Julliard
Vitaliy Margolen writes: > Alexandre Julliard wrote: >> Vitaliy writes: >> >>> + /* Get non-client size */ >>> + if (!psInfo->isModeless) >>> + { >>> +RECT rc1; >>> + >>> +GetWindowRect(hwndDlg, &rc); >>> +GetClientRect(hwndDlg, &rc1); >>> +tabOffsetX = rc.right - rc.left -

Re: comctl32: Fix propsheet size calculation (resent)

2009-01-30 Thread Vitaliy Margolen
Alexandre Julliard wrote: > Vitaliy writes: > >> + /* Get non-client size */ >> + if (!psInfo->isModeless) >> + { >> +RECT rc1; >> + >> +GetWindowRect(hwndDlg, &rc); >> +GetClientRect(hwndDlg, &rc1); >> +tabOffsetX = rc.right - rc.left - (rc1.right - rc.left); >> +tabOffs

Re: comctl32: Fix propsheet size calculation (resent)

2009-01-30 Thread Alexandre Julliard
Vitaliy writes: > + /* Get non-client size */ > + if (!psInfo->isModeless) > + { > +RECT rc1; > + > +GetWindowRect(hwndDlg, &rc); > +GetClientRect(hwndDlg, &rc1); > +tabOffsetX = rc.right - rc.left - (rc1.right - rc.left); > +tabOffsetY = rc.bottom - rc.top - (rc1.bottom

Re: First complete test run passing on a Windows platform

2009-01-30 Thread Florian Köberle
Hello Gé. >> I think the main problem is that the thread might run >> parallel with some other test code. >> >> That is why I would suggest to wait for the thread to finish >> at the end of the test. >> >> I made a patch and attached it to this email. I can't >> reproduce the failure on my syste

RE: First complete test run passing on a Windows platform

2009-01-30 Thread Ge van Geldorp
Hi Florian, > From: Florian Köberle [mailto:flor...@fkoeberle.de] > I think the main problem is that the thread might run > parallel with some other test code. > > That is why I would suggest to wait for the thread to finish > at the end of the test. > > I made a patch and attached it to this

DIB Engine - Rebased on current tree (Takes 2) - Part one - GDI32 patches

2009-01-30 Thread Massimo Del Fedele
As there where some changes on GDI32 in latest commits, previous testing DIB Engine had to be modified too. I'm posting here (and in bug 421 page) the 2 needed patches, separated by GDI32 changes and winedib.drv folder. In order to keep patches smaller, I dropped the autogenerated 'configure',

Re: First complete test run passing on a Windows platform

2009-01-30 Thread Florian Köberle
Ge van Geldorp wrote: >> From: Reece Dunn [mailto:mscl...@googlemail.com] >> >> Do you know why you need to do a SetForegroundWindow there to >> make the tests succeed? >> Why is the input being sent to a different window? >> Why does it vary from platform-to-platform and machine-to-machine? >>

Re: gdiplus: GdipCreateBitmapFromHICON implemented (with some tests)

2009-01-30 Thread Nikolay Sivov
Alexandre Julliard wrote: > Nikolay Sivov writes: > > >> @@ -4,7 +4,7 @@ SRCDIR= @srcdir@ >> VPATH = @srcdir@ >> MODULE= gdiplus.dll >> IMPORTLIB = gdiplus >> -IMPORTS = uuid shlwapi oleaut32 ole32 user32 gdi32 kernel32 >> +IMPORTS = uuid shlwapi oleaut32 ole32 user32 gdi32 k

Re: gdiplus: GdipCreateBitmapFromHICON implemented (with some tests)

2009-01-30 Thread Alexandre Julliard
Nikolay Sivov writes: > @@ -4,7 +4,7 @@ SRCDIR= @srcdir@ > VPATH = @srcdir@ > MODULE= gdiplus.dll > IMPORTLIB = gdiplus > -IMPORTS = uuid shlwapi oleaut32 ole32 user32 gdi32 kernel32 > +IMPORTS = uuid shlwapi oleaut32 ole32 user32 gdi32 kernel32 shell32 It's a bit wasteful to

Re: Wined3d being used with VirtualBox D3D

2009-01-30 Thread Roderick Colenbrander
> All, > > An interesting piece from Phoronix about new VirtualBox Direct3D > support; which apparently uses WineD3D in the backend. I haven't > noticed anything in particular but has Sun been filing bugs / sending > patches? > > http://www.phoronix.com/scan.php?page=news_item&px=NzAyNA > > --Z

Another MSVCRT problem, perhaps __RTDynamicCast()

2009-01-30 Thread Uwe Bonnes
Hello, after registering at http://forms.analog.com/form_pages/rfcomms/adisimpll.asp?ref=ASC-PR-067 you can download ADIsimPLL Version 3.1 for free. Running the program (with richedit from winetricks) it offers to run a tutorial. In the course of clicking next in this tutorial, at some point som

Re: report on obscure issues: running out of file handles with python under wine

2009-01-30 Thread Luke Kenneth Casson Leighton
On Fri, Jan 30, 2009 at 3:41 AM, Vitaliy Margolen wrote: > Luke Kenneth Casson Leighton wrote: >> also note it's file descriptors not file handles > There are no such thing as "handle" in *NIX world. The only thing matter is > a file descriptor. But it's for files, directories, devices, etc. > > W

Re: Quick and dirty testcases for MS-DOS API?

2009-01-30 Thread Henri Verbeet
2009/1/30 Dan Kegel : > Do you see any harm in using nasm? I can't imagine > it would be hard to update our list of build dependencies, > and if anybody doesn't have it for some reason, no harm done... > Would gas work?

Re: First complete test run passing on a Windows platform

2009-01-30 Thread Paul Vriens
Reece Dunn wrote: 2009/1/30 Ge van Geldorp : From: Reece Dunn The Wine tests are now passing on a Windows XP machine (http://test.winehq.org/data/4b27dfec939d131c9d7e09f97f14dfc7dabe8843/#group _XP). Actually, that was not the first time. On 20 Jan an XP machine passed: http://test.winehq.o

RE: First complete test run passing on a Windows platform

2009-01-30 Thread Ge van Geldorp
> From: Reece Dunn [mailto:mscl...@googlemail.com] > > Do you know why you need to do a SetForegroundWindow there to > make the tests succeed? > Why is the input being sent to a different window? > Why does it vary from platform-to-platform and machine-to-machine? It's a timing issue. It doesn't

Re: Quick and dirty testcases for MS-DOS API?

2009-01-30 Thread Alexandre Julliard
Dan Kegel writes: > On Thu, Jan 29, 2009 at 9:40 PM, Dmitry Timoshkov > wrote: >> The exception tests in ntdll is a nice example how to do that >> without hurting readability and maintainability. > > Sure, it's doable, but after a while one's fingers begin > to bleed. It all depends on how much

Re: First complete test run passing on a Windows platform

2009-01-30 Thread Reece Dunn
2009/1/30 Ge van Geldorp : >> From: Reece Dunn >> >> The Wine tests are now passing on a Windows XP machine >> > (http://test.winehq.org/data/4b27dfec939d131c9d7e09f97f14dfc7dabe8843/#group > _XP). > > Actually, that was not the first time. On 20 Jan an XP machine passed: > http://test.winehq.org/

RE: First complete test run passing on a Windows platform

2009-01-30 Thread Ge van Geldorp
> From: Reece Dunn > > The Wine tests are now passing on a Windows XP machine > (http://test.winehq.org/data/4b27dfec939d131c9d7e09f97f14dfc7dabe8843/#group _XP). Actually, that was not the first time. On 20 Jan an XP machine passed: http://test.winehq.org/data/e9d8c9f572998054b1f9c386ea81a3570