Re: comctl32[2/2]: toolbar: fix the layout of TBUTTON_INFO on Win64

2009-01-24 Thread Dmitry Timoshkov
"Mikolaj Zalewski" wrote: > +/* Note: TOOLBAR_DumpButton assumes the layout of the beginning of the > structure > + * is the same as of TBBUTTON */ > typedef struct > { > INT iBitmap; > @@ -96,6 +98,9 @@ typedef struct > BYTE fsStyle; > BYTE bHot; > BYTE bDropDownPressed; > +#

performance issue when OffscreenRenderingMode = "pbuffer"

2009-01-24 Thread Jérôme Gardou
I tried to play Supreme Commander using pbuffer option instead of fbo. I was quite happy with it, since I gained quite a bunch of performance (I mean, something I really COULD see), but after a while, the performance dropped dramatically, to ~4-5 fps. I tested quite a few thing, and I finally

Updated testing DIB Engine

2009-01-24 Thread Massimo Del Fedele
I did some update on the engine, I tried to post it here as a zipped patch, but didn't got published So I've put it on bug 421 page with instructions on how to use it. I'd like to have some feedback if the implementation way is the right one. Ciao Max

Re: [2/3]: winemenubuilder: generate fd.o MIME and file type associations

2009-01-24 Thread Frank Richter
On 24.01.2009 12:03, Damjan Jovanovic wrote: > +static char* wchars_to_unix_chars(LPCWSTR string) > +{ > +char *ret; > +INT size = WideCharToMultiByte(CP_UNIXCP, 0, string, -1, NULL, 0, NULL, > NULL); Since that is used to write fd.o desktop and mime files: double-check the respective spe

Re: user32: Resend: Move character conversion logic to dde_server.d &remove todo's

2009-01-24 Thread Dmitry Timoshkov
"Jeff Latimer" wrote: >>> Agreed, the point I was making is that DDEML wraps the raw DDE, the >>> translation occurs in the server not the client. >> Does it really matter? > It highlights the problem and that the translation should take place in > the server. In earlier discussions last year

Re: New Coverity run

2009-01-24 Thread Dan Kegel
On Sat, Jan 24, 2009 at 8:29 AM, Alexandre Julliard wrote: >> http://bugs.winehq.org/show_bug.cgi?id=17112 >> Should we make that a release criterion? > > I don't think so, getting access to that info is troublesome, and we > can't easily trigger new test runs. We don't want to have the release >

Re: New Coverity run

2009-01-24 Thread Alexandre Julliard
Dan Kegel writes: > On Sat, Jan 24, 2009 at 3:24 AM, Marcus Meissner > wrote: >>> David promised me we get even more issues reported once we get to rung2 :). >>> The engine they use for rung2 is new and better apparently. >> >> I see it with gphoto2 for instance. >> >> However, what was the cri

Re: New Coverity run

2009-01-24 Thread Dan Kegel
On Sat, Jan 24, 2009 at 3:24 AM, Marcus Meissner wrote: >> David promised me we get even more issues reported once we get to rung2 :). >> The engine they use for rung2 is new and better apparently. > > I see it with gphoto2 for instance. > > However, what was the criteria again for rung2? 0 unrevi

Re: msi: Fix NULL dereference in MsiQueryComponentStateW (coverity)

2009-01-24 Thread Nikolay Sivov
Paul Vriens wrote: > Nikolay Sivov wrote: >> Changelog: >> - Fix NULL dereference in MsiQueryComponentStateW, test added >> >> +r = pMsiQueryComponentStateA(prodcode, NULL, >> MSIINSTALLCONTEXT_MACHINE, NULL, &state); >> +ok(r == ERROR_INVALID_PARAMETER, "Expected ERROR_SUCCESS, got >

Re: msi: Fix NULL dereference in MsiQueryComponentStateW (coverity)

2009-01-24 Thread Paul Vriens
Nikolay Sivov wrote: > Changelog: > - Fix NULL dereference in MsiQueryComponentStateW, test added > > +r = pMsiQueryComponentStateA(prodcode, NULL, MSIINSTALLCONTEXT_MACHINE, > NULL, &state); > +ok(r == ERROR_INVALID_PARAMETER, "Expected ERROR_SUCCESS, got %d\n", r); Copy-paste error

Re: help with coverity spotted problem in region.c::CreatePolyPolygonRgn

2009-01-24 Thread James McKenzie
Marcus Meissner wrote: > Hi, > > Coverity says something about array indices in CreatePolyPolygonRgn > and I see some code that looks bad: > > if (((nbpolygons == 1) && ((*Count == 4) || >((*Count == 5) && (Pts[4].x == Pts[0].x) && (Pts[4].y == Pts[0].y))) && > (((Pts[0].y == Pt

Re: [1/3] d3dxof: Make parsing more permissive about semicolon and comma in objects

2009-01-24 Thread Paul Vriens
Christian Costa wrote: > > > > > Hi Christian, + if ((token != TOKEN_SEMICOLON) && (token != TOKEN_COMMA)) { /* Allow comma instead of semicolon in some specific cases */ if (!((token == T

Re: New Coverity run

2009-01-24 Thread Kai Blin
On Saturday 24 January 2009 12:24:29 Marcus Meissner wrote: > On Sat, Jan 24, 2009 at 12:22:33PM +0100, Paul Vriens wrote: > > Dan Kegel wrote: > >> On Fri, Jan 23, 2009 at 2:47 PM, Marcus Meissner wrote: > >>> There are actually more ... 815 - 870 (ca 57), and other types too. > >> > >> Whoops,

Re: New Coverity run

2009-01-24 Thread Marcus Meissner
On Sat, Jan 24, 2009 at 12:22:33PM +0100, Paul Vriens wrote: > Dan Kegel wrote: >> On Fri, Jan 23, 2009 at 2:47 PM, Marcus Meissner >> wrote: >>> There are actually more ... 815 - 870 (ca 57), and other types too. >> >> Whoops, right, I only got the first page, I guess. Here's a more complete >

Re: New Coverity run

2009-01-24 Thread Paul Vriens
Dan Kegel wrote: > On Fri, Jan 23, 2009 at 2:47 PM, Marcus Meissner > wrote: >> There are actually more ... 815 - 870 (ca 57), and other types too. > > Whoops, right, I only got the first page, I guess. Here's a more complete > list. David promised me we get even more issues reported once we

Re: user32: Resend: Move character conversion logic to dde_server.d &remove todo's

2009-01-24 Thread Jeff Latimer
Dmitry Timoshkov wrote: > DDE and DDEML are supposed to interchangeable. A DDE client can talk to a DDEML server and turnabout. >>> DDEML is just a wrapper around raw DDE messages, and raw DDE messages >>> don't have a translation layer in the user32 messaging system. >> Agreed, the poi

help with coverity spotted problem in region.c::CreatePolyPolygonRgn

2009-01-24 Thread Marcus Meissner
Hi, Coverity says something about array indices in CreatePolyPolygonRgn and I see some code that looks bad: if (((nbpolygons == 1) && ((*Count == 4) || ((*Count == 5) && (Pts[4].x == Pts[0].x) && (Pts[4].y == Pts[0].y))) && (((Pts[0].y == Pts[1].y) && (Pts[1].x == Pts

Re: user32: Resend: Move character conversion logic to dde_server.d &remove todo's

2009-01-24 Thread Dmitry Timoshkov
"Jeff Latimer" wrote: >>> DDE and DDEML are supposed to interchangeable. A DDE client can talk >>> to a DDEML server and turnabout. >> DDEML is just a wrapper around raw DDE messages, and raw DDE messages >> don't have a translation layer in the user32 messaging system. > Agreed, the point I wa

Re: user32: Resend: Move character conversion logic to dde_server.d &remove todo's

2009-01-24 Thread Jeff Latimer
Dmitry Timoshkov wrote: >> DDE and DDEML are supposed to interchangeable. A DDE client can talk >> to a DDEML server and turnabout. > DDEML is just a wrapper around raw DDE messages, and raw DDE messages > don't have a translation layer in the user32 messaging system. Agreed, the point I was maki