Re: mlang: implementation of base functionality ofIMultiLanguage2::ValidateCodePageand IMultiLanguage2::ValidateCodePageEx

2009-01-23 Thread Dmitry Timoshkov
"Aric Stewart" wrote: > @@ -2990,7 +2989,13 @@ static HRESULT WINAPI > fnIMultiLanguage2_ValidateCodePageEx( > DWORD dwfIODControl) > { > ICOM_THIS_MULTI(MLang_impl, vtbl_IMultiLanguage3, iface); > -FIXME("%p %u %p %08x: stub!\n", This, uiCodePage, hwnd, dwfIODControl); > + > +TR

Re: user32: Resend: Move character conversion logic to dde_server.d &remove todo's

2009-01-23 Thread Dmitry Timoshkov
"Jeff Latimer" wrote: >> Passing raw DDE messages should be >> out of interest, it's the application's problem. > DDE and DDEML are supposed to interchangeable. A DDE client can talk to > a DDEML server and turnabout. DDEML is just a wrapper around raw DDE messages, and raw DDE messages don't

Re: gdiplus: do not call delete_element(NULL)

2009-01-23 Thread Andrew Nguyen
On Sat, Jan 24, 2009 at 12:42 AM, Vincent Povirk wrote: > In several cases we call delete_element(x) after x has been set to > NULL or after an unsuccessful clone_element(y, &x) call. clone_element > always gives a NULL element pointer when it fails. > delete_element(NULL) will dereference the NUL

Re: gdiplus: do not call delete_element(NULL)

2009-01-23 Thread Austin English
On Sat, Jan 24, 2009 at 12:42 AM, Vincent Povirk wrote: > In several cases we call delete_element(x) after x has been set to > NULL or after an unsuccessful clone_element(y, &x) call. clone_element > always gives a NULL element pointer when it fails. > delete_element(NULL) will dereference the NUL

Re: user32: Resend: Move character conversion logic to dde_server.d &remove todo's

2009-01-23 Thread Jeff Latimer
Dmitry Timoshkov wrote: > "Jeff Latimer" wrote: > >> The issue is that the client passes data using messaging or DDEML >> there is no method in the api to inform the server whether the data >> is Unicode or not. The only method I have determined is to use >> IsTextUnicode() but that is guessin

Re: user32: Resend: Move character conversion logic to dde_server.d &remove todo's

2009-01-23 Thread Dmitry Timoshkov
"Jeff Latimer" wrote: > The issue is that the client passes data using messaging or DDEML there > is no method in the api to inform the server whether the data is Unicode > or not. The only method I have determined is to use IsTextUnicode() but > that is guessing. However, it looks like Wind

user32: Resend: Move character conversion logic to dde_server.d & remove todo's

2009-01-23 Thread Jeff Latimer
I have resubmitted this patch for discussion purposes. Patch "user32/tests: Clarify the msgs to differentiate Unicode and ASCII in tests" cleans up existing tests for this situation and demonstrates the functionality. The problem remains that the application passes to the dde/ddeml data that i

Re: Anything wrong with this patch?

2009-01-23 Thread Austin English
On Fri, Jan 23, 2009 at 5:37 PM, Jérôme Gardou wrote: > Ben Klein a écrit : >> >> 2009/1/24 Austin English : >> >>> >>> On Fri, Jan 23, 2009 at 4:58 PM, Jérôme Gardou >>> wrote: >>> Ben Klein a écrit : > > I just looked at bug 15616. Maybe you should look at it too. > >

Re: Anything wrong with this patch?

2009-01-23 Thread Jérôme Gardou
Ben Klein a écrit : > 2009/1/24 Austin English : > >> On Fri, Jan 23, 2009 at 4:58 PM, Jérôme Gardou >> wrote: >> >>> Ben Klein a écrit : >>> I just looked at bug 15616. Maybe you should look at it too. Also, please hit "Reply to all" so your message gets sent to the

Re: Anything wrong with this patch?

2009-01-23 Thread Jérôme Gardou
Austin English a écrit : > >> Of course... Austin English already noticed my patch. Austin, any idea >> why it was rejected? >> >> Sorry for the "reply to all", I forgot it this time... >> >> >> >> > > I don't know. I only noticed the empty patch. AJ would be the one to ask. > > Off hand thoug

Re: Anything wrong with this patch?

2009-01-23 Thread Ben Klein
2009/1/24 Austin English : > On Fri, Jan 23, 2009 at 4:58 PM, Jérôme Gardou > wrote: >> Ben Klein a écrit : >>> >>> I just looked at bug 15616. Maybe you should look at it too. >>> >>> Also, please hit "Reply to all" so your message gets sent to the >>> mailing list too :) >>> >> Of course... Aus

Re: Anything wrong with this patch?

2009-01-23 Thread Austin English
On Fri, Jan 23, 2009 at 4:58 PM, Jérôme Gardou wrote: > Ben Klein a écrit : >> 2009/1/24 Jérôme Gardou : >> >>> Ben Klein a écrit : >>> 2009/1/24 Jerome Leclanche : > (Damnit, gmail interface) > Pipermail shows as empty, here. > > On Fri, Jan 23, 2009 at 10:05 PM, Jé

Re: New Coverity run

2009-01-23 Thread Dan Kegel
On Fri, Jan 23, 2009 at 2:47 PM, Marcus Meissner wrote: > There are actually more ... 815 - 870 (ca 57), and other types too. Whoops, right, I only got the first page, I guess. Here's a more complete list. For more info, get a coverity account at http://scan.coverity.com/devfaq.html#account or a

Re: Anything wrong with this patch?

2009-01-23 Thread Jérôme Gardou
Ben Klein a écrit : > 2009/1/24 Jérôme Gardou : > >> Ben Klein a écrit : >> >>> 2009/1/24 Jerome Leclanche : >>> >>> (Damnit, gmail interface) Pipermail shows as empty, here. On Fri, Jan 23, 2009 at 10:05 PM, Jérôme Gardou wrote: > htt

Re: New Coverity run

2009-01-23 Thread Marcus Meissner
On Fri, Jan 23, 2009 at 01:42:38PM -0800, Dan Kegel wrote: > ... and here are the new issues since the last run, all of type FORWARD_NULL. > If you don't have coverity access, see > http://scan.coverity.com/devfaq.html#account > for how to get it. > > 595 CryptDecodeObjectEx dlls/crypt32/d

Re: Anything wrong with this patch?

2009-01-23 Thread Ben Klein
2009/1/24 Jérôme Gardou : > Ben Klein a écrit : >> >> 2009/1/24 Jerome Leclanche : >> >>> (Damnit, gmail interface) >>> Pipermail shows as empty, here. >>> >>> On Fri, Jan 23, 2009 at 10:05 PM, Jérôme Gardou >>> wrote: >>> http://www.winehq.org/pipermail/wine-patches/2009-January/067564.html

re: New Coverity run

2009-01-23 Thread Dan Kegel
... and here are the new issues since the last run, all of type FORWARD_NULL. If you don't have coverity access, see http://scan.coverity.com/devfaq.html#account for how to get it. 595 CryptDecodeObjectEx dlls/crypt32/decode.c 596 CryptEncodeObjectEx dlls/crypt32/encode.c 549 S

Re: Anything wrong with this patch?

2009-01-23 Thread Ben Klein
2009/1/24 Jerome Leclanche : > (Damnit, gmail interface) > Pipermail shows as empty, here. > > On Fri, Jan 23, 2009 at 10:05 PM, Jérôme Gardou > wrote: >> http://www.winehq.org/pipermail/wine-patches/2009-January/067564.html >> Any comment on this one? Related to bug 15616. >> Looks like http://

Re: Anything wrong with this patch?

2009-01-23 Thread Jerome Leclanche
(Damnit, gmail interface) Pipermail shows as empty, here. On Fri, Jan 23, 2009 at 10:05 PM, Jérôme Gardou wrote: > http://www.winehq.org/pipermail/wine-patches/2009-January/067564.html > Any comment on this one? Related to bug 15616. > > > -- Adys

Re: New Coverity run

2009-01-23 Thread Marcus Meissner
On Fri, Jan 23, 2009 at 09:44:45PM +0100, Paul Vriens wrote: > Hi, > > I've been in touch with David Maxwell and he looked into the 'lack' of > reports since the end of October. And there is now Run 278 :) Ciao, Marcus

New Coverity run

2009-01-23 Thread Paul Vriens
Hi, I've been in touch with David Maxwell and he looked into the 'lack' of reports since the end of October. -- Cheers, Paul.

Anything wrong with this patch?

2009-01-23 Thread Jérôme Gardou
http://www.winehq.org/pipermail/wine-patches/2009-January/067564.html Any comment on this one? Related to bug 15616.

Re: wineg++ compile error

2009-01-23 Thread Rino Farina
Yep. I switched to mingw as cross-compiler, and all is right with the world again ;) Thanks everyone! -rino On Tue, Jan 20, 2009 at 11:07 AM, Hin-Tak Leung wrote: > --- On Tue, 20/1/09, Rino Farina wrote: > >> Right, I wasn't able to find iostream among the >> available headers >> (remember, I

Re: server(1/3): Use kernel support for process affinity when available

2009-01-23 Thread Alexandre Julliard
Juan Lang writes: > +static void get_process_affinity( struct process *process ) > +{ > +affinity_t affinity = ~0; > + > +#ifdef HAVE_SCHED_H > +if (process->unix_pid != -1) > +{ > +cpu_set_t set; > + > +CPU_ZERO( &set ); > +if (!sched_getaffinity( process->uni

Re: [user32] Allocate buffer on heap (Bug 17076)

2009-01-23 Thread Paul Vriens
Jeff Latimer wrote: > Paul Vriens wrote: >> >> Some called functions assume that buffer is always on heap. That isn't >> the case >> anymore. > If you do > > +local_buffer = HeapAlloc(GetProcessHeap(), 0, buffer_size); > > shouldn't there be a HeapFree() added to match? > > Jeff > > > >

Re: [user32] Allocate buffer on heap (Bug 17076)

2009-01-23 Thread Jeff Latimer
Paul Vriens wrote: > > > Some called functions assume that buffer is always on heap. That isn't > the case > anymore. If you do +local_buffer = HeapAlloc(GetProcessHeap(), 0, buffer_size); shouldn't there be a HeapFree() added to match? Jeff

Re: AppDB: Rating / Patching

2009-01-23 Thread Paul TBBle Hampson
On Thu, Jan 22, 2009 at 10:56:50PM +1100, Ben Klein wrote: > 2009/1/22 Francois Gouget : >> On Thu, 22 Jan 2009, Ben Klein wrote: >> [...] >>> Perhaps the question remains, is a VC7 runtime library intended to be >>> developed and shipped with Wine? I don't think this is the case. >> We have msvci

Re: LWN Timeline for 2008: Wine 1.0 made it!

2009-01-23 Thread Hin-Tak Leung
--- On Thu, 22/1/09, Brian Vincent wrote: > LWN is definitely receptive to any articles. Things that > come to mind > would be an article describing Wine being used to get a > specific > Windows program to run. For example, how you could use > Wine to make > iTunes run (not sure if iTunes is ac

Re: AppDB: Rating / Patching

2009-01-23 Thread IneedAname
On Thu, 22 Jan 2009 11:48:34 + Darragh Bailey wrote: > Warcraft III and Frozen Throne expansion was released to support Windows > 98/ME/2k/XP. Nowhere in it's patch notes does it say that the minimum > requirements to run Warcraft 3 have changed to have the minimum > requirements of Windows

Re: LWN Timeline for 2008: Wine 1.0 made it!

2009-01-23 Thread Hin-Tak Leung
--- On Thu, 22/1/09, David Gerard wrote: > Has anyone managed to concoct a Google Alert that reliably > picks up > most or all articles about Wine the software, but without a > zilliion > articles about wine the drink? I use "wine linux" - I know wine is not just for linux, but most mentions of

Re: msxml3/tests:domdoc.c Test doc pointer before using it (coverity)

2009-01-23 Thread Joris Huizer
--- On Thu, 1/22/09, Austin English wrote: > From: Austin English > >From: Joris Huizer > > Your e-mail is messed up in the patches. Alexandre's > scripts take the > patch info over the e-mail headers, so you should fix that. > > -- > -Austin Sorry about that. Had forgotten I had reset loc