Re: ole32: add a test for OleInitialize

2009-01-12 Thread Austin English
On Tue, Jan 13, 2009 at 1:28 AM, Paul Vriens wrote: > Austin English wrote: >> >> Pointed out by Anastasius in bug 13011. Tested on XP SP2 & 2K SP4 (and >> Wine, of course). >> >> >> >> >> >> > Hi Austin, > > The test case th

Re: ole32: add a test for OleInitialize

2009-01-12 Thread Paul Vriens
Austin English wrote: > Pointed out by Anastasius in bug 13011. Tested on XP SP2 & 2K SP4 (and > Wine, of course). > > > > > > Hi Austin, The test case that is pointed out in bug 13011 is different though: hr = CoInitia

Re: winequartz.drv Mac OS X UI discontinued?

2009-01-12 Thread James McKenzie
Emmanuel Maillard wrote: > > Le 3 janv. 09 à 04:14, James McKenzie a écrit : > >> Emmanuel Maillard wrote: >>> Hi, >>> >>> Le 4 juil. 08 à 12:37, Adam Strzelecki a écrit : >>> >>> Hi Emmanuel, hello Wine developers, Latest WineQuartz.drv patch is 0.9.58. Is there any change for

Re: [dxdiagn] Implemented retrieval of b3DAccelerationEnabled property

2009-01-12 Thread Markus
On Monday 12 January 2009 11:50:27 Vitaliy Margolen wrote: > Markus wrote: > > +V_VT(&v) = VT_BOOL; V_BOOL(&v) = get_ddraw_acceleration(); > > +IDxDiagContainerImpl_AddProp( pDisplayAdapterSubCont, > > b3DAccelerationEnabled, &v ); +VariantClear(&v); > > Why don't you use add_prop_bool(

Re: [PATCH 1/6] wininet: Make sure that we have data buffered before sending INTERNET_STATUS_REQUEST_COMPLETE notification.

2009-01-12 Thread Jacek Caban
Jacek Caban wrote: > Hans Leidekker wrote: > >> And I guess this is also a good opportunity to round that buffer size up >> to the nearest power of two. >> >> > > It won't change much, we don't wait for whole data, so, in my tests, > recv returns after reading 1448 bytes. It's similar t

Re: [PATCH 1/6] wininet: Make sure that we have data buffered before sending INTERNET_STATUS_REQUEST_COMPLETE notification.

2009-01-12 Thread Jacek Caban
Hans Leidekker wrote: > On Monday 12 January 2009 18:19:54 Jacek Caban wrote: > > >> +static void HTTP_ReceiveRequest(WININETHTTPREQW *req) >> +{ >> +INTERNET_ASYNC_RESULT iar; >> +BYTE buffer[4048]; >> > > I think HTTP_ReceiveRequestData would be a better name for this function. >

Re: [dxdiagn] Implemented retrieval of b3DAccelerationEnabled property

2009-01-12 Thread Detlef Riekenberg
On Mo, 2009-01-12 at 09:50 -0700, Vitaliy Margolen wrote: > > +LPCSTR searchSubKey = "SOFTWARE\\Microsoft\ > \DirectDraw"; > > +LPCSTR dataSubKey = "EmulationOnly"; > I don't see anywhere Wine using this key. How did you came up with > this key? That was m

Re: comctl32: fix Itemtext in treeview.c (Bug #16466)

2009-01-12 Thread Austin English
On Sun, Jan 11, 2009 at 10:03 AM, Nerv wrote: > This fixes TREEVIEW_DoSetItemT if tvItem->pszText=0 > > > > Please use your full real name on patches. A testcase would help. -- -Austin

Re: Comctl32 tests on version 6.0

2009-01-12 Thread Reece Dunn
2009/1/12 Nikolay Sivov : > Running crossbuilt tests for comctl32 showed some failures when version > 6.0 used: > > 27 - imagelist > 25 - rebar > 130 - toolbar > > (version 6.0 module used through external manifest xml in my test) > Toolbar and rebar failures show different rectangle coordinates (a

Comctl32 tests on version 6.0

2009-01-12 Thread Nikolay Sivov
Running crossbuilt tests for comctl32 showed some failures when version 6.0 used: 27 - imagelist 25 - rebar 130 - toolbar (version 6.0 module used through external manifest xml in my test) Toolbar and rebar failures show different rectangle coordinates (all toolbar fails are about -2 shift of y

Failing wine tests

2009-01-12 Thread Rico Schüller
Hi, I've just done 4 runs on the same machine with the same wine version with the same test version (see http://test.winehq.org/data/8cf8e2c60a263e0b015b36dc36c9bf83e6767aa8/#group_Wine - the rs-f10-...). Therefore I named the runs like: inst - test run from a wine version with an installed w

Re: [PATCH 1/6] wininet: Make sure that we have data buffered before sending INTERNET_STATUS_REQUEST_COMPLETE notification.

2009-01-12 Thread Hans Leidekker
On Monday 12 January 2009 18:19:54 Jacek Caban wrote: > +static void HTTP_ReceiveRequest(WININETHTTPREQW *req) > +{ > +INTERNET_ASYNC_RESULT iar; > +BYTE buffer[4048]; I think HTTP_ReceiveRequestData would be a better name for this function. And I guess this is also a good opportunity to

Re: [1/2] httpapi: add HttpInitialize and HttpTerminate stubs

2009-01-12 Thread Andrey Turkin
Austin English wrote: > On Mon, Jan 12, 2009 at 11:33 AM, Andrey Turkin > wrote: > >> .Net 3.0 installer needs these >> --- >> dlls/httpapi/httpapi.spec |2 + >> dlls/httpapi/httpapi_main.c | 42 + >> include/http.h | 48 >> +

Re: [1/2] httpapi: add HttpInitialize and HttpTerminate stubs

2009-01-12 Thread Austin English
On Mon, Jan 12, 2009 at 11:33 AM, Andrey Turkin wrote: > > .Net 3.0 installer needs these > --- > dlls/httpapi/httpapi.spec |2 + > dlls/httpapi/httpapi_main.c | 42 + > include/http.h | 48 > +++ >

Re: gecko regressions; debug build of gecko?

2009-01-12 Thread Jacek Caban
Dan Kegel wrote: > On Sun, Jan 11, 2009 at 11:12 AM, Jacek Caban wrote: > >>> Hmm, can we have a debug version of the gecko download >>> so we can give more useful backtraces? >>> >> We already have it, it's on SourceForge. To use it you have to replace >> existing Wine Gecko installatio

Re: [dxdiagn] Implemented retrieval of b3DAccelerationEnabled property

2009-01-12 Thread Vitaliy Margolen
Markus wrote: > > > > +HKEYkey_handle; > +LPCSTR searchSubKey = "SOFTWARE\\Microsoft\\DirectDraw"; > +LPCSTR dataSubKey = "EmulationOnly"; I don't see anywher

Re: [PATCH 2/2] widl: Optimise the generated code by skipping calls calling the type function directly for some reference pointers.

2009-01-12 Thread Alexandre Julliard
"Rob Shearman" writes: > Skip calling the Pointer marshalling/unmarshalling/buffer > sizing/freeing function in this case. > > Output code for calling union marshalling/unmarshalling/buffer > sizing/freeing functions. Now it breaks the tests: ../../../tools/runtest -q -P wine -M qmgr.dll -T ../

RE: rpcrt4/tests: NdrVaryingArrayUnmarshall() is broken on Windows

2009-01-12 Thread Ge van Geldorp
> From: Paul Vriens [mailto:paul.vriens.w...@gmail.com] > > It looks like we've had exceptions on anything but XP and > W2K3 for a long time. > The exceptions (as reported on test.winehq.org) for XP and > W2K3 started happening after the move to use winetest.exe > from test.winehq.org. I'm n

RE: rpcrt4/tests: NdrVaryingArrayUnmarshall() is broken on Windows

2009-01-12 Thread Ge van Geldorp
> From: Rob Shearman [mailto:robertshear...@gmail.com] > > 2009/1/12 Alexandre Julliard : > > "Ge van Geldorp" writes: > > > > > > Changelog: > > > NdrVaryingArrayUnmarshall() is broken on Windows > > > > If it's broken on Windows then there's no point in testing > > it, you can simply remove

Re: rpcrt4/tests: NdrVaryingArrayUnmarshall() is broken on Windows

2009-01-12 Thread Alexandre Julliard
"Rob Shearman" writes: > 2009/1/12 Alexandre Julliard : >> "Ge van Geldorp" writes: >> >>> The failures in rpcrt4:server on Windows are caused by an access violation >>> thrown in NdrVaryingArrayUnmarshall() called from get_5numbers(). I've >>> created a minimum get_5numbers() test with Microsof

Re: rpcrt4/tests: NdrVaryingArrayUnmarshall() is broken on Windows

2009-01-12 Thread Paul Vriens
Rob Shearman wrote: > 2009/1/12 Alexandre Julliard : >> "Ge van Geldorp" writes: >> >>> The failures in rpcrt4:server on Windows are caused by an access violation >>> thrown in NdrVaryingArrayUnmarshall() called from get_5numbers(). I've >>> created a minimum get_5numbers() test with Microsoft too

Re: rpcrt4/tests: NdrVaryingArrayUnmarshall() is broken on Windows

2009-01-12 Thread Rob Shearman
2009/1/12 Alexandre Julliard : > "Ge van Geldorp" writes: > >> The failures in rpcrt4:server on Windows are caused by an access violation >> thrown in NdrVaryingArrayUnmarshall() called from get_5numbers(). I've >> created a minimum get_5numbers() test with Microsoft tools and that throws >> the s

Re: rpcrt4/tests: NdrVaryingArrayUnmarshall() is broken on Windows

2009-01-12 Thread Alexandre Julliard
"Ge van Geldorp" writes: > The failures in rpcrt4:server on Windows are caused by an access violation > thrown in NdrVaryingArrayUnmarshall() called from get_5numbers(). I've > created a minimum get_5numbers() test with Microsoft tools and that throws > the same access violation. The access viola

Re: [4/5] widl: Rewrite of cant_be_null

2009-01-12 Thread Alexandre Julliard
Michael Karcher writes: > As Rob Shearman commented to my patch "Null-check pointers with [size_is]", > the code flow in cant_be_null is non-obvious, the variable type check could > be included into this function and last but not least it is buggy. This > is a hopefully cleaner rewrite of this fu

Re: [PATCH 2/2] widl: Optimise the generated code by skipping calls calling the type function directly for some reference pointers.

2009-01-12 Thread Rob Shearman
2009/1/12 Alexandre Julliard : > "Rob Shearman" writes: > >> Skip calling the Pointer marshalling/unmarshalling/buffer >> sizing/freeing function in this case. >> >> Output code for calling union marshalling/unmarshalling/buffer >> sizing/freeing functions. > > It doesn't work: > > ../../tools/wid

Re: WIDL 'import' question

2009-01-12 Thread Nikolay Sivov
Rob Shearman wrote: > 2009/1/11 Nikolay Sivov : > >> Hi, I've a small question on using 'import' in .idl. Sorry if it's too >> dummy, it's my first try to use widl. >> Trying to get commoncontrols.idl port compile on Wine I've got the >> following problems - >> this file contains struct definiti

Re: WIDL 'import' question

2009-01-12 Thread Rob Shearman
2009/1/11 Nikolay Sivov : > Hi, I've a small question on using 'import' in .idl. Sorry if it's too > dummy, it's my first try to use widl. > Trying to get commoncontrols.idl port compile on Wine I've got the > following problems - > this file contains struct definitions already defined in commctrl.

Re: [2/9] cryptui: Use "-1" as a "don't care value", fix dialog id duplicates.

2009-01-12 Thread Alexandre Julliard
Dmitry Timoshkov writes: > diff --git a/dlls/cryptui/cryptui_En.rc b/dlls/cryptui/cryptui_En.rc > index 119eac6..b5bd067 100644 > --- a/dlls/cryptui/cryptui_En.rc > +++ b/dlls/cryptui/cryptui_En.rc > @@ -274,11 +274,11 @@ BEGIN >PUSHBUTTON "B&rowse...", IDC_IMPORT_BROWSE_FILE, 236,11,60,14 >

Re: gecko regressions; debug build of gecko?

2009-01-12 Thread Paul TBBle Hampson
On Sun, Jan 11, 2009 at 11:04:32AM -0800, Dan Kegel wrote: > I've been doing some random qa of popular apps lately, and > think I've found some regressions caused by the gecko update: > http://bugs.winehq.org/show_bug.cgi?id=16869 - Sketchup 7 crashes when > bringing up 3d Warehouse > http://bugs.w

Re: [1/2] server: add ability to send a unix signal to arbitrary thread

2009-01-12 Thread Alexandre Julliard
"Kirill K. Smirnov" writes: > diff --git a/server/protocol.def b/server/protocol.def > index 6d6be5b..35dfcc0 100644 > --- a/server/protocol.def > +++ b/server/protocol.def > @@ -664,6 +664,12 @@ typedef union > int count;/* new suspend count */ > @END > > +/* Send a unix

Re: [PATCH 2/2] widl: Optimise the generated code by skipping calls calling the type function directly for some reference pointers.

2009-01-12 Thread Alexandre Julliard
"Rob Shearman" writes: > Skip calling the Pointer marshalling/unmarshalling/buffer > sizing/freeing function in this case. > > Output code for calling union marshalling/unmarshalling/buffer > sizing/freeing functions. It doesn't work: ../../tools/widl/widl -I. -I. -I../../include -I../../includ

Re: user32/tests: keybd_event can send HCBT_KEYSKIPPED notifications

2009-01-12 Thread Dmitry Timoshkov
"Ge van Geldorp" wrote: > static const struct message WmKeyUpSkippedSeq[] = > { > -{ HCBT_KEYSKIPPED, hook|wparam|lparam|optional, 'N', 0xc001 }, /* XP > */ > +{ HCBT_KEYSKIPPED, hook|wparam|optional, 'N' }, /* XP */ > +{ 0 } > +}; > +static const struct message WmUserKeyUpSkip

Re: [TOOLS] Add Windows 7

2009-01-12 Thread Paul Vriens
James Hawkins wrote: > On Sat, Jan 10, 2009 at 3:32 AM, Paul Vriens > wrote: >> Hi, >> >> We have our first Windows 7 test results : >> http://test.winehq.org/data/a69c86d3f517f659ba47495f77deac2df671fb03/vista_windows7-virtualbox/version.html >> >> I'm not sure if '7' is a nice/correct header th