Re: [PATCH 1/2] Add definitions used by reparse points

2009-01-06 Thread Paul Vriens
Paul TBBle Hampson wrote: > Not much to say about this. It's needed for the unit tests coming up. > > > > > Hi Paul, Part of your signature says: License: http://creativecommons.org/licenses/by/2.5/au/ Does this mean yo

Re: [1/2] dlls: Add loadperf.dll

2009-01-06 Thread Andrew Nguyen
On Tue, Jan 6, 2009 at 8:21 AM, Andrey Turkin wrote: > .NET 1.1 uses this dll during installation > > --- > configure.ac |1 + > dlls/loadperf/Makefile.in | 13 + > dlls/loadperf/loadperf.spec | 14 ++ > dlls/loadperf/loadperf_main.c | 29 +

Re: [PATCH 1/2] Add definitions used by reparse points

2009-01-06 Thread Paul TBBle Hampson
On Wed, Jan 07, 2009 at 12:22:15AM -0600, Austin English wrote: > On Wed, Jan 7, 2009 at 12:05 AM, Paul TBBle Hampson > wrote: >> Not much to say about this. It's needed for the unit tests coming up. > +// Used for all tags where IsReparseTagMicrosoft is false > +// and for some tags where IsRepa

Re: [PATCH 1/2] Add definitions used by reparse points

2009-01-06 Thread Austin English
On Wed, Jan 7, 2009 at 12:05 AM, Paul TBBle Hampson wrote: > Not much to say about this. It's needed for the unit tests coming up. > -- > --- > Paul "TBBle" Hampson, B.Sc, LPI, MCSE > Very-later-year Asian Studies student, ANU > The Boss, Bub

why are we not using pkg-config in configure

2009-01-06 Thread Danny Rawlins
Hi, I would like to know if there is any issues as to why we are not using pkg-config to check for needed library's with the m4 macros. Also this question arose in #winehackers TBBle> Hmm. Is pkg-config broken under mingw? And do we care? Regards, Danny Rawlins

Re: Implementing b3DAccelerationExists and b3DAccelerationEnabled in dxdiagn

2009-01-06 Thread Markus
On Tuesday 06 January 2009 03:58:27 Detlef Riekenberg wrote: > On Mo, 2009-01-05 at 22:10 -0500, Markus wrote: > > can anyone tell me where to find information about the > > b3DAccelerationExists and b3DAccelerationEnabled properties in the > > display container returned by > > I suggest to use dxd

Re: readme: add a note about UNIX paths

2009-01-06 Thread Austin English
On Tue, Jan 6, 2009 at 9:07 PM, James Hawkins wrote: > On Tue, Jan 6, 2009 at 7:04 PM, Austin English > wrote: >> Adds a note discouraging use of UNIX paths, since there's seems to >> have been a rash of it in recent bug reports. >> > > If we don't recommend it, and usually advise against it, wh

Re: readme: add a note about UNIX paths

2009-01-06 Thread James Hawkins
On Tue, Jan 6, 2009 at 7:04 PM, Austin English wrote: > Adds a note discouraging use of UNIX paths, since there's seems to > have been a rash of it in recent bug reports. > If we don't recommend it, and usually advise against it, why not just remove that line from the README? -- James Hawkins

Re: Dates in Wine announcement

2009-01-06 Thread Peter Urbanec
Ian Macfarlane wrote: > Very small suggestion - it would be helpful to have dates included > somewhere (preferably near the top) of the wine announce pages Speaking of dates... My pet peeve is seeing ambiguous dates such as 2/1/08. To me (and most of the world), that looks like 2nd Jan 2008, but i

Re: AppDB: Rating / Patching

2009-01-06 Thread Nathaniel Gray
On Tue, Jan 6, 2009 at 11:03 AM, James Mckenzie wrote: > No, the appdb should not be touched. Rosanne said it correctly, ordinary > users are NOT going to take the time to build Wine, nor should they. We can > put in the bug report that the patch works and whether or not it has been > submit

Re: AppDB: Rating / Patching

2009-01-06 Thread Nathaniel Gray
On Tue, Jan 6, 2009 at 10:12 AM, Austin English wrote: > On Tue, Jan 6, 2009 at 11:42 AM, Nathaniel Gray wrote: >> It sounds like the problem is that the version string in appdb isn't >> descriptive enough. It's perfectly reasonable to wonder if a given >> program can be made to work with a patc

Re: AppDB: Rating / Patching

2009-01-06 Thread nicholas . g . lawrence
Sometimes to make an app work, you need to copy over some native dlls. To get these dlls don't you need to own a copy of windows? Could this be a criterion in the rating system? Wether or not you need to own a copy of windows? nick **

Re: AppDB: Rating / Patching

2009-01-06 Thread Nathaniel Gray
On Tue, Jan 6, 2009 at 10:15 AM, Rosanne DiMesio wrote: >> >> It sounds like the problem is that the version string in appdb isn't >> descriptive enough. It's perfectly reasonable to wonder if a given >> program can be made to work with a patched version of wine, and wonder >> how well it will wo

Dates in Wine announcement

2009-01-06 Thread Ian Macfarlane
Very small suggestion - it would be helpful to have dates included somewhere (preferably near the top) of the wine announce pages, for example: http://www.winehq.org/announce/1.1.12 This will let people who come to it via search engines know what date this particular release was made on, without

Re: PR 16828 dlls/ntdll/serial.c clear IEXTEN when clearing ICANON

2009-01-06 Thread Austin English
On Tue, Jan 6, 2009 at 1:08 PM, G. Paul Ziemba wrote: > austinengl...@gmail.com ("Austin English") writes: >>Again, no C++ comments. > > Oops. Self-LART applied. Should I resubmit patches with modified comments > to wine-patches? > > ~!paul > -- > G. Paul Ziemba > FreeBSD unix: > 11:06AM up 12 d

Re: PR 16828 dlls/ntdll/serial.c clear IEXTEN when clearing ICANON

2009-01-06 Thread G. Paul Ziemba
austinengl...@gmail.com ("Austin English") writes: >Again, no C++ comments. Oops. Self-LART applied. Should I resubmit patches with modified comments to wine-patches? ~!paul -- G. Paul Ziemba FreeBSD unix: 11:06AM up 12 days, 21:45, 11 users, load averages: 0.27, 0.23, 0.24

Re: AppDB: Rating / Patching

2009-01-06 Thread James Mckenzie
>On Tue, Jan 6, 2009 at 6:48 AM, Rosanne DiMesio wrote: >> >>> Now, the story changes if the patch is conforming and has been accepted >>> by AJ and is pending the next development release. >>> >> Then the next development release can get the gold, but previous ones still >> shouldn't. AppDB test

Re: PR 16828 dlls/ntdll/serial.c clear IEXTEN when clearing ICANON

2009-01-06 Thread Austin English
On Tue, Jan 6, 2009 at 12:49 PM, G. Paul Ziemba wrote: > FreeBSD fix for Nirvis CDJ application, PR 16828 > > > --- dlls/ntdll/serial.c.orig2008-12-20 06:55:38.0 -0800 > +++ dlls/ntdll/serial.c 2009-01-05 21:35:47.0 -0800 > @@ -648,7 +648,9 @@ > port.c_cflag &= ~(HUPCL); >

Re: PR 16592: dlls/kernel32/volume.c

2009-01-06 Thread Austin English
On Tue, Jan 6, 2009 at 12:25 PM, G. Paul Ziemba wrote: > Fix for PR 16592, GetVolumeInformationW() handling of unusual "root" > parameter. > > > --- dlls/kernel32/volume.c.orig 2008-12-05 08:57:45.0 -0800 > +++ dlls/kernel32/volume.c 2008-12-22 00:15:51.0 -0800 > @@ -518,7 +51

Re: Packagers: consider not packaging wine-1.1.12, or cherrypicking fixes

2009-01-06 Thread Scott Ritchie
Dan Kegel wrote: > wine-1.1.12 has a couple regressions in it: > http://bugs.winehq.org/show_bug.cgi?id=16754 > http://bugs.winehq.org/show_bug.cgi?id=16732 > http://bugs.winehq.org/show_bug.cgi?id=16708 > > Please consider either cherrypicking the fixes, > or skipping wine-1.1.12. > > 1.1.11 h

Re: AppDB: Rating / Patching

2009-01-06 Thread Rosanne DiMesio
> > It sounds like the problem is that the version string in appdb isn't > descriptive enough. It's perfectly reasonable to wonder if a given > program can be made to work with a patched version of wine, and wonder > how well it will work. It's also reasonable to wonder how it will > work with a

Re: AppDB: Rating / Patching

2009-01-06 Thread Austin English
On Tue, Jan 6, 2009 at 11:42 AM, Nathaniel Gray wrote: > On Tue, Jan 6, 2009 at 6:48 AM, Rosanne DiMesio wrote: >> >>> Now, the story changes if the patch is conforming and has been accepted >>> by AJ and is pending the next development release. >>> >> Then the next development release can get th

Re: AppDB: Rating / Patching

2009-01-06 Thread Austin English
On Tue, Jan 6, 2009 at 8:48 AM, Rosanne DiMesio wrote: > >> Now, the story changes if the patch is conforming and has been accepted >> by AJ and is pending the next development release. >> > Then the next development release can get the gold, but previous ones still > shouldn't. AppDB test rating

Re: AppDB: Rating / Patching

2009-01-06 Thread Nathaniel Gray
On Tue, Jan 6, 2009 at 6:48 AM, Rosanne DiMesio wrote: > >> Now, the story changes if the patch is conforming and has been accepted >> by AJ and is pending the next development release. >> > Then the next development release can get the gold, but previous ones still > shouldn't. AppDB test rating

Re: wined3d: Fix a memory leak in compile_state_table()

2009-01-06 Thread Allan Tong
On Tue, Jan 6, 2009 at 5:51 AM, Henri Verbeet wrote: > 2009/1/6 Rico Schüller : >> Allan Tong schrieb: >>> Wrong pointer was being passed to HeapFree. >>> >>> - Allan >>> >>> >> Why did you remove these two lines? Was this your intention? >> -dev_multistate_funcs[cur[i].state]

Re: AppDB: Rating / Patching

2009-01-06 Thread Rosanne DiMesio
> Now, the story changes if the patch is conforming and has been accepted > by AJ and is pending the next development release. > Then the next development release can get the gold, but previous ones still shouldn't. AppDB test ratings are tied to specific releases, and intended to tell normal

Re: [shell32/tests 1/2] ILFree() is only exported by ordinal on Win9x

2009-01-06 Thread Paul Vriens
Alexandre Julliard wrote: > "Rob Shearman" writes: > >> 2009/1/6 Paul Vriens : >>> Hi, >>> >>> For some reason this only shows up when I use my own cross compiled tests. >>> >>> Changelog >>> ILFree() is only exported by ordinal on Win9x >> ILFree is exported using -noname in Wine, so it should

Re: Unused function in quartz

2009-01-06 Thread Rob Shearman
2009/1/6 Francois Gouget : > In the following commit you added the OutputPin_DeliverNewSegment() > function to pin.c. However today it is unused. Is there any plan to use > it? Is it still relevant? Not, it looks like it has been superseded by InputPin_NewSegment. If Maarten agrees, then feel free

Re: [shell32/tests 1/2] ILFree() is only exported by ordinal on Win9x

2009-01-06 Thread Alexandre Julliard
"Rob Shearman" writes: > 2009/1/6 Paul Vriens : >> Hi, >> >> For some reason this only shows up when I use my own cross compiled tests. >> >> Changelog >> ILFree() is only exported by ordinal on Win9x > > ILFree is exported using -noname in Wine, so it should be imported by > ordinal. You need t

Re: [shell32/tests 1/2] ILFree() is only exported by ordinal on Win9x

2009-01-06 Thread Paul Vriens
Rob Shearman wrote: > 2009/1/6 Paul Vriens : >> Hi, >> >> For some reason this only shows up when I use my own cross compiled tests. >> >> Changelog >> ILFree() is only exported by ordinal on Win9x > > ILFree is exported using -noname in Wine, so it should be imported by > ordinal. You need to in

Re: [shell32/tests 1/2] ILFree() is only exported by ordinal on Win9x

2009-01-06 Thread Rob Shearman
2009/1/6 Paul Vriens : > Hi, > > For some reason this only shows up when I use my own cross compiled tests. > > Changelog > ILFree() is only exported by ordinal on Win9x ILFree is exported using -noname in Wine, so it should be imported by ordinal. You need to investigate further as to why it isn

Re: wined3d: Fix a memory leak in compile_state_table()

2009-01-06 Thread Henri Verbeet
2009/1/6 Rico Schüller : > Allan Tong schrieb: >> Wrong pointer was being passed to HeapFree. >> >> - Allan >> >> > Why did you remove these two lines? Was this your intention? > -dev_multistate_funcs[cur[i].state][0] = > multistate_funcs[cur[i].state][0]; > -

Unused function in quartz

2009-01-06 Thread Francois Gouget
Hi, In the following commit you added the OutputPin_DeliverNewSegment() function to pin.c. However today it is unused. Is there any plan to use it? Is it still relevant? commit 0a6f11c88a8da49d80e4e7d8a0236ae4b36926b7 Author: Robert Shearman Date: Thu Sep 25 23:50:06 2003 +

Re: wined3d: Fix a memory leak in compile_state_table()

2009-01-06 Thread Rico Schüller
Allan Tong schrieb: > Wrong pointer was being passed to HeapFree. > > - Allan > > Why did you remove these two lines? Was this your intention? -dev_multistate_funcs[cur[i].state][0] = multistate_funcs[cur[i].state][0]; -dev_multistate_funcs[cur[i].sta

Re: Unused function in winhttp

2009-01-06 Thread Hans Leidekker
On Tuesday 06 January 2009 10:22:17 Francois Gouget wrote: > In the following commit you added the netconn_set_timeout() function to > net.c. However today it is unused. Is there any plan to use it? Is it > still relevant? Yes, it should be called from WinHttpSetTimeouts at some point. -Hans

Unused function in winhttp

2009-01-06 Thread Francois Gouget
Hi, In the following commit you added the netconn_set_timeout() function to net.c. However today it is unused. Is there any plan to use it? Is it still relevant? commit 266c4b2c046b334ca44cdc1826c4434625dcb29f Author: Hans Leidekker Date: Tue Aug 26 11:03:19 2008 +0200 winhttp

Re: Implementing b3DAccelerationExists and b3DAccelerationEnabled in dxdiagn

2009-01-06 Thread Detlef Riekenberg
On Mo, 2009-01-05 at 22:10 -0500, Markus wrote: > can anyone tell me where to find information about the b3DAccelerationExists > and b3DAccelerationEnabled properties in the display container returned by I suggest to use dxdiag and regmon on Windows. In dxdiag, you can disable DirectDraw / Dire

Re: Functions that should be static

2009-01-06 Thread Francois Gouget
On Sun, 21 Dec 2008, Andrew Talbot wrote: [...] > The dlls/advapi32/svcctl_c.c: svcctl_*() functions are peculiar, too. They > look like they need to be exported in some manner. My script already detects that svcctl_c.c was generated from svcctl.idl and thus won't complain about any of the functi

Re: Functions that should be static

2009-01-06 Thread Francois Gouget
On Sun, 21 Dec 2008, Kai Blin wrote: > On Thursday 18 December 2008 10:09:02 Francois Gouget wrote: > > > dlls/secur32/secur32.dll.so: SECUR32_initNegotiateSP > > This function would (and at some point did) register the Negotiate security > provider. It's not called right now because the provid