Re: Contribution to the Toolbar common control

2008-12-31 Thread Austin English
On Wed, Dec 31, 2008 at 6:53 PM, Alan Feldman wrote: > Ouch Austin. But thanks Ricardo for explaining to Austin that I wasn't > actually contributing "code" and I also didn't use any reverse > engineering to come up with that discovery. Didn't mean for it come off as harsh. I know that wasn't cod

Re: Contribution to the Toolbar common control

2008-12-31 Thread Alan Feldman
Ouch Austin. But thanks Ricardo for explaining to Austin that I wasn't actually contributing "code" and I also didn't use any reverse engineering to come up with that discovery. All I did was go to Microsoft's MSDN Libary web site and compare the Toolbar messages listed there with the "publicly av

RE: Contribution to the Toolbar common control

2008-12-31 Thread ricardo filipe
although he used disassembly to check our implementation, he gave msdn proof for the notifications he talked about... and didn't contribute code. > Date: Wed, 31 Dec 2008 08:45:43 -0600 > From: austinengl...@gmail.com > To: alanf...@gmail.com > Subject: R

Please add glut to winetricks :)

2008-12-31 Thread Couannette
Hi Dan, I found winetricks very helpful ! Thank you for this very nice script ;). Could you please add glut [1] to the packages winetricks knows about ? Thank you very much, Couannette [1] http://www.opengl.org/resources/libraries/glut/glut_downloads.php

Re: winhttp: Correctly parse specified ports in WinHttpCrackUrl

2008-12-31 Thread Paul TBBle Hampson
On Tue, Dec 30, 2008 at 11:51:13PM -0800, Dan Kegel wrote: > Hi Paul, > you wrote >> Depends on my previous patch: winhttp/tests:... > The way we usually express that is to prefix each patch > with its position in the series of patches. For instance, > your two-patch series might have used subjec

Re: winmm: Check param in joyConfigChanged

2008-12-31 Thread Alexandre Julliard
Christian Costa writes: >> There's no reason to rename the parameter, 'flags' is a perfectly good >> name. >> > It was just to reflect more the MSDN. Maybe it's not that usefull. No it's not, MSDN uses the stupid Hungarian notation everywhere, and we should stay as far away as possible from t

Re: winmm: Check param in joyConfigChanged

2008-12-31 Thread Christian Costa
Alexandre Julliard a écrit : > Christian Costa writes: > > >> -MMRESULT WINAPI joyConfigChanged(DWORD flags) >> +MMRESULT WINAPI joyConfigChanged(DWORD dwFlags) >> { >> -FIXME("(%x) - stub\n", flags); >> +FIXME("(%x) - stub\n", dwFlags); >> + >> +if (dwFlags) >> +return JOY

Re: Wine on Windows - wiki notes

2008-12-31 Thread Steven Edwards
On Tue, Dec 30, 2008 at 5:02 PM, Roderick Colenbrander wrote: > Cygwin/Mingw doesn't work due to missing functionality for wineserver I > believe (not sure what). Someone recently claimed that he indeed had wine > working on Interix on a 32-bit WinXP. Right now he was trying to compile it > on

Re: Contribution to the Toolbar common control

2008-12-31 Thread Austin English
On Wed, Dec 31, 2008 at 3:49 AM, Alan Feldman wrote: > Hello Wine developers, > > I am writing to this forum because I wanted to contribute some useful > development information to your community while at the same time not > have to get too involved as I currently have no plans to stay involved >

Re: winmm: Check param in joyConfigChanged

2008-12-31 Thread Alexandre Julliard
Christian Costa writes: > -MMRESULT WINAPI joyConfigChanged(DWORD flags) > +MMRESULT WINAPI joyConfigChanged(DWORD dwFlags) > { > -FIXME("(%x) - stub\n", flags); > +FIXME("(%x) - stub\n", dwFlags); > + > +if (dwFlags) > +return JOYERR_PARMS; There's no reason to rename the p

Re: dlls/user32/dde_client.c warning fixes (RESEND)

2008-12-31 Thread Alexandre Julliard
Gerald Pfeifer writes: > The current version likely is actually broken since the ! operator has > a higher priority than bitwise & in C. Unless someone really wanted to > use a very, hmm, unusual construct here? No, it's clearly not intended, but fixing this breaks the tests, this would need to

Re: Ouch.

2008-12-31 Thread Marcus Meissner
On Wed, Dec 31, 2008 at 10:21:29AM +0100, Kai Blin wrote: > On Tuesday 30 December 2008 23:55:56 Dan Kegel wrote: > > http://enquiringmimes.com/wp/2008/12/30/a-rumor-we-hope-is-true/ > > said > > "WINE is the famous, this-would-be-so-cool-if-it-only-actually-worked > > way of running Windows on oth

Contribution to the Toolbar common control

2008-12-31 Thread Alan Feldman
Hello Wine developers, I am writing to this forum because I wanted to contribute some useful development information to your community while at the same time not have to get too involved as I currently have no plans to stay involved going forward. I wanted to say that I am *really* impressed with

Re: Ouch.

2008-12-31 Thread Kai Blin
On Tuesday 30 December 2008 23:55:56 Dan Kegel wrote: > http://enquiringmimes.com/wp/2008/12/30/a-rumor-we-hope-is-true/ > said > "WINE is the famous, this-would-be-so-cool-if-it-only-actually-worked > way of running Windows on other platforms without needing Windows, > kind of like how useful it m