Re: Testing DIB Engine (second part)

2008-12-23 Thread Jeff Zaroyko
On Wed, Dec 24, 2008 at 11:23 AM, Massimo Del Fedele wrote: > Here the second part, it contains winedib.drv code and changes to Makefiles. > > Still no way to enable/disable the engine, besides of deleting the .so > inside dlls/winedib.drv. > > I'll wait for some feedback before going fourther. >

Combining Fuse and Wine - What's the best way?

2008-12-23 Thread Richard Stitz
I'm writing a program in which I have a Windows DLL that I need to load. The DLL contains a function that returns a pointer to some data, and I want to expose that data as file data in a Fuse file system. My first thought was that I could have the program load the DLL using winelib, but I'm not su

Re: Regression: Sound broken in PoP series

2008-12-23 Thread Jerome Leclanche
See http://bugs.winehq.org/show_bug.cgi?id=16607 On Wed, Dec 24, 2008 at 4:53 AM, M.Kiesel wrote: > Hi! > > The following commit breaks sound in (at least) Prince of Persia SoT and > PoP TWW. Reece, let me know how I can help with that. > > commit ce06de420874b9983324508f8257a580fee341ca > Author

Regression: Sound broken in PoP series

2008-12-23 Thread M.Kiesel
Hi! The following commit breaks sound in (at least) Prince of Persia SoT and PoP TWW. Reece, let me know how I can help with that. commit ce06de420874b9983324508f8257a580fee341ca Author: Reece Dunn Date: Mon Dec 22 13:33:43 2008 + dsound: Correct the dsound fraglen calculations. Reg

Re: [Wine] Re: MacOS X cocoa and carbon for Linux?

2008-12-23 Thread James McKenzie
Richie wrote: > James McKenzie wrote: > >> hahomir4ev wrote: >> You might find a friendly discussion somewhere else on the >> implementation of Cocoa/Carbon on Linux, but this is not a topic of >> discussion here. >> James McKenzie >> > > Of cource it would be a completely unrelated proje

re: Symlink vulnerability in winetricks

2008-12-23 Thread Dan Kegel
Stefan Nordhaus wrote: > Winetricks has a symlink vulnerability... Fixed in today's winetricks (20081223), thanks! - Dan

Re: Wine t-shirts?

2008-12-23 Thread Ismael Barros²
Looks like the poll is pretty dead, and unless somebody wants to link it somewhere, I suppose we should start getting some conclussion White T-shirt wins 17-11 over white and red, but designs A and B are drawn, so our designer will choose (and she really disliked option A :P) About the slogan, th

Re: Trouble compiling today's git.

2008-12-23 Thread Austin English
On Tue, Dec 23, 2008 at 5:13 PM, Susan Cragin wrote: > Is anyone else having trouble compiling today's git? > Or is it just my flu-addled brain? > > > make[1]: Entering directory `/home/susan/wine/server' > ../tools/makedep -C. -S.. -T.. async.c atom.c change.c class.c clipboard.c > completion.c

RE: [PATCH] Fix glReadPixels call from read_from_framebuffer (re-redux)

2008-12-23 Thread Nick Burns
Why not create a texture and draw a quad instead of using glDrawPixels (as it is deprecated in gl3)?Reference -- ogl 3 spec -- (http://www.opengl.org/registry/doc/glspec30.20080811.pdf)Under "E.1 Profiles and Deprecated Features of OpenGL 3.0""Pixel drawing - DrawPixels and PixelZoom (section 3

Trouble compiling today's git.

2008-12-23 Thread Susan Cragin
Is anyone else having trouble compiling today's git? Or is it just my flu-addled brain? make[1]: Entering directory `/home/susan/wine/server' ../tools/makedep -C. -S.. -T.. async.c atom.c change.c class.c clipboard.c completion.c console.c context_alpha.c context_i386.c context_powerpc.c conte

Re: [06/10] wintrust: Implement CryptCATOpen and CryptCATClose.

2008-12-23 Thread Maarten Lankhorst
Hi Juan and Hans, Juan Lang schreef: > Hi Hans, > > >> Maarten, do you remember what the code to store attribute certs was >> needed for? I'd like to address Juan's concern by either adding a test >> or taking the code out. >> > > I wouldn't worry about it. The code looks correct to the e

Re: Wine build failed

2008-12-23 Thread Austin English
On Tue, Dec 23, 2008 at 3:43 AM, Stefan Leichter wrote: > Hello, > > building current git tree fails to me on Debian Etch (x86) with: > > ccache gcc -c -I../../../wine-git/dlls/gdi32 -I. -I../../../wine-git/include > -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ > -D_REENTRAN

RE: [PATCH] Fix glReadPixels call from read_from_framebuffer (re-redux)

2008-12-23 Thread Nick Burns
Thanks for reviewing my patch (it sure makes the SHOGO menu much nicer) BTW do you know if I need to resubmit my other SHOGO patch ([PATCH] Fix ddraw surface version setting)? Concerning negative pixelzoom and drawpixels on R500 Please file a radar on that (and email the mac-opengl mailing list

Symlink vulnerability in winetricks

2008-12-23 Thread Stefan Nordhausen
Hi! Winetricks has a symlink vulnerability, it does (echo "$title"; echo ""; echo "$text") > /tmp/x_showmenu.txt An attacker can exploit this by creating a symlink called /tmp/x_showmenu.txt and have it point to some file that a winetricks user can write (e.g. ~/Documents/important_stuff.odf).

Re: how to create a broken .tlb file

2008-12-23 Thread Alexandre Julliard
Michael Karcher writes: > a) Include a broken (hand-patched) tlb file as binary file in git > b) Include a program that breaks tlb files and call it while > building tests > c) Include tlb file patching into the testcase (i.e. copy a good tlb, > patch it, and perform some tests with th

Re: bugfix: resend: fix serial_flush

2008-12-23 Thread Alexandre Julliard
Wolfgang Walter writes: > Would it be acceptable to call tcdrain directly in NtFlushBuffersFile: Yes, something like that. -- Alexandre Julliard julli...@winehq.org

Re: d3d9/visual tests timed out

2008-12-23 Thread Rico Schüller
Michael Stefaniuc schrieb: > Jeff Zaroyko wrote: >> On Tue, Dec 23, 2008 at 9:57 PM, Rico Schüller wrote: >>> Hi, >>> >>> on my XP machine the visual d3d9 test produces a timeout message, when >>> it is started from the winetest build. Anyone here could run the tests >>> on windows without a timeo

[RFC] wined3d: Avoid triggering OPENGL errors when setting point size

2008-12-23 Thread Vincent Pelletier
(Resent, originally sent to -patches... Sorry) If WINED3DRS_POINTSCALEENABLE is false and WINED3DRS_POINTSIZE render state is set to an invalid size, glPointSize will fail. This happens in "Black & White 2", causing log/stderr to be flooded with opengl errors. I'm not sure if this should be fix

Re: d3d9/visual tests timed out

2008-12-23 Thread Michael Stefaniuc
Jeff Zaroyko wrote: > On Tue, Dec 23, 2008 at 9:57 PM, Rico Schüller wrote: >> Hi, >> >> on my XP machine the visual d3d9 test produces a timeout message, when >> it is started from the winetest build. Anyone here could run the tests >> on windows without a timeout (and off course without skipping

Re: DIB Engine

2008-12-23 Thread Jesse Allen
On Tue, Dec 23, 2008 at 3:44 AM, Massimo Del Fedele wrote: > As my DIB engine is becoming usable (I already use it on Autocad for my > job), I'm thinking to publish the patches. > As it's still not complete, I'm thinking to add a way to enable it on > demand with registry and environment variable

Re: d3d9/tests: Don't create a Null-shader in d3d9, it will crash.

2008-12-23 Thread Rico Schüller
Stefan Dösinger schrieb: > I never saw this crashing on any of my systems, so it is probably driver > dependent. Which Windows driver are you using? > > If the test crashes on either ATI, Nvidia or Intel it is a good idea to > remove it. I don't think we should remove it if it crashes on somethin

Re: MSVCP80 implementation

2008-12-23 Thread Paul Chitescu
On Tuesday 23 December 2008 16:22:52 Steven Edwards wrote: > On Mon, Dec 22, 2008 at 10:31 PM, Dmitry Timoshkov > > wrote: > > MSVCP80 is not a part of win32 API, that's a redistributable run-time > > library supposed to be provided by an application. > > Does the EULA allow for it to be packaged

Re: MSVCP80 implementation

2008-12-23 Thread Steven Edwards
On Mon, Dec 22, 2008 at 10:31 PM, Dmitry Timoshkov wrote: > MSVCP80 is not a part of win32 API, that's a redistributable run-time > library supposed to be provided by an application. Does the EULA allow for it to be packaged for use on non-windows systems? If not then thats not an option for Wine

RE: d3d9/tests: Don't create a Null-shader in d3d9, it will crash.

2008-12-23 Thread Detlef Riekenberg
On Di, 2008-12-23 at 14:24 +0100, Stefan Dösinger wrote: > I'm only afraid of this hypothetical scenario: > 1) We remove a test because it breaks on $NONSTANDARDWINDRV We disable the test with: if (0) { /* that crash on $NONSTANDARDWINDRV */ } > 3) Some future patch ch

RE: d3d9: Set IDirect3DDevice9Impl_GetVertexShader return value to NULL on error

2008-12-23 Thread Stefan Dösinger
> No, this patch is obviously correct. Hmm right, the code treats pShader == NULL as 'failure'. Looking at the WineD3D code, it would only fail if ppShader == NULL, which would moot the point of setting *ppShader to NULL anyway. My bad in this case

RE: d3d9/tests: Don't create a Null-shader in d3d9, it will crash.

2008-12-23 Thread Stefan Dösinger
> The patch is already applied, but I think removing the test is the > right thing to do. I only added the test to test what error d3d9 > returns when a NULL shader is passed. If it depends on the driver, I > doubt we care. This patch was a good idea, yes I'm only afraid of this hypothetical scena

Re: d3d9: Set IDirect3DDevice9Impl_GetVertexShader return value to NULL on error

2008-12-23 Thread Henri Verbeet
2008/12/23 Stefan Dösinger : > Hi, > > Please write a test for this. This behavior differs from function to > function unfortunately. Some functions do not set the value to NULL, and > some apps depend on this. > > I think dlls/d3d9/tests/shader.c is a good place to put this test. > No, this patch

RE: d3d9: Set IDirect3DDevice9Impl_GetVertexShader return value to NULL on error

2008-12-23 Thread Stefan Dösinger
Hi, Please write a test for this. This behavior differs from function to function unfortunately. Some functions do not set the value to NULL, and some apps depend on this. I think dlls/d3d9/tests/shader.c is a good place to put this test. -Original Message- > From: wine-patches-boun...@w

Re: DIB Engine

2008-12-23 Thread Massimo Del Fedele
Austin English ha scritto: > On Tue, Dec 23, 2008 at 10:44 AM, Massimo Del Fedele wrote: >> As my DIB engine is becoming usable (I already use it on Autocad for my >> job), I'm thinking to publish the patches. >> As it's still not complete, I'm thinking to add a way to enable it on >> demand with

Re: d3d9/tests: Don't create a Null-shader in d3d9, it will crash.

2008-12-23 Thread Henri Verbeet
2008/12/23 Stefan Dösinger : > I never saw this crashing on any of my systems, so it is probably driver > dependent. Which Windows driver are you using? > > If the test crashes on either ATI, Nvidia or Intel it is a good idea to > remove it. I don't think we should remove it if it crashes on some

RE: [PATCH] Fix glReadPixels call from read_from_framebuffer (re-redux)

2008-12-23 Thread Stefan Dösinger
This patch looks good. There's one last thing we should check: It seems that this is the only code that uses GL_PACK_ROW_LENGTH and friends, so the backup and restore is probably not needed. I think for now it is better to add it because I suspect the code in surface_download_data most likely depe

RE: d3d9/tests: Don't create a Null-shader in d3d9, it will crash.

2008-12-23 Thread Stefan Dösinger
I never saw this crashing on any of my systems, so it is probably driver dependent. Which Windows driver are you using? If the test crashes on either ATI, Nvidia or Intel it is a good idea to remove it. I don't think we should remove it if it crashes on something like VMWare or other 'noname' c

RE: Valgrind warning in wined3d/swapchain.c in IWineD3DSwapChainImpl_Destroy

2008-12-23 Thread Stefan Dösinger
Hi, I'm doing an mail purge and stumbled across this mail. Can you try the attached patch? > -Original Message- > From: daniel.r.ke...@gmail.com [mailto:daniel.r.ke...@gmail.com] On > Behalf Of Dan Kegel > Sent: Saturday, November 15, 2008 5:30 AM > To: Wine Devel > Cc: Stefan Dösinger >

Re: DIB Engine

2008-12-23 Thread Austin English
On Tue, Dec 23, 2008 at 10:44 AM, Massimo Del Fedele wrote: > As my DIB engine is becoming usable (I already use it on Autocad for my > job), I'm thinking to publish the patches. > As it's still not complete, I'm thinking to add a way to enable it on > demand with registry and environment variable

Re: winecfg: Disable nonfunctional advanced drive settings

2008-12-23 Thread Austin English
On Tue, Dec 23, 2008 at 4:04 AM, M.Kiesel wrote: > On Tue, 23 Dec 2008, Austin English wrote: > >>> In the winecfg drive tab, advanced drive settings (setting label and >>> serial) >>> seem to be broken currently due to other Wine bugs (see drive.c >>> apply_drive_changes comments). Disable these

Re: DIB Engine

2008-12-23 Thread IneedAname
On Tue, 23 Dec 2008 11:44:39 +0100 Massimo Del Fedele wrote: > How should I publish it ? http://repo.or.cz/w/wine.git?a=forks

Fwd: Linking to a Mac OS X build of Wine from winehq.org/download ?

2008-12-23 Thread Zach Drayer
Begin forwarded message: > From: "Austin English" > Date: December 22, 2008 6:12:13 PM EST > To: "Zach Drayer" > Subject: Re: Linking to a Mac OS X build of Wine from winehq.org/ > download ? > > On Mon, Dec 22, 2008 at 5:06 PM, Zach Drayer wrote: >> >> On Dec 22, 2008, at 10:25 AM, Austin E

Re: DIB Engine

2008-12-23 Thread Massimo Del Fedele
Roderick Colenbrander ha scritto: >> As my DIB engine is becoming usable (I already use it on Autocad for my >> job), I'm thinking to publish the patches. >> As it's still not complete, I'm thinking to add a way to enable it on >> demand with registry and environment variable : >> >> export WINED

Re: DIB Engine

2008-12-23 Thread Roderick Colenbrander
> As my DIB engine is becoming usable (I already use it on Autocad for my > job), I'm thinking to publish the patches. > As it's still not complete, I'm thinking to add a way to enable it on > demand with registry and environment variable : > > export WINEDIB=ON activates it > export WINEDIB=OFF

DIB Engine

2008-12-23 Thread Massimo Del Fedele
As my DIB engine is becoming usable (I already use it on Autocad for my job), I'm thinking to publish the patches. As it's still not complete, I'm thinking to add a way to enable it on demand with registry and environment variable : export WINEDIB=ON activates it export WINEDIB=OFF deactivates i

Re: d3d9/visual tests timed out

2008-12-23 Thread Jeff Zaroyko
On Tue, Dec 23, 2008 at 9:57 PM, Rico Schüller wrote: > Hi, > > on my XP machine the visual d3d9 test produces a timeout message, when > it is started from the winetest build. Anyone here could run the tests > on windows without a timeout (and off course without skipping half of > the tests - have

Re: Wine build failed

2008-12-23 Thread Dmitry Timoshkov
"Dmitry Timoshkov" wrote: >> building current git tree fails to me on Debian Etch (x86) with: >> >> ccache gcc -c -I../../../wine-git/dlls/gdi32 -I. -I../../../wine-git/include >> -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ >> -D_REENTRANT -fPIC -Wall -pipe -fno-strict-ali

Re: Wine build failed

2008-12-23 Thread Dmitry Timoshkov
"Stefan Leichter" wrote: > building current git tree fails to me on Debian Etch (x86) with: > > ccache gcc -c -I../../../wine-git/dlls/gdi32 -I. -I../../../wine-git/include > -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ > -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing

Re: Wine build failed

2008-12-23 Thread Nikolay Sivov
Stefan Leichter wrote: > Hello, > > building current git tree fails to me on Debian Etch (x86) with: > > ccache gcc -c -I../../../wine-git/dlls/gdi32 -I. -I../../../wine-git/include > -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ > -D_REENTRANT -fPIC -Wall -pipe -fno-strict-al

d3d9/visual tests timed out

2008-12-23 Thread Rico Schüller
Hi, on my XP machine the visual d3d9 test produces a timeout message, when it is started from the winetest build. Anyone here could run the tests on windows without a timeout (and off course without skipping half of the tests - have to be more than 4k tests)? Also there is no message about a t

Wine build failed

2008-12-23 Thread Stefan Leichter
Hello, building current git tree fails to me on Debian Etch (x86) with: ccache gcc -c -I../../../wine-git/dlls/gdi32 -I. -I../../../wine-git/include -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-stateme