Re: ntoskrnl.exe: Add a redirect for IoGetCurrentProcess

2008-12-19 Thread Andrey Turkin
I believe this is wrong - IoGetCurrentProcess return pointer to kernel EPROCESS structure instance, and GetCurrentProcess return constant (HANDLE)-1 . The structure is declared opaque so drivers must not dereference it, but some drivers surely won't obey. 2008/12/20 Chris Wulff > Redirect for Io

Re: mscoree: Add a stub for LockClrVersion

2008-12-19 Thread Jeff Zaroyko
On Sat, Dec 20, 2008 at 3:12 PM, Chris Wulff wrote: > A stub for LockClrVersion. > > -- Chris Wulff > > Hi Chris You need to set your name and email address in git then regenerate your patches. git repo-config user.name "Your Name" git repo-config user.email "m...@example.com" -Jeff

Re: qedit: tests/mediadet.c test skips sometimes

2008-12-19 Thread Rico Schüller
Austin English schrieb: > On Thu, Dec 18, 2008 at 4:22 PM, Rico Schüller wrote: > >> Hi, >> could anyone try the attached patch for the qedit test on a windows machine? >> It works around bug 16548. But according to the comment in the source I >> think this could be a mistake. I'd like to know

Re: qedit: tests/mediadet.c test skips sometimes

2008-12-19 Thread Austin English
On Fri, Dec 19, 2008 at 2:32 PM, Rico Schüller wrote: > Austin English schrieb: >> >> On Thu, Dec 18, 2008 at 4:22 PM, Rico Schüller wrote: >> >>> >>> Hi, >>> could anyone try the attached patch for the qedit test on a windows >>> machine? >>> It works around bug 16548. But according to the comme

Re: jscript: Do not call memcpy() with a NULL pointer argument

2008-12-19 Thread Andrew Talbot
Jacek Caban wrote: > The string was always zero-terminated without your patch. It's fine to > call create_string with NULL str argument as long as len is 0 and > current implementation works fine in this case. > > > Jacek Hi Jacek, Technically, behavior is undefined if the pointers do not each

Re: qedit: tests/mediadet.c test skips sometimes

2008-12-19 Thread Austin English
On Thu, Dec 18, 2008 at 4:22 PM, Rico Schüller wrote: > Hi, > could anyone try the attached patch for the qedit test on a windows machine? > It works around bug 16548. But according to the comment in the source I > think this could be a mistake. I'd like to know if it works without renaming > the

Re: qedit: tests/mediadet.c test skips sometimes

2008-12-19 Thread Rico Schüller
Austin English schrieb: On Thu, Dec 18, 2008 at 4:22 PM, Rico Schüller wrote: Hi, could anyone try the attached patch for the qedit test on a windows machine? It works around bug 16548. But according to the comment in the source I think this could be a mistake. I'd like to know if it works w

Re: [2/5] wined3d: Properly reset the stateblock.

2008-12-19 Thread Alexandre Julliard
Henri Verbeet writes: >>From fe7697e20a1316e9bf5dba0469b4d39e5259d07b Mon Sep 17 00:00:00 2001 > From: Henri Verbeet > Date: Thu, 18 Dec 2008 17:59:06 +0100 > Subject: wined3d: Properly reset the stateblock. This doesn't work here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d

Re: qedit: tests/mediadet.c test skips sometimes

2008-12-19 Thread Austin English
On Thu, Dec 18, 2008 at 4:22 PM, Rico Schüller wrote: > Hi, > could anyone try the attached patch for the qedit test on a windows machine? > It works around bug 16548. But according to the comment in the source I > think this could be a mistake. I'd like to know if it works without renaming > the

Re: user32: set an error in SetParent if parent == hwnd

2008-12-19 Thread Dmitry Timoshkov
Please don't top post, this makes reply following awkward. "Vincent Povirk" wrote: > I would, but I can't run the user32:win tests successfully on a > windows machine. I've attached a test program to the bug. > > Vincent Povirk > > > > On Fri, Dec 19, 2008 at 6:41 AM, Dmitry Timoshkov > wro

Re: Last change to http://wiki.winehq.org/Comctl32

2008-12-19 Thread Austin English
On Fri, Dec 19, 2008 at 8:52 AM, John Klehm wrote: > On Fri, Dec 19, 2008 at 2:41 AM, Paul Vriens > wrote: >> Hi, >> >> I was just wondering if the addition of a link to >> http://www.dll-download-system.com should be in our wiki. Isn't it better to >> point to winetricks for getting riched20? >

Re: user32: set an error in SetParent if parent == hwnd

2008-12-19 Thread Vincent Povirk
I would, but I can't run the user32:win tests successfully on a windows machine. I've attached a test program to the bug. Vincent Povirk On Fri, Dec 19, 2008 at 6:41 AM, Dmitry Timoshkov wrote: > "Vincent Povirk" wrote: > >> fixes bug 16566 > > This kind of changes require a test case, adding

Re: [2/2] mshtml: Add VT_INT support in IHTMLElementCollection_item

2008-12-19 Thread Jacek Caban
HI Konstantin, Konstantin Kondratyuk wrote: > VT_INT type isn't documented in MSDN, but it is supported in Windows > > You're duplicating the code that handles VT_I4 case. Please avoid it. Jacek

Re: Patch Feedback

2008-12-19 Thread Jacek Caban
Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > Is there anything wrong with patches? > > [1/2] mshtml: Implement IHTMLScriptElement get/put event > > [2/2] mshtml: Implement IHTMLScriptElement get/put htmlFor > > First of all, are you trying to fix a real bug? We're starting to handle s

Re: Last change to http://wiki.winehq.org/Comctl32

2008-12-19 Thread John Klehm
On Fri, Dec 19, 2008 at 2:41 AM, Paul Vriens wrote: > Hi, > > I was just wondering if the addition of a link to > http://www.dll-download-system.com should be in our wiki. Isn't it better to > point to winetricks for getting riched20? > I'd vote yes, that site seems a bit shady to me. --John

Re: jscript: Do not call memcpy() with a NULL pointer argument

2008-12-19 Thread Jacek Caban
Andrew Talbot wrote: > On Thu Dec 18 22:41 , 'James Hawkins' sent: > > >> I didn't write jscript, so I'm not the expert, but create_string is >> internal, so we should probably crash if str is NULL instead of hiding >> the error. What is this patch for? >> >> -- >> James Hawkins >> > > H

Re: jscript: Do not call memcpy() with a NULL pointer argument

2008-12-19 Thread Andrew Talbot
On Thu Dec 18 22:41 , 'James Hawkins' sent: >I didn't write jscript, so I'm not the expert, but create_string is >internal, so we should probably crash if str is NULL instead of hiding >the error. What is this patch for? > >-- >James Hawkins Hi James, create_string() is called on line 1323

Re: user32: set an error in SetParent if parent == hwnd

2008-12-19 Thread Dmitry Timoshkov
"Vincent Povirk" wrote: > fixes bug 16566 This kind of changes require a test case, adding which is trivial in this case. -- Dmitry.

Re: Functions that should be static

2008-12-19 Thread Francois Gouget
On Thu, 18 Dec 2008, Christian Costa wrote: [...] > For 1) Why not adding a keyword to mark these functions. Something like > WINAPI which resolve to nothing but that can be tracked by your script. We could potentially go this way if I merge these checks with winapi_check one day. But for now I

Re: dmime: Remove unused Wine debug channel

2008-12-19 Thread Francois Gouget
On Thu, 18 Dec 2008, Andrew Talbot wrote: > Changelog: > dmime: Remove unused Wine debug channel. > > diff --git a/dlls/dmime/dmutils.c b/dlls/dmime/dmutils.c > index ad46303..3f25728 100644 > --- a/dlls/dmime/dmutils.c > +++ b/dlls/dmime/dmutils.c > @@ -43,7 +43,6 @@ > > #include "dmutils

strange

2008-12-19 Thread Hervÿffffe9 Chanal
It's rather quickly made but... http://img72.imageshack.us/my.php?image=dessindi7.png

Last change to http://wiki.winehq.org/Comctl32

2008-12-19 Thread Paul Vriens
Hi, I was just wondering if the addition of a link to http://www.dll-download-system.com should be in our wiki. Isn't it better to point to winetricks for getting riched20? -- Cheers, Paul.

Re: RE: 4/4 WineD3D: add G16R16F / G32R32F support

2008-12-19 Thread Roderick Colenbrander
I don't think we have had issues when we didn't have this format before. Emulation might be tricky it is not as easy as emulating R32F we could just read back using GL_RED but there is no GL_RG without texture_rg. On the Nvidia side ARB_texture_rg is catching up quickly. A stable gl3 driver will