Re: Another machine passing tests

2008-12-17 Thread Alasdair Sinclair
Michael Stefaniuc wrote: > Hi Alasdair, > > Alasdair Sinclair wrote: > >>> Would you mind sharing what hardware that's on? You're using Fedora 10, >>> right? >>> >>> >>> >> Sure, Its a Dell XPS1530 laptop (core 2 duo T8100), 4GB Ram, GeForce >> 8600M GT. >> Running fedora 10 x86-64 (

Re: [1/2] imm32: Fix the ImmIsUIMessageA/W.

2008-12-17 Thread Aric Stewart
Since I value your input in imm32 and i do a lot of work there. If you would like to send me that high level overview then I can see if it works into wine. That way you can continue to contribute and we do not compromise the source code. I have not looked at these patches yet so just send me a

Re: [1/2] imm32: Fix the ImmIsUIMessageA/W.

2008-12-17 Thread James Hawkins
On Wed, Dec 17, 2008 at 2:51 PM, ByeongSik Jeon wrote: > By an analysis of the ImmIsUIMessageA/W disassemble code, > 1. checked msg : > WM_IME_STARTCOMPOSITION <= msg <= WM_IME_KEYLAST, > WM_IME_SETCONTEXT, WM_IME_NOTIFY, > WM_IME_COMPOSITIONFULL, WM_IME_SELECT. > 2. SendMessageA/W is used.

Re: Wine t-shirts?

2008-12-17 Thread Ismael Barros²
On Wed, Dec 17, 2008 at 4:49 PM, Andrew Fenn wrote: > Thinking about me walking down the street again I have to say I prefer > Remco's suggestion the best because it describes best what wine does. > I like the idea of a witty shirt however the lines suggested requires > that you already understand

WineD3D: add some new GL extensions

2008-12-17 Thread Roderick Colenbrander
Hi, Add some new GL extensions which are needed for better d3d9 floating point support for R32F/RG32F and friends. Roderick -- Sensationsangebot verlängert: GMX FreeDSL - Telefonanschluss + DSL für nur 16,37 Euro/mtl.!* http://dsl.gmx.de/?ac=OM.AD.PD003K1308T4569a >From 73b14244008b5541c7f92f2

Re: Better user feedback and better user experience (idea)

2008-12-17 Thread Reece Dunn
2008/12/17 Austin English : > On Wed, Dec 17, 2008 at 2:10 PM, Sander Devrieze wrote: >> 2008/12/17 Scott Ritchie : >> >>> If it's that users blame the distro when it's a Wine problem, then we >>> can present them with some sort of information before installing (or >>> perhaps running) Wine. Aft

Re: Better user feedback and better user experience (idea)

2008-12-17 Thread Sander Devrieze
2008/12/17 Austin English : >>> Writing an elaborate >>> system to tell us about known problems isn't particularly helpful; >> >> It shouldn't be an elaborate system: it can be as easy as asking the >> user to click on a button to send a list of API calls, used DLLs, a >> hash of the .exe binary,

Re: Better user feedback and better user experience (idea)

2008-12-17 Thread Austin English
On Wed, Dec 17, 2008 at 2:10 PM, Sander Devrieze wrote: > 2008/12/17 Scott Ritchie : > >> If it's that users blame the distro when it's a Wine problem, then we >> can present them with some sort of information before installing (or >> perhaps running) Wine. After that we should get out of the wa

Re: Better user feedback and better user experience (idea)

2008-12-17 Thread Sander Devrieze
2008/12/17 Scott Ritchie : > If it's that users blame the distro when it's a Wine problem, then we > can present them with some sort of information before installing (or > perhaps running) Wine. After that we should get out of the way and let > them use Wine as normal. Wine should go out of way

Re: fixing all the not-properly-displaying characters that have suddenly appeared in the appdb

2008-12-17 Thread Aneurin Price
On Wed, Dec 17, 2008 at 2:48 PM, Rosanne DiMesio wrote: > On Wed, 17 Dec 2008 14:13:31 +0100 > Alexander Nicolaysen Sørnes wrote: > >> On Tuesday 16 December 2008 20:52:04 Rosanne DiMesio wrote: >> > Since the change to the new design, AppDB entries have been displaying >> > either a ? (Firefox,

Re: winewtsn: add a new program that shows a dialog to inform about a crash

2008-12-17 Thread Alexandre Julliard
Mikołaj Zalewski writes: > Currently, when a program is started from the KDE or Gnome menu and > it crashes, it simply disappears from the screen without any > explanation what happened - the information that goes to the console > is not visible. This program uses a similar technique as Windows'

Re: gdi32/winex11.drv: Change all gdi/opengl declarations to use __cdecl

2008-12-17 Thread Maarten Lankhorst
Hi Dmitry, Dmitry Timoshkov schreef: > "Maarten Lankhorst" wrote: > >> Needed to get +relay working in wine64 > > You should have used CDECL instead of __cdecl, have a look how it's > done in msvcrt.dll. In msvcrt both were used, so that doesn't really help. I guess that confused me a little. se

Re: Wine t-shirts?

2008-12-17 Thread Andrew Fenn
On Wed, Dec 17, 2008 at 3:17 PM, Ismael Barros² wrote: >> "Windows translation layer" >> "Run Windows applications on Linux, BSD and Mac OS X." > > It doesn't really sound very T-shirt-y to me. I think I'd rather wear > a T-shirt with a short, witty slogan than being a walking banner :) > > Someth

Re: Wine t-shirts?

2008-12-17 Thread Ismael Barros²
> "Windows translation layer" > "Run Windows applications on Linux, BSD and Mac OS X." It doesn't really sound very T-shirt-y to me. I think I'd rather wear a T-shirt with a short, witty slogan than being a walking banner :) Something like "Releasing your computer of Windows since 1993" or "Closi

Re: gdi32/winex11.drv: Change all gdi/opengl declarations to use __cdecl

2008-12-17 Thread Alexandre Julliard
Maarten Lankhorst writes: > @@ -33,9 +33,9 @@ > WINE_DEFAULT_DEBUG_CHANNEL(bitmap); > > > -static HGDIOBJ BITMAP_SelectObject( HGDIOBJ handle, HDC hdc ); > -static INT BITMAP_GetObject( HGDIOBJ handle, void *obj, INT count, LPVOID > buffer ); > -static BOOL BITMAP_DeleteObject( HGDIOBJ hand

Re: Wine t-shirts?

2008-12-17 Thread Remco
On Wed, Dec 17, 2008 at 12:41 PM, Andrew Fenn wrote: > > Perhaps some smaller text underneath where it says wine, "The windows > translation layer" or something similar to this? Just to define what I > might be for someone who has no idea. > Probably better to use the WineHQ tag line. A normal pe

Re: fixing all the not-properly-displaying characters that have suddenly appeared in the appdb

2008-12-17 Thread Rosanne DiMesio
On Wed, 17 Dec 2008 14:13:31 +0100 Alexander Nicolaysen Sørnes wrote: > On Tuesday 16 December 2008 20:52:04 Rosanne DiMesio wrote: > > Since the change to the new design, AppDB entries have been displaying > > either a ? (Firefox, Konqueror, Opera) or a blank rectangle (IE in Windows) > > in pla

Making the shell32/appbar tests pass on Vista

2008-12-17 Thread Paul Vriens
Hi Vincent, I was trying to have the appbar tests succeed on Vista. One way I could make it work is with the attached patch. Does this make sense? Or should we have another possible outcome of the test? (or even a broken()?). The change to do_events_until was only for my troubleshooting purposes

Re: server: implement move/rename change notifications and support for multiple change notification in one reply

2008-12-17 Thread Dan Kegel
On Wed, Dec 17, 2008 at 1:21 AM, Henri Verbeet wrote: > The attachment is here: > http://www.winehq.org/pipermail/wine-patches/2008-December/066225.html > The archive seems to create separate mails for attached mails. D'oh! Geez, we've got to fix that... - Dan

Re: Another machine passing tests

2008-12-17 Thread Michael Stefaniuc
Hi Alasdair, Alasdair Sinclair wrote: >> Would you mind sharing what hardware that's on? You're using Fedora 10, >> right? >> >> > Sure, Its a Dell XPS1530 laptop (core 2 duo T8100), 4GB Ram, GeForce > 8600M GT. > Running fedora 10 x86-64 (recently upgraded from 9) all latest patches > appli

Re: wined3d: Implement check for shader creation if hardware supports requested version.

2008-12-17 Thread Henri Verbeet
2008/12/17 Paul Vriens : > So that leaves the C++ comments? > No, the code you quoted was in d3d9/tests/shader.c, so I think your comment was right, even though it's a pretty minor issue.

Re: wined3d: Implement check for shader creation if hardware supports requested version.

2008-12-17 Thread Henri Verbeet
2008/12/17 Stefan Dösinger : >> if () >> { >> } >> else >> { >> } >> >> block to stick with the style. > Actually most of WineD3D's code uses the style the patch uses, but its not > 100% consistent :-/ > Most of the tests don't.

Re: wined3d: Implement check for shader creation if hardware supports requested version.

2008-12-17 Thread Paul Vriens
Henri Verbeet wrote: > 2008/12/17 Stefan Dösinger : >>> if () >>> { >>> } >>> else >>> { >>> } >>> >>> block to stick with the style. >> Actually most of WineD3D's code uses the style the patch uses, but its not >> 100% consistent :-/ >> > Most of the tests don't. So that leaves the C++ comments?

RE: wined3d: Implement check for shader creation if hardware supports requested version.

2008-12-17 Thread Stefan Dösinger
> if () > { > } > else > { > } > > block to stick with the style. Actually most of WineD3D's code uses the style the patch uses, but its not 100% consistent :-/

Re: fixing all the not-properly-displaying characters that have suddenly appeared in the appdb

2008-12-17 Thread Alexander Nicolaysen Sørnes
On Tuesday 16 December 2008 20:52:04 Rosanne DiMesio wrote: > Since the change to the new design, AppDB entries have been displaying > either a ? (Firefox, Konqueror, Opera) or a blank rectangle (IE in Windows) > in place of a variety of special characters, including anything with an > umlaut (bug

Re: wined3d: Reduce and improve error message spam when shader creation fails.

2008-12-17 Thread Henri Verbeet
These should probably all be WARNs as well.

Re: wined3d: Implement check for shader creation if hardware supports requested version.

2008-12-17 Thread Henri Verbeet
2008/12/17 Pauli Nieminen : > +static inline BOOL is_pshader_version_supported(IWineD3DDeviceImpl > *deviceImpl, const DWORD *byte_code) > +{ > +struct shader_caps shader_caps; > +const DWORD shader_version = *byte_code; /* First instruction should be > shader version */ Please don't do t

Re: d3d9/tests: Add missing new lines to ok() and split long lines

2008-12-17 Thread Paul Vriens
Pauli Nieminen wrote: > --- > dlls/d3d9/tests/shader.c | 16 > 1 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/dlls/d3d9/tests/shader.c b/dlls/d3d9/tests/shader.c > index 55b414a..caae395 100644 > --- a/dlls/d3d9/tests/shader.c > +++ b/dlls/d3d9/tests/shader.

Re: wined3d: Implement check for shader creation if hardware supports requested version.

2008-12-17 Thread Paul Vriens
Pauli Nieminen wrote: > + > +if( version <= caps->VertexShaderVersion ) > +{ > +ok(hret == D3D_OK && vshader_ptr != NULL, "Vertex shader (0x%x) > creation failed but d3dcaps claim to support it. hret = 0x%x, vshader_ptr = > %p", version, hret, vshader_ptr); > +IDirect3DVer

Re: Wine t-shirts?

2008-12-17 Thread Andrew Fenn
On Wed, Dec 17, 2008 at 12:14 AM, Ismael Barros² wrote: > > Well, what do you expect from a program called wine? :P > All the wine logos I know are wine-related. Maybe we can use them but > with some kind of C source code background, but even then most people > would think you are some kind of alc

Re: [try2] ntoskrnl.exe: Implement Io{Allocate, Get}DriverObjectExtension.

2008-12-17 Thread Michael Stefaniuc
Alexander Morozov wrote: > Please, use this patch instead of previous "ntoskrnl.exe: Implement > Io{Allocate,Get}DriverObjectExtension." Shouldn't this have gone to wine-patches instead of wine-devel? bye michael

[try2] ntoskrnl.exe: Implement Io{Allocate, Get}DriverObjectExtension.

2008-12-17 Thread Alexander Morozov
Please, use this patch instead of previous "ntoskrnl.exe: Implement Io{Allocate,Get}DriverObjectExtension." From b5441d22fe51640849436b563ca3ab6c9a80c1a5 Mon Sep 17 00:00:00 2001 From: Alexander Morozov Date: Wed, 17 Dec 2008 12:44:46 +0300 Subject: [PATCH] ntoskrnl.exe: Implement Io{Allocate,Get

Re: [PATCH] wined3d: Implement check for shader creation if hardware supports requested version.

2008-12-17 Thread Henri Verbeet
2008/12/17 Pauli Nieminen : > On Wed, Dec 17, 2008 at 10:51 AM, Henri Verbeet wrote: >> If creation succeeds, you need to Release the shader again. Same goes >> for the pixel shader version of this function. > > I tried to search for example of releasing shaders from the test file but > when I co

Re: [PATCH] wined3d: Implement check for shader creation if hardware supports requested version.

2008-12-17 Thread Pauli Nieminen
On Wed, Dec 17, 2008 at 10:51 AM, Henri Verbeet wrote: > 2008/12/17 Pauli Nieminen : > > +static inline void test_create_vshader_version_check(IDirect3DDevice9 > *device_ptr, const D3DCAPS9 *caps, > > +const DWORD version, const DWORD *shader_code) > > +{ > > +IDirect3DVertexShader9 *

Re: server: implement move/rename change notifications and support for multiple change notification in one reply

2008-12-17 Thread Henri Verbeet
2008/12/17 Dan Kegel : > On Tue, Dec 16, 2008 at 5:21 PM, Michael Pujos > wrote: >>> I don't see an attachment to >>> http://www.winehq.org/pipermail/wine-patches/2008-December/066224.html >>> or rather, there's only a zero-length one. >> >> I just attached (In thunderbird) the file outputted by "

Re: [PATCH] wined3d: Implement check for shader creation if hardware supports requested version.

2008-12-17 Thread Henri Verbeet
2008/12/17 Pauli Nieminen : > +static inline void test_create_vshader_version_check(IDirect3DDevice9 > *device_ptr, const D3DCAPS9 *caps, > +const DWORD version, const DWORD *shader_code) > +{ > +IDirect3DVertexShader9 *vshader_ptr = 0; > +HRESULT hret = 0; > + > +hret = IDirec