Re: wintrust: Sign-compare warnings fix

2008-12-10 Thread Andrew Talbot
Juan Lang wrote: > Hi Andy, > > -if (pbEncoded[1] + 1 > cbEncoded) > +if (pbEncoded[1] + 1U > cbEncoded) > > Is this change necessary? The resulting code is less clear than the > original, IMO. It's clearly a spurious warning: a BYTE (max value > 255) + 1 can't yield a value t

compiling Windows code with g++ on Linux using msvcrt - good idea? if so, how do you do it?

2008-12-10 Thread foobarbaz biffblaff
Hi, I have a huge amount of Windows code that I'm porting to Linux. Wine is turning out to be a read godsend, thank you guys! Anyway, I've had tons of luck including the directory /include/wine/windows in my include path. All my Windows types are there and everything is wonderful. I've even b

[no subject]

2008-12-10 Thread foobarbaz biffblaff
Hi, I have a huge amount of Windows code that I'm porting to Linux. Wine is turning out to be a read godsend, thank you guys! Anyway, I've had tons of luck including the directory /include/wine/windows in my include path. All my Windows types are there and everything is wonderful. I've even b

Re: wintrust: Sign-compare warnings fix

2008-12-10 Thread Juan Lang
Hi Andy, -if (pbEncoded[1] + 1 > cbEncoded) +if (pbEncoded[1] + 1U > cbEncoded) Is this change necessary? The resulting code is less clear than the original, IMO. It's clearly a spurious warning: a BYTE (max value 255) + 1 can't yield a value that overflows an unsigned int, so

Re: Canonical and wine

2008-12-10 Thread Remco
Canonical doesn't want to include Wine, because they are trying to provide a complete desktop experience. Wine is a necessity for many people, but Canonical wants to market Ubuntu as the Linux distribution that works well for normal usage. Including a half-working Windows-emulator (functionality em

Re: Translating to winehq.org

2008-12-10 Thread Jeremy Newman
One at a time is fine. As you can see from our Spanish translation, it does not need to be complete. The site will fall back to english when it can't find the template. I would start with home.template and branch out from there. If you see obsolete content, you can send patches to update the en

Translating to winehq.org

2008-12-10 Thread Maik Schulz
Hi, I just started translating the new winehq.org to German. How would you like to receive the git patches for the translated template files? One at a time whenever I have them ready, or at the end in one batch? Also, what about obsolete content? E.g. contributing.template still lists Wine

Re : RFC: Wine Icons

2008-12-10 Thread Hervÿffffe9 Chanal
> On Friday 14 November 2008 19:13:32 Juan Lang wrote: > > > > I find that a bit alarming. I'm sure he's working very hard, and doing > > > good stuff, but I don't think Wine should be redrawing anything. Not > > > when we have Tango around - it's designed to try create some consistency > > > throu

Re: Canonical and wine

2008-12-10 Thread Zachary Goldberg
> On Wednesday 10 December 2008 19:09:16 Dan Kegel wrote: > http://www.technewsworld.com/rsstory/65431.html > quotes Gerry Carr, marketing manager at Canonical: > "We aren't considering a pitch about using Wine or Parallels like on a > Mac. There is no real look at Wine. It doesn't always work well

Re: Canonical and wine

2008-12-10 Thread Kai Blin
On Wednesday 10 December 2008 19:09:16 Dan Kegel wrote: > http://www.technewsworld.com/rsstory/65431.html > quotes Gerry Carr, marketing manager at Canonical: > "We aren't considering a pitch about using Wine or Parallels like on a > Mac. There is no real look at Wine. It doesn't always work well.

Canonical and wine

2008-12-10 Thread Dan Kegel
http://www.technewsworld.com/rsstory/65431.html quotes Gerry Carr, marketing manager at Canonical: "We aren't considering a pitch about using Wine or Parallels like on a Mac. There is no real look at Wine. It doesn't always work well. So this won't win over users to the benefits of Linux," So ther

Re: wininet/tests: Use new test URLs on test.winehq.org.

2008-12-10 Thread Paul Vriens
Hi Alexandre, These changes introduce 15 errors on all platforms. -- Cheers, Paul.

Re: [PATCH 14/14] msi: Add tests for MsiGetProductProperty.

2008-12-10 Thread James Hawkins
On Wed, Dec 10, 2008 at 8:49 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: >> >> --- >> dlls/msi/tests/package.c | 232 >> ++ >> 1 files changed, 232 insertions(+), 0 deletions(-) >> >> >>

Re: [PATCH 14/14] msi: Add tests for MsiGetProductProperty.

2008-12-10 Thread Paul Vriens
James Hawkins wrote: > --- > dlls/msi/tests/package.c | 232 > ++ > 1 files changed, 232 insertions(+), 0 deletions(-) > > > > > Hi James, These fail on Win9x as we are relyi

Re: [5/8] jscript: Implement the String.anchor() method.

2008-12-10 Thread Jacek Caban
Hi Andrew, Andrew Nguyen wrote: > --- > dlls/jscript/string.c | 58 ++ > dlls/jscript/tests/api.js | 17 + > 2 files changed, 73 insertions(+), 2 deletions(-) > +static HRESULT do_attribute_tag_format(DispatchEx *dispex, LCID lcid, W

Re: [5/8] jscript: Implement the String.anchor() method.

2008-12-10 Thread Jacek Caban
Hi Andrew, Andrew Nguyen wrote: > --- > dlls/jscript/string.c | 58 ++ > dlls/jscript/tests/api.js | 17 + > 2 files changed, 73 insertions(+), 2 deletions(-) > +static HRESULT do_attribute_tag_format(DispatchEx *dispex, LCID lcid, W

Re: oleaut32: added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with test (try3)

2008-12-10 Thread Nikolay Sivov
Paul Vriens wrote: > Nikolay Sivov wrote: >> Changelog(try3): >> - fixed identation in testlist >> Changelog(try2): >> - added PICTYPE_NONE and PICTYPE_UNINITIALIZED to >> IPicture::Render with test >> - added test for zero dimensions >> >> P.S. Render with this types spotted in traces

Re: oleaut32: added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with test (try3)

2008-12-10 Thread Paul Vriens
Nikolay Sivov wrote: > Changelog(try3): > - fixed identation in testlist > Changelog(try2): > - added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with > test > - added test for zero dimensions > > P.S. Render with this types spotted in traces of bugs 6799 and 10050 > >

Re: oleaut32: added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with test

2008-12-10 Thread Nikolay Sivov
Michael Karcher wrote: > Am Mittwoch, den 10.12.2008, 13:31 +0300 schrieb Nikolay Sivov: > - remove some tabs from testfile >>> Please don't change formatting, especially with an incorrect tab size. >>> >> Ok, but I'm using 4 spaces tab size. Is it wrong? >> >

Re: oleaut32: added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with test

2008-12-10 Thread Michael Karcher
Am Mittwoch, den 10.12.2008, 13:31 +0300 schrieb Nikolay Sivov: > >> - remove some tabs from testfile > > Please don't change formatting, especially with an incorrect tab size. > Ok, but I'm using 4 spaces tab size. Is it wrong? Tab size in wine source code is defined to be 8. Your patch was m

Re: [5/5] winex11.drv: Fix color conversion for 16 bpp cursors.

2008-12-10 Thread Alexandre Julliard
Henri Verbeet <[EMAIL PROTECTED]> writes: > case 16: > -/* BGR, 5 red, 6 green, 5 blue */ > -*pixel_ptr = *xor_ptr * 0x1f; > -*pixel_ptr |= (*xor_ptr & 0xe0) << 3; > +/* [gggb][rggg] -> > [xxx

Re: oleaut32: added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with test

2008-12-10 Thread Nikolay Sivov
Alexandre Julliard wrote: > Nikolay Sivov <[EMAIL PROTECTED]> writes: > > >> Changelog: >> - added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with >> test >> - added test for zero dimensions >> - remove some tabs from testfile >> > > Please don't change formatti

Re: oleaut32: added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with test

2008-12-10 Thread Alexandre Julliard
Nikolay Sivov <[EMAIL PROTECTED]> writes: > Changelog: > - added PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render with > test > - added test for zero dimensions > - remove some tabs from testfile Please don't change formatting, especially with an incorrect tab size. -- Al