Re: winetest: fix a compiler warning

2008-12-09 Thread Vincent Povirk
These are addressing some very weird cases. They should be an improvement, but I wonder if we can't do better. > void xprintf (const char *fmt, ...) > { > va_list ap; >-size_t size; >+size_t size = 0; > DWORD written; It would make more sense, IMO, to update the vstrfmtmake functi

Patchwatcher status: offline

2008-12-09 Thread Dan Kegel
My house is being rewired, so Patchwatcher is offline for a day.

Re: App hang on creating modal dialog

2008-12-09 Thread Dan Kegel
On Tue, Dec 9, 2008 at 6:48 PM, Jeff Miller <[EMAIL PROTECTED]> wrote: >>> http://bugs.winehq.org/show_bug.cgi?id=16346 > > I'm not sure how to create a non-interactive unit test case for this, since > it involves interplay with the window manager and results in a hang. Does it hang all of wine?

Re: App hang on creating modal dialog

2008-12-09 Thread Jeff Miller
Dan Kegel wrote: > Jeff wrote: > >> I'm trying to solve my bug 16346 >> http://bugs.winehq.org/show_bug.cgi?id=16346 >> ... >> I'm trying to figure out where in the wine code I should look for a >> system that might be eating all of the messages intended for my >> application. Can anyone point

RE: Одговор: Regression in 'Environment Bump Mapping' test (3DMark2001SE) with wine-1.1.10

2008-12-09 Thread Stefan Dösinger
> > Henry, with this patch 'Environment Bump Mapping' test is looking > good, but > > 'fixme:d3d_shader:register_for_arg Unknown source argument 255' is > > still there - continous in many cases, not just in 3DMark2001SE... Is > > this fixme useless, when this works? > > > Stefan has a fix for tha

Re: oleaut32: add PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render

2008-12-09 Thread Nikolay Sivov
Jeremy Drake wrote: > On Tue, 9 Dec 2008, Nikolay Sivov wrote: > > >> + case PICTYPE_NONE: >> + case PICTYPE_UNINITIALIZED: >> + /* undocumented code */ >> + return 0x800A017C; >> > > This code looks suspiciously like CTL_E_INVALIDPROPERTYVALUE (from > olectl.h) to me... > >

RE: appdb sidebar has issues

2008-12-09 Thread ricardo filipe
i'm on firefox 3 too, but it's fixed now :) thx jeremy.> From: [EMAIL PROTECTED]> To: wine-devel@winehq.org; [EMAIL PROTECTED]> Subject: Re: appdb sidebar has issues> Date: Tue, 9 Dec 2008 21:40:54 +0100> > What browser are you using? For me the sidebar text is displayed within the > intended

Re: appdb sidebar has issues

2008-12-09 Thread Jeremy Newman
Fixed the blank spaces thing that logged in users were seeing. Been a long time since I played with the appdb codebase. -Newman Alexander Nicolaysen Sørnes wrote: > What browser are you using? For me the sidebar text is displayed within the > intended confinement, however it is smaller tha

Re: WineHQ redesign

2008-12-09 Thread Jeremy Newman
It is in sync with the rest of the site(s). It is now using 10pt font instead of 10px. Fix it for someone, break it for someone else. -Newman Vitaliy Margolen wrote: > Jeremy Newman wrote: >> I have committed my work for the WineHQ redesign. I've also updated the >> AppDB and Bugzilla codebase

Re: appdb sidebar has issues

2008-12-09 Thread Alexander Nicolaysen Sørnes
What browser are you using? For me the sidebar text is displayed within the intended confinement, however it is smaller than the rest of the AppDB text and thus a tiny bit harder to read than it should be. Firefox 3 Alexander On Tuesday 09 December 2008 20:47:10 ricardo filipe wrote: > http:

Re: WineHQ redesign

2008-12-09 Thread Vitaliy Margolen
Jeremy Newman wrote: > I have committed my work for the WineHQ redesign. I've also updated the > AppDB and Bugzilla codebases with the new theme. The font on bugzilla looks 2x bigger then it's used to. The strange part it's only the bugzilla part that looks big. Menus are fine. Vitaliy

Re: Одговор: Regressio n in 'Environment Bump Mapping' test (3DMark2001SE) with wine-1.1.10

2008-12-09 Thread Henri Verbeet
2008/12/9 Milan Kostić <[EMAIL PROTECTED]>: > Henry, with this patch 'Environment Bump Mapping' test is looking good, but > 'fixme:d3d_shader:register_for_arg Unknown source argument 255' is > still there - continous in many cases, not just in 3DMark2001SE... Is > this fixme useless, when this wor

Re: defwnd: implement handling of WM_INPUTLANGCHANGE

2008-12-09 Thread Aric Stewart
doh! good catch! thanks, i will correct that and resend. -aric Paul Chitescu wrote: > On Tuesday 09 December 2008 21:17:32 Aric Stewart wrote: > [...] > +while (win_array[count]) > +SendMessageA( win_array[count], WM_INPUTLANGCHANGE, wParam, > lParam); > > Missing a

Re: defwnd: implement handling of WM_INPUTLANGCHANGE

2008-12-09 Thread Paul Chitescu
On Tuesday 09 December 2008 21:17:32 Aric Stewart wrote: [...] +while (win_array[count]) +SendMessageA( win_array[count], WM_INPUTLANGCHANGE, wParam, lParam); Missing a ++ here ?

Re: WineHQ redesign

2008-12-09 Thread Paul Chitescu
On Monday 08 December 2008 22:49:15 Jeremy Newman wrote: > I tweaked the font sizes a bit. > > -Newman > > Tijl Coosemans wrote: > > On Monday 08 December 2008 20:42:30 Jeremy Newman wrote: > >> This is because of the "font-size: medium". IE Renders medium text > >> much larger than Gecko and Webki

Re: new web design takes too much space on left

2008-12-09 Thread Jeremy Newman
I'm done, this design has taken enough of my time. You will need to generate patches for ALL the sites if you want to change it now. -Newman Dan Kegel wrote: > When working on a notebook computer, I find myself > resenting the amount of real estate taken by > the left hand navbar in bugzilla. >

Re: new web design takes too much space on left

2008-12-09 Thread Lei Zhang
On Tue, Dec 9, 2008 at 10:38 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > When working on a notebook computer, I find myself > resenting the amount of real estate taken by > the left hand navbar in bugzilla. > > I bet we could shave 20% of that space without > bothering anyone... The images in the b

Re: WineHQ redesign

2008-12-09 Thread Brian Vincent
On Mon, Dec 8, 2008 at 10:40 AM, Jeremy Newman <[EMAIL PROTECTED]>wrote: > I have committed my work for the WineHQ redesign. I've also updated the > AppDB and Bugzilla codebases with the new theme. > By the way, the new site looks great on a Blackberry using Opera Mini or even the regular Blackbe

Re: [PATCH] gdi32: Use font substitution for source font when linking fonts.

2008-12-09 Thread Lei Zhang
On Fri, Dec 5, 2008 at 4:46 PM, Lei Zhang <[EMAIL PROTECTED]> wrote: > Hi, > > This is sort of related to bug 16325. I've noticed some applications > use the "MS Shell Dlg" font to display CJK text and fails. > > In HKLM\Software\Microsoft\Windows NT\CurrentVersion\FontSubstitutes, > MS Shell Dlg i

new web design takes too much space on left

2008-12-09 Thread Dan Kegel
When working on a notebook computer, I find myself resenting the amount of real estate taken by the left hand navbar in bugzilla. I bet we could shave 20% of that space without bothering anyone...

Re: WineHQ redesign

2008-12-09 Thread Jeremy Newman
Reece Dunn wrote: > Some issues: > 1. The wiki is not using the new layout. Dimi is currently updating the Wiki. > 2. In the forums top-level page, the navigation is displayed in one > big list that pushes the forum content to the bottom of the screen. > 3. The WineHQ link on the forums page l

Re: WineHQ redesign

2008-12-09 Thread Tomasz Sałaciński
Honestly - I am never using IE, I even don't know how to enable Javascript. I've changed the security level from "Custom" to "Medium" - it fixed the problem. But since the images are not moving, why someone can't draw the correct background onto them, so people in corporate networks when taking de

Re: WineHQ redesign

2008-12-09 Thread Reece Dunn
2008/12/9 Reece Dunn <[EMAIL PROTECTED]>: > Some issues: > 1. The wiki is not using the new layout. > 2. In the forums top-level page, the navigation is displayed in one > big list that pushes the forum content to the bottom of the screen. > 3. The WineHQ link on the forums page links back to th

Re: WineHQ redesign

2008-12-09 Thread Jeremy Newman
Do you have javascript disabled? I have a javascript workaround that makes PNGs load the alpha correctly under IE6. -Newman Tomasz Sałaciński wrote: > Hi, > > I've been looking at the new WineHQ webiste and it looks really nice, > but it doesn't support older browsers. > > Today I tried to tes

Re: WineHQ redesign

2008-12-09 Thread Tomasz Sałaciński
Hi, I've been looking at the new WineHQ webiste and it looks really nice, but it doesn't support older browsers. Today I tried to test it at my computer at work and the website doesn't work properly on IE6: http://alarm-clock.54.pl/winehq.png IE6 doesn't support transparency in PNG's. If WINE

Re: WineHQ redesign

2008-12-09 Thread Reece Dunn
Some issues: 1. The wiki is not using the new layout. 2. In the forums top-level page, the navigation is displayed in one big list that pushes the forum content to the bottom of the screen. 3. The WineHQ link on the forums page links back to the forums page and not the main website. Looking goo

Re: uxtheme: fix a compiler warning

2008-12-09 Thread Austin English
On Tue, Dec 9, 2008 at 2:35 AM, Michael Karcher <[EMAIL PROTECTED]> wrote: > Am Dienstag, den 09.12.2008, 00:39 -0600 schrieb Austin English: >> -MSSTYLES_GetNextInteger(lpValue, lpValueEnd, &lpValue, &g); >> -if(MSSTYLES_GetNextInteger(lpValue, lpValueEnd, &lpValue, &b)) { >> +if(MSSTY

Re: Alexandre Julliard : include: Added some definitions for x86_64 exception handling.

2008-12-09 Thread Alexandre Julliard
"Steven Edwards" <[EMAIL PROTECTED]> writes: > On Tue, Dec 9, 2008 at 7:23 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: >> Author: Alexandre Julliard <[EMAIL PROTECTED]> >> Date: Mon Dec 8 19:27:59 2008 +0100 >> >> include: Added some definitions for x86_64 exception handling. > > was this

Re: WineHQ redesign

2008-12-09 Thread Rosanne DiMesio
On Tue, 09 Dec 2008 10:08:56 -0600 The background on the forum is now entirely black. Links are red, but messages are completely unreadable. -- Rosanne DiMesio <[EMAIL PROTECTED]>

Re: oleaut32: add PICTYPE_NONE and PICTYPE_UNINITIALIZED to IPicture::Render

2008-12-09 Thread Jeremy Drake
On Tue, 9 Dec 2008, Nikolay Sivov wrote: > + case PICTYPE_NONE: > + case PICTYPE_UNINITIALIZED: > + /* undocumented code */ > + return 0x800A017C; This code looks suspiciously like CTL_E_INVALIDPROPERTYVALUE (from olectl.h) to me...

Re: Alexandre Julliard : include: Added some definitions for x86_64 exception handling.

2008-12-09 Thread Steven Edwards
On Tue, Dec 9, 2008 at 7:23 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > Author: Alexandre Julliard <[EMAIL PROTECTED]> > Date: Mon Dec 8 19:27:59 2008 +0100 > > include: Added some definitions for x86_64 exception handling. was this a typo? You also added ia64/itanium stuff on this comm

Re: WineHQ redesign

2008-12-09 Thread Jeremy Newman
It's possible. -Newman Ferenc Wagner wrote: > Jeremy Newman <[EMAIL PROTECTED]> writes: > >> http://wine.codeweavers.com/winehq_new/ > > Is it possible to add some preload magic for the impressed button > images? Otherwise the buttons disappear for a moment when I hover > above them the first

Re: WineHQ redesign

2008-12-09 Thread Jeremy Newman
I prefer the rounded tabs. -Newman Stephen Gentle wrote: > I still think that the tabs could use a little work - I hacked this > together in Photoshop a little while ago: > http://stephengentle.com/media/images/wine/tabs.png - ignore the lack of > content and most of the layout... > > As for

Re: [msi/tests] Run tests again on Win9x and NT4

2008-12-09 Thread Paul Vriens
James Hawkins wrote: > On Tue, Dec 9, 2008 at 9:32 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: >> Hi, >> >> MsiEnumPatchesExA is not implemented below NT4. >> >> Changelog >> Run tests again on Win9x and NT4 >> > > -r = MsiEnumPatchesExA("", usersid, MSIINSTALLCONTEXT_USERUNMANAGED, > +r =

Re: [msi/tests] Run tests again on Win9x and NT4

2008-12-09 Thread James Hawkins
On Tue, Dec 9, 2008 at 9:32 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > Hi, > > MsiEnumPatchesExA is not implemented below NT4. > > Changelog > Run tests again on Win9x and NT4 > -r = MsiEnumPatchesExA("", usersid, MSIINSTALLCONTEXT_USERUNMANAGED, +r = pMsiEnumPatchesExA("", usersid, MSI

Re: Regression in 'Environment Bump Mapping' test (3DMark2001SE) with wine-1.1.10

2008-12-09 Thread Henri Verbeet
I've attached a patch to bug 16412 (http://bugs.winehq.org/show_bug.cgi?id=16412) that might help.

Re: Huw Davies : opengl/tests: Skip tests if we can't find a pixel format.

2008-12-09 Thread Alexandre Julliard
Huw Davies <[EMAIL PROTECTED]> writes: > Ok, I'll send in a patch with todo_wine and let you decide. > > My feeling was that without opengl support we should skip the opengl32 > tests, hence the skip in the original patch. The todo_wine was to > flag Wine's ChoosePixelFormat bug. My concern is t

Re: Huw Davies : opengl/tests: Skip tests if we can't find a pixel format.

2008-12-09 Thread Huw Davies
On Mon, Dec 08, 2008 at 01:44:41PM +0100, Alexandre Julliard wrote: > Huw Davies <[EMAIL PROTECTED]> writes: > > > Hi Alexandre, > > > > This wasn't what I intended my patch to do. The problem is that > > Wine's ChoosePixelFormat() rets 0 on XServers without glX. The > > win_skip results in a te

Re: Regression in 'Environment Bump Mapping' test (3DMark2001SE) with wine-1.1.10

2008-12-09 Thread James Mckenzie
Milan Kostić <[EMAIL PROTECTED]> at Dec 9, 2008 7:27 AM (MST) wrote about: Regression in 'Environment Bump Mapping' test (3DMark2001SE) withwine-1.1.10 > > Console says: > > fixme:d3d_shader:register_for_arg Unknown source argument 255 > > And picture is odd with 1.1.10, in 1.1.9<= it was good

Regression in 'Environment Bump Mapping' test (3DMark2001SE) with wine-1.1.10

2008-12-09 Thread Milan Kostić
Console says: fixme:d3d_shader:register_for_arg Unknown source argument 255 And picture is odd with 1.1.10, in 1.1.9<= it was good i think. I don't know exactly, but this regression can be due changes in ati_fragment_shader.c. http://i263.photobucket.com/albums/ii149/smokidungeon/wine-1110.j

Re: WineHQ redesign

2008-12-09 Thread Alexandru Balut
On Mon, Dec 8, 2008 at 6:57 PM, Jeremy Newman <[EMAIL PROTECTED]> wrote: > http://wine.codeweavers.com/winehq_new/ The images which appear when hovering the main links have some white pixels in the upper left part, between the bright red border and the srinked original image. It would be nice if

RE: [3/4]

2008-12-09 Thread Stefan Dösinger
> The patch essentially adds a version to the constants and throws them > in a queue. The disadvantage is that setting a constant becomes a bit > more expensive, and cache usage becomes a bit worse if you have to > load constants from deeper in the tree, but it still gives me about 10 > extra fps i

Re: uxtheme: fix a compiler warning

2008-12-09 Thread Michael Karcher
Am Dienstag, den 09.12.2008, 00:39 -0600 schrieb Austin English: > -MSSTYLES_GetNextInteger(lpValue, lpValueEnd, &lpValue, &g); > -if(MSSTYLES_GetNextInteger(lpValue, lpValueEnd, &lpValue, &b)) { > +if(MSSTYLES_GetNextInteger(lpValue, lpValueEnd, &lpValue, &r) && > +MSSTYLES_GetNext

Re: WineHQ redesign

2008-12-09 Thread Stephen Gentle
I still think that the tabs could use a little work - I hacked this together in Photoshop a little while ago: http://stephengentle.com/media/images/wine/tabs.png - ignore the lack of content and most of the layout... As for the rest of the site, the main thing I don't like is that everything i

Re: WineHQ redesign

2008-12-09 Thread Remco
I've made a few observations when using an 800x600 viewport: http://www.few.vu.nl/~rkg230/files/winehq-new-800x600.png The text alignment on the left could be improved by having the next line start on the same horizontal position. The thing about the Codeweavers logo is not that important since on

Re: Gecko package

2008-12-09 Thread Marco Meijer
Ok than I will start using the new version when it's ready. It' s a good thing that someone is working on a update. thank you Marco Jacek Caban schreef: > Dan Kegel wrote: >> marco <[EMAIL PROTECTED]> wrote: >> >>> And what do we do for now ? >>> Is it still wise to distribute a old version, w

Re: Gecko package

2008-12-09 Thread Jacek Caban
Dan Kegel wrote: > marco <[EMAIL PROTECTED]> wrote: > >> And what do we do for now ? >> Is it still wise to distribute a old version, what are the risk that someone >> can use a gecko bug and do some harm in linux or is that not very likely >> with wine ? >> > > Either > a) wait for Jacek's

Re: WineHQ redesign

2008-12-09 Thread Ferenc Wagner
Jeremy Newman <[EMAIL PROTECTED]> writes: > http://wine.codeweavers.com/winehq_new/ Is it possible to add some preload magic for the impressed button images? Otherwise the buttons disappear for a moment when I hover above them the first time. -- Cheers, Feri.

Re: [3/4]

2008-12-09 Thread Henri Verbeet
2008/12/8 Stefan Dösinger <[EMAIL PROTECTED]>: >> Does the patch have any other advantages besides making the fixed >> function state handlers somewhat simpler though? I'm not sure if >> introducing a dependency on the state tracker in the shader backend is >> worth this. (I've got a better way to

Re: hal: add stub for ExAcquireFastMutex

2008-12-09 Thread Alexander Morozov
On Tuesday 09 December 2008 03:52:01 ricardo filipe wrote: > this is for http://bugs.winehq.org/show_bug.cgi?id=12628 This is fastcall function. It should be defined like KfAcquireSpinLock.