Re: [4/5] wined3d: Use a bitmask to store which bool and int constants are set.

2008-12-02 Thread Juan Lang
> Why is this a good thing - this just artificially caps your constants at > 32. If I remember correctly I had to change shaders to do the exact > opposite change, because newer versions introduced more than 32 constants. I agree with you, this is a questionable change. The benefit in reduced dat

Re: [4/5] wined3d: Use a bitmask to store which bool and int constants are set.

2008-12-02 Thread Ivan Gyurdiev
> Re: [4/5] wined3d: Use a bitmask to store which bool and int constantsare set. Why is this a good thing - this just artificially caps your constants at 32. If I remember correctly I had to change shaders to do the exact opposite change, because newer versions introduced more than 32 cons

RE: Coverity Telco coming up

2008-12-02 Thread ricardo filipe
even if there are admins the information about them and how to apply is well hidden and not easy to join :) so it's a good subject to bring...> Date: Tue, 2 Dec 2008 15:54:39 -0600> From: [EMAIL PROTECTED]> To: [EMAIL PROTECTED]> Subject: Re: Coverity Telco coming up> CC: wine-devel@winehq.org>

Re: Coverity Telco coming up

2008-12-02 Thread Austin English
On Tue, Dec 2, 2008 at 11:58 AM, Kai Blin <[EMAIL PROTECTED]> wrote: > Hi folks, > > Coverity is hosting a telco tomorrow about some new technology they're going > to roll out to projects. I'm planning to attend, and would like to bring up > any issues we're currently having in the Q&A session. > >

Re: Coverity Telco coming up

2008-12-02 Thread Paul Vriens
Marcus Meissner wrote: > On Tue, Dec 02, 2008 at 06:58:37PM +0100, Kai Blin wrote: >> Hi folks, >> >> Coverity is hosting a telco tomorrow about some new technology they're going >> to roll out to projects. I'm planning to attend, and would like to bring up >> any issues we're currently having in

Re: Coverity Telco coming up

2008-12-02 Thread Marcus Meissner
On Tue, Dec 02, 2008 at 06:58:37PM +0100, Kai Blin wrote: > Hi folks, > > Coverity is hosting a telco tomorrow about some new technology they're going > to roll out to projects. I'm planning to attend, and would like to bring up > any issues we're currently having in the Q&A session. > > Issues

Coverity Telco coming up

2008-12-02 Thread Kai Blin
Hi folks, Coverity is hosting a telco tomorrow about some new technology they're going to roll out to projects. I'm planning to attend, and would like to bring up any issues we're currently having in the Q&A session. Issues I'm currently seeing with our Coverity experience: - Adding new develop

Re: today's git does not compile with yesterday's new gcc -- regression test results

2008-12-02 Thread Susan Cragin
>>> I did the regression test. But how legitimate are the results if the >>> problem is the new gcc that I downloaded recently, and not wine? This problem was an Ubuntu linux bug, and has been fixed in headers for kernel 2.6.28-2.2. See Ubuntu bug 303711. https://bugs.launchpad.net/ubuntu/+so

Patchwatcher status

2008-12-02 Thread Dan Kegel
Patchwatcher is down for the moment - I mistakenly tried using proprietary nvidia drivers, forgetting that my nvidia card is too old to be supported, and don't have time this morning to recover. I'll fix it tonight.

Re: Status of 64 bit Wine

2008-12-02 Thread Francois Gouget
On Tue, 2 Dec 2008, Michael Ost wrote: [...] > Thanks for the link. It says AMD64 --- I hope this doesn't sound stupid > but will that work on 64 bit Intels too? Yes. It's called AMD64 in many places because the 64bit extension of the x86 ISA was made by AMD and Intel played catch up later. So f

Re: Status of 64 bit Wine

2008-12-02 Thread Michael Ost
Maarten Lankhorst wrote: > Hi Michael, > > Michael Ost schreef: >> Hi list, >> >> Every once in a while my boss asks me about 64 bit wine. And today was >> the day. So what's the status? >> >> From my understanding there are two parts to the question. First, is >> anyone using a 64 bit build of

Re: Status of 64 bit Wine

2008-12-02 Thread Maarten Lankhorst
Hi Michael, Michael Ost schreef: > Hi list, > > Every once in a while my boss asks me about 64 bit wine. And today was > the day. So what's the status? > > From my understanding there are two parts to the question. First, is > anyone using a 64 bit build of Wine? How successfully? Does it pass

Re: wineoss.drv: Eliminate all 64-bits warnings

2008-12-02 Thread Alexandre Julliard
Maarten Lankhorst <[EMAIL PROTECTED]> writes: > sizeof is defined as int on 32-bits, and long on 64-bits. To keep this > working I'm casting all sizeofs to longs Please don't add casts, simply get rid of sizeof in traces like we did in the rest of the code. And please do it as a separate patch.

Re: wineoss.drv: Eliminate all 64-bits warnings

2008-12-02 Thread Kai Blin
On Tuesday 02 December 2008 10:28:04 Austin English wrote: > Minor, but you've got a few extraneous whitespace changes: Those are on otherwise empty lines, I don't see how that'd matter. The reason people don't like formatting-only patches is that it breaks "git blame" history. As git blame supp

Re: wineoss.drv: Eliminate all 64-bits warnings

2008-12-02 Thread Austin English
On Tue, Dec 2, 2008 at 3:19 AM, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > sizeof is defined as int on 32-bits, and long on 64-bits. To keep this > working I'm casting all sizeofs to longs > --- > Minor, but you've got a few extraneous whitespace changes: diff --git a/dlls/wineoss.drv/audio.c