Re: ntdll: DPRINTF -> TRACE. (heap.c)

2008-11-26 Thread Dmitry Timoshkov
"Andrew Riedi" <[EMAIL PROTECTED]> wrote: > The wiki page states that DPRINTF should only be used with a > TRACE_ON(relay) check before it. I believe you that DPRINTF has a > good reason for being there, but for future reference and so I can > correct the wiki, what is it? TRACE_ON(relay) should

Re: user32: Improve the LoadImage() test.

2008-11-26 Thread Andrew Riedi
On Wed, Nov 26, 2008 at 10:14 PM, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "Andrew Riedi" <[EMAIL PROTECTED]> wrote: > >> -icon_entry->xHotspot = 1; >> -icon_entry->yHotspot = 1; >> +icon_entry->xHotspot = 1; /* Color planes for .ico. */ >> +icon_entry->yHotspot = ICON_BPP; /*

Re: ntdll: DPRINTF -> TRACE. (heap.c)

2008-11-26 Thread Andrew Riedi
On Wed, Nov 26, 2008 at 10:16 PM, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "Andrew Riedi" <[EMAIL PROTECTED]> wrote: > >> Changelog: >> ntdll: DPRINTF -> TRACE. (heap.c) > > DPRINTF is used for a reason here. > > -- > Dmitry. > The wiki page states that DPRINTF should only be used with a TRAC

Re: imm32: Add some really basic tests for ImmSetCompositionString().

2008-11-26 Thread Andrew Riedi
On Wed, Nov 26, 2008 at 10:06 PM, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "Andrew Riedi" <[EMAIL PROTECTED]> wrote: > >> +static int test_ImmSetCompositionString(void) > > It's a usual practice to have the test cases return 'void', > especially if you don't use the return value. > >> +{ >> +

Re: ntdll: DPRINTF -> TRACE. (heap.c)

2008-11-26 Thread Dmitry Timoshkov
"Andrew Riedi" <[EMAIL PROTECTED]> wrote: > Changelog: > ntdll: DPRINTF -> TRACE. (heap.c) DPRINTF is used for a reason here. -- Dmitry.

Re: user32: Improve the LoadImage() test.

2008-11-26 Thread Dmitry Timoshkov
"Andrew Riedi" <[EMAIL PROTECTED]> wrote: > -icon_entry->xHotspot = 1; > -icon_entry->yHotspot = 1; > +icon_entry->xHotspot = 1; /* Color planes for .ico. */ > +icon_entry->yHotspot = ICON_BPP; /* BPP for .ico. */ ... > ok(icon_info.xHotspot == 1, "xHotspot is %u.\n", icon

Re: imm32: Add some really basic tests for ImmSetCompositionString().

2008-11-26 Thread Dmitry Timoshkov
"Andrew Riedi" <[EMAIL PROTECTED]> wrote: > +static int test_ImmSetCompositionString(void) It's a usual practice to have the test cases return 'void', especially if you don't use the return value. > +{ > +HIMC imc; > +BOOL ret; > +DWORD error; > + > +imc = ImmGetContext(hwnd); F

Re: [1/5] D3D9: Document a Microsoft header bug

2008-11-26 Thread Adam Petaccia
On Thu, 2008-11-27 at 01:30 +0100, Stefan Dösinger wrote: > > + > +/* Note: Microsoft's d3d9.h does not declare > IDirect3D9Ex::RegisterSoftwareDevice . This would mean that > + * the offsets of the other methods in the Vtable change too. > This, however, seems wrong. In Microsoft's > +

Re: mshtml: Do a case-insensitive compare of type (resend 1)

2008-11-26 Thread Alistair Leslie-Hughes
Any thing wrong with this patch? Best Regards Alistair Leslie-Hughes "Alistair Leslie-Hughes" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Hi, > > Changelog: > mshtml: Do a case-insensitive compare of type > ---

Re: RFC: Proposed new web site design

2008-11-26 Thread Scott Ritchie
Jeremy Newman wrote: > * AppDB, Forums, and Bugzilla will look like the Wiki Sample, just with > their sidebar navs, and content areas. This is why I did not mock them up. > This is probably just a small bug but a commenter on my blog pointed out that you should make the tabs themselves clickabl

Re: Bugzilla's down again

2008-11-26 Thread Austin English
On Wed, Nov 26, 2008 at 4:12 PM, Jeremy Newman <[EMAIL PROTECTED]> wrote: > mysqld didn't crash at least. This seems to be a temporary issue that > cleared up when the server load came back down. > > I don't think the server has been down hardly at all? Where are you getting > your "down so much" f

Re: Bugzilla's down again

2008-11-26 Thread Jeremy Newman
mysqld didn't crash at least. This seems to be a temporary issue that cleared up when the server load came back down. I don't think the server has been down hardly at all? Where are you getting your "down so much" from? -Newman Austin English wrote: > Different error than usual though: > > >

Re: RFC: Proposed new web site design

2008-11-26 Thread Dimi Paun
On Wed, 2008-11-26 at 12:26 -0800, Matt Perry wrote: > > The fonts don't resize correctly in IE6. Go to the view menu and > choose Text Size -> Largest. Only the size of the bullets changes. > This will exclude people from the site that have visual disabilities > such as myself. IIRC IE does not

Bugzilla's down again

2008-11-26 Thread Austin English
Different error than usual though: 500 Internal Server Error Internal Server Error The server encountered an internal error or misconfiguration and was unable to complete your request. Please contact the server administrator, [EMAIL PROTECTED] and inform them of the time the error occurred, an

Re: RFC: Proposed new web site design

2008-11-26 Thread Matt Perry
On Tue, Nov 25, 2008 at 12:25 PM, Jeremy Newman <[EMAIL PROTECTED]>wrote: > * More IE6 tweaks. The fonts don't resize correctly in IE6. Go to the view menu and choose Text Size -> Largest. Only the size of the bullets changes. This will exclude people from the site that have visual disabilities

Re: atl: Remove WINAPI on static functions where not needed.

2008-11-26 Thread Francois Gouget
Ken Thomases wrote: [...] > Could you perhaps grep the output from the preprocessor, instead? The problem would be guessing the right preprocessor command to use as it would normally issue an error if there's a missing include file. -- Francois Gouget [EMAIL PROTECTED]

Re: ole32: Add Co*InitializeSpy functions

2008-11-26 Thread Rob Shearman
2008/11/26 Maarten Lankhorst <[EMAIL PROTECTED]>: > + > +HRESULT WINAPI CoRevokeInitializeSpy(ULARGE_INTEGER cookie) > +{ > +struct oletls *info = COM_CurrentInfo(); > +TRACE("(%s)\n", wine_dbgstr_longlong(cookie.QuadPart)); > + > +if (!info || !info->spy || cookie.QuadPart != (DWORD_PT

Re: mshtml: suppress module unloading while gecko is loaded (take 2)

2008-11-26 Thread Paul Vriens
Dan Kegel wrote: > Thanks to Mike Hearn for pointing out that mshtml reference > counting was wrong, and Jacek for pointing out how to fix > it for now. > > Once gecko is loaded, don't let mshtml unload. > This fixes a crash in starting Sketchup (bug 16164), > and probably fixes a number of other