dead stores in advapi32

2008-11-20 Thread ricardo filipe
hi rob. i have some dead stores in advapi32 files that i would like to clarify. first, what do you want to do on lines 173 and 194 of cred.c? now, there are also 3 dead assignments in cred.c, lines 992, 199 and 1064. i didn't understand what you meant in your last email about my patch that remo

Re: dlls/ole32: check some dead store results (llvm/clang)

2008-11-20 Thread Michael Karcher
Am Donnerstag, den 20.11.2008, 18:36 + schrieb ricardo filipe: | - if ((err=RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey))) { | + if (RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey) == ERROR_SUCCESS) { No. This inverts the logic of the tests. if(x) means if(x != 0). And ERROR_SUCCESS is just

Re: Fedora 9 and MingW

2008-11-20 Thread Jason L Tibbitts III
> "HL" == Hans Leidekker <[EMAIL PROTECTED]> writes: HL> Looks promising! If Fedora accepts it under that name it's HL> certainly worthwhile to add it to configure. FYI, here are the mingw packages which have been submitted for Fedora: https://bugzilla.redhat.com/buglist.cgi?query_format=ad

Re: cryptdlg: Implement FormatVerisignExtension (take 2)

2008-11-20 Thread Alexandre Julliard
"Juan Lang" <[EMAIL PROTECTED]> writes: > +LPWSTR verisign_statement; > +DWORD bytesNeeded; > + > +LoadStringW(hInstance, IDS_VERISIGN_STATEMENT, > + (LPWSTR)&verisign_statement, 0); > +bytesNeeded = (strlenW(verisign_statement) + 1) * sizeof(WCHAR); You ca

Re: urlmon #6: Added more policy tests.

2008-11-20 Thread Paul Vriens
Jacek Caban wrote: > --- > dlls/urlmon/tests/misc.c | 78 > +- > 1 files changed, 77 insertions(+), 1 deletions(-) > > > > > Hi Jacek, I'm checking out a test failure on a f

Re: shdocvw/tests: Make the webbrowser test dpi aware, make is pass in wine

2008-11-20 Thread Paul Vriens
Detlef Riekenberg wrote: > I set every dpi between 72 and 100 on Windows, wrote down the results > and > multiplied the results with the dpi value. > The formula ist the best guess. > Works on win98, w2k, Wine > Hi Detlef, This one introduces some extra failures now. If I look at the comment in