"ricardo filipe" <[EMAIL PROTECTED]> wrote:
> --- a/dlls/cabinet/fci.c
> +++ b/dlls/cabinet/fci.c
> @@ -462,7 +462,7 @@ static cab_ULONG fci_get_checksum(const void *pv, UINT
> cb, CHECKSUM seed)
> case 2:
>ul |= (((ULONG)(*pb++)) << 8);
> case 1:
> - ul |= *pb++;
> +
I can't say for sure, but I think you should share code with
GdipGetLogFontW somehow (probably either calling it or adding a helper
for both functions to call).
Vincent Povirk
On Mon, Nov 17, 2008 at 6:47 PM, Adam Petaccia <[EMAIL PROTECTED]> wrote:
> Was there something wrong with this patch s
2008/11/17 Michael Karcher <[EMAIL PROTECTED]>:
> Am Montag, den 17.11.2008, 13:09 -0800 schrieb Jeremy Drake:
>> As far as the "standard OLE file stream object", if you know of one please
>> let me know. AFAIK, it is a pretty major oversight in the OLE IStream
>> APIs that there is not a function
Was there something wrong with this patch series?
On Tue, 2008-11-11 at 11:24 -0500, Adam Petaccia wrote:
> Changelog:
> try3:
> Only copy the bytes we'll use
> Toss out bytesWritten
> try2:
> Fix memcpy() use
> Add documentation
> Add testcase
> ---
> dlls/gdiplus/font.c
Am Montag, den 17.11.2008, 13:09 -0800 schrieb Jeremy Drake:
> > Be sure to write your findings like (this is hypothetical, as I did not
> > look at your patches and the OlePicture stuff till now): "Loads an image
> > from a File. This is just like OleLoadPictureStream, but with a file
> > name ins
Andrew wrote:
>When sending a patch to wine-patches put the patch number followed by
>how many patches you are sending so the automated scripts can read it.
yes, please!
> For example "[1/1] sending only one patch".
Poor example, please don't do it on single patches.
You only need to do it for s
> Can we fix that? I think I would prefer it if
> primitiveDeclarationConvertToStridedData() handled all that, and just
> returned whether we can use the fast draw function, or have to use the
> slow one.
We never call primitiveDeclarationConverToStridedData() with
drawPrimitiveStrided. We could o
Your patch adds extra whitespace on an empty line.
You are mixing coding styles with your if statements.
When sending a patch to wine-patches put the patch number followed by
how many patches you are sending so the automated scripts can read it.
For example "[1/1] sending only one patch".
2008/1
On Mon, 17 Nov 2008, Michael Karcher wrote:
> The best way to do this is (in my oppinion) submitting the testcase
> again, but without the implementation, and marking the test todo_wine. A
> bug might be useful, but wouldn't a mail that contains the testcase as
> patch and the description in the c
On Sun, 16 Nov 2008, Juan Lang wrote:
> Do you have a bug open? Sorry, I've forgotten. If not, please do open
> one. You can describe your findings there.
No, but a quick search on bugzilla for OleLoadPictureFile turned up bug
10156. A comment on that bug suggests changing the summary to
"Ole
В сообщении от Friday 14 November 2008 12:43:48 Roderick Colenbrander
написал(а):
> > В сообщении от Thursday 13 November 2008 13:22:07 Massimo Del
> > Fedele
> >
> > написал(а):
> > > Sergey Novosyolov ha scritto:
> > > > I've already started working on it about 3 months ago and released
> >
> >
On Thu, 13 Nov 2008, Juan Lang wrote:
> > Any feedback on the spec file or the debug trace?
>
> I'm afraid I don't know what substantive difference there is between
> looking at one small portion of the disassembly (to verify a function
> is being called) and learning something more substantial.
Alexandre Julliard wrote:
> Aric Stewart <[EMAIL PROTECTED]> writes:
>
>> @@ -182,19 +182,26 @@ static UINT CALLBACK create_view_window2_hook(HWND
>> dlg, UINT msg, WPARAM wParam,
>>
>> hr = IShellView2_GetCurrentInfo(shell_view2, &folder_settings);
>> ok(SUCCEEDED(hr)
Hi,
I've noticed that the AddDevice member of DRIVER_EXTENSION is not declared as
a functio pointer. I've put up a patch to fix this.
Alessandro Pignotti
--
Vi Veri Veniversum Vivus Vici
-Dr. Faustus - Marlowe
Public GPG Key ID 0x650B3ED9 on subkeys.gpg.net
Key Fingerprint 6243 AAD3 E3E
Michael Karcher wrote:
[...]
>> As a reminder, the issue is that it's not because the libxslt.so we
>> compile against has xlstInit() that the one we load at runtime will have
>> it too. And vice versa.
> Wait a moment. I don't know about Wine's dl* functions, but can't we use
> dlsym with the RTLD
2008/11/17 Stefan Dösinger <[EMAIL PROTECTED]>:
>> 2008/11/17 Stefan Dösinger <[EMAIL PROTECTED]>:
>> > -} else if (fixup ||
>> > +} else if (device->vertex_pipe->can_convert_d3dcolor || fixup ||
>> Shouldn't this be redundant if you already handle color conversion in
>> IWineD3DVertexBuffe
Am Montag, den 17.11.2008, 15:09 +0100 schrieb Francois Gouget:
> configure will need to be regenerated. I did not include it here since
> the consensus seems to be that it should not be included.
Just a nitpick: Same applies for config.h.in, then.
> As a reminder, the issue is that it's not bec
> 2008/11/17 Stefan Dösinger <[EMAIL PROTECTED]>:
> > -} else if (fixup ||
> > +} else if (device->vertex_pipe->can_convert_d3dcolor || fixup ||
> Shouldn't this be redundant if you already handle color conversion in
> IWineD3DVertexBufferImpl_FindDecl()?
Not all vertex data comes from a ve
2008/11/17 James McKenzie <[EMAIL PROTECTED]>:
> Rob Shearman wrote:
>> 2008/11/14 Dan Kegel <[EMAIL PROTECTED]>:
>>
>>> I'm seeing the following valgrind warning
>>> in three out of eight runs under heavy load:
>>>
>>> InvalidRead
>>> IMM_FreeThreadData:233
>>> DllMain:382
>>> __wine_spec_dll_e
I'm seeing a lot of errors like this lately:
cp: `/home/dank/.local/share/icons/3550_shell32.0.xpm' and
`/home/dank/.local/share/icons/3550_shell32.0.xpm' are the same file
Did the recent rewrite of menu item creation break something?
"Alistair Leslie-Hughes" <[EMAIL PROTECTED]> wrote:
> +if(RtlUnicodeStringToAnsiString(&routineNameA, SystemRoutineName, TRUE)
> == STATUS_SUCCESS)
> +{
> +/* We only support functions exported from ntoskrnl.exe or hal.dll */
> +hMod = GetModuleHandleW(ntoskrnlW);
> +
2008/11/17 paulo lesgaz <[EMAIL PROTECTED]>:
> The problem is that the test takes the value 0x3f once (if the test is
> correct), and that my function can not never obtain such a value.
>
Looks like you need to set one of the
D3DVIS_INSIDE_FRUSTUM/D3DVIS_INTERSECT_FRUSTUM/D3DVIS_OUTSIDE_FRUSTUM
fl
Hello Jeremy, Juan and rest of wine-devel
[sorry for shifting quotes around, this makes following my points easier
and in this case shouldn't forge you to seem to have said something you
didn't say]
> > And now that I know that, I certainly won't be doing it again.
> Thank you for your understanin
23 matches
Mail list logo
