Re: Grumble. Kernel lockup in Intrepid.

2008-11-16 Thread Marcus Meissner
On Sun, Nov 16, 2008 at 12:20:37PM -0800, Dan Kegel wrote: > Wonder why patchwatcher was down for 12 hours? It > seems to have been a kernel problem. > > This is on an Ubuntu 8.10 32 bit Core 2 Duo system > on a P5K Pro motherboard, with a PCI-E NVidia card. > I have the proprietary Nvidia driver

Re: ComputeSphereVisibility: a patch

2008-11-16 Thread paulo lesgaz
Hi, here is a new patch for ComputeSphereVisibility implementing Henri and Franck's idea. The problem is that the test takes the value 0x3f once  (if the test is correct), and that my function can not never obtain such a value. Any idea to fix this problem. Here is the only one link talking ab

Re: implement OleLoadPictureFile

2008-11-16 Thread Juan Lang
> And now that I know that, I certainly won't be doing it again. Thank you for your understaning. > Well, I still have an application that won't run under wine because this > function is not implemented. So assuming *this* patch doesn't get in, > what can I do to help get *a* patch in that imple

Re: d3dx9: Add ID3DXSprite tests (review please)

2008-11-16 Thread Dmitry Timoshkov
"Vitaliy Margolen" <[EMAIL PROTECTED]> wrote: > In all of your patch: >> +if(!obj) return 0; > Please add space after "if" to make it consistent and more readable: >if (!obj) return 0; Actually it would be better to either completely remove that line, or even do an assert(obj != NULL) ins

Re: Race in thread shutdown in imm32?

2008-11-16 Thread James McKenzie
Rob Shearman wrote: > 2008/11/14 Dan Kegel <[EMAIL PROTECTED]>: > >> I'm seeing the following valgrind warning >> in three out of eight runs under heavy load: >> >> InvalidRead >> IMM_FreeThreadData:233 >> DllMain:382 >> __wine_spec_dll_entry:40 >> MODULE_InitDLL:911 >> LdrShutdownThread:21

Re: [1/5] WineD3D: Get some vertex pipeline infrastructure in place

2008-11-16 Thread Henri Verbeet
2008/11/17 Stefan Dösinger <[EMAIL PROTECTED]>: > -} else if (fixup || > +} else if (device->vertex_pipe->can_convert_d3dcolor || fixup || Shouldn't this be redundant if you already handle color conversion in IWineD3DVertexBufferImpl_FindDecl()? > -} else { > +} else if(!device->ve

Re: [5/5] WineD3D: Move the fogdensity state to the misc state table

2008-11-16 Thread Austin English
On Sun, Nov 16, 2008 at 5:20 PM, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > fogstart and fogend will probably follow as well later, I still have to look > at those because they interfere with glEnable(GL_FOG) and the fog source > settings and are thus involved in the vertex pipeline as well > > >

Re: ComputeSphereVisibility: a patch

2008-11-16 Thread Henri Verbeet
2008/11/15 Frank Richter <[EMAIL PROTECTED]>: > On 14.11.2008 20:27, paulo lesgaz wrote: >> Hi, >> >> here is a patch for a first try to implement ComputeSphereVisibility. >> Any feedback is welcome. > > I think you can simplify the sphere-plane intersection. Just compute the > signed distance D of

Re: d3dx9: Implement ID3DXSprite_OnLostDevice/OnResetDevice

2008-11-16 Thread Henri Verbeet
2008/11/15 Tony Wasserka <[EMAIL PROTECTED]>: > +if(This->sprites) { > +int i; > +for(i=0;isprite_count;i++) > +if(This->sprites[i].texture) This if should be redundant. I looked at some of the other sprite code, and noticed you've got similar constructions in other

Re: d3dx9: ID3DXSprite: Move vdecl creation to ID3DXSprite_Begin [PATCH 2/3]

2008-11-16 Thread Henri Verbeet
As a general remark about drawing sprites, when shaders are available you can use those instead, which should save you from messing around with render states and texture stage states.

Re: d3dx9: Implement ID3DXSprite_*etTransform [PATCH 1/3]

2008-11-16 Thread Henri Verbeet
2008/11/15 Tony Wasserka <[EMAIL PROTECTED]>: > +TRACE("(%p): relay\n", This); "relay" doesn't make sense here. > +memcpy(transform, &This->transform, sizeof(D3DXMATRIX)); Why not just write "*transform = This->transform"?

Re: DIB Engine

2008-11-16 Thread Massimo Del Fedele
I put a testing patch (which introduces Jesse Allen's dib engine in current tree) on bugzilla - Bug 421 page. The engine was tested on autocad (many display problems, but noticeable speedup) and with Excel (quickly, works, display problems in dialogs). The patch is just for testing purposes and

Re: Slovak translations

2008-11-16 Thread Austin English
2008/11/16 Kario <[EMAIL PROTECTED]>: > hi, my name is Mario Kacmar, I am from Slovakia > > and I made this patch with Slovak translations > > please commit my patch, or if is something wrong > > please contact me back > > > > see attachment > > === reklama == >

Re: [1/4] user32/tests: Test size and minmax of WS_THICKFRAME child.

2008-11-16 Thread Florian Köberle
Hi Austin, >> From 762f49e2192b6d8477826c6535ef1ba0e1fd9d9b Mon Sep 17 00:00:00 2001 >> From: =?utf-8?q?Florian=20K=C3=B6berle?= <[EMAIL PROTECTED]> >> > > Looks like you've botched the encoding somehow... > That's correct this way. If you have a look at other mails you will see that it is

Re: [1/4] user32/tests: Test size and minmax of WS_THICKFRAME child.

2008-11-16 Thread Austin English
On Sun, Nov 16, 2008 at 10:52 AM, Florian Köberle <[EMAIL PROTECTED]> wrote: > Patch to fix bug 15188. > > This work is based on: > http://www.winehq.org/pipermail/wine-patches/2008-October/062460.html > > In this new patch series I calculate size like this: > > const int outer = 2; > int resizeBor

Re: tools/fnt2bdf: fix a few compiler warnings (1/10)

2008-11-16 Thread Austin English
On Sun, Nov 16, 2008 at 3:21 AM, Marcus Meissner <[EMAIL PROTECTED]> wrote: > On Wed, Nov 12, 2008 at 10:28:37AM +0100, Michael Stefaniuc wrote: >> Austin English wrote: >> > This series of patches fixes most of the new warnings generated in gcc >> > 4.3.2. There's one issue left, but I'm not quite

Grumble. Kernel lockup in Intrepid.

2008-11-16 Thread Dan Kegel
Wonder why patchwatcher was down for 12 hours? It seems to have been a kernel problem. This is on an Ubuntu 8.10 32 bit Core 2 Duo system on a P5K Pro motherboard, with a PCI-E NVidia card. I have the proprietary Nvidia drivers installed, so I can't expect support from anybody, but I did want to

Re: d3dx9: Add ID3DXSprite tests (review please)

2008-11-16 Thread Vitaliy Margolen
Tony Wasserka wrote: > This is my first test, so I think it's better to ask for feedback on > wine-devel, first. > And please fix your e-mail server to properly accept e-mails if you asking some one to comment on them. Vitaliy.

Re: d3dx9: Add ID3DXSprite tests (review please)

2008-11-16 Thread Vitaliy Margolen
Tony Wasserka wrote: > This is my first test, so I think it's better to ask for feedback on > wine-devel, first. > In all of your patch: > +if(!obj) return 0; Please add space after "if" to make it consistent and more readable: if (!obj) return 0; > hr=IDirect3DDevice9_CreateTexture Plea

Re: DIB Engine

2008-11-16 Thread Massimo Del Fedele
Well, I managed to introduce Jesse Allen's dib engine in current wine tree, and it worked. It has many stubbed functions, but I could load and run Autocad with it, which IMHO is a good result. Autocad misses many toolbar's icons but, about the problem of very slow TT fonts, the performance incre

Re: [PATCH 1/7] msi: Add more tests for the CompLocator part of the AppSearch action.

2008-11-16 Thread Paul Vriens
James Hawkins wrote: --- dlls/msi/tests/package.c | 526 +- 1 files changed, 421 insertions(+), 105 deletions(-) Hi James, I was looking at why on Win9x there were some reg

Re: tools/fnt2bdf: fix a few compiler warnings (1/10)

2008-11-16 Thread Michael Stefaniuc
Marcus Meissner wrote: > On Wed, Nov 12, 2008 at 10:28:37AM +0100, Michael Stefaniuc wrote: >> Austin English wrote: >>> This series of patches fixes most of the new warnings generated in gcc >>> 4.3.2. There's one issue left, but I'm not quite sure what should be >>> done on that one. >>> diff --g

d3dx9: Add ID3DXSprite tests (review please)

2008-11-16 Thread Tony Wasserka
This is my first test, so I think it's better to ask for feedback on wine-devel, first. There are some points, where I wasn't sure what to do: line 26: Is using inline okay here? IIRC that's C++ only, but other tests do it the same way... line 82: Is it legal to demand A8R8G8B8 support here? Ot

Re: uninitialized reference in wineconsole in call to WriteConsoleInput?

2008-11-16 Thread Eric Pouech
Dan Kegel a écrit : > One more of the 100 valgrind warnings; this one is > in kernel32/tests/console.c (but really in wineconsole). > It's code Eric wrote six years ago, and the fix might be > as straightforward as using memcpy(&ir, 0, sizeof(ir)) in > WCUSER_GenerateMouseInputRecord(). > Is there

Re: tools/fnt2bdf: fix a few compiler warnings (1/10)

2008-11-16 Thread Marcus Meissner
On Wed, Nov 12, 2008 at 10:28:37AM +0100, Michael Stefaniuc wrote: > Austin English wrote: > > This series of patches fixes most of the new warnings generated in gcc > > 4.3.2. There's one issue left, but I'm not quite sure what should be > > done on that one. > > diff --git a/tools/fnt2bdf.c b/too