noob req: ddraw/vertexbuffer.c and HW vertex buffers

2008-11-06 Thread FeepingCreature
Hi, I've been playing Gothic2 and getting lots of messages regarding d3d7:IDirect3DVertexBufferImpl_Optimize, printed by ddraw/vertexbuffer.c. Reading the comments for that function seems to indicate that vertex buffers are currently emulated in software, and will be handled in hardware as soon as

Re: Launchpad Bugzilla plugin can allow us to share comment histories for forwarded bugs

2008-11-06 Thread Kai Blin
On Thursday 06 November 2008 17:50:48 Scott Ritchie wrote: > There's a launchpad bugzilla plugin available now, made by bugzilla > developers: https://help.launchpad.net/Bugs/BugzillaPlugin > > Having this seems like it would simplify things, as there wouldn't be a > need to forward comments on a l

Re: [2/3] comctl32: toolbar: Improve text layout in TBSTYLE_LIST toolbars.

2008-11-06 Thread Paul Vriens
Sergey Khodych wrote: > > > > > Sorry for the previous email (replied to the wrong patch email). Hi, Could you have a look at http://test.winehq.org/data/3f4333d70c27a813b4d99e0daeeb613e9e941a9a/ as this patch introduc

Re: [1/3] comctl32: toolbar: Calculate a correct size for empty buttons with the BTNS_AUTOSIZE style.

2008-11-06 Thread Paul Vriens
Sergey Khodych wrote: > > > > > Hi, Could you have a look at http://test.winehq.org/data/3f4333d70c27a813b4d99e0daeeb613e9e941a9a/ as this patch introduced a failure on all Windows platforms. I guess it's just changing

Re: mshtml: Implement IHTMLStyle get/put posLeft (try 8)

2008-11-06 Thread Jacek Caban
Alistair Leslie-Hughes wrote: > Hi, >Made functions for get/set. > > Changelog: > mshtml: Implement IHTMLStyle get/put posLeft +for(ptr=value; isdigitW(*ptr); ptr++) +{ +if(*ptr && !strcmpW(ptr, pxW)) { This if expression will never be true. You s

Re: winmm: Increase tolerance range in tests

2008-11-06 Thread Alistair Leslie-Hughes
Hi Robert -- From: "Robert Reif" <[EMAIL PROTECTED]> Sent: Thursday, November 06, 2008 11:00 PM To: "Alistair Leslie-Hughes" <[EMAIL PROTECTED]> Cc: Subject: Re: winmm: Increase tolerance range in tests >> > On real hardware or on a virtual mach

Re: patchwatcher status: online but no email

2008-11-06 Thread Dimi Paun
On Thu, 2008-11-06 at 09:29 -0800, Dan Kegel wrote: > > Would you settle for static alternating colors? > I'm kind of anti hover highlight. IIRC there was a recent study claiming that alternating row colors are not all that useful in practice, the on-hover has the advantage of focusing your att

Re: patchwatcher status: online but no email

2008-11-06 Thread Dan Kegel
On Thu, Nov 6, 2008 at 9:07 AM, Dimi Paun <[EMAIL PROTECTED]> wrote: > One suggestion that I have is changing the background color > of the row on hover so you can easily match the result on the > RHS to the Subject, right now that is a bit difficult to > do visually on a wide-screen monitor. Woul

Re: patchwatcher status: online but no email

2008-11-06 Thread Dimi Paun
On Thu, 2008-11-06 at 08:32 -0800, Dan Kegel wrote: > You should see your patch appear at > http://kegel.com/wine/patchwatcher/results Very nice! One suggestion that I have is changing the background color of the row on hover so you can easily match the result on the RHS to the Subject, right

Re: What happened to __TRY?

2008-11-06 Thread Michael Ost
Alexandre Julliard wrote: > Michael Ost <[EMAIL PROTECTED]> writes: > >> When I upgraded wine-develfrom 1.0 to 1.1.7, my winelib app that uses >> __TRY no longer links. It complains that RtlUnwind cannot be found. I >> can see that RtlUnwind was added to wine/exception.h, but I am not sure >> h

Re: What happened to __TRY?

2008-11-06 Thread Michael Ost
Rob Shearman wrote: > 2008/11/6 Michael Ost <[EMAIL PROTECTED]>: >> Hi all, >> >> When I upgraded wine-develfrom 1.0 to 1.1.7, my winelib app that uses >> __TRY no longer links. It complains that RtlUnwind cannot be found. I >> can see that RtlUnwind was added to wine/exception.h, but I am not sure

Re: What happened to __TRY?

2008-11-06 Thread Dmitry Timoshkov
"Rob Shearman" <[EMAIL PROTECTED]> wrote: >> When I upgraded wine-develfrom 1.0 to 1.1.7, my winelib app that uses >> __TRY no longer links. It complains that RtlUnwind cannot be found. I >> can see that RtlUnwind was added to wine/exception.h, but I am not sure >> how to fix it. >> >> I tried add

Launchpad Bugzilla plugin can allow us to share comment histories for forwarded bugs

2008-11-06 Thread Scott Ritchie
There's a launchpad bugzilla plugin available now, made by bugzilla developers: https://help.launchpad.net/Bugs/BugzillaPlugin Having this seems like it would simplify things, as there wouldn't be a need to forward comments on a launchpad bug to the one posted at WineHQ. It can be quite annoying

Re: What happened to __TRY?

2008-11-06 Thread Alexandre Julliard
Michael Ost <[EMAIL PROTECTED]> writes: > When I upgraded wine-develfrom 1.0 to 1.1.7, my winelib app that uses > __TRY no longer links. It complains that RtlUnwind cannot be found. I > can see that RtlUnwind was added to wine/exception.h, but I am not sure > how to fix it. > > I tried adding -

Re: What happened to __TRY?

2008-11-06 Thread Rob Shearman
2008/11/6 Michael Ost <[EMAIL PROTECTED]>: > Hi all, > > When I upgraded wine-develfrom 1.0 to 1.1.7, my winelib app that uses > __TRY no longer links. It complains that RtlUnwind cannot be found. I > can see that RtlUnwind was added to wine/exception.h, but I am not sure > how to fix it. > > I tri

patchwatcher status: online but no email

2008-11-06 Thread Dan Kegel
Patchwatcher is now working well enough to depend on, I think, but doesn't send email yet. You should see your patch appear at http://kegel.com/wine/patchwatcher/results under a minute after you post, and if your patch is simple, test results should show up about ten minutes later. (Long patch ser

Re: winmm: Increase tolerance range in tests

2008-11-06 Thread Jeff Zaroyko
On Thu, Nov 6, 2008 at 11:00 PM, Robert Reif <[EMAIL PROTECTED]> wrote: > Alistair Leslie-Hughes wrote: >> Robert Reif wrote: >> >>> Please give an explanation why? If it's just to make the test pass, >>> then we need to know why the test is failing. >>> >>> Is it only needed for wine? Could be a

Re: Vincent Povirk : setupapi: Implement ProfileItems directive.

2008-11-06 Thread Rob Shearman
2008/11/5 Vincent Povirk <[EMAIL PROTECTED]>: > +CoInitialize(NULL); > + > +if (!SUCCEEDED(CoCreateInstance( &CLSID_ShellLink, NULL, > + CLSCTX_INPROC_SERVER, &IID_IShellLinkW, > (LPVOID*)&shelllink))) > +goto done; > + > +IShellLinkW_SetPath

Re: winmm: Increase tolerance range in tests

2008-11-06 Thread Robert Reif
Alistair Leslie-Hughes wrote: > Robert Reif wrote: > >> Please give an explanation why? If it's just to make the test pass, >> then we need to know why the test is failing. >> >> Is it only needed for wine? Could be a wine problem. >> >> Is it only needed for specific versions of Windows or

Finish the implementation of ID3DXMatrixStack

2008-11-06 Thread paulo lesgaz
Hello You should send one patch for one implementation of a function, not one patch for all the functions. Moreover, you should keep the style of the file. The semi-colon ; is placed just after the parenthesis ) not like this: ) ; David --- En date deĀ : Mer 29.10.08, paulo lesgaz <[EMAIL PROT

Re: [2/2] WINED3D: Fix D3DCOLOR swizzling in shaders.

2008-11-06 Thread Henri Verbeet
2008/11/6 Mark Kilgard <[EMAIL PROTECTED]>: > > WineD3D, > > Please be aware of this new OpenGL extension: > > http://www.opengl.org/registry/specs/EXT/vertex_array_bgra.txt > http://www.opengl.org/registry/specs/EXT/vertex_array_bgra.txt > > This extension allows OpenGL implementations supportin

Re: winmm: Increase tolerance range in tests

2008-11-06 Thread Alistair Leslie-Hughes
Robert Reif wrote: > Please give an explanation why? If it's just to make the test pass, > then we need to know why the test is failing. > > Is it only needed for wine? Could be a wine problem. > > Is it only needed for specific versions of Windows or specific hardware > or drivers? > > Is