Re: [Try 5] msvcrt: Set permissions of file in sopen

2008-10-22 Thread Dmitry Timoshkov
"Ivan Peevski" <[EMAIL PROTECTED]> wrote: > the pmode flag test should be: > if it has the IREAD but not the IWRITE flag (read only) > does that make sense? Is it doing what I think it is? It should be: if ((pmode & MSVCRT__S_IREAD) && !(pmode & MSVCRT__S_IWRITE)) ...; IMO it would be more

Re: [1/2] richedit: Added test for correct behaviour for callingEditWordBreakProc.

2008-10-22 Thread Dmitry Timoshkov
"Dylan Smith" <[EMAIL PROTECTED]> wrote: > EditWordBreakProc documented the third parameter as being the number of > unicode characters in the string for richedit 2.0 and up. It turns out > that it should actually be the number of bytes in the string. Have you tried to set a unicode word break p

Re: wine users forum registration issue

2008-10-22 Thread Rosanne DiMesio
>> >> > Not sure what they are complaining about - worked for me first time around. > I think some people might have problems with: > 1. Entering lower case text instead of caps > 2. Not knowing (and not willing to find out) "who is the current maintainer". > > IMHO people should be able to figure

Re: [Try 5] msvcrt: Set permissions of file in sopen

2008-10-22 Thread Dmitry Timoshkov
"Ivan Peevski" <[EMAIL PROTECTED]> wrote: > + if (pmode & (MSVCRT__S_IREAD & !MSVCRT__S_IWRITE)) > +attrib |= FILE_ATTRIBUTE_READONLY; The pmode flags test doesn't look right. Also the 'attrib |= ' line has a trailing space. -- Dmitry.

Re: [Try 5] msvcrt: Set permissions of file in sopen

2008-10-22 Thread Austin English
On Wed, Oct 22, 2008 at 10:13 PM, Ivan Peevski <[EMAIL PROTECTED]> wrote: > Followed the documentation at > http://msdn.microsoft.com/en-us/library/w7sa2b22(VS.80).aspx. Ignore pmode if > the file already exist and emulate permissions as best we can during file > creation. > > --- > dlls/msvcrt

Re: wine users forum registration issue

2008-10-22 Thread Vitaliy Margolen
Zachary Goldberg wrote: > On Wed, Oct 22, 2008 at 8:19 AM, Jeremy White <[EMAIL PROTECTED]> wrote: >> Does anyone know *why* these people suffer? Is there something specific to >> their >> monitor or is it just a general struggle with captchas? >> >> Finally, is there someone who would be willing

Re: [include] - add dde.rh

2008-10-22 Thread Dmitry Timoshkov
"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote: > Changelog > -- > Add dde.rh Why are you plain copying it from PSDK? -- Dmitry.

Re: wine users forum registration issue

2008-10-22 Thread Zachary Goldberg
On Wed, Oct 22, 2008 at 8:19 AM, Jeremy White <[EMAIL PROTECTED]> wrote: > Does anyone know *why* these people suffer? Is there something specific to > their > monitor or is it just a general struggle with captchas? > > Finally, is there someone who would be willing to help users through this? >

Re: [6/6] d3d10: d3d10 doesn't need wined3d.

2008-10-22 Thread Henri Verbeet
2008/10/22 Stefan Dösinger <[EMAIL PROTECTED]>: > Do you have any long-time intentions with this? Or are you just changing it > because we don't need wined3d right now because d3d10 is a stub? > Wined3d's main entrypoint is WineDirect3DCreate, everything else happens through COM objects. WineDirect

RE: [6/6] d3d10: d3d10 doesn't need wined3d.

2008-10-22 Thread Stefan Dösinger
Do you have any long-time intentions with this? Or are you just changing it because we don't need wined3d right now because d3d10 is a stub? > -Original Message- > From: [EMAIL PROTECTED] [mailto:wine-patches- > [EMAIL PROTECTED] On Behalf Of Henri Verbeet > Sent: Wednesday, October 22, 2

make test solution

2008-10-22 Thread chris ahrendt
NM figured it out... some odd reason the git directory has to be mapped to a windows drive.. once I did that.. it all cleaned up... chris

make test issue..

2008-10-22 Thread chris ahrendt
I have a general question on the make files... specifically the make test portion of it.. Since talking to dan about things this would be where I could be of most help. I have an issue with the make test currently.. I am getting : [EMAIL PROTECTED] wine-git]$ make test make[1]: Entering direct

Re: [PATCH 1/2] jscript: Added Math.floor implementation.

2008-10-22 Thread Jacek Caban
Vincent Povirk wrote: > +tmp = Math.floor(1.1); > +ok(tmp === 1, "Math.round(1.1) = " + tmp); > > Copy/paste error? > > Yes, good catch, thanks. Jacek

Re: cryptui: Add a partial implementation of CryptUIWizImport.

2008-10-22 Thread Juan Lang
> Yes, so those users may benefit from the stub as well. And I do print > a FIXME. This is nothing new, we've been ignoring invalid certificates > in wininet for years where we should stop and show a UI. When I tested with native cryptui and imported a cert, it didn't pick the root store. So I'm

re: Dylan Smith : richedit:Added tests for ctrl-key shortcut handling in WM_KEYDOWN.

2008-10-22 Thread Dan Kegel
Dmitry wrote: >> + BYTE key_state[256]; >> +... >> + result = GetKeyboardState((LPBYTE)&key_state); > the casts in the above code clearly > show that the pointer syntax is wrong there. Nah. It's ugly, but not wrong. key_state == &key_state here. - Dan

Re: cryptui: Add a partial implementation of CryptUIWizImport.

2008-10-22 Thread Hans Leidekker
On Wednesday 22 October 2008 16:37:16 you wrote: > I don't think that's typical usage at all: typical usage presents a > UI. It's called from elsewhere in cryptui, so it's under the control Sure, but the app may present its own UI like Outlook does, and call this function with CRYPTUI_WIZ_NO_UI

Re: [PATCH 3/3] ole32: Call the appropriate storage function when we run the object.

2008-10-22 Thread Huw Davies
On Wed, Oct 22, 2008 at 02:03:26PM +0100, Rob Shearman wrote: > 2008/10/22 Huw Davies <[EMAIL PROTECTED]>: > > On Wed, Oct 22, 2008 at 12:46:39PM +0100, Rob Shearman wrote: > >> 2008/10/21 Huw Davies <[EMAIL PROTECTED]>: > >> > @@ -1728,6 +1767,10 @@ static HRESULT WINAPI > >> > DefaultHandler_IPe

Re: cryptui: Add a partial implementation of CryptUIWizImport.

2008-10-22 Thread Juan Lang
> If I'm right about typical usage of this function it will do the right > thing more often than not, which is pretty good for a stub. I don't think that's typical usage at all: typical usage presents a UI. It's called from elsewhere in cryptui, so it's under the control of the user how frequent

Re: wine users forum registration issue

2008-10-22 Thread James Mckenzie
Kai Blin <[EMAIL PROTECTED]> at Oct 22, 2008 12:36 AM wrote about wine users forum registration issue > >On Tuesday 21 October 2008 18:25:19 Andreas Mohr wrote: > >Given that most people on this list don't seem to use the forum and thus don't >notice, how about the people who actually use the fo

Re: [PATCH 3/3] ole32: Call the appropriate storage function when we run the object.

2008-10-22 Thread Rob Shearman
2008/10/22 Huw Davies <[EMAIL PROTECTED]>: > On Wed, Oct 22, 2008 at 12:46:39PM +0100, Rob Shearman wrote: >> 2008/10/21 Huw Davies <[EMAIL PROTECTED]>: >> > @@ -1728,6 +1767,10 @@ static HRESULT WINAPI >> > DefaultHandler_IPersistStorage_HandsOffStorage( >> > if(SUCCEEDED(hr) && object_is_ru

Re: configure: Require at least version 1.6 of gnutls.

2008-10-22 Thread James Mckenzie
Francois Gouget <[EMAIL PROTECTED]> at Oct 22, 2008 2:15 AM wrote about configure: Require at least version 1.6 of gnutls. > >On Tue, 21 Oct 2008, James Mckenzie wrote: > >> Henri Verbeet <[EMAIL PROTECTED]> at Oct 21, 2008 10:04 AM wrote about >> configure: Require at least version 1.6 of gnutls

re: QueryDosDevice

2008-10-22 Thread Dan Kegel
Tomasz Salacinski wrote: > I was trying to find a solution for bug 5351... Are you trying to fix it, or just work around it? "winetricks volnum" works around it just fine. > I need to have Visual Studio on Linux (otherwise I will have > to install Windows), and I can try to fix the problem. I can

Re: Dylan Smith : richedit:Added tests for ctrl-key shortcut handling in WM_KEYDOWN.

2008-10-22 Thread Dmitry Timoshkov
"Alexandre Julliard" <[EMAIL PROTECTED]> wrote: > +static BOOL hold_key(int vk) > +{ > + BYTE key_state[256]; > + BOOL result; > + > + result = GetKeyboardState((LPBYTE)&key_state); > + ok(result, "GetKeyboardState failed.\n"); > + if (!result) return FALSE; > + key_state[vk] |= 0x80; > + r

Re: [PATCH 3/3] ole32: Call the appropriate storage function when we run the object.

2008-10-22 Thread Huw Davies
On Wed, Oct 22, 2008 at 12:46:39PM +0100, Rob Shearman wrote: > 2008/10/21 Huw Davies <[EMAIL PROTECTED]>: > > @@ -1728,6 +1767,10 @@ static HRESULT WINAPI > > DefaultHandler_IPersistStorage_HandsOffStorage( > > if(SUCCEEDED(hr) && object_is_running(This)) > > hr = IPersistStorage_Ha

Re: wine users forum registration issue

2008-10-22 Thread Marcus Meissner
On Wed, Oct 22, 2008 at 07:19:46AM -0500, Jeremy White wrote: > > Right. So the forum software is broken, and all of the Wine devs would > > rather > > fix Wine than the forums? Sounds like a good case for ditching the forums. > > I disagree violently. The case for the forums is clear; users pr

Re: wine users forum registration issue

2008-10-22 Thread Jeremy White
> Right. So the forum software is broken, and all of the Wine devs would rather > fix Wine than the forums? Sounds like a good case for ditching the forums. I disagree violently. The case for the forums is clear; users prefer them by a rather large amount. If we're going to provide user facing

Re: [PATCH 1/3] ole32: Create the '\1Ole' stream.

2008-10-22 Thread Rob Shearman
2008/10/21 Huw Davies <[EMAIL PROTECTED]>: > +/*** > + * init_ole_stream > + * > + * Creates the '\1Ole' stream. > + * The format of this stream is as follows: > + * > + * DWORD Version == 0x0201 > + * DWORD Flags - high bit

Re: [PATCH 3/3] ole32: Call the appropriate storage function when we run the object.

2008-10-22 Thread Rob Shearman
2008/10/21 Huw Davies <[EMAIL PROTECTED]>: > @@ -1728,6 +1767,10 @@ static HRESULT WINAPI > DefaultHandler_IPersistStorage_HandsOffStorage( > if(SUCCEEDED(hr) && object_is_running(This)) > hr = IPersistStorage_HandsOffStorage(This->pPSDelegate); > > +old_stg = InterlockedExchange

QueryDosDevice

2008-10-22 Thread Tomasz Salacinski
Hello, I was trying to find a solution for bug 5351 and I've found it. When user is trying to install Visual Studio he gets a message: Unable to find a volume for file extraction. Please verify that you have proper permissions. The problem is, that when vcssetup.exe is running, it is using func

Re: cryptui: Add a partial implementation of CryptUIWizImport.

2008-10-22 Thread Hans Leidekker
On Wednesday 22 October 2008 10:47:25 Marcus Meissner wrote: > > It's a stub of course, so it doesn't always do the right thing. We have > > many of these in Wine, and that's OK as long as you are warned about the > > shortcomings. > > > > If I'm right about typical usage of this function it will

Re: RFC: Implement XML loading in msxml3 directly from IStream

2008-10-22 Thread Michael Karcher
Am Freitag, den 17.10.2008, 00:46 +0200 schrieb Michael Karcher: > If libxml2 is new enough, it is possible to parse directly from the > stream using xmlReadIO to avoid copying the whole stream contents to > memory. Testing native, it looks like this is the right approach. Piotr Caban asked me whet

Re: advapi32: Fall back to /dev/random if /dev/urandom can't be opened, and add warnings if opening either fails (try 2)

2008-10-22 Thread Alexandre Julliard
"Juan Lang" <[EMAIL PROTECTED]> writes: > Changed a WARN to a FIXME. Any other suggestions? I don't see the point. Is there really a platform that has /dev/random but not /dev/urandom, and a /dev/random that is guaranteed not to block? -- Alexandre Julliard [EMAIL PROTECTED]

Re: shell32: try to guess the working directory in the run dialog

2008-10-22 Thread Francois Gouget
On Tue, 21 Oct 2008, Vincent Povirk wrote: > Yep. > > It's still broken though; the string I allocated is too small (strlen > excludes the null terminator), and that will be a problem if cmdline > ends in a backslash. Also it would be nice to avoid the HEAP_ZERO_MEMORY if we are going to overwr

Re: configure: Require at least version 1.6 of gnutls.

2008-10-22 Thread Francois Gouget
On Tue, 21 Oct 2008, James Mckenzie wrote: > Henri Verbeet <[EMAIL PROTECTED]> at Oct 21, 2008 10:04 AM wrote about > configure: Require at least version 1.6 of gnutls. > > Why are we looking to use gnutls 1.6? Is there a feature that is > needed for Wine? If so, I will have to check Fink befo

Re: cryptui: Add a partial implementation of CryptUIWizImport.

2008-10-22 Thread Marcus Meissner
On Wed, Oct 22, 2008 at 10:41:00AM +0200, Hans Leidekker wrote: > On Tuesday 21 October 2008 19:06:20 Juan Lang wrote: > > > But you don't check whether those conditions are true, and you march > > ahead and install the certificate into the root store whether or not > > they are true. I'm sorry,

Re: cryptui: Add a partial implementation of CryptUIWizImport.

2008-10-22 Thread Hans Leidekker
On Tuesday 21 October 2008 19:06:20 Juan Lang wrote: > But you don't check whether those conditions are true, and you march > ahead and install the certificate into the root store whether or not > they are true. I'm sorry, but the code is just not correct. Please > write some test cases. It's a

Re: wine users forum registration issue

2008-10-22 Thread Kai Blin
On Tuesday 21 October 2008 18:25:19 Andreas Mohr wrote: > > This is now about the 30th time (no, REALLY, this __IS__ the 30th time, > or possibly even 50th!) that someone has severe issues with WineHQ > forum registration, in the last 12 or so months. > Could someone _please_ finally do something

Re: wine users forum registration issue

2008-10-22 Thread Andreas Mohr
Hi, On Tue, Oct 21, 2008 at 11:37:22AM -0400, [EMAIL PROTECTED] wrote: > Hi-- > > I'm a new user of linux and wine and was looking for some help with a > database program that ALMOST runs. I found an entry on the forum with a > problem > similar to mine and wanted to comment, so I decided t