Re: cryptui: Add a partial implementation of CryptUIWizImport.

2008-10-20 Thread Hans Leidekker
On Monday 20 October 2008 23:21:44 Juan Lang wrote: > You haven't convinced me that Windows does indeed import the > certificate to the root store in all cases. Making the root store I don't think I said that. I put a fixme in the code that explicitly warns that the store should be determined dy

Re: [PATCH 11/12] LookupAccountNameW() - refactor to eliminate code duplication

2008-10-20 Thread Kai Blin
On Tuesday 21 October 2008 01:06:45 Paul Bryan Roberts wrote: > -FIXME("%s %s %p %p %p %p %p - stub\n", debugstr_w(lpSystemName), > debugstr_w(lpAccountName), > +TRACE("%s %s %p %p %p %p %p - stub\n", debugstr_w(lpSystemName), > debugstr_w(lpAccountName), >Sid, cbSid, Referenc

Re: [PATCH 07/12] LookupAccountNameW() - NULL account name handled

2008-10-20 Thread Kai Blin
On Tuesday 21 October 2008 01:05:34 Paul Bryan Roberts wrote: Hi Paul, I'm glad to see someone tackle this. One minor thing I have with this patch.. > +ok(sid_use == SidTypeDomain, "Expected SidTypeDomain, got %d\n", > SidTypeDomain); seems like this should be ok(sid_use == SidTypeDomain

Re: latest GIT

2008-10-20 Thread Austin English
On Mon, Oct 20, 2008 at 10:37 PM, chris ahrendt <[EMAIL PROTECTED]> wrote: > Austin English wrote: >> On Sun, Oct 19, 2008 at 9:15 PM, chris ahrendt <[EMAIL PROTECTED]> wrote: >> >>> Anyone else having a problem compiling the latest git? >>> >>> mine has failed 2 times when I compile... one with a

Re: Wine PulseAudio Driver

2008-10-20 Thread Arthur Taylor
Hello. I have updated the testing pulseaudio waveout patch for http://bugs.winehq.org/show_bug.cgi?id=10495 The patch has been split in two. The first adds a stub driver that just creates waveout devices based upon pulseaudio sinks and adds checks for pulseaudio to configure.ac. The second patch ad

Re: latest GIT

2008-10-20 Thread chris ahrendt
Austin English wrote: > On Sun, Oct 19, 2008 at 9:15 PM, chris ahrendt <[EMAIL PROTECTED]> wrote: > >> Anyone else having a problem compiling the latest git? >> >> mine has failed 2 times when I compile... one with a clean tree and one >> with an older tree.. >> >> chris >> >> >> >>

Re: DOS game support - just needs a little VGA love?

2008-10-20 Thread Peter Dons Tychsen
Don't forget the .com files those wonderful real-mode 64K wonders... I noticed that the distros do not map .com files to wine. They probably should. /p On Mon, 2008-10-20 at 16:18 -0700, Dan Kegel wrote: > Jochen wrote: > >> I would love to see support for games like "paratrooper" and > >> "

Re: DOS game support - just needs a little VGA love?

2008-10-20 Thread Chris Robinson
On Monday 20 October 2008 02:14:41 pm Jochen Theodorou wrote: > don't they work in DOS-Box? I know Daggerfall doesn't work all that great in DOSBox (it's a heavy effort in tweaking to get the videos to play at the right speed, and that usually causes the game to play like crap, and vice-versa..)

Re: DOS game support - just needs a little VGA love?

2008-10-20 Thread Dan Kegel
Jochen wrote: >> I would love to see support for games like "paratrooper" and >> "police quest". > > don't they work in DOS-Box? We would like to get to the point where users don't have to wonder which tool to use to run .exe's with. i.e. it would be nice if we could just map .exe's to Wine in the

Re: mshtml: Implement IHTMLStyle get/put posLeft (Try 7)

2008-10-20 Thread Jacek Caban
Jacek Caban wrote: > for(ptr=ret; isdigitW(*ptr); ptr++); > if(*ptr || strcmp(ptr, pxW)) { > .. && .. of course... Jacek

Re: mshtml: Implement IHTMLStyle get/put posLeft (Try 7)

2008-10-20 Thread Jacek Caban
Alistair Leslie-Hughes wrote: > Hi, > Clean up the get function. > Make sure we round down the value passed in. > Corrected test to prove above. > > Changelog: > mshtml: Implement IHTMLStyle get/put posLeft > + +V_VT(&v) = VT_I4; +V_I4(&v) = floor(f); + +if(VariantChangeType(&

Re: winedos interrupts getting lost.

2008-10-20 Thread Peter Dons Tychsen
Hello Markus. I think this is exactly what is going wrong. It fits the description of what i am seeing. The kernel man-pages even go so far as to state: "The effects of this call in a multi-threaded process are unspecified." http://linux.die.net/man/2/signal So i guess using signal() inside wine

Re: cryptui: Add a partial implementation of CryptUIWizImport.

2008-10-20 Thread Juan Lang
> It may not persist but I could import the certificate fine on Wine. > Is there an alternative for the root store? What's involved in making > the root store read-write? You haven't convinced me that Windows does indeed import the certificate to the root store in all cases. Making the root store

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-20 Thread Michael Karcher
Am Montag, den 20.10.2008, 19:04 +0400 schrieb Vitaly Perov: > >I suspect (but I am definitely not an expert in this area), that the > >patch Vitaly Perov sent: > > > >| +/* move many files into directory with FOF_MULTIDESTFILES */ > >| +set_curr_dir_path(from, "test?.txt\0"); > >| +se

Re: DOS game support - just needs a little VGA love?

2008-10-20 Thread Jochen Theodorou
Peter Dons Tychsen schrieb: [...] > I would love to see support for games like "paratrooper" and "police > quest". don't they work in DOS-Box? bye Jochen

Re: cryptui: Add a partial implementation of CryptUIWizImport.

2008-10-20 Thread Hans Leidekker
On Monday 20 October 2008 23:06:35 Juan Lang wrote: > > It persists in Windows, yes. Haven't tested Wine, where do you see a crash? > > In crypt32. I wrote a quick test program that does what your patch > does, and it crashes adding the certificate to the root store. I'll > send a patch shortly

Re: cryptui: Add a partial implementation of CryptUIWizImport.

2008-10-20 Thread Juan Lang
> It persists in Windows, yes. Haven't tested Wine, where do you see a crash? In crypt32. I wrote a quick test program that does what your patch does, and it crashes adding the certificate to the root store. I'll send a patch shortly that'll avoid the crash. Nevertheless, this won't do what you

Re: cryptui: Add a partial implementation of CryptUIWizImport.

2008-10-20 Thread Hans Leidekker
On Monday 20 October 2008 22:51:15 Juan Lang wrote: > > It's my limited manual testing with a self-signed root CA certificate > > that turned this up on Windows. The certificate is still there after > > Outook is closed. > > In Windows? Sure. In Wine? I can't see how that would be the case. >

Re: cryptui: Add a partial implementation of CryptUIWizImport.

2008-10-20 Thread Juan Lang
> It's my limited manual testing with a self-signed root CA certificate > that turned this up on Windows. The certificate is still there after > Outook is closed. In Windows? Sure. In Wine? I can't see how that would be the case. (In fact it turns up a crash here for me.) --Juan

Re: cryptui: Add a partial implementation of CryptUIWizImport.

2008-10-20 Thread Hans Leidekker
On Monday 20 October 2008 21:48:37 Juan Lang wrote: > +/* FIXME: verify certificate and determine store name dynamically */ > +if (!(store = CertOpenStore(CERT_STORE_PROV_SYSTEM_W, 0, 0, > CERT_SYSTEM_STORE_CURRENT_USER, Root))) > +{ > +WARN("unable to open certificate store\n"

Re: cryptui: Add a partial implementation of CryptUIWizImport.

2008-10-20 Thread Juan Lang
Hi Hans, I know this patch already got committed. +BOOL WINAPI CryptUIWizImport(DWORD dwFlags, HWND hwndParent, LPCWSTR pwszWizardTitle, + PCCRYPTUI_WIZ_IMPORT_SRC_INFO pImportSrc, HCERTSTORE hDestCertStore) +{ +static const WCHAR Root[] = {'R','o','o','t',0}; (sni

Re: [PATCH 16/16] tools/wine.inf: Quote the winebrowser executable in the shell open command.

2008-10-20 Thread Alexandre Julliard
"James Hawkins" <[EMAIL PROTECTED]> writes: > Even if it is editable, I don't see what the problem is with making > this the default value. Susan Craig has already run into this problem > with the DNS 10 installer, which uses the AppSearch action to search > for IE using this value. I don't know

Re: [Fwd: mpr: fix NULL pointer dereference in WNetGetResourceInformationW]

2008-10-20 Thread James Mckenzie
Andrey Turkin <[EMAIL PROTECTED]> on Oct 20, 2008 1:02 AM wrote about Re: [Fwd: mpr: fix NULL pointer dereference in WNetGetResourceInformationW] > >2008/10/20 James McKenzie <[EMAIL PROTECTED]> > >> Was this ever processed through Patchwatcher? >> >> James McKenzie >> >> Original Message

Re: [RFC] jscript: Fix shift/reduce conflict by removing redundant FunctionDeclaration rule.

2008-10-20 Thread Jacek Caban
Rob Shearman wrote: > > I've looked at the spec and I see that it has a nice "lookahead not a > member of '{, function'" in the rule for ExpressionStatement, meaning > that the grammar cannot be implemented unambiguously by a LALR(1) > parser-generator like bison. :-( > > I've found on MS blog

Re: [PATCH 16/16] tools/wine.inf: Quote the winebrowser executable in the shell open command.

2008-10-20 Thread James Hawkins
On Mon, Oct 20, 2008 at 12:19 PM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > "James Hawkins" <[EMAIL PROTECTED]> writes: > >> The value is quoted in Windows; what's the harm in matching that? The >> test in question was added to fix an installer (can't remember which >> one now), and the rece

Re: today build's broken for me

2008-10-20 Thread Henri Verbeet
2008/10/20 Lei Zhang <[EMAIL PROTECTED]>: >> I'm using libgnutls-dev 1.4.4-3 from etch. > > It looks like you need libgnutls-dev 2.x to compile schannel.c as is. > That function was introduced in 1.5.4, apparently. You can of course also configure with "--without-gnutls" to avoid building that code

Re: [PATCH 16/16] tools/wine.inf: Quote the winebrowser executable in the shell open command.

2008-10-20 Thread Alexandre Julliard
"James Hawkins" <[EMAIL PROTECTED]> writes: > The value is quoted in Windows; what's the harm in matching that? The > test in question was added to fix an installer (can't remember which > one now), and the recently added tests now show that msi is correct, > while the current value of the comman

Re: today build's broken for me

2008-10-20 Thread Lei Zhang
On Mon, Oct 20, 2008 at 6:44 AM, Nikolay Sivov <[EMAIL PROTECTED]> wrote: > make[2]: Entering directory `/home/mrlarch/wine/dlls/secur32' > gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT > -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement > -Wwrite-

Re: Today's git won't install DNS10 - IE not found

2008-10-20 Thread James Hawkins
On Mon, Oct 20, 2008 at 10:17 AM, Susan Cragin <[EMAIL PROTECTED]> wrote: > I have been installing Dragon NaturallySpeaking 10 without using winetricks > fakie6. > For weeks, until today, that has worked. > Today nothing works, including winetricks fakeie6. > Here is the entire setup terminal outp

Re: [PATCH 16/16] tools/wine.inf: Quote the winebrowser executable in the shell open command.

2008-10-20 Thread James Hawkins
On Mon, Oct 20, 2008 at 6:25 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > "James Hawkins" <[EMAIL PROTECTED]> writes: > >> diff --git a/tools/wine.inf.in b/tools/wine.inf.in >> index 4756d7d..bc1b1d6 100644 >> --- a/tools/wine.inf.in >> +++ b/tools/wine.inf.in >> @@ -128,7 +128,7 @@ HKCR,fol

Today's git won't install DNS10 - IE not found

2008-10-20 Thread Susan Cragin
I have been installing Dragon NaturallySpeaking 10 without using winetricks fakie6. For weeks, until today, that has worked. Today nothing works, including winetricks fakeie6. Here is the entire setup terminal output with fakeie6 installed. wine-1.1.6-379-g07badc7 fixme:advapi:LookupAccountName

Today's git won't install DNS10 - IE not found

2008-10-20 Thread Susan Cragin
I have been installing Dragon NaturallySpeaking 10 without using winetricks fakie6. For weeks, until today, that has worked. Today nothing works, including winetricks fakeie6. Here is the entire setup terminal output with fakeie6 installed. The popup messages says that IE 5 or greater is needed.

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-20 Thread Vitaly Perov
>Vitaly claims he gets no feedback for his patches.  He knows full well >that I give him plenty of feedback.  I explained to him what was wrong >with his test SHFileOperation patches, yet he repeatedly sent the same >patch to the list.  I'm not going to repeat the same comment over and >over again.

Re: wintrust: Implement CryptCATAdminCalcHashFromFileHandle

2008-10-20 Thread Juan Lang
Hi Maarten, +if (pbHash && *pcbHash < 20) +{ +SetLastError(ERROR_INSUFFICIENT_BUFFER); +return FALSE; +} That's not correct, *pcbHash must be set to 20 if it's too small. +while (ReadFile(hFile, tempbuffer, TEMP_BLOCK_SIZE, &readbytes, NULL) && readbytes) +

Re: latest GIT

2008-10-20 Thread chris ahrendt
Austin English wrote: > On Sun, Oct 19, 2008 at 9:15 PM, chris ahrendt <[EMAIL PROTECTED]> wrote: > >> Anyone else having a problem compiling the latest git? >> >> mine has failed 2 times when I compile... one with a clean tree and one >> with an older tree.. >> >> chris >> >> >> >>

today build's broken for me

2008-10-20 Thread Nikolay Sivov
make[2]: Entering directory `/home/mrlarch/wine/dlls/secur32' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o schannel.o schannel.c schannel.c:61: error: ‘g

Re: DOS game support - just needs a little VGA love?

2008-10-20 Thread Peter Dons Tychsen
On Sun, 2008-10-19 at 20:56 -0700, Dan Kegel wrote: > Hey, that CGA video support patch today from Peter Dons Tychsen, > http://winehq.org/pipermail/wine-patches/2008-October/063417.html > reminded me there's an old downloadable DOS game my wife likes > to dig out every now and then. I tried it to

RE: DOS game support - just needs a little VGA love?

2008-10-20 Thread Michael Karcher
Am Montag, den 20.10.2008, 12:36 +0200 schrieb Stefan Dösinger: > Dosemu (not dosbox) works nice here on my 64 bit linux distro. How are they > doing that? Afaics dosemu uses vm86 instead of a full-blown CPU emulation. Dosemu has a hybrid approach. On x86, vm86 is used. On systems lacking vm86 (tha

Re: dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

2008-10-20 Thread Joris Huizer
--- On Sun, 10/19/08, Rob Shearman <[EMAIL PROTECTED]> wrote: > > The information is added at commit time so it won't > make any > difference if you just run "git format-patch" > after configuring the > above settings, it matters what the settings were when you > committed. > > If you haven't com

Re: [PATCH 16/16] tools/wine.inf: Quote the winebrowser executable in the shell open command.

2008-10-20 Thread Alexandre Julliard
"James Hawkins" <[EMAIL PROTECTED]> writes: > diff --git a/tools/wine.inf.in b/tools/wine.inf.in > index 4756d7d..bc1b1d6 100644 > --- a/tools/wine.inf.in > +++ b/tools/wine.inf.in > @@ -128,7 +128,7 @@ HKCR,folder\shell\open\ddeexec,,2,"[ViewFolder("%l", %I, > %S)]" > HKCR,folder\shell\open\dde

RE: DOS game support - just needs a little VGA love?

2008-10-20 Thread Stefan Dösinger
> Perhaps support for more VGA features can increase compatibility of DOS > software on 32-bit hardware. 64-bit users won't be able to run most dos > programs as there is no vm86 support when using a 64-bit kernel. In the > end we need x86 emulation.. Dosemu (not dosbox) works nice here on my 64 bi

Re: shlwapi/tests: Make the shlwapi tests load on systems < Vista by provid

2008-10-20 Thread Nicolas Le Cam
Hi Paul, I've just seen that. Please ignore my patch. I've followed the same 'trick' that has been used in other tests but I also think Detlef's approach is better. Thanks for your feedback, Nicolas Le Cam 2008/10/20 Paul Vriens <[EMAIL PROTECTED]>: > Nicolas Le Cam wrote: >> >> Regards, >> Nico

Re: shlwapi/tests: Make the shlwapi tests load on systems < Vista by provid

2008-10-20 Thread Paul Vriens
Nicolas Le Cam wrote: > Regards, > Nicolas Le Cam > > > > > Hi Nicolas, Detlef already sent a patch for this: http://www.winehq.org/pipermail/wine-patches/2008-October/063319.html I think his approach is better as W-cal

Re: shlwapi/tests: Make the shlwapi tests load on systems < Vista by provid

2008-10-20 Thread Nicolas Le Cam
Sorry again, didn't see Detlef has already sent a fix to this one [1]. Please ignore. Regards, Nicolas Le Cam [1] http://www.winehq.org/pipermail/wine-patches/2008-October/063319.html 2008/10/20 Nicolas Le Cam <[EMAIL PROTECTED]>: > Sorry for the truncated object, certainly a copy/paste error. >

Re: shlwapi/tests: Make the shlwapi tests load on systems < Vista by provid

2008-10-20 Thread Nicolas Le Cam
Sorry for the truncated object, certainly a copy/paste error. It should be: "Make the shlwapi tests load on systems < Vista by providing a private implementation of RegDeleteTreeW." Regards, Nicolas Le Cam

Re: DOS game support - just needs a little VGA love?

2008-10-20 Thread Roderick Colenbrander
Hi, Perhaps support for more VGA features can increase compatibility of DOS software on 32-bit hardware. 64-bit users won't be able to run most dos programs as there is no vm86 support when using a 64-bit kernel. In the end we need x86 emulation.. Roderick > Hey, that CGA video support patch

Re: [Fwd: mpr: fix NULL pointer dereference in WNetGetResourceInformationW]

2008-10-20 Thread Andrey Turkin
Yes, the mail is at http://kegel.com/wine/patchwatcher/results/3193.txt and log is at http://kegel.com/wine/patchwatcher/results/3193.log . Why, was there any problems with this patch? Regards, Andrey 2008/10/20 James McKenzie <[EMAIL PROTECTED]> > Was this ever processed through Patchwatcher?

Re: winedos interrupts getting lost.

2008-10-20 Thread Markus Amsler
Peter Dons Tychsen wrote: > Hello. > > It starting with me trying to figure out why i was loosing keyboard > events in winedos. > > 1) I then traced the keyboard events to a call to signal(SIGUSR2) in > function DOSVM_QueueEvent(). > > 2) The signal() triggers code in ntdll, which generates an e