Re: msi: quiet a noisy err

2008-10-18 Thread James Hawkins
On Sat, Oct 18, 2008 at 9:37 PM, Austin English <[EMAIL PROTECTED]> wrote: > -- Please don't commit this patch. The err is there for a reason. Each time this is output, it's a different insertion that fails. -- James Hawkins

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread Michael Karcher
Am Samstag, den 18.10.2008, 22:18 + schrieb Louis. Lenders: > Spent loads of time for more than 3 years trying to help triaging bugs > and helping out in appdb, only to find out that all my patches are > ignored silently Sorry, what do you mean by *all* of your patches? This is from the win

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread James Hawkins
On Sat, Oct 18, 2008 at 5:18 PM, Louis. Lenders <[EMAIL PROTECTED]> wrote: > > >>Thank you for your answer. > >>I agree, that before sending a patch I should write a test first. >>But the problem is that even a tests are ignored without any explanation. >>Maybe my tests aren't good, but why anybody

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread Louis. Lenders
>Thank you for your answer. >I agree, that before sending a patch I should write a test first. >But the problem is that even a tests are ignored without any explanation. >Maybe my tests aren't good, but why anybody just tell what's wrong. Seems to be common habit on this list. I hope you're n

Re: Which graphics cards really pass the conformance tests, again?

2008-10-18 Thread Henri Verbeet
2008/10/18 Dan Kegel <[EMAIL PROTECTED]>: > When I put together the current patchwatcher box, I made > sure to get a graphics card based on a recent nvidia chip. > http://www2.pny.com/8500-GT-512MB-PCIe-P2322C269.aspx > seemed recent enough, but I still get buttloads of > conformance test failures

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread James Hawkins
On Sat, Oct 18, 2008 at 7:47 AM, Vitaly Perov <[EMAIL PROTECTED]> wrote: > >> You never mentioned a specific program, so I still don't know if this >> is a real world bug you're running into. Either way, your logic is >> flawed, as fileOp.pTo is a single directory in this case, so using >> FOF_MUL

Re: Which graphics cards really pass the conformance tests, again?

2008-10-18 Thread Alasdair Sinclair
Dan Kegel wrote: > When I put together the current patchwatcher box, I made > sure to get a graphics card based on a recent nvidia chip. > http://www2.pny.com/8500-GT-512MB-PCIe-P2322C269.aspx > seemed recent enough, but I still get buttloads of > conformance test failures in d3d and ddraw. > > So,

Which graphics cards really pass the conformance tests, again?

2008-10-18 Thread Dan Kegel
When I put together the current patchwatcher box, I made sure to get a graphics card based on a recent nvidia chip. http://www2.pny.com/8500-GT-512MB-PCIe-P2322C269.aspx seemed recent enough, but I still get buttloads of conformance test failures in d3d and ddraw. So, which graphics cards exactly

Re: wined3d: Add one more FBO error status code

2008-10-18 Thread Henri Verbeet
2008/10/18 Vitaliy Margolen <[EMAIL PROTECTED]>: > Oh, Alexandre working overtime? > > These messages are from STALKER Clear Sky. But I suspect there is more to > it. Like more driver bugs. I'm seeing major graphics corruptions, black > screen and eventual system crash. > It probably tries to use

Re: wined3d: Add one more FBO error status code

2008-10-18 Thread Vitaliy Margolen
Henri Verbeet wrote: > 2008/10/18 Vitaliy Margolen <[EMAIL PROTECTED]>: >> Without that I'm getting messages like this: >> >> fixme:d3d:context_check_fbo_status FBO status Unrecognied FBO status >> 0x8d56 >> fixme:d3d:context_check_fbo_status Color attachment 0: (0x5e44590) >> WINED3DFMT_

Re: wined3d: Add one more FBO error status code

2008-10-18 Thread Vitaliy Margolen
Henri Verbeet wrote: > 2008/10/18 Vitaliy Margolen <[EMAIL PROTECTED]>: >> Meaning? You don't like the place where I put it into wined3d_gl.h? I can >> change that to numerical order: >> > You should add support for GL_EXT_framebuffer_multisample if you want > to use that constant. It shouldn't be

Re: wined3d: Add one more FBO error status code

2008-10-18 Thread Henri Verbeet
2008/10/18 Vitaliy Margolen <[EMAIL PROTECTED]>: > > Without that I'm getting messages like this: > > fixme:d3d:context_check_fbo_status FBO status Unrecognied FBO status > 0x8d56 > fixme:d3d:context_check_fbo_status Color attachment 0: (0x5e44590) > WINED3DFMT_X8R8G8B8 1024x768 > fixme:d

Re: wined3d: Add one more FBO error status code

2008-10-18 Thread Henri Verbeet
2008/10/18 Vitaliy Margolen <[EMAIL PROTECTED]>: > Meaning? You don't like the place where I put it into wined3d_gl.h? I can > change that to numerical order: > You should add support for GL_EXT_framebuffer_multisample if you want to use that constant. It shouldn't be much work, the extension only

Re: wined3d: Add one more FBO error status code

2008-10-18 Thread Vitaliy Margolen
Henri Verbeet wrote: > 2008/10/18 Vitaliy Margolen <[EMAIL PROTECTED]>: >> diff --git a/include/wine/wined3d_gl.h b/include/wine/wined3d_gl.h >> index 5e55a0d..b26ab78 100644 >> --- a/include/wine/wined3d_gl.h >> +++ b/include/wine/wined3d_gl.h >> @@ -1819,6 +1819,7 @@ typedef void (WINE_GLAPI * PG

Re: wpp: Check for overflows when parsing integer constants.

2008-10-18 Thread Alexandre Julliard
"Rob Shearman" <[EMAIL PROTECTED]> writes: > diff --git a/libs/wpp/ppl.l b/libs/wpp/ppl.l > index 3e84a2e..829ac35 100644 > --- a/libs/wpp/ppl.l > +++ b/libs/wpp/ppl.l > @@ -163,6 +163,9 @@ ul > [uUlL]|[uUlL][lL]|[lL][uU]|[lL][lL][uU]|[uU][lL][lL]|[lL][uU][lL] > #include > #include >

Re: wined3d: Add one more FBO error status code

2008-10-18 Thread Henri Verbeet
2008/10/18 Vitaliy Margolen <[EMAIL PROTECTED]>: > diff --git a/include/wine/wined3d_gl.h b/include/wine/wined3d_gl.h > index 5e55a0d..b26ab78 100644 > --- a/include/wine/wined3d_gl.h > +++ b/include/wine/wined3d_gl.h > @@ -1819,6 +1819,7 @@ typedef void (WINE_GLAPI * PGLFNGLVERTEXBLENDARB) > (GLi

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread Vitaly Perov
Thank you for your answer. I agree, that before sending a patch I should write a test first. But the problem is that even a tests are ignored without any explanation. Maybe my tests aren't good, but why anybody just tell what's wrong. Maybe a'm not enough persistent? > Have you tried asking on th

Re: gdi32: Add job name field into CreateSpoolFile (try2)

2008-10-18 Thread Michael Karcher
Am Samstag, den 18.10.2008, 15:58 +0400 schrieb Konstantin Kondratyuk: > Try 2: add quotes in parameter: -T'%s' That's the right way to go, but are you sure that pszTitle does not contain single quotes itself? If not, you have to escape them (for the shell, it should be "\" -> "'\''") or to replace

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread Reece Dunn
2008/10/18 Vitaly Perov <[EMAIL PROTECTED]>: > The program is Garant 7 F1 (Russian legal system database). I don't think you > know this program. > It is not a real world bug, but there are some significant bugs in > SHFileOperationW. I don't think a lot of programs use SHFileOperationW to > move a

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread Vitaly Perov
> You never mentioned a specific program, so I still don't know if this > is a real world bug you're running into. Either way, your logic is > flawed, as fileOp.pTo is a single directory in this case, so using > FOF_MULTIDESTFILES is wrong. MSDN: FOF_MULTIDESTFILES The pTo member specifies m

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread James Hawkins
On Sat, Oct 18, 2008 at 5:48 AM, Vitaly Perov <[EMAIL PROTECTED]> wrote: >>We've been over this before. This needs a test case. Either way, >>this doesn't look right. What are you trying to fix? > > Some program call SHFileOperationW to move one folder to another without > FOF_MULTIDESTFILES. Th

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory

2008-10-18 Thread Vitaly Perov
>We've been over this before.  This needs a test case.  Either way, >this doesn't look right.  What are you trying to fix? Some program call SHFileOperationW to move one folder to another without FOF_MULTIDESTFILES. The source folder contain subfolders, so SHFileOperationW is called recursively.

Re: [PATCH] include: fixed the tom constant values.

2008-10-18 Thread Rob Shearman
2008/10/17 Reece Dunn <[EMAIL PROTECTED]>: > The hexadecimal constants should be 8 characters long, not 9. Found by > building the include project (via msvcmaker) with VC9. Good catch. I'll fix widl and our other parsers to check for these kinds of overflows. -- Rob Shearman