Hi Detlef,
-if (dwLenOut >= MAX_PATH)
+if (dwLenOut >= MAX_PATH) {
lpszReturnW = HeapAlloc(GetProcessHeap(), 0,
(dwLenOut + 1) * sizeof(WCHAR));
+}
This first set of parentheses seems like an unnecessary addition..
+else
+{
+
Hello developers,
the current implementation of IPersistStream::Load for XMLDOMDocument
takes a copy of the given stream into a hglobal stream, and uses a
helper function to parse that, namely parse_xml that calls xmlReadMemory
if available (since 2.6.0) and uses the old xmlParseMemory call
otherw
> "Stefan Reimer" <[EMAIL PROTECTED]> writes:
>
>> compiling binaries with the LARGE_ADDRESS_AWARE flag set is not enough
>> to
>> be able to use more than 2GB user space.
>> To behave like WindowsXP booted with the /3GB option, at least the
>> lpMaximumApplicationAddress in GetSystemInfo has to be
> I think HeapAlloc will already set the last
> error correctly, so I don't have to worry about that.
It doesn't.
> It might be better to just wrap it in an 'else { ... }' to be more specific
> about this.
Yeah, an else block would be clearer to me, but I didn't want to
dictate style ;-)
Thanks
Juan Lang schreef:
> Hi Maarten,
>
> overall this patch looks pretty good. A few minor comments:
>
> +tempbuffer = HeapAlloc(GetProcessHeap(), 0, TEMP_BLOCK_SIZE);
> +if (!tempbuffer)
> +goto out;
>
> You return TRUE in this case. You probably ought to set last error
>
> +SetLastError(ERROR_INSUFFICIENT_BUFFER);
> return TRUE;
>
> Why are you setting ERROR_INSUFFICIENT_BUFFER in the success case?
Oops, just read the patch more closely. Please ignore this comment, I
obviously missed the return statement above it.
--Juan
Hi Maarten,
overall this patch looks pretty good. A few minor comments:
+tempbuffer = HeapAlloc(GetProcessHeap(), 0, TEMP_BLOCK_SIZE);
+if (!tempbuffer)
+goto out;
You return TRUE in this case. You probably ought to set last error
and return FALSE instead.
+
Hi Vincent,
Vincent Povirk schreef:
> The patch you sent doesn't match the subject line.
>
Thanks for catching that, I sent the wrong patch by accident. The
attached patch was never meant to be sent in because I knew aj wasn't
going to accept it. I'll resend the patch tomorrow.
Cheers,
Maart
"Stefan Reimer" <[EMAIL PROTECTED]> writes:
> compiling binaries with the LARGE_ADDRESS_AWARE flag set is not enough to
> be able to use more than 2GB user space.
> To behave like WindowsXP booted with the /3GB option, at least the
> lpMaximumApplicationAddress in GetSystemInfo has to be changed t
Am Donnerstag, den 16.10.2008, 15:42 -0500 schrieb Jacek Caban:
> > So, I doubt this patch is correct.
> This patch fixes regression in Photoshop CS4 installer caused by your
> patch. The double free is exactly what happened with your patch and my
> patch fixes it. The new root has to be removed
Michael Karcher wrote:
> Am Donnerstag, den 16.10.2008, 13:55 -0500 schrieb Jacek Caban:
> @@ -932,9 +933,17 @@ static HRESULT WINAPI domdoc_put_documentElement(
> return hr;
>
> xmlNode = impl_from_IXMLDOMNode( elementNode );
> -xmlDocSetRootElement( get_doc(This), xmlNode->nod
Am Donnerstag, den 16.10.2008, 13:55 -0500 schrieb Jacek Caban:
@@ -932,9 +933,17 @@ static HRESULT WINAPI domdoc_put_documentElement(
return hr;
xmlNode = impl_from_IXMLDOMNode( elementNode );
-xmlDocSetRootElement( get_doc(This), xmlNode->node);
+
+if(!xmlNode->node->paren
On Tue, Oct 14, 2008 at 5:11 PM, Joris Huizer <[EMAIL PROTECTED]> wrote:
> When pszExtra is unequal to zero, set pszExtraFromReg to zero as it'll get
> free'd later on;
>
> (Another way would be to set the variable to NULL explicitly if it's
> desirable to make this case very explicit)
>
>
>
>
>
On Wed, Oct 15, 2008 at 04:50:30PM -0500, Jacek Caban wrote:
> Alexandre Julliard wrote:
> >I'd suggest to take advantage of the variant union instead of copying
> >all these glibc definitions. Something like
> >
> >#ifdef NAN
> >V_R8(&vt) = NAN;
> >#else
> >V_I8(&vt) = nan_magic_pattern;
>
Rob Shearman wrote:
> Jacek, are you OK with deviating from the specification like this?
>
Sure, I was thinking about something like this when I was writing the
parser, but I decided that it's better to stick with documentation then
to get something working. Now that we have tests and we may
Hi,
Please use a consistent indenting style. Use the same one as used by the rest
of the code and make sure not to mix up spaces and tabs.
Roderick
> Michael / All
>
> here is the third go at the ddraw test... and the patch for that...
>
> note I went ahead and used the goto.
>
> Also I foun
Hi,
compiling binaries with the LARGE_ADDRESS_AWARE flag set is not enough to
be able to use more than 2GB user space.
To behave like WindowsXP booted with the /3GB option, at least the
lpMaximumApplicationAddress in GetSystemInfo has to be changed to
0xBFFE and the virtual user space has to be
Am Donnerstag, den 16.10.2008, 18:34 +0400 schrieb Nikolay Sivov:
> It isn't obvious (your patch fot ret value). Why are you hiding all
> codes except E_FAIL?
You seem to misread that patch. All it does is return E_FAIL instead of
S_OK in the case of a short read. For clarity, the conditional stat
>It isn't obvious (your patch fot ret value). Why are you hiding all
>codes except E_FAIL? Tests are needed, but I think you're hiding
>something by this change.
Please, clarify, what patch are you trying to blame:
(1) [2/3] oleaut32: return correct error code.
or
(2) gdiplus: IPicture_SaveAsFile
Sorry, commited patch seems to be right. Still it's better to use
hr!=S_OK instead of hr itself I think..
On 10/16/08, Nikolay Sivov <[EMAIL PROTECTED]> wrote:
> It isn't obvious (your patch fot ret value). Why are you hiding all
> codes except E_FAIL? Tests are needed, but I think you're hiding
>
It isn't obvious (your patch fot ret value). Why are you hiding all
codes except E_FAIL? Tests are needed, but I think you're hiding
something by this change.
On 10/16/08, Kirill K. Smirnov <[EMAIL PROTECTED]> wrote:
> This patch fixes gdiplus test failures revealed by patch:
> [2/3] oleaut32: ret
Today's git ads a significant functionality to Dragon NaturallySpeaking 10.
After the program loads, there are a couple of options. One of them is to scan
the Documents files for wordprocessing documents, and add them to its grammar
model. I have always selected that option, but until today the c
Francois Gouget wrote:
> I'm glad you're happy with CodeWeavers' work :-) CodeWeavers got a real
> demand to get Wine working on Solaris (as strange as that may seem) so
> we've been able to devote some resources to it. The patches you see in
> 1.1.3 (and some older and newer releases) are a res
Hello
>@@ -1802,7 +1802,7 @@ static HRESULT WINAPI
>OLEPictureImpl_Load(IPersistStream* iface,IStream*pStm) {
> hr=IStream_Read(pStm,header,8,&xread);
> if (hr || xread!=8) {
> ERR("Failure while reading picture header (hr is %x, nread is %d).
\n",hr,xread);
>- re
Zac Brown <[EMAIL PROTECTED]> writes:
> +si.hEvent = CreateEvent(NULL, 0, 0, NULL);
> +si.port = rand() + 8000;
You need to search for an available port, rand() is not an appropriate
mechanism.
--
Alexandre Julliard
[EMAIL PROTECTED]
2008/10/16 Jacek Caban <[EMAIL PROTECTED]>:
> Hi Rob,
>
> Rob Shearman wrote:
>>
>> The rule is implemented by FunctionExpression which is reduced using
>> the Statement rule.
>> ---
>> dlls/jscript/parser.y | 37 -
>> 1 files changed, 0 insertions(+), 37 dele
Am Mittwoch, den 15.10.2008, 17:25 -0700 schrieb chris ahrendt:
> Michael / All
>
> here is the third go at the ddraw test... and the patch for that...
Looks much better now, but two issues remains.
> note I went ahead and used the goto.
As I suggested the approach, this is OK with me, but...
>
27 matches
Mail list logo
