Just a small bug, but patchwatcher is complaining about my lostwages
patch not applying.
Thanks,
Scott Ritchie
"Aric Stewart" <[EMAIL PROTECTED]> wrote:
> +static inline INT calculate_vlc(EDITSTATE *es)
> +{
> + INT vlc = (es->format_rect.bottom - es->format_rect.top) / es->line_height;
> +return max(1,vlc);
> +}
The formatting of the above hunk is broken, you will notice that
once you set tab size in
Michael Karcher wrote:
> I put the list back on CC because someone there might know about the
> drmMap problem.
>
> Am Dienstag, den 14.10.2008, 15:30 -0700 schrieb chris ahrendt:
>
>>> PS: From the attachments of Chris' mail, one can get the following
>>> information: The environment we are cur
Michael Karcher wrote:
> I put the list back on CC because someone there might know about the
> drmMap problem.
>
> Am Dienstag, den 14.10.2008, 15:30 -0700 schrieb chris ahrendt:
>
>>> PS: From the attachments of Chris' mail, one can get the following
>>> information: The environment we are cur
I put the list back on CC because someone there might know about the
drmMap problem.
Am Dienstag, den 14.10.2008, 15:30 -0700 schrieb chris ahrendt:
> > PS: From the attachments of Chris' mail, one can get the following
> > information: The environment we are currently talking about is Wine on
> >
On Tuesday 14 October 2008 23:07:45 Jacek Caban wrote:
> ---
> dlls/jscript/engine.c | 28
> dlls/jscript/tests/lang.js | 12
> 2 files changed, 28 insertions(+), 12 deletions(-)
>
I'm not sure if this applies to javascript but if it does, yo
Am Dienstag, den 14.10.2008, 13:34 -0700 schrieb chris ahrendt:
> Yes if we need to move this off list please let me know
>
> Michael Karcher wrote:
> > That's why I suggested you to introduce the err2 label. The end of the
> > function should look like this:
> Ya, Ich versteh
Sehr gut.
Yes if we need to move this off list please let me know
Michael Karcher wrote:
> That's why I suggested you to introduce the err2 label. The end of the
> function should look like this:
>
Ya, Ich versteh
here is the first patch to fix exception 1. I did have the patch with
the skip b
Hallo!
About two weeks ago I tried to hand in a (corrected version of my)
patch for "StretchDIBits" [1].
However it isn't accepted until now and I didn't yet notice any
response.
Would someone please tell me what's wrong or if it was just missed out
accidentally?
[1] http://www.winehq.org/piperm
To all: sorry for so much quoting, but I don't think trimming the quotes
down helps understanding my point. If you are annoyed, we can move the
discussion off-list.
Am Dienstag, den 14.10.2008, 09:16 -0700 schrieb chris ahrendt:
> >> diff --git a/dlls/ddraw/tests/dsurface.c b/dlls/ddraw/tests/d
Great idea, patch resubmitted.
-aric
Juan Lang wrote:
> Hi Aric,
>
> Just a suggestion:
>
> @@ -1818,6 +1818,7 @@ static void EDIT_ML_InvalidateText(EDITSTATE
> *es, INT start, INT end)
> RECT rcUpdate;
> INT l;
>
> + if (vlc == 0) vlc = 1;
> if ((el < es->y_offset) || (s
Hi Aric,
Just a suggestion:
@@ -1818,6 +1818,7 @@ static void EDIT_ML_InvalidateText(EDITSTATE
*es, INT start, INT end)
RECT rcUpdate;
INT l;
+ if (vlc == 0) vlc = 1;
if ((el < es->y_offset) || (sl > es->y_offset + vlc))
return;
@@ -2235,6 +2236,7 @
Michael Karcher wrote:
> Am Montag, den 13.10.2008, 21:05 -0400 schrieb Chris Ahrendt:
>
>> Fixed a trailing space error..
>>
> Sorry to chime in so late on this patchset.
>
> First, some general remarks: The subject of your mail will be the
> one-line commit message. "Try #2" is not a good
> General observation: other tests in Wine explicitly check for specific
> hr values, is there a reason you have used the generic SUCCEEDED here
> instead of that approach?
In general we don't care what the return value on success is.
Applications sometimes sometimes do check for particular failur
> The change is OK but you'll want to flesh out RtlGenRandom first,
> currently it will fail pretty badly if /dev/urandom isn't available.
Ah, good point. Thanks. Where isn't it available, out of curiosity?
--Juan
On Tuesday 14 October 2008 11:10:34 Kai Blin wrote:
> As the code checks for ofnW->lpstrFile not being NULL, it seems like
> PathFindFileNameW() and PathFindExtensionW() don't make sense on NULL
> ofnW->lpstrFile. If offset and extension are not updated, it doesn't make
> sense to call UpdateResult
"Ilya Shpigor" <[EMAIL PROTECTED]> wrote:
> +trace("creating maximized visible MDI child window 3\n");
> +mdi_child3 = CreateWindowExA(WS_EX_MDICHILD, "MDI_child_class", "MDI
> child",
> +WS_CHILD | WS_VISIBLE | WS_MAXIMIZEBOX |
> WS_MAXIMIZE,
> +
"Juan Lang" <[EMAIL PROTECTED]> writes:
> This unfortunately causes test failures in quartz. I strongly suspect
> the failures are spurious, because I'm pretty confident my tests show
> that this change is correct, but I don't know enough about quartz to
> know the cause.
> --Juan
>
> From cf9fc6
2008/10/14 Michael Karcher <[EMAIL PROTECTED]>:
> But there might be Win32 applications that do care about specific return
> values. So the implementation in Wine has to match native in returning
> S_OK or S_FALSE (the two most common success values). What is the point
> in not testing your impleme
Am Montag, den 13.10.2008, 14:30 -0400 schrieb Chris Ahrendt:
> Ok I fixed the code to take this out... however : one section there is
> something I am not sure of so I left it in to prevent the exception from
> occuring.
This is an additional explanation in addition to the remarks I made to
your
Am Montag, den 13.10.2008, 21:05 -0400 schrieb Chris Ahrendt:
> Fixed a trailing space error..
Sorry to chime in so late on this patchset.
First, some general remarks: The subject of your mail will be the
one-line commit message. "Try #2" is not a good choice for that. Also it
does not have enough
2008/10/14 Reece Dunn <[EMAIL PROTECTED]>:
> 2008/10/14 Henri Verbeet <[EMAIL PROTECTED]>:
>> +IShellView2_DestroyViewWindow(shell_view2);
>> +ok(SUCCEEDED(hr), "DestroyViewWindow returned %#x\n", hr);
>
> You are missing a "hr = " here, otherwise the ok check is not checkin
"Ilya Shpigor" <[EMAIL PROTECTED]> wrote:
> --- a/dlls/user32/tests/win.c
> +++ b/dlls/user32/tests/win.c
> @@ -1674,9 +1674,78 @@ static BOOL mdi_RegisterWindowClasses(void)
> cls.lpszClassName = "MDI_child_Class_2";
> if(!RegisterClassA(&cls)) return FALSE;
>
> +cls.lpfnWndProc =
2008/10/14 Henri Verbeet <[EMAIL PROTECTED]>:
> +IShellView2_DestroyViewWindow(shell_view2);
> +ok(SUCCEEDED(hr), "DestroyViewWindow returned %#x\n", hr);
You are missing a "hr = " here, otherwise the ok check is not checking
the return value from DestroyViewWindow.
> +
24 matches
Mail list logo
