Re: Fix to exceptions in ddtest

2008-10-12 Thread Marcus Meissner
On Sun, Oct 12, 2008 at 09:52:06PM -0400, Chris Ahrendt wrote: > Ok I have threaded through ddraw_test adding as I had them fail a check > and a fix in dsurface.c test. The test now fails when the CreateSurface > fails. Before this there were several point in the test where the return > status

Re: Fix to exceptions in ddtest

2008-10-12 Thread James Hawkins
On Sun, Oct 12, 2008 at 8:52 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: > Ok I have threaded through ddraw_test adding as I had them fail a check and > a fix in dsurface.c test. The test now fails when the CreateSurface fails. > Before this there were several point in the test where the return s

Fix to exceptions in ddtest

2008-10-12 Thread Chris Ahrendt
Ok I have threaded through ddraw_test adding as I had them fail a check and a fix in dsurface.c test. The test now fails when the CreateSurface fails. Before this there were several point in the test where the return status was not checked. As I encountered them and they failed with an excepti

Re: Latest Windows Conformance Tests

2008-10-12 Thread Vitaliy Margolen
Chris Ahrendt wrote: > Vitaliy Margolen wrote: >> Chris Ahrendt wrote: >>> Causes windows XP SP3 to reboot during d3d test.. >> >> Would you please stop hijacking threads! Do NOT reply when starting a new >> topic!!! This is highly annoying and it's deemed a really bad habit. >> >> Vitaliy. > I did

Re: comctl32/tests: Fix tests to not depend on 96 dpi

2008-10-12 Thread Dmitry Timoshkov
"Detlef Riekenberg" <[EMAIL PROTECTED]> wrote: > #define DEFAULT_MIN_TAB_WIDTH 54 > -#define TAB_DEFAULT_WIDTH 96 > #define TAB_PADDING_X 6 > #define EXTRA_ICON_PADDING 3 > #define MAX_TABLEN 32 > @@ -507,11 +506,13 @@ static void test_tab(INT nMinTabWidth) > HDC hdc; > HFONT hOldFon

Re: gdi32/tests: Fix tests to not depend on 96 dpi

2008-10-12 Thread Dmitry Timoshkov
"Detlef Riekenberg" <[EMAIL PROTECTED]> wrote: > @@ -101,7 +101,9 @@ static void test_world_transform(void) > > if (is_win9x) > { > -expect_viewport_ext(hdc, 96, 96); > +DWORD dpi; > +dpi = GetDeviceCaps(hdc, LOGPIXELSY); > +expect_viewport_ext(hdc, dpi,

patchwatcher status

2008-10-12 Thread Dan Kegel
The most pressing issue for patchwatcher is to finish the refactoring into libpatchwatcher.sh and wine-slave.sh. I made a tiny bit of progress there today by applying some typo fixes Rob sent me, and adding the missing timeout enforcement that was already in the monolithic patchwatcher. (Checked in

Re: Re[2] [user32: 2/2] Testcase for font size = 0x7fff

2008-10-12 Thread Austin English
On Sun, Oct 12, 2008 at 2:16 PM, Koro <[EMAIL PROTECTED]> wrote: >> Interesting. Would you be willing to contribute your Task Dialogs >> implementation to Wine under the terms of the LGPL? > > I'd have to almost rewrite it completly to fit it into WINE. I don't > feel like it, and neither do I hav

Re: DIB engine status

2008-10-12 Thread Detlef Riekenberg
On 9/29/08, Sergey Novosyolov <[EMAIL PROTECTED]> wrote: >> The first thing, i like to see is a Design in the correct way: >> Inside gdi32 while using Eng* and friends. >> (Needed by Printer drivers, and any Display driver including mirror / >> remote display drivers) >> > why can't we release DIB

Re: winex11.drv: Improve tracing of wintab WTInfo

2008-10-12 Thread James Hawkins
On Sun, Oct 12, 2008 at 3:42 PM, John Klehm <[EMAIL PROTECTED]> wrote: > @@ -1079,6 +1079,7 @@ UINT X11DRV_WTInfoW(UINT wCategory, UINT nIndex, LPVOID lpOutput) switch(wCategory) { case 0: +TRACE("category: NULL. Asking for needed buffer size"); /* retur

Re: Latest Windows Conformance Tests

2008-10-12 Thread Chris Ahrendt
Vitaliy Margolen wrote: > Chris Ahrendt wrote: >> Causes windows XP SP3 to reboot during d3d test.. > > Would you please stop hijacking threads! Do NOT reply when starting a new > topic!!! This is highly annoying and it's deemed a really bad habit. > > Vitaliy. I did not hijack a thread I opened

Re: Latest Windows Conformance Tests

2008-10-12 Thread Vitaliy Margolen
Chris Ahrendt wrote: > Causes windows XP SP3 to reboot during d3d test.. Would you please stop hijacking threads! Do NOT reply when starting a new topic!!! This is highly annoying and it's deemed a really bad habit. Vitaliy.

Re: Latest Windows Conformance Tests

2008-10-12 Thread James Hawkins
On Sun, Oct 12, 2008 at 2:09 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: >> >> On Sun, Oct 12, 2008 at 2:02 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >>> >>> Causes windows XP SP3 to reboot during d3d test.. >>> >>> What and where do I need to send in the information >>>

Re[2] [user32: 2/2] Testcase for font size = 0x7fff

2008-10-12 Thread Koro
> Interesting. Would you be willing to contribute your Task Dialogs > implementation to Wine under the terms of the LGPL? I'd have to almost rewrite it completly to fit it into WINE. I don't feel like it, and neither do I have the time for it. Sorry.

Re: Latest Windows Conformance Tests

2008-10-12 Thread Chris Ahrendt
James Hawkins wrote: > On Sun, Oct 12, 2008 at 2:02 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >> Causes windows XP SP3 to reboot during d3d test.. >> >> What and where do I need to send in the information >> on the issue. >> > > You're going to have to set up a cross-build environment to compil

Re: Latest Windows Conformance Tests

2008-10-12 Thread John Klehm
On Sun, Oct 12, 2008 at 2:02 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: > Causes windows XP SP3 to reboot during d3d test.. > > What and where do I need to send in the information > on the issue. > > Microsoft Windows XP > Home Edition > Version 2002 > Sp 3 > > Pent 4 3.2ghz > 2 gig ram > > Prob

Re: Latest Windows Conformance Tests

2008-10-12 Thread James Hawkins
On Sun, Oct 12, 2008 at 2:02 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: > Causes windows XP SP3 to reboot during d3d test.. > > What and where do I need to send in the information > on the issue. > You're going to have to set up a cross-build environment to compile the d3d tests and figure out w

Latest Windows Conformance Tests

2008-10-12 Thread Chris Ahrendt
Causes windows XP SP3 to reboot during d3d test.. What and where do I need to send in the information on the issue. Microsoft Windows XP Home Edition Version 2002 Sp 3 Pent 4 3.2ghz 2 gig ram Chris

Re[7] [user32: 2/2] Testcase for font size = 0x7fff

2008-10-12 Thread Koro
> This is an explanation of the test primitives. Feel free to put it on > the Wine wiki, if you like it. That is an *excellent* explanation. Everything becomes clear now, and indeed this should be documented somewhere (except I can't find how to edit the wiki without making an account). Maybe so

Re: Added missing values to VGA Mode 19 (256 color) palette registers with comments for related VGA operations. Windows programs that access VGA directly or through BIOS that previously displayed blac

2008-10-12 Thread James Hawkins
On Sat, Oct 11, 2008 at 4:15 PM, Jeremiah Flerchinger <[EMAIL PROTECTED]> wrote: > > @@ -476,10 +743,12 @@ static void WINAPI VGA_DoSetMode(ULONG_PTR arg) > return; > } > IDirectDrawSurface_SetPalette(lpddsurf,lpddpal); > + > vga_retrace_vertical = vga_retrace_ho

Re: wordpad: do not try to close uninitialized handles

2008-10-12 Thread James Hawkins
On Sun, Oct 12, 2008 at 6:09 AM, Andrey Turkin <[EMAIL PROTECTED]> wrote: > > Fix some functions where CloseHandle was called not matter if previous > open succeeded or not. > HKEY hKey; DWORD size = sizeof(RECT); +BOOL succeeded = FALSE; -if(registry_get_handle(&hKey, 0, ke

Re: mshtml: Implement IHTMLStyle get/put posLeft

2008-10-12 Thread Jacek Caban
Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Implement IHTMLStyle get/put posLeft > > Best Regards > Alistair Leslie-Hughes > > {attrMarginRight, DISPID_IHTMLSTYLE_MARGINRIGHT}, > {attrPaddingLeft, DISPID_IHTMLSTYLE_PADDINGLEFT}, > +{attrLeft,

Re: wordpad: do not pass resource ids to MessageBox

2008-10-12 Thread Dmitry Timoshkov
"Andrey Turkin" <[EMAIL PROTECTED]> wrote: >>> It seems that automatic loading of string from resources in MessageBox* >>> is Wine extension. Useful and logical one but still other platform does >>> not support it. >> >> That's not a Wine extension, looks like the author of that code just >> didn'

Re: Proposal: switch Wine source tree to utf-8

2008-10-12 Thread Dan Kegel
On Tue, Sep 2, 2008 at 3:43 AM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote: > Dan Kegel wrote: >> [Let's convert the whole wine source tree to utf-8. Some of it already is, >> but I suspect lots of other files are in obscure character >> sets, which complicates patch processing and display. >> Th

re: [user32: 2/2] Testcase for font size = 0x7fff

2008-10-12 Thread Dan Kegel
Koro wrote: > I wrote one this summer (http://www.korosoft.net/projects/tdemu/). Interesting. Would you be willing to contribute your Task Dialogs implementation to Wine under the terms of the LGPL? If not, well, thanks for the testcase and bug fix! - Dan

Re: wordpad: do not pass resource ids to MessageBox

2008-10-12 Thread Andrey Turkin
Dmitry Timoshkov wrote: > "Andrey Turkin" <[EMAIL PROTECTED]> wrote: > >> It seems that automatic loading of string from resources in MessageBox* >> is Wine extension. Useful and logical one but still other platform does >> not support it. > > That's not a Wine extension, looks like the author of t

Re: wordpad: do not pass resource ids to MessageBox

2008-10-12 Thread Dmitry Timoshkov
"Andrey Turkin" <[EMAIL PROTECTED]> wrote: > It seems that automatic loading of string from resources in MessageBox* > is Wine extension. Useful and logical one but still other platform does > not support it. That's not a Wine extension, looks like the author of that code just didn't test it. One

Re: Re[5] [user32: 2/2] Testcase for font size = 0x7fff

2008-10-12 Thread Michael Karcher
Am Sonntag, den 12.10.2008, 01:33 -0400 schrieb Koro: > > ok() is for calls never expected to fail, broken() is for broken API > > implementations and should never be used for Wine. > Noted. More specifically: You *never* use broken on its own. This is an explanation of the test primitives. Feel f

Re: notoskrnl.exe: Fix the stack overflow bugs in raising exceptions(DLL_PROCESS_DETACH processing for DllMain in ntoskrnl.c)

2008-10-12 Thread Anton Rudnev
RtlAddVectoredHandler is never fail. vectored_handler_added store adress of handler for DLL_PROCESS_DETACH-case. If vectored_handler_added is null then handler is not been added at DLL_PROCESS_ATTACH-case. If handler not has been removed in DLL_PROCESS_DETACH-case, then called it after FreeLibrar