Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

James Hawkins wrote: > On Thu, Oct 9, 2008 at 4:14 PM, Andrey Turkin <[EMAIL PROTECTED]> wrote: > >> [now with tests, fixed and reformatted as per James' suggestions] >> >> Implement CredReadDomainCredentialsA and CredReadDomainCredentialsW >> stubs and few tests for them. Required for MSN Mess

Re: DrawTextEx parameter return value fix

On Thu, Oct 9, 2008 at 9:13 PM, Dean <[EMAIL PROTECTED]> wrote: > What are you trying to fix? You need to add a test to the test suite to verify that this change is correct. -- James Hawkins

Additional debugging thoughts...

So Sitting on the airplane I was thinking of additional clarifications on debugging. Again these are just some ideas... So lets look at an exception: What I am talking about when more descriptive is this : Since we know from other parts where the read is done.. why not dump the line of code?

Re: [PATCH] Revert "comctl32: Fix a test on locales where default first day of week is not the max value."

On Thu, Oct 9, 2008 at 4:27 PM, Marcus Meissner <[EMAIL PROTECTED]> wrote: > > Hi, > > This is breaking my "make test" run for 2 weeks now. > (LANG=de_DE.utf8) > > This reverts commit 2f8830d55b71d2fb8be912c7041d7adab7580391. > --- > dlls/comctl32/tests/monthcal.c |3 +-- > 1 files changed, 1

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

On Thu, Oct 9, 2008 at 4:14 PM, Andrey Turkin <[EMAIL PROTECTED]> wrote: > > [now with tests, fixed and reformatted as per James' suggestions] > > Implement CredReadDomainCredentialsA and CredReadDomainCredentialsW > stubs and few tests for them. Required for MSN Messenger 7.0 > --- > dlls/advapi

d3d: Bug in handling of depth-stencil surfaces, and potential patch

See bug 10758. If you create a depth-stencil surface with Direct3D 9 on Windows, select it into a D3D9 device with SetDepthStencilSurface() and then release it (so its reference count goes to zero), the surface will not be deleted. It will persist until its external reference count is zero /and/

Re: Wineconf follow up: Wine Usage Data Collection

James Hawkins wrote: > On Thu, Oct 9, 2008 at 2:09 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >> I am sure there are some things that may be automated somewhat... or we can >> compare exceptions etc... that way we can get some idea of atleast what the >> hot bugs are at the time... Maybe one of

Need help with the quartz filtermapper tests

Hi Alexander, my recent patch to improve the GUIDs generated by rpcrt4[1] causes a failure in the quartz filtermapper tests. Specifically, I get the following error: quartz:filtermapper.c:142: Test failed: EnumMatchingFilters failed to return the test filter 2 The trouble is, I can't imagine how

Re: Wineconf follow up: Wine Usage Data Collection

On Thu, Oct 9, 2008 at 2:09 PM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >> > I am sure there are some things that may be automated somewhat... or we can > compare exceptions etc... that way we can get some idea of atleast what the > hot bugs are at the time... Maybe one of the first tasks towards

Re: Wineconf follow up: Wine Usage Data Collection

James Hawkins wrote: > On Thu, Oct 9, 2008 at 9:32 AM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: >> Alexandre Julliard wrote: >>> "Henri Verbeet" <[EMAIL PROTECTED]> writes: >>> 2008/10/8 Austin English <[EMAIL PROTECTED]>: > Currently, we've got two problems: > 1) We want to collect Wi

Favor: review refactor of gdi32/freetype.c - AddFontToList

So in my ongoing quest to get CreateScalableFontResource completed, I believe that I need to refactor gdi32/freetype.c - AddFontToList to expose an interface to allow me to retrieve a Face *. Attached is a series of 4 patches that accomplish what I believe to be a reasonable refactoring of that fu

Re: Wineconf follow up: Wine Usage Data Collection

On Thu, Oct 9, 2008 at 9:32 AM, Chris Ahrendt <[EMAIL PROTECTED]> wrote: > Alexandre Julliard wrote: >> "Henri Verbeet" <[EMAIL PROTECTED]> writes: >> >>> 2008/10/8 Austin English <[EMAIL PROTECTED]>: Currently, we've got two problems: 1) We want to collect Wine usage data, so we know whe

Re: [PATCH 3/4] msi: Add initial implementation of MsiDatabaseMerge, with tests.

James Hawkins wrote: > --- > dlls/msi/database.c | 497 > ++- > dlls/msi/msipriv.h |2 + > dlls/msi/record.c | 71 > dlls/msi/tests/db.c | 449 +- > 4 files changed, 1014 insertions(+),

Re: actxprxy/qmgrprxy: Specify dlldata.c in C_SRCS instead of in EXTRA_OBJS to allow dependencies to be generated.

"Rob Shearman" <[EMAIL PROTECTED]> writes: > Yes, I have verified that by looking at the dependencies in the > makefile for these DLLs. I did check this before sending the patch, > but I'm not sure why I didn't see this before. > > However, I'm not that happy with depending on a magic name here -

Re: Wineconf follow up: Wine Usage Data Collection

Alexandre Julliard wrote: > "Henri Verbeet" <[EMAIL PROTECTED]> writes: > >> 2008/10/8 Austin English <[EMAIL PROTECTED]>: >>> Currently, we've got two problems: >>> 1) We want to collect Wine usage data, so we know where to concentrate >>> our efforts. >> Just curious, but do any actual developer

Re: Wineconf follow up: Wine Usage Data Collection

Guillaume VanderEst wrote: > It could also be possible to have a crash count? > > On Sun, Oct 5, 2008 at 9:22 PM, Zachary Goldberg <[EMAIL PROTECTED] > > wrote: > > Hello All, > > Just wanted to continue the thread from Wineconf about tracking usage > data

Re: actxprxy/qmgrprxy: Specify dlldata.c in C_SRCS instead of in EXTRA_OBJS to allow dependencies to be generated.

2008/10/9 Alexandre Julliard <[EMAIL PROTECTED]>: > "Rob Shearman" <[EMAIL PROTECTED]> writes: > >> @@ -6,9 +6,9 @@ MODULE= actxprxy.dll >> IMPORTS = rpcrt4 kernel32 ntdll >> EXTRADEFS = -DREGISTER_PROXY_DLL -DPROXY_CLSID_IS="{ 0xb8da6310, 0xe19b, >> 0x11d0, { 0x93, 0x3c, 0x00, 0xa0, 0xc9,

Re: Wineconf follow up: Wine Usage Data Collection

"Henri Verbeet" <[EMAIL PROTECTED]> writes: > 2008/10/8 Austin English <[EMAIL PROTECTED]>: >> Currently, we've got two problems: >> 1) We want to collect Wine usage data, so we know where to concentrate >> our efforts. > Just curious, but do any actual developers really care about this? My > feel

Re: Wineconf follow up: Wine Usage Data Collection

It could also be possible to have a crash count? On Sun, Oct 5, 2008 at 9:22 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: > Hello All, > > Just wanted to continue the thread from Wineconf about tracking usage > data in Wine. We had discussed adding an opt-in system at first run > where all in

Re: oleacc: implemented GetRoleText[A/W] with tests (try6 - rebased)

On Tue, 2008-10-07 at 21:23 +0400, Nikolay Sivov wrote: > Changelog(try5, try6): > - rebased with current git > Changelog(try4): > - tests for string length added > - configure.ac in the same patch > Changelog: > - implemented GetRoleText[A/W] with tests > > >From 82eeac4de0a082b3c

Re: mlang: tests, converstion test was falsely failing on windows xp for codepage 1361 (Korean, Johab) because of lack of roman characters

Aric Stewart <[EMAIL PROTECTED]> writes: > @@ -259,6 +259,15 @@ static BOOL check_convertible(IMultiLanguage2 *iML2, > UINT from, UINT to) > > static WCHAR strW[] = {'a','b','c',0}; > > +if (from == 1361 || to == 1361) > +{ > +/* > + * This is Korean (Johab). Thi

Re: actxprxy/qmgrprxy: Specify dlldata.c in C_SRCS instead of in EXTRA_OBJS to allow dependencies to be generated.

"Rob Shearman" <[EMAIL PROTECTED]> writes: > @@ -6,9 +6,9 @@ MODULE= actxprxy.dll > IMPORTS = rpcrt4 kernel32 ntdll > EXTRADEFS = -DREGISTER_PROXY_DLL -DPROXY_CLSID_IS="{ 0xb8da6310, 0xe19b, > 0x11d0, { 0x93, 0x3c, 0x00, 0xa0, 0xc9, 0x0d, 0xca, 0xa9 } }" > > -EXTRA_OBJS = dlldata.o > -

Re: Resend patch for 15494

The whole issue is a driver bug (the drmMap issue related to lack of virtual memory caused by Wine). This causes CreateSurface to fail. Though there can also be other reasons why CreateSurface can fail (though not in this case). The test should just for the failure of creating surfaces and then