Kai Blin wrote:
> ---
> dlls/kernel32/tests/locale.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
>
>
>
Hi Kai,
Already sent a patch for this :
http://www.winehq.org/pipermail/wine-patches/2008-Octo
On Monday 06 October 2008 23:05:25 Jacek Caban wrote:
> +UINT WINAPI MsiInstallMissingComponentW(LPCWSTR szProduct, LPCWSTR
...
> 83 stub MsiInstallMissingComponentA
> -84 stub MsiInstallMissingComponentW
> +84 stdcall MsiInstallMissingComponentW(wstr wstr long)
...
> diff --git a/include/msi.h b
On Tuesday 07 October 2008 06:46:06 Kai Blin wrote:
> ---
> dlls/kernel32/tests/locale.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
I forgot to mention that Coverity found this one. Alexandre, can you please
add (Coverity) to the subject before the commit?
Cheers,
Kai
--
Ka
2008/10/6 Louis. Lenders <[EMAIL PROTECTED]>:
> fixes a crash reported on userlist:
> http://forum.winehq.org/viewtopic.php?t=2447
>
> As the function is a complete stub, it's probably a good ides to initialize
> it to zero anyway.
>
You haven't addressed the concerns pointed out by Juan.
--
Jam
"Paul Vriens" <[EMAIL PROTECTED]> wrote:
> (Independent from the other user32/tests patch "Run tests on win95 again").
>
> Basically the same patch/logic as in commit
> 5cf418f5218d46e28c00f15ba2eb574794f6 but now for user32. The
> GetProcAddress
> is needed as GetComboBoxInfo is not availab
On Mon, Oct 6, 2008 at 5:48 PM, Michael Karcher
<[EMAIL PROTECTED]> wrote:
> sName is an uninitialized pointer if GetMemberName faild.
> ---
> dlls/msxml3/tests/domdoc.c |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/d
On Mon, Oct 6, 2008 at 4:05 PM, Jacek Caban <[EMAIL PROTECTED]> wrote:
> ---
> dlls/msi/msi.c|9 +
> dlls/msi/msi.spec |2 +-
> include/msi.h |4
> 3 files changed, 14 insertions(+), 1 deletions(-)
>
+{
+FIXME("(%s %s %d\n", debugstr_w(szProduct),
debugstr_w(s
"Stefan Ziel" <[EMAIL PROTECTED]> wrote:
> >This patch is obviously wrong
>
> may be, but the handling of symbol fonts in wine also is ;)
>
>>TranslateCharsetInfo does handle SYMBOL_CHARSET, and code page
>>for symbol *is* defined.
>
> its the charset-bits in fontinfo structure where most sy
Hi Jacek,
>static HRESULT WINAPI HTMLStyle_put_border(IHTMLStyle *iface, BSTR v)> {>
>HTMLStyle *This = HTMLSTYLE_THIS(iface);>-FIXME("(%p)->(%s)\n", This,
>debugstr_w(v));>-return E_NOTIMPL;>+>+TRACE("(%p)->(%s)\n", This,
>debugstr_w(v));>+>+return set_style_attr(This, STY
Hello Alexandre,
please cherry-pick the attached list of translation patches into the
"stable" aka wine-1.0.x branch. Some of the patches seem to be already
cherry-picked but as a git cherry-pick will just do nothing for those I
didn't bother to find them and remove them.
The list was genera
2008/10/6 Dan Kegel <[EMAIL PROTECTED]>:
> Thanks to the half-dozen Wine developers attacking the Coverity
> warnings, we are slowly making progress.
>
> Here are the warnings that were new as of October 1st
> and which have not yet been classified.
> They fall into five areas (four DLLs and one ki
Hi Louis, this isn't about spaces this time.
diff --git a/dlls/mapi32/mapi32_main.c b/dlls/mapi32/mapi32_main.c
index 936d435..5aace9a 100644
--- a/dlls/mapi32/mapi32_main.c
+++ b/dlls/mapi32/mapi32_main.c
@@ -109,6 +109,7 @@ HRESULT WINAPI MAPILogonEx(ULONG_PTR uiparam,
LPWSTR profile,
{
FI
> Sorry , i don't understand what you mean with that comment above.
I'm sorry, that's my mistake. When it was quoted in Austin's replay,
the number of spaces got screwed up in my email reader. There's no
such spacing mistake in your patch. Sorry for the sloppy review.
--Juan
On Mon, Oct 6, 2008 at 2:32 PM, Louis. Lenders
<[EMAIL PROTECTED]> wrote:
>
>
> - Original Message
> From: Juan Lang <[EMAIL PROTECTED]>
> To: Louis Lenders <[EMAIL PROTECTED]>
> Cc: wine-devel@winehq.org
> Sent: Monday, 6 October, 2008 13:36:52
> Subject: Re: mapi32: initialize session po
- Original Message
From: Juan Lang <[EMAIL PROTECTED]>
To: Louis Lenders <[EMAIL PROTECTED]>
Cc: wine-devel@winehq.org
Sent: Monday, 6 October, 2008 13:36:52
Subject: Re: mapi32: initialize session pointer to zero in MAPILogonEx (2nd
resend)
> diff --git a/dlls/mapi32/mapi32_main.c b
This fixme is quite an important one and it is not printed much in each app. It
can indicate real problems. At most it is printed a handful of times but in
general only once or twice. It is not a standard fixme which is printed
thousands of times for no good reason.
Roderick
> On Mon, Oct 6, 2
Austin English wrote:
>
> +[propget, id(DISPID_IHTMLELEMENT2_ONROWSINSERTED), displaybind, bindable]
> + VARIANT onrowsinserted();
> +
>
> Extra space before VARIANT
>
Calm down, you send one mail per space. Emacs for some reason doesn't
understand indention in dispinterfaces. I don't
Austin English wrote:
>
> +/* NOTE: Make sure to keep in sync with stryle_strings in htmlstrle.c */
>
> s/stryle_strings/style_strings && s/htmlstrle.c/htmlstyle.c
>
>
Thanks, I will change it more soon, so I will fix it then as I don't
think such typos are worth resending or separated patch.
>This patch is obviously wrong
may be, but the handling of symbol fonts in wine also is ;)
>TranslateCharsetInfo does handle SYMBOL_CHARSET, and code page
>for symbol *is* defined.
its the charset-bits in fontinfo structure where most symbol fonts
set bit 31 (reserved for OEM in original doc
Am Samstag, den 04.10.2008, 20:44 +0200 schrieb Michael Karcher:
> Hello Huw Davies,
>
> it looks like test_removeChild (introduced by you in commit 187ab1c0)
> contains a typo.
Ugh. Please disregard the previous mail. The test after "fixing" the
typo does *not* succeed in WinXP, only in wine.
R
--- On Sat, 4/10/08, Dan Kegel <[EMAIL PROTECTED]> wrote:
> I'm getting the feeling it's widespread. Anyone
> else
> know of examples of apps that Wine displays poorly
> because of the lack of this feature?
> - Dan
I have a .NET2 application which has pull-down menu's that doesn't pull-down
with
Umm, disregard all of this... sorry for spam
> To wine developers: would it be useful to review dlls/winmm? Currently
> all mm-drivers (aux, mid, mod, wid, wod) functions are called using
> MDRV_Message calls. The arguments of a MDRV_Message are the device id
> (an array index), the message identif
>
> With this patch it's possible to test scripts by running
> wine jscript_test.exe.so run
> Although it's not what Wine tests are for, it proved to be very useful
> for me.
That's the second time in the last couple days that
your patches confused patchwatcher's patch series
detector.
You resen
On Mon, Oct 6, 2008 at 9:54 AM, Jacek Caban <[EMAIL PROTECTED]> wrote:
> ---
> include/mshtmdid.h | 12 +
> include/mshtml.idl | 957
>
> 2 files changed, 969 insertions(+), 0 deletions(-)
>
>
>
>
+[propget, id(DISPID_IHTMLELEMENT2_ONROW
Thanks to the half-dozen Wine developers attacking the Coverity
warnings, we are slowly making progress.
Here are the warnings that were new as of October 1st
and which have not yet been classified.
They fall into five areas (four DLLs and one kind of generated code):
CID Checker
On Mon, Oct 6, 2008 at 9:48 AM, Jacek Caban <[EMAIL PROTECTED]> wrote:
> ---
> dlls/mshtml/htmlstyle.c | 108
> ---
> dlls/mshtml/htmlstyle.h | 21 +
> 2 files changed, 85 insertions(+), 44 deletions(-)
>
>
>
>
+/* NOTE: Make sure to keep in
On Mon, Oct 6, 2008 at 9:47 AM, Jacek Caban <[EMAIL PROTECTED]> wrote:
> ---
> include/mshtmdid.h | 26
> include/mshtml.idl | 355
> +++-
> 2 files changed, 380 insertions(+), 1 deletions(-)
>
>
>
>
+[propget, id(DISPID_IHTMLCURRENTSTYL
On Mon, Oct 6, 2008 at 3:39 AM, Henri Verbeet <[EMAIL PROTECTED]> wrote:
> 2008/10/6 Austin English <[EMAIL PROTECTED]>:
>> -if(DepthStencilFormat != WINED3DFMT_D24S8)
>> -FIXME("Add OpenGL context recreation support to
>> SetDepthStencilSurface\n");
>>
>> +if(DepthStencilFormat !=
> diff --git a/dlls/mapi32/mapi32_main.c b/dlls/mapi32/mapi32_main.c
> index 936d435..5aace9a 100644
> --- a/dlls/mapi32/mapi32_main.c
> +++ b/dlls/mapi32/mapi32_main.c
> @@ -109,6 +109,7 @@ HRESULT WINAPI MAPILogonEx(ULONG_PTR uiparam,
> LPWSTR profile,
> {
> FIXME("(0x%08lx %s %p 0x%08x %p)
On Mon, Oct 6, 2008 at 12:26 PM, Louis. Lenders
<[EMAIL PROTECTED]> wrote:
>
> 2nd resend. If the patch is wrong, could you just tell me what's wrong with
> it? Might be handier, then me having to guess what's wrong...
>
>
> As the function is a complete stub, it's probably a good idea to initializ
On Mon, Oct 6, 2008 at 12:23 PM, Louis. Lenders
<[EMAIL PROTECTED]> wrote:
> 3rd resend. If the patch is wrong, could you just tell me what's wrong with
> it? Might be handier, then me having to guess what's wrong...
>
>
>
>
>
>
+typedef enum tagMSIPATCHDATATYPE
+{
+MSIPATCH_DATATYPE_PATCHFILE
On Mon, Oct 6, 2008 at 5:26 AM, Jeremy White <[EMAIL PROTECTED]> wrote:
>> Oh, I don't know. Seems to me that the wiki it's a *better*
>> landing page for newbies; it does a better job of leading them
>> by the hand without making them scroll or click.
>
> I disagree. People still have an expecta
> 2008/10/6 Alexander Morozov <[EMAIL PROTECTED]>:
> > +@ stdcall [EMAIL PROTECTED](ptr ptr)
> > USBD_CreateConfigurationRequestEx
>
> ...
>
> > +@ stdcall [EMAIL PROTECTED](ptr ptr long long
> > long long long) USBD_ParseConfigurationDescriptorEx +@ stub
> > [EMAIL PROTECTED]
>
> The stdcall calli
Dmitry Timoshkov wrote:
> "Nikolay Sivov" <[EMAIL PROTECTED]> wrote:
>
to prove this I need to add a new module named oleaccrc.dll which
contains this resources on Win.
>>>
>>> I don't understand the argument about oleaccrc.dll.
>>>
>> This module contains localized resource strings used
true, that would be cleaner. I will resubmit.
-aric
Dmitry Timoshkov wrote:
> "Aric Stewart" <[EMAIL PROTECTED]> wrote:
>
>> -wszPatternString++; /* skip ',' */
>> +if (hr == S_OK)
>> +wszPatternString++; /* skip ',' */
>>
>> if (hr == S_OK)
>> {
>
> Why not just move i
"Aric Stewart" <[EMAIL PROTECTED]> wrote:
> -wszPatternString++; /* skip ',' */
> +if (hr == S_OK)
> +wszPatternString++; /* skip ',' */
>
> if (hr == S_OK)
> {
Why not just move it into the below block?
--
Dmitry.
"Nikolay Sivov" <[EMAIL PROTECTED]> wrote:
>>> to prove this I need to add a new module named oleaccrc.dll which
>>> contains this resources on Win.
>>
>> I don't understand the argument about oleaccrc.dll.
>>
> This module contains localized resource strings used by GetRoleText in
> Win. I trie
Dmitry Timoshkov wrote:
> "Nikolay Sivov" <[EMAIL PROTECTED]> wrote:
>
>>> First of all there is no need to send the configure.ac patch
>>> separately.
>> Ok, but how could I remove auto generated files from patch?
>> Now I commit 3 times:
>> 1) configure.ac
>> 2) regenerated 'configure'
>> 3) mai
> Oh, I don't know. Seems to me that the wiki it's a *better*
> landing page for newbies; it does a better job of leading them
> by the hand without making them scroll or click.
I disagree. People still have an expectation that a 'front page'
has some sort of introductory component to it. And e
2008/10/6 Alexander Morozov <[EMAIL PROTECTED]>:
> +@ stdcall [EMAIL PROTECTED](ptr ptr) USBD_CreateConfigurationRequestEx
...
> +@ stdcall [EMAIL PROTECTED](ptr ptr long long long long long)
> USBD_ParseConfigurationDescriptorEx
> +@ stub [EMAIL PROTECTED]
The stdcall calling convention specifie
"Nikolay Sivov" <[EMAIL PROTECTED]> wrote:
>> First of all there is no need to send the configure.ac patch separately.
> Ok, but how could I remove auto generated files from patch?
> Now I commit 3 times:
> 1) configure.ac
> 2) regenerated 'configure'
> 3) main patch body.
>
> Then I simply don't
Dmitry Timoshkov wrote:
> "Nikolay Sivov" <[EMAIL PROTECTED]> wrote:
>
> First of all there is no need to send the configure.ac patch separately.
Ok, but how could I remove auto generated files from patch?
Now I commit 3 times:
1) configure.ac
2) regenerated 'configure'
3) main patch body.
Then I
"Nikolay Sivov" <[EMAIL PROTECTED]> wrote:
First of all there is no need to send the configure.ac patch separately.
> +/* zero role number - not documented */
> +ret = GetRoleTextA(0, NULL, 0);
> +ok(ret > 0, "GetRoleTextA doesn't return length for zero role number,
> got %d\n", ret)
"Nikolay Sivov" <[EMAIL PROTECTED]> wrote:
> I've made these tests but I still don't follow you:
> - GetRoleTextW returns length when called with NULL buffer (and zero or
> not-zero buflen)
I don't see such a test.
> - GetRoleTextA returns length only when called with NULL buffer. On zero
> bu
> Alexandre's keynote is available at
http://www.winehq.org/site/wineconf/media.
The link here is broken - the dot should be removed from the end.
-Stephen
2008/10/6 Austin English <[EMAIL PROTECTED]>:
> -if(DepthStencilFormat != WINED3DFMT_D24S8)
> -FIXME("Add OpenGL context recreation support to
> SetDepthStencilSurface\n");
>
> +if(DepthStencilFormat != WINED3DFMT_D24S8) {
> + if (warn) {
> +FIXME("Add OpenGL context
Dmitry Timoshkov wrote:
> "Nikolay Sivov" <[EMAIL PROTECTED]> wrote:
>
LoadStringA doesn't return necessary buffer length when called with
(buflen = 0) but LoadStringW does.
Since I need to return a necessary buffer length from both
GetRoleText[A/W] I used LoadStringW in both
"Kai Blin" <[EMAIL PROTECTED]> wrote:
> "News: WineConf 2008"
> - the things I work on are spelled secur32 and kerberos
> - I _think_ the pink ninja's first name is Caron, not Caran, might be wrong
> here.
> - It's not Andrew Bodat, it's Andrew Bogott
In addition to things pointed out by Kai:
-
On Sun, Oct 05, 2008 at 05:41:31PM -0500, Austin English wrote:
> On Sun, Oct 5, 2008 at 2:26 PM, Marcus Meissner <[EMAIL PROTECTED]> wrote:
> > Hi,
> >
> > This fixes http://bugs.winehq.org/show_bug.cgi?id=9008
> > by also filtering out the backbuffer flag.
> >
> > Ciao, Marcus
> > ---
> > dlls/d
On Monday 06 October 2008 07:36:29 Zachary Goldberg wrote:
> All,
>
> This WWN is all my writing and no quotes, and thus a lot more room for
> typographical and other errors. Thus I wanted to send everybody the
> WWN for review before publication. In particular please check the
> first section fo
50 matches
Mail list logo
