Re: [1/2] user32: Converted rcScrollBar to screen coordinates.

2008-10-05 Thread Dmitry Timoshkov
"Dylan Smith" <[EMAIL PROTECTED]> wrote: >> You need to fix SCROLL_GetScrollBarRect for the SB_CTL case instead. >> > > SCROLL_GetScrollBarRect is used is used in multiple places where client > coordinates are expected, and it isn't just the SB_CTL case that needs to be > changed, in fact it was

Re: [1/2] user32: Converted rcScrollBar to screen coordinates.

2008-10-05 Thread Dylan Smith
On Mon, Oct 6, 2008 at 2:17 AM, Dmitry Timoshkov <[EMAIL PROTECTED]>wrote: > You need to fix SCROLL_GetScrollBarRect for the SB_CTL case instead. > SCROLL_GetScrollBarRect is used is used in multiple places where client coordinates are expected, and it isn't just the SB_CTL case that needs to be

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-05 Thread Steven Edwards
On Mon, Oct 6, 2008 at 12:32 AM, Austin English <[EMAIL PROTECTED]> wrote: > If it's stored in WINEPREFIX, then each time a new prefix is used, > they'll get the prompt each time. Then again, maybe most people aren't > doing this. > How are we tracking apps? By filename/md5sum/filesize/installed fi

Re: [1/2] user32: Converted rcScrollBar to screen coordinates.

2008-10-05 Thread Dmitry Timoshkov
"Dylan Smith" <[EMAIL PROTECTED]> wrote: > @@ -1252,6 +1253,9 @@ static BOOL SCROLL_GetScrollBarInfo(HWND hwnd, LONG > idObject, LPSCROLLBARINFO in > > SCROLL_GetScrollBarRect(hwnd, nBar, &info->rcScrollBar, &nDummy, > &info->dxyLineButton, &info->xyThumbTop);

Re: Wineconf follow up: Cosmetic website changes

2008-10-05 Thread Dan Kegel
On Sun, Oct 5, 2008 at 10:20 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: > So there seem to be some fundamental issues conflicting here. > wiki.winehq.org is a good place to send newbies because it has tons of > information, but its not an easy landing page for somebody new to look > at. Oh, I

Please Review WWN 353

2008-10-05 Thread Zachary Goldberg
All, This WWN is all my writing and no quotes, and thus a lot more room for typographical and other errors. Thus I wanted to send everybody the WWN for review before publication. In particular please check the first section for name typos etc. http://home.bluesata.com/WineWWN/WineHQ/?issue=353

Re: [2/2] oleacc: implemented GetRoleText[A/W] with tests

2008-10-05 Thread Dmitry Timoshkov
"Nikolay Sivov" <[EMAIL PROTECTED]> wrote: >>> LoadStringA doesn't return necessary buffer length when called with >>> (buflen = 0) but LoadStringW does. >>> Since I need to return a necessary buffer length from both >>> GetRoleText[A/W] I used LoadStringW in both cases, >>> converting to multib

Re: Wineconf follow up: Cosmetic website changes

2008-10-05 Thread Zachary Goldberg
On Mon, Oct 6, 2008 at 12:52 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > That's right, I foolishly volunteered to put together > a draft for winehq.org's front page inspired by > openoffice.org's front page. > > The main constraint discussed at wineconf was that > the site navigation should not chan

re: Wineconf follow up: Cosmetic website changes

2008-10-05 Thread Dan Kegel
That's right, I foolishly volunteered to put together a draft for winehq.org's front page inspired by openoffice.org's front page. The main constraint discussed at wineconf was that the site navigation should not change with this redesign ('cause that requires lots more work). Also, it's inaccura

Re: Wineconf follow up: Wine Usage Data Collection

2008-10-05 Thread Austin English
On Sun, Oct 5, 2008 at 11:22 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: > Hello All, > > Just wanted to continue the thread from Wineconf about tracking usage > data in Wine. We had discussed adding an opt-in system at first run > where all invokations of Wine would send a token to WineHQ to

Wineconf follow up: Wine Usage Data Collection

2008-10-05 Thread Zachary Goldberg
Hello All, Just wanted to continue the thread from Wineconf about tracking usage data in Wine. We had discussed adding an opt-in system at first run where all invokations of Wine would send a token to WineHQ to track the number of times users run given applications to help direct development. Th

Wineconf follow up: Cosmetic website changes

2008-10-05 Thread Zachary Goldberg
Hello all, I just wanted to start up a thread to continue the conversation from Wineconf about revamping the WineHQ homepage. The last notes I took on the subject had Dan Kegel considering doing an actual redesign. --Zach

Re: [PATCH] also remove backbuffer flags in the v1 DDRAW interface

2008-10-05 Thread Austin English
On Sun, Oct 5, 2008 at 2:26 PM, Marcus Meissner <[EMAIL PROTECTED]> wrote: > Hi, > > This fixes http://bugs.winehq.org/show_bug.cgi?id=9008 > by also filtering out the backbuffer flag. > > Ciao, Marcus > --- > dlls/ddraw/ddraw_thunks.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions

Re: request for windows test ddraw/dsurface

2008-10-05 Thread Nikolay Sivov
Marcus Meissner wrote: > Hi, > > I am suspecting that in IDirectDraw1 the behaviour > regarding backbuffer creation might change if we have > a just created frontbuffer of the same size. > > (This is similar to behaviour shown by bulanci.exe > of http://bugs.winehq.org/show_bug.cgi?id=9008 ) > > Ca

request for windows test ddraw/dsurface

2008-10-05 Thread Marcus Meissner
Hi, I am suspecting that in IDirectDraw1 the behaviour regarding backbuffer creation might change if we have a just created frontbuffer of the same size. (This is similar to behaviour shown by bulanci.exe of http://bugs.winehq.org/show_bug.cgi?id=9008 ) Can someone please try this on Windows ple

Re: [2/2] oleacc: implemented GetRoleText[A/W] with tests

2008-10-05 Thread Nikolay Sivov
Dmitry Timoshkov wrote: > "Nikolay Sivov" <[EMAIL PROTECTED]> wrote: > >> LoadStringA doesn't return necessary buffer length when called with >> (buflen = 0) but LoadStringW does. >> Since I need to return a necessary buffer length from both >> GetRoleText[A/W] I used LoadStringW in both cases, >

Re: [2/2] oleacc: implemented GetRoleText[A/W] with tests

2008-10-05 Thread Dmitry Timoshkov
"Nikolay Sivov" <[EMAIL PROTECTED]> wrote: > LoadStringA doesn't return necessary buffer length when called with > (buflen = 0) but LoadStringW does. > Since I need to return a necessary buffer length from both > GetRoleText[A/W] I used LoadStringW in both cases, > converting to multibyte in ans

Re: d3d8: initialize IDirect3DDevice8 *device to NULL incase of immedient cleanup. (coverity 795)

2008-10-05 Thread Rob Shearman
2008/10/3 Aric Stewart <[EMAIL PROTECTED]>: > -IDirect3DDevice8 *device; > +IDirect3DDevice8 *device=NULL; Add spaces around the "=" here to match the rest of the code. -- Rob Shearman

Re: [2/2] oleacc: implemented GetRoleText[A/W] with tests

2008-10-05 Thread Nikolay Sivov
Dmitry Timoshkov wrote: > "Nikolay Sivov" <[EMAIL PROTECTED]> wrote: > >> The thought that WideCharToMultiByte will not fill buffer of >> insufficient length, that's where I was wrong. I've just posted a >> corrected patch. Any feedback will be appreciated. > > After looking at your patch I don't

Re: [2/2] oleacc: implemented GetRoleText[A/W] with tests

2008-10-05 Thread Dmitry Timoshkov
"Nikolay Sivov" <[EMAIL PROTECTED]> wrote: > The thought that WideCharToMultiByte will not fill buffer of > insufficient length, that's where I was wrong. I've just posted a > corrected patch. Any feedback will be appreciated. After looking at your patch I don't see much difference with what Lo

Re: [2/2] oleacc: implemented GetRoleText[A/W] with tests

2008-10-05 Thread Nikolay Sivov
Dmitry Timoshkov wrote: > "Nikolay Sivov" <[EMAIL PROTECTED]> wrote: > > Why do you need to allocate an intermediate roletextA? > WideCharToMultiByte requires to have a sufficient buffer. I think it's the easiest way to allocate necessary buffer instead of using local buffe

Re: [2/2] oleacc: implemented GetRoleText[A/W] with tests

2008-10-05 Thread Dmitry Timoshkov
"Nikolay Sivov" <[EMAIL PROTECTED]> wrote: Why do you need to allocate an intermediate roletextA? >>> WideCharToMultiByte requires to have a sufficient buffer. I think >>> it's the easiest way to allocate necessary buffer instead of using >>> local buffer of some hardcoded length. What

Re: [2/2] oleacc: implemented GetRoleText[A/W] with tests

2008-10-05 Thread Nikolay Sivov
Dmitry Timoshkov wrote: > "Nikolay Sivov" <[EMAIL PROTECTED]> wrote: > >>> Why do you need to allocate an intermediate roletextA? >>> >> WideCharToMultiByte requires to have a sufficient buffer. I think >> it's the easiest way to allocate necessary buffer instead of using >> local buffer of some

Re: [2/2] oleacc: implemented GetRoleText[A/W] with tests

2008-10-05 Thread Dmitry Timoshkov
"Nikolay Sivov" <[EMAIL PROTECTED]> wrote: >> Why do you need to allocate an intermediate roletextA? >> > WideCharToMultiByte requires to have a sufficient buffer. I think it's > the easiest way to allocate necessary buffer instead of using local > buffer of some hardcoded length. What do you th