Re: msi: Implement the DROP TABLE sql command.

2008-10-02 Thread Steven Edwards
On Thu, Oct 2, 2008 at 5:21 PM, Rob Shearman <[EMAIL PROTECTED]> wrote: > I don't like this idea because of the expression "If you gave an > infinite number of monkeys an infinite number of typewriters they > would eventually produce the complete works of Shakespeare." In other > words, if someone

Re: msi: Implement the DROP TABLE sql command.

2008-10-02 Thread Rob Shearman
2008/10/2 Steven Edwards <[EMAIL PROTECTED]>: > On Thu, Oct 2, 2008 at 3:25 PM, James Hawkins <[EMAIL PROTECTED]> wrote: >> Hi, I can't repro this problem on my machine, so I'm sending this >> patch to patchwatcher by way of wine-patches to get some info. Please >> do not apply. > > Regarding our

Re: msi: Implement the DROP TABLE sql command.

2008-10-02 Thread Austin English
On Thu, Oct 2, 2008 at 3:47 PM, Steven Edwards <[EMAIL PROTECTED]> wrote: > On Thu, Oct 2, 2008 at 4:42 PM, Austin English <[EMAIL PROTECTED]> wrote: >> You'd still be sending the patch twice to wine-patches, and by that >> logic, for _EVERY_ patch, not just ones that were rejected. > > No. you wou

Re: msi: Implement the DROP TABLE sql command.

2008-10-02 Thread Steven Edwards
On Thu, Oct 2, 2008 at 4:42 PM, Austin English <[EMAIL PROTECTED]> wrote: > You'd still be sending the patch twice to wine-patches, and by that > logic, for _EVERY_ patch, not just ones that were rejected. No. you would only have to send it again if the first one was rejected by patchwatcher. By d

Re: msi: Implement the DROP TABLE sql command.

2008-10-02 Thread Austin English
On Thu, Oct 2, 2008 at 3:27 PM, Steven Edwards <[EMAIL PROTECTED]> wrote: > On Thu, Oct 2, 2008 at 3:25 PM, James Hawkins <[EMAIL PROTECTED]> wrote: >> Hi, I can't repro this problem on my machine, so I'm sending this >> patch to patchwatcher by way of wine-patches to get some info. Please >> do

Re: msi: Implement the DROP TABLE sql command.

2008-10-02 Thread James Hawkins
On Thu, Oct 2, 2008 at 3:27 PM, Steven Edwards <[EMAIL PROTECTED]> wrote: > On Thu, Oct 2, 2008 at 3:25 PM, James Hawkins <[EMAIL PROTECTED]> wrote: >> Hi, I can't repro this problem on my machine, so I'm sending this >> patch to patchwatcher by way of wine-patches to get some info. Please >> do

Re: howto fix bug 13462

2008-10-02 Thread Louis Lenders
Rob Shearman gmail.com> writes: Thanks very much for your comments Rob, I've updated the patch here: http://bugs.winehq.org/attachment.cgi?id=16397 Hopefully correct now? But now got another problem with the test, i changed it a bit like here: http://bugs.winehq.org/attachment.cgi?id=16430 This

Re: msi: Implement the DROP TABLE sql command.

2008-10-02 Thread Steven Edwards
On Thu, Oct 2, 2008 at 3:25 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > Hi, I can't repro this problem on my machine, so I'm sending this > patch to patchwatcher by way of wine-patches to get some info. Please > do not apply. Regarding our wineconf discussion about patchwatcher spam on wine-p

Re: Detecting Wine

2008-10-02 Thread Scott Ritchie
Markus Hitter wrote: > Am 30.09.2008 um 12:55 schrieb Eric Pouech: > >> Your design is wrong IMO. You don't handle reparse points at all; >> you only >> rely on the nature of a drive, which isn't sufficient in most >> cases. See >> mounting volumes for example where you can mount a whole volum

Re: Be careful out there

2008-10-02 Thread Roderick Colenbrander
The names in the headers don't matter to programs which use them and source which is compiled using them. Only the order matters. Using the same names is fine. Roderick > Andrew Fenn wrote: > > Actually I wanted to ask a question about this.. > > > > When implementing an API do we have to chan

D3DXAssembleShader, unknown texture formats and misc

2008-10-02 Thread Kjell Rune Skaaraas
Hello,I'm taking a stab at implmenting D3DXAssembleShader, which takes shader instructions like "mul r1, r2.xy, r3.z" and turns them into binary code (one-to-one mapping). Although I've got very little clue what I'm really doing, I've come quite a way on a parser that breaks it down into the sep

Re: winequartz.drv Mac OS X UI discontinued?

2008-10-02 Thread Saulius Krasuckas
Sorry for the lag, * On Thu, 10 Jul 2008, Adam Strzelecki wrote: Is it really technically impossible to access the Quartz APIs or write Mac applications using C? Well it is possible, for example iTunes is non Objective-C Carbon (API) app AFAIK. Problem is that Carbon (pure C interface) is co

Re: Wine PulseAudio Driver

2008-10-02 Thread Juan Lang
> Humm, I can see splitting the changes to configure.ac and Makefile.in, > but as for splitting the rest of it, should I split it per-file? No. Patches should be split along functional lines. E.g., patch 1: add stub driver patch 2: add small feature x to driver patch 3: add small feature y to dr

Re: Be careful out there

2008-10-02 Thread Kornél Pál
Andrew Fenn wrote: > Actually I wanted to ask a question about this.. > > When implementing an API do we have to change the variable names from > those given in the msdn documentation? > > More specifically, the typedefs for the xinput structs ( documentation > here: http://msdn.microsoft.com/en-

Re: Wine PulseAudio Driver

2008-10-02 Thread Arthur Taylor
> Hi Art, > > > Currently I am looking for any feedback at all. > > I believe you've already gotten some: split up your patches so that > we can read them a little more easily. If you send a large patch as a > new contributor, it's very unlikely to get committed. Humm, I can see splitting the

Re: Be careful out there

2008-10-02 Thread Andrew Fenn
Actually I wanted to ask a question about this.. When implementing an API do we have to change the variable names from those given in the msdn documentation? More specifically, the typedefs for the xinput structs ( documentation here: http://msdn.microsoft.com/en-us/library/bb173049(VS.85).aspx )

Re: Fullscreen window in metacity hides owned window

2008-10-02 Thread Dmitry Timoshkov
Michael Ost <[EMAIL PROTECTED]> wrote: > So, what's the preferred fix? Should I change set_wm_hints to catch the > DIALOG styles first (see diff below)? That seems reasonable to me. Does > that sound safe to you? > > Is this something that should be generally available or just a one off > hack

Re: Fullscreen window in metacity hides owned window

2008-10-02 Thread Michael Ost
Dmitry Timoshkov wrote: > Michael Ost <[EMAIL PROTECTED]> wrote: > >> We are seeing a problem in Metacity where a fullscreen window obscures a >> second created window that has a particular style: WS_DLGFRAME | >> WS_THICKFRAME. >> >> When window A is created fullscreen (WS_POPUP, size matches s

Be careful out there

2008-10-02 Thread Juan Lang
Unfortunately, there is some Microsoft code available on the Internet. More unfortunately, Google has indexed some of it. I was searching for an undocumented function and ran across something that seemed to describe it. I clicked on the link, and fortunately the indexed page was just a reference

Re: (try 2)version: check for out of memory when VerInstallFileA/W converstion. (response to coverity 635)

2008-10-02 Thread Rob Shearman
2008/10/2 Aric Stewart <[EMAIL PROTECTED]>: > Whoops on the whitespace. > > The paths are irrelevent. They are intentionally pointing at a file and > location that is not existing. Should I change the paths to express that > more explicitly; something like: "D:\\oes\\not\\exist" ? Sure, that wo

Re: (try 2)version: check for out of memory when VerInstallFileA/W converstion. (response to coverity 635)

2008-10-02 Thread Aric Stewart
Whoops on the whitespace. The paths are irrelevent. They are intentionally pointing at a file and location that is not existing. Should I change the paths to express that more explicitly; something like: "D:\\oes\\not\\exist" ? -aric Rob Shearman wrote: > 2008/10/2 Aric Stewart <[EMAIL PROT

Re: (try 2)version: check for out of memory when VerInstallFileA/W converstion. (response to coverity 635)

2008-10-02 Thread Rob Shearman
2008/10/2 Aric Stewart <[EMAIL PROTECTED]>: > @@ -543,34 +543,50 @@ DWORD WINAPI VerInstallFileW( > len = WideCharToMultiByte( CP_ACP, 0, srcfilename, -1, NULL, 0, > NULL, NULL ); > if ((wsrcf = HeapAlloc( GetProcessHeap(), 0, len ))) > WideCharToMultiByte( CP_ACP, 0

Re: gdi32: if a font substitution is given then only match to that substitution not to the original family name.

2008-10-02 Thread Dmitry Timoshkov
Aric Stewart <[EMAIL PROTECTED]> wrote: > LIST_FOR_EACH(family_elem_ptr, &font_list) { > family = LIST_ENTRY(family_elem_ptr, Family, entry); > -if (!strcmpiW(family->FamilyName, FaceName) || > -(psub && !strcmpiW(family->FamilyName, psub->to.name)

Re: [PATCH 1/2] wininet: Return error codes explicitly from URLCache functions instead of returning a BOOL and storing the error code in the last error value.

2008-10-02 Thread Juan Lang
Hi Rob, + * Locks the index for system-wide exclusive access. + * + * RETURNS + * TRUE if successful + * FALSE if failed and calls SetLastError. */ static LPURLCACHE_HEADER URLCacheContainer_LockIndex(URLCACHECONTAINER * pContainer) The comment's off here. @@ -1346,34 +1353,32 @@ static BOO

Re: Fullscreen window in metacity hides owned window

2008-10-02 Thread Dmitry Timoshkov
Michael Ost <[EMAIL PROTECTED]> wrote: > We are seeing a problem in Metacity where a fullscreen window obscures a > second created window that has a particular style: WS_DLGFRAME | > WS_THICKFRAME. > > When window A is created fullscreen (WS_POPUP, size matches screen res) > and window B is cr

Re: version: check for out of memory when VerInstallFileA/W converstion. (response to coverity 635)

2008-10-02 Thread Rob Shearman
2008/10/2 Aric Stewart <[EMAIL PROTECTED]>: > @@ -543,34 +543,50 @@ DWORD WINAPI VerInstallFileW( > len = WideCharToMultiByte( CP_ACP, 0, srcfilename, -1, NULL, 0, > NULL, NULL ); > if ((wsrcf = HeapAlloc( GetProcessHeap(), 0, len ))) > WideCharToMultiByte( CP_ACP, 0

Re: Wine PulseAudio Driver

2008-10-02 Thread Juan Lang
Hi Art, > Currently I am looking for any feedback at all. I believe you've already gotten some: split up your patches so that we can read them a little more easily. If you send a large patch as a new contributor, it's very unlikely to get committed. Also, this function: +/* +const char * PULSE

Re: gdiplus: Stub GdipRecordMetafileFileName andGdipRecordMetafileFileNameI

2008-10-02 Thread Nikolay Sivov
Alistair Leslie-Hughes wrote: > "Alistair Leslie-Hughes" <[EMAIL PROTECTED]> wrote in message > news:[EMAIL PROTECTED] > >> Hi, >> >> Changelog: >> gdiplus: Stub GdipRecordMetafileFileName and GdipRecordMetafileFileNameI >> >> > Was there anything wrong with this patch? > > Best Regards >

Re: gdiplus: Stub GdipRecordMetafileFileName andGdipRecordMetafileFileNameI

2008-10-02 Thread Alistair Leslie-Hughes
"Alistair Leslie-Hughes" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Hi, > > Changelog: > gdiplus: Stub GdipRecordMetafileFileName and GdipRecordMetafileFileNameI > Was there anything wrong with this patch? Best Regards Alistair Leslie-Hughes

Re: Wine PulseAudio Driver

2008-10-02 Thread Arthur Taylor
I have put a newer patch in bugzilla: http://bugs.winehq.org/attachment.cgi?id=16412&action=edit Currently I am looking for any feedback at all. Should I send a message to wine-patches as well? > 2. We ought to be able to use PulseAudio's ALSA emulation. If that > doesn't work, then either our A