Wineconf photos

2008-09-28 Thread Zachary Goldberg
http://picasaweb.google.com/zgold550/Wineconf2008 (a.k.a. an exhibit in terrible white balance). I haven't edited any of the shots, just uploaded straight from Picasa. If you want a full 10MP RAW or JPG of any of the shots with some actual editing / touchups let me know. -Zach

Re: DirectDraw: fix compilation on mingw

2008-09-28 Thread Henri Verbeet
2008/9/28 Roderick Colenbrander <[EMAIL PROTECTED]>: > From: Roderick Colenbrander <[EMAIL PROTECTED](none)> You're certainly not the only one who does this, but you're supposed to have a proper email address in there.

Re: wined3d: Convert between A8R8G8B8 and X8R8G8B8

2008-09-28 Thread Henri Verbeet
2008/9/29 Kjell Rune Skaaraas <[EMAIL PROTECTED]>: > Hello, > > A simple patch which adds converting between A8R8G8B8 and X8R8G8B8 that > gives me one less warning to deal with while trying to make a game function. > It zeroes out the alpha channel to be on the safe side, though it should > never b

Re: dsound: GetVolume should check error from driver (resend)

2008-09-28 Thread Kirill K. Smirnov
Hi, Dan! >ALSA_CheckSetVolume returns right early because hctl is NULL, >but that error is not propagated through dsound properly. >While we should figure out the alsa part, for now, let's at least >propagate the error, and skip tests that can't be done without >sensing volume. >If this patch is a

Re: Discussion of bug versions

2008-09-28 Thread James McKenzie
Hin-Tak Leung wrote: > --- On Sun, 28/9/08, Jeremy White <[EMAIL PROTECTED]> wrote: > > > The con is actually less trouble than you think - if somebody reports > a bug against CVS/GIT, it would be reasonable to assume that the > report date is within a day or two compared to the git > clone/reb

Re: Discussion of bug versions

2008-09-28 Thread Hin-Tak Leung
--- On Sun, 28/9/08, Jeremy White <[EMAIL PROTECTED]> wrote: > Second, we'd like new bug reporters to not be able to > use > the 'CVS/GIT' version choice, but to instead be > encouraged to > report the current version. (wine --version reports > something > that is easy to match up to the choices)

Re: Getting Coverity access

2008-09-28 Thread James McKenzie
Juan Lang wrote: > As we're talking about this at WineConf and not everyone has an > account, you can get one by emailing [EMAIL PROTECTED] and > asking. There are fewer than 100 bugs that we haven't looked at it, > and I'd appreciate the help! > --Juan > > > > Juan: I was wondering how to get

Re: Discussion of bug versions

2008-09-28 Thread Vitaliy Margolen
James Hawkins wrote: > On Sun, Sep 28, 2008 at 4:43 PM, Vitaliy Margolen > <[EMAIL PROTECTED]> wrote: >> Jeremy White wrote: >>> Second, we'd like new bug reporters to not be able to use >>> the 'CVS/GIT' version choice, but to instead be encouraged to >>> report the current version. (wine --versi

Re: Discussion of bug versions

2008-09-28 Thread James Hawkins
On Sun, Sep 28, 2008 at 4:43 PM, Vitaliy Margolen <[EMAIL PROTECTED]> wrote: > Jeremy White wrote: >> We discussed bugzilla versions at Wineconf, re: >> >> http://bugs.winehq.org/show_bug.cgi?id=12728 >> >> There were several points of consensus. First, it would be helpful >> if we could reduce th

Re: Discussion of bug versions

2008-09-28 Thread Vitaliy Margolen
Jeremy White wrote: > We discussed bugzilla versions at Wineconf, re: > > http://bugs.winehq.org/show_bug.cgi?id=12728 > > There were several points of consensus. First, it would be helpful > if we could reduce the number of versions visible in the drop down > box when entering a new bug. That

Discussion of bug versions

2008-09-28 Thread Jeremy White
We discussed bugzilla versions at Wineconf, re: http://bugs.winehq.org/show_bug.cgi?id=12728 There were several points of consensus. First, it would be helpful if we could reduce the number of versions visible in the drop down box when entering a new bug. That would seem to require a bugzilla c

Re: [PATCH 1/2] gdiplus: Allocate enough space for BITMAPINFO in GdipCreateTextureIA.

2008-09-28 Thread Marcus Meissner
On Sun, Sep 28, 2008 at 01:26:37PM -0700, Lei Zhang wrote: > On Sun, Sep 28, 2008 at 12:53 PM, Nikolay Sivov <[EMAIL PROTECTED]> wrote: > > Lei Zhang wrote: > >> @@ -512,8 +512,11 @@ GpStatus WINGDIPAPI GdipCreateTextureIA(GpImage > >> *image, > >> IPicture_get_CurDC(image->picture, &hdc); >

Re: [PATCH 1/2] gdiplus: Allocate enough space for BITMAPINFO in GdipCreateTextureIA.

2008-09-28 Thread Lei Zhang
On Sun, Sep 28, 2008 at 12:53 PM, Nikolay Sivov <[EMAIL PROTECTED]> wrote: > Lei Zhang wrote: >> @@ -512,8 +512,11 @@ GpStatus WINGDIPAPI GdipCreateTextureIA(GpImage *image, >> IPicture_get_CurDC(image->picture, &hdc); >> bm_is_selected = (hdc != 0); >> >> -bmi.bmiHeader.biSize = size

comctl32:listview crash on Win98

2008-09-28 Thread Francois Gouget
Listview has a test to ensure that sending a LVM_SETIMAGELIST between WM_NCCREATE and WM_CREATE works fine. The problem is that this causes the conformance test to crash on my Windows 98 OSR0 VM. Right on this line: static LRESULT CALLBACK create_test_wndproc(HWND hwnd, UINT uMsg, WPARAM wPar

Re: Wineconf-er caught at security.

2008-09-28 Thread Owen Rudge
> I was stopped at security for carrying 'a wine bottle' through > security. Upon a brief inspection it was revealed that my > super-awesome crossover t-shirts had tripped the machine due to their > lusciously exquisite compressed shape. Whoops. I'll be sure to put mine in my hold luggage rath

Wineconf-er caught at security.

2008-09-28 Thread Zachary Goldberg
I was stopped at security for carrying 'a wine bottle' through security. Upon a brief inspection it was revealed that my super-awesome crossover t-shirts had tripped the machine due to their lusciously exquisite compressed shape. Whoops. --Zach

Getting Coverity access

2008-09-28 Thread Juan Lang
As we're talking about this at WineConf and not everyone has an account, you can get one by emailing [EMAIL PROTECTED] and asking. There are fewer than 100 bugs that we haven't looked at it, and I'd appreciate the help! --Juan

Re: [PATCH 1/2] gdiplus: Allocate enough space for BITMAPINFO in GdipCreateTextureIA.

2008-09-28 Thread Nikolay Sivov
Lei Zhang wrote: > @@ -512,8 +512,11 @@ GpStatus WINGDIPAPI GdipCreateTextureIA(GpImage *image, > IPicture_get_CurDC(image->picture, &hdc); > bm_is_selected = (hdc != 0); > > -bmi.bmiHeader.biSize = sizeof(BITMAPINFOHEADER); > -bmi.bmiHeader.biBitCount = 0; > +pbmi = GdipAll

Re: howto fix bug 13462

2008-09-28 Thread Reece Dunn
2008/9/28 Louis Lenders <[EMAIL PROTECTED]>: > >> > +//#include "ctxtcall.h" >> >> Please resend the patch adding the IDL file for this generated file >> and get it in before sending this patch adding the tests. >> > > Hi Rob, thanks very much for the comments. I'll do the above , but i have > prob

Re: howto fix bug 13462

2008-09-28 Thread Rob Shearman
2008/9/28 Louis Lenders <[EMAIL PROTECTED]>: > >> > +//#include "ctxtcall.h" >> >> Please resend the patch adding the IDL file for this generated file >> and get it in before sending this patch adding the tests. >> > > Hi Rob, thanks very much for the comments. I'll do the above , but i have > prob

Re: user32/tests: Move shell test to the end - killing explorer affects lots of tests

2008-09-28 Thread Dmitry Timoshkov
Vitaliy Margolen <[EMAIL PROTECTED]> wrote: > This fixes all win tests except 2 on win2k. If it will affect other test(s) > following win test then we either shouldn't kill explorer or restart it or > more correctly configured shell. Probably adding a comment requesting to keep the test at the e

Re: howto fix bug 13462

2008-09-28 Thread Louis Lenders
> > +//#include "ctxtcall.h" > > Please resend the patch adding the IDL file for this generated file > and get it in before sending this patch adding the tests. > Hi Rob, thanks very much for the comments. I'll do the above , but i have problems when I uncomment the above include, i get: compo

Re: [PATCH] shell32: print the correct GUIDs in the shellpath tests.

2008-09-28 Thread Juan Lang
> Juan's proposed version will cause a memory leak / valgrind warning. Not at all. I'm proposing stack pointers, not HeapAlloc'ed versions. See for example how I fixed this for the SIP tests: http://www.winehq.org/pipermail/wine-cvs/2008-July/045766.html --Juan

Re: [PATCH] shell32: print the correct GUIDs in the shellpath tests.

2008-09-28 Thread Maarten Lankhorst
Juan's proposed version will cause a memory leak / valgrind warning. 2008/9/28, Reece Dunn <[EMAIL PROTECTED]>: > 2008/9/28 Maarten Lankhorst <[EMAIL PROTECTED]>: >> Hi Juan, >> >> 2008/9/28, Juan Lang <[EMAIL PROTECTED]>: >>> Hi Reece, I'm not nak'ing your patch. I just wanted to point out a >>

Re: [PATCH] shell32: print the correct GUIDs in the shellpath tests.

2008-09-28 Thread Reece Dunn
2008/9/28 Maarten Lankhorst <[EMAIL PROTECTED]>: > Hi Juan, > > 2008/9/28, Juan Lang <[EMAIL PROTECTED]>: >> Hi Reece, I'm not nak'ing your patch. I just wanted to point out a simpler >> way: >> >> -static const char *printGUID(const GUID *guid) >> +static char *printGUID(const GUID *guid) >> { >

Re: [PATCH] shell32: print the correct GUIDs in the shellpath tests.

2008-09-28 Thread Maarten Lankhorst
Hi Juan, 2008/9/28, Juan Lang <[EMAIL PROTECTED]>: > Hi Reece, I'm not nak'ing your patch. I just wanted to point out a simpler > way: > > -static const char *printGUID(const GUID *guid) > +static char *printGUID(const GUID *guid) > { > -static char guidSTR[39]; > +char *guidSTR = HeapAl

Patchwatcher: boldly going where MS has gone before

2008-09-28 Thread Dan Kegel
Pre-commit tests were done commonly at Microsoft as early as 2001 by a system named Gauntlet, see http://blogs.msdn.com/misampso/archive/2005/03/14/395374.aspx http://blogs.msdn.com/vcblog/archive/2006/11/02/gauntlet-a-peek-into-visual-c-development-practices.aspx Well, better late than never!

Re: [PATCH] shell32: print the correct GUIDs in the shellpath tests.

2008-09-28 Thread Juan Lang
Hi Reece, I'm not nak'ing your patch. I just wanted to point out a simpler way: -static const char *printGUID(const GUID *guid) +static char *printGUID(const GUID *guid) { -static char guidSTR[39]; +char *guidSTR = HeapAlloc(GetProcessHeap(), 0, 39); Rather than allocating the necessary

Re: RFC: Adding annotations to function declarations to improve static analysis

2008-09-28 Thread Rob Shearman
2008/9/28 Reece Dunn <[EMAIL PROTECTED]>: > 2008/9/28 Rob Shearman <[EMAIL PROTECTED]>: >> Hi all, >> >> This will be talked about in more detail at WineConf tomorrow, but I >> just thought I'd throw this out there as a bit of background to any >> discussions. >> >> Adding annotations to function d

Bug squish party!

2008-09-28 Thread Dan Kegel
All the cool kids at Wineconf are busily fixing "make test" failures. If you're not at Wineconf, you can still play along! See http://wiki.winehq.org/BugSquishParty for details and how to claim a bug to fix.

Re: [WineHQ] Remove google adds box

2008-09-28 Thread Zachary Goldberg
There was talk and it seemed like JWhite's intention to remove the box so I figure'd i'de throw in the patch for when the final decision was made. I expected the Jeremys to make that decision. On Sun, Sep 28, 2008 at 5:56 AM, Tom Wickline <[EMAIL PROTECTED]> wrote: > Can I object the removal? >

Re: howto fix bug 13462

2008-09-28 Thread Rob Shearman
2008/9/28 Louis. Lenders <[EMAIL PROTECTED]>: > Rob Shearman gmail.com> writes: >> 2008/9/15 Louis Lenders yahoo.co.uk>: >> > Rob Shearman gmail.com> writes: >> I suggest you write a test case that replicates what the >> application does and either send it to wine-patches >> with appropriate tod

Re: Wine PulseAudio Driver

2008-09-28 Thread Maarten Lankhorst
Hi Arthur, 2008/9/27, Arthur Taylor <[EMAIL PROTECTED]>: > "If someone wants to write a pulseaudio driver, he should feel free to > do so, but he should be aware that just writing a simple 20 line > linear PCM out driver is not sufficient." > http://bugs.winehq.org/show_bug.cgi?id=10495 > > I have

Re: howto fix bug 13462

2008-09-28 Thread Louis. Lenders
Rob Shearman gmail.com> writes: > > 2008/9/15 Louis Lenders yahoo.co.uk>: > > Rob Shearman gmail.com> writes: > I suggest you write a test case that replicates what the > application does and either send it to wine-patches > with appropriate todo_wine's or attach it to the bug. > > Well, it

Re: [WineHQ] Remove google adds box

2008-09-28 Thread Tom Wickline
Can I object the removal? There will be a WineConf next year right? On Sat, Sep 27, 2008 at 2:28 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: > Was for sponsoring WineConf. > > > > -- http://www.wine-reviews.net/