And while we're on the subject, is "make depend" really
needed anymore? I thought it happened automatically.
I see different advice on the best way to compile in various places. The
http://www.winehq.org/site/docs/wineusr-guide/installing-wine-source user
guide says to run:
$ ./configure
$ make depend
$ make
$ make install
The README in the root of the
2008/9/26 Paul Bryan Roberts <[EMAIL PROTECTED]>:
> @@ -2532,11 +2532,30 @@ BOOL WINAPI LookupAccountNameW( LPCWSTR
> lpSystemName, LPCWSTR lpAccountName, PSI
> {
> if (!strcmpW(lpAccountName, ACCOUNT_SIDS[i].account))
> {
> -if (*cchReferencedDomainName)
> -
2008/9/26 Paul Bryan Roberts <[EMAIL PROTECTED]>:
> +if (!ADVAPI_IsLocalComputer(lpSystemName))
> +{
> +/*FIXME("Only local computer supported!\n");*/
> +SetLastError(ERROR_NONE_MAPPED);
> +return FALSE;
> +}
There's no need to comment this FIXME out.
> @@ -254
Paul Bryan Roberts wrote:
> This is the SECOND of a series of NINE patches ...
When you send a series of 9 patches that depend on each other,
please number them 1/9, 2/9, ... 7/9 in the subject line.
Otherwise patchwatcher will try to apply each patch independently to
current git, which won't work
2008/9/25 Rob Shearman <[EMAIL PROTECTED]>:
> Using a signed constant for an unsigned value isn't good practice. I'd
> recommend defining a constant at the top of the file like so:
> #define SCHANNEL_INVALID_HANDLE ~0UL
>
> And then using that everywhere that you use -1 now.
>
You're right on these
