Re: Flaky test update

2008-09-25 Thread Vitaliy Margolen
Dan Kegel wrote: > On Wed, Sep 24, 2008 at 7:04 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: >> Two tests usually failed: >> >> user32:msg.c 940 >> user32:input.c 756 > > That system doesn't even *have* a mouse, so it wasn't mouse motion. > > As a reality check, I verified that it failed on a > diffe

Re: [4/5] secur32: Allocate schannel client credentials

2008-09-25 Thread Rob Shearman
2008/9/22 Henri Verbeet <[EMAIL PROTECTED]>: > @@ -47,6 +61,7 @@ struct schan_handle > struct schan_credentials > { > ULONG credential_use; > +gnutls_certificate_credentials_t credentials; > }; > > static struct schan_handle *schan_handle_table; > @@ -273,6 +288,7 @@ static SECURITY_ST

Re: [3/5] secur32: Basic implementation of schannel AcquireCredentialsHandle/FreeCredentialsHandle

2008-09-25 Thread Rob Shearman
2008/9/22 Henri Verbeet <[EMAIL PROTECTED]>: > +static ULONG_PTR schan_alloc_handle(void *object, enum schan_handle_type > type) > +{ > +struct schan_handle *handle; > + > +if (schan_free_handles) > +{ > +/* Use a free handle */ > +handle = schan_free_handles; > +

Re: [2/2] oleacc: implemented GetRoleText[A/W] with some tests

2008-09-25 Thread Dmitry Timoshkov
Nikolay Sivov <[EMAIL PROTECTED]> wrote: > +UINT WINAPI GetRoleTextA(DWORD role, LPSTR lpRole, UINT rolemax) > +{ > +UINT length; > +WCHAR *roletext; > +INT ret; > + > +TRACE("%u %p %u\n", role, lpRole, rolemax); > + > +length = GetRoleTextW(role, NULL, 0); > + > +if(!lengt

Re: [2/2] oleacc: implemented GetRoleText[A/W] with some tests

2008-09-25 Thread Alexandre Julliard
Nikolay Sivov <[EMAIL PROTECTED]> writes: > +UINT WINAPI GetRoleTextA(DWORD role, LPSTR lpRole, UINT rolemax) > +{ > +UINT length; > +WCHAR *roletext; > +INT ret; > + > +TRACE("%u %p %u\n", role, lpRole, rolemax); > + > +length = GetRoleTextW(role, NULL, 0); > + > +if(!leng

Re: comctl32: comboex - fix some unintialized variables

2008-09-25 Thread Austin English
On Wed, Sep 24, 2008 at 8:45 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > You wrote: >> Fixes a compiler bug when using gcc-4.1 > > Wait- which is it, uninitialized variables (as your subject line > said), or a compiler bug (as your message said)? Didn't mean to send this one yet, was saving it as a

Re: msi: add stub for MsiDetermineApplicablePatches{A,W} (resend)

2008-09-25 Thread James Hawkins
On Thu, Sep 25, 2008 at 2:10 AM, Louis. Lenders <[EMAIL PROTECTED]> wrote: > Resend: removed spaces around brackets, and added also A-version. > > +/*** + * * MsiDetermineApplicablePatchesA [EMAIL PROTECTED] + * */ Copy/pa

Re: msi: add stub for MsiDetermineApplicablePatchesW

2008-09-25 Thread Louis. Lenders
- Original Message From: James Hawkins <[EMAIL PROTECTED]> >The vast majority of this file does not put spaces around parenthesis, >so can you resend with that fixed? well, the last functions from that file do put the spaces around them, but if you prefer otherwise, i'll resend