re: comctl32: comboex - fix some unintialized variables

2008-09-24 Thread Dan Kegel
You wrote: > Fixes a compiler bug when using gcc-4.1 Wait- which is it, uninitialized variables (as your subject line said), or a compiler bug (as your message said)? If it's a compiler bug, which one? Probably http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24639, right? Would setting the fields t

RE: [5/5] wined3d: Handle texture coordinates the same way we handle other vertex attributes

2008-09-24 Thread Stefan Dösinger
> Yeah, although I wouldn't be opposed to simply making ARB_multitexture > a hard requirement either. I doubt there are any configurations left > that don't support multitexture but that would otherwise be able to > run Wine. I guess(and we discussed that on IRC, just adding it for the sake of the

Re: user32:input.c fails only when run from make?!

2008-09-24 Thread Dan Kegel
On Wed, Sep 24, 2008 at 12:50 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: >... On my Levnovo x60 running Hardy, > the user32 test input.c fails when run from make > nearly all of the time, but doesn't fail if run standalone. FWIW, running the test under valgrind makes it fail reliably with input.c:7

user32:input.c fails only when run from make?!

2008-09-24 Thread Dan Kegel
Here's an odd one. On my Levnovo x60 running Hardy, with or without metacity-2.23.8 built from source, the user32 test input.c fails when run from make nearly all of the time, but doesn't fail if run standalone. The problem persists even with a trivial makefile, e.g. foo.ok: env WINETEST_

Re: [5/5] wined3d: Handle texture coordinates the same way we handle other vertex attributes

2008-09-24 Thread Henri Verbeet
2008/9/24 Stefan Dösinger <[EMAIL PROTECTED]>: > Here's a thought regarding handling the lack of GL_ARB_multitexture support. > Since pretty much all cards out there have multitexture support(even my > junky Mach64 card), we could just use one texcoord function array, and if > multitextures are rea

Re: msi: add stub for MsiDetermineApplicablePatchesW

2008-09-24 Thread James Hawkins
On Wed, Sep 24, 2008 at 1:12 PM, Louis. Lenders <[EMAIL PROTECTED]> wrote: > This is the 2nd stub needed to let .net 2.0 SP1 installer finish fine. I'll > resend the first one (corrected) > The vast majority of this file does not put spaces around parenthesis, so can you resend with that fixed? +

Re: secur32: Fix a failing test in win95

2008-09-24 Thread James Hawkins
On Wed, Sep 24, 2008 at 6:23 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > On Wed, Sep 24, 2008 at 12:47 PM, James Hawkins > <[EMAIL PROTECTED]> wrote: >> On Wed, Sep 24, 2008 at 5:30 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: >>> On Wed, Sep 24, 2008 at 10:06 AM, James Hawkins >>> <[EMAIL PROTECTED

Re: Flaky test update

2008-09-24 Thread Dan Kegel
On Wed, Sep 24, 2008 at 7:04 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > Two tests usually failed: > > user32:msg.c 940 > user32:input.c 756 And here's histogram of first error message in the user32:input.c failures: 156 user32:input.c:740: Test failed: a4/0: the msg sequence is not complete: e

Re: d3dx9: Add d3dx9effect.h

2008-09-24 Thread Alexandre Julliard
Busquets Pérez Luis C. <[EMAIL PROTECTED]> writes: > +typedef struct D3DXEFFECT_DESC { > +LPCSTR Creator; > +UINT Parameters; > +UINT Techniques; > +UINT Functions; > +} D3DXEFFECT_DESC, *LPD3DXEFFECT_DESC; > + > +typedef struct D3DXPARAMETER_DESC { > +LPCSTR Name; > +LPCST

RE: [5/5] wined3d: Handle texture coordinates the same way we handle other vertex attributes

2008-09-24 Thread Stefan Dösinger
Here's a thought regarding handling the lack of GL_ARB_multitexture support. Since pretty much all cards out there have multitexture support(even my junky Mach64 card), we could just use one texcoord function array, and if multitextures are really not supported, use a wrapper function that calls th

Flaky test update

2008-09-24 Thread Dan Kegel
Here's some data over 1042 test runs over the last three weeks, all on a dual core Ubuntu 8.04 linux box with a cheap nVidia GeForce 8500 GT graphics card. Three tests crashed from 1% to 10% of the time (as opposed to failed): ddraw 136 d3d9 48 d3d8 12 Three tests always failed: urlmon:protoc

Re: Patchwatcher problems

2008-09-24 Thread Dan Kegel
Rob Shearman <[EMAIL PROTECTED]> wrote: > Dan, I believe it would fix things if you were to change > patchwatcher.sh to use "git apply" instead of patch. It might also be > able to guess the p value better for patches generated by diff, CVS > and SVN. OK, sounds like a must. Thanks for diagnosing

Re: secur32: Fix a failing test in win95

2008-09-24 Thread Paul Vriens
On Wed, Sep 24, 2008 at 12:47 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > On Wed, Sep 24, 2008 at 5:30 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: >> On Wed, Sep 24, 2008 at 10:06 AM, James Hawkins >> <[EMAIL PROTECTED]> wrote: >>> Hi, >>> >>> Changelog: >>> * Fix a failing test in win95. >>> >>>

Re: secur32: Fix compilation with GNU TLS 1.0.16.

2008-09-24 Thread Henri Verbeet
2008/9/24 Henri Verbeet <[EMAIL PROTECTED]>: > I don't think that'll work, this is what newer versions of gnutls have: Ignore that, I should've actually tried the patch instead of looking at the header. gnutls_certificate_credentials is defined as gnutls_certificate_credentials_t in gnutls/compat.h

Re: secur32: Fix compilation with GNU TLS 1.0.16.

2008-09-24 Thread Henri Verbeet
2008/9/24 Francois Gouget <[EMAIL PROTECTED]>: > --- > > On my system I have libgnutls11-dev 1.0.16-14+b1 which has > gnutls_certificate_credentials but not the corresponding ..._t type. So > this patch lets it compile on my system. Hopefully it will still work > with the newer headers (otherwise w

Re: secur32: Fix a failing test in win95

2008-09-24 Thread James Hawkins
On Wed, Sep 24, 2008 at 5:30 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > On Wed, Sep 24, 2008 at 10:06 AM, James Hawkins > <[EMAIL PROTECTED]> wrote: >> Hi, >> >> Changelog: >> * Fix a failing test in win95. >> >> dlls/secur32/tests/main.c |3 ++- >> 1 files changed, 2 insertions(+), 1 deleti

Re: secur32: Fix a failing test in win95

2008-09-24 Thread Paul Vriens
On Wed, Sep 24, 2008 at 10:06 AM, James Hawkins <[EMAIL PROTECTED]> wrote: > Hi, > > Changelog: > * Fix a failing test in win95. > > dlls/secur32/tests/main.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > -- > James Hawkins > But if the result is SEC_E_UNSUPPORTED_FUNCTION it'