Re: Patchwatcher problems

2008-09-23 Thread Rob Shearman
2008/9/24 Andrew Fenn <[EMAIL PROTECTED]>: > On Fri, Sep 19, 2008 at 6:27 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: >> Andrew Fenn wrote: >>> I just submitted a patch to wine patches (Started implementing the >>> xinput library for xbox 360 joystick support ) and I believe patch >>> watcher failed f

Re: Call SetLastError() in ParseStringAclToAcl() to correct Conformance Test failure

2008-09-23 Thread James Hawkins
On Wed, Sep 24, 2008 at 1:19 AM, Paul Bryan Roberts <[EMAIL PROTECTED]> wrote: > From 2f6d33f2d66e252bbd6ad3bc0f3e93a1fb780485 Mon Sep 17 00:00:00 2001 > From: Paul Bryan Roberts <[EMAIL PROTECTED]> > Date: Wed, 24 Sep 2008 06:57:33 +0100 > Subject: Call SetLastError() in ParseStringAclToAcl() to

Re: secur32: Add kerberos tests. (try 3)

2008-09-23 Thread Kai Blin
On Wednesday 24 September 2008 06:24:15 Kai Blin wrote: This breaks on Win2k3 and newer. It worked on XP, dammit. I'll have to poke this some more tomorrow. Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developerhttp://wiki.winehq.org/KaiBlin Samba team member

Re: secur32: Add kerberos tests. (try 2)

2008-09-23 Thread Kai Blin
On Wednesday 24 September 2008 05:32:20 Kai Blin wrote: Aw, coding while being jet-lagged sucks. I'll resend a version without warnings and memory leaks. Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developerhttp://wiki.winehq.org/KaiBlin Samba team member h

Re: secur32: Add kerberos tests.

2008-09-23 Thread Kai Blin
On Wednesday 24 September 2008 04:18:42 Kai Blin wrote: Actually, never mind this one. I just realized one of the tests doesn't run on windows after all. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developerhttp://wiki.winehq.org/KaiBlin Samba team mem

Re: Patchwatcher problems

2008-09-23 Thread Andrew Fenn
On Fri, Sep 19, 2008 at 6:27 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > Andrew Fenn wrote: >> I just submitted a patch to wine patches (Started implementing the >> xinput library for xbox 360 joystick support ) and I believe patch >> watcher failed for a few reasons. >> >>1) Although it applied my

Re: Curious Behaviour

2008-09-23 Thread Vitaliy Margolen
Chris Ahrendt wrote: > Vitaliy Margolen wrote: >> Chris Ahrendt wrote: >> >>> I also noticed another bit of weirdness as well... If the application >> You missing the part that those dlls where loaded successfully. You keep >> looking for problems in the wrong places. >> > That is incorrect.. they

Re: Curious Behaviour

2008-09-23 Thread Chris Ahrendt
Vitaliy Margolen wrote: > Chris Ahrendt wrote: > >> I also noticed another bit of weirdness as well... If the application > You missing the part that those dlls where loaded successfully. You keep > looking for problems in the wrong places. > > Vitaliy That is incorrect.. they didnt load is the

Re: gdi32: "StretchDIBits" with value of zero for "xSrc" and "ySrc"

2008-09-23 Thread Vitaliy Margolen
Mathias Kosch wrote: >> +assert(hDC != NULL); >> dont' use assert() in the tests, especially for conditions such as >> this which have nothing to do with the function you're testing. [...] >> or use ok to check them if there's some reasonable probability they >> may fail > > Vitaliy Margolen r

Re: Curious Behaviour

2008-09-23 Thread Vitaliy Margolen
Chris Ahrendt wrote: > I also noticed another bit of weirdness as well... If the application You missing the part that those dlls where loaded successfully. You keep looking for problems in the wrong places. Vitaliy

Re: Curious Behaviour

2008-09-23 Thread Chris Ahrendt
Vitaliy Margolen wrote: > Chris Ahrendt wrote: >> When I turned on the debugging flag +ntdll I noticed a rather strange >> behavior in wine. But before I open a bug on it I wanted to understand >> how the shared libraries that emulate the various windows dll's are >> handled. When I turned on th

Re: Re[2]: gdi32: "StretchDIBits" with value of zero for "xSrc" and "ySrc"

2008-09-23 Thread Juan Lang
Hi Mathias, >> + * mkosch (2008/09/22) >> Please don't put such comments in source files, the source files >> aren't a changelog. > Is there a right place for such comments? I meant your name and the date in particular. The rest of the comment is probably okay, though a FIXME wou

Re[2]: gdi32: "StretchDIBits" with value of zero for "xSrc" and "ySrc"

2008-09-23 Thread Mathias Kosch
Hello Juan! Thanks for your valuable comments. > + * mkosch (2008/09/22) > Please don't put such comments in source files, the source files > aren't a changelog. Is there a right place for such comments? Since I didn't yet prove if this code is buggy and also don't want to investig

Re: wine.inf.in: create default key App Paths (and key for IEXPLORE)

2008-09-23 Thread James Hawkins
On Tue, Sep 23, 2008 at 12:23 PM, Louis. Lenders <[EMAIL PROTECTED]> wrote: > > As for the patch for MsiSetExternalUIRecord , i compared again with de > definition at http://msdn.microsoft.com/en-us/library/aa370385(VS.85).aspx, > but i don't see a problem there. Also i matched the definition for >

Re: wine.inf.in: create default key App Paths (and key for IEXPLORE)

2008-09-23 Thread Louis. Lenders
- Original Message From: Alexandre Julliard <[EMAIL PROTECTED]> "Louis. Lenders" <[EMAIL PROTECTED]> writes: > Hi, the key HKLM//Software\\Microsoft\\Windows\\CurrentVersion\\App Paths is > needed by LexWare installer (bug http://bugs.winehq.org/show_bug.cgi?id=15347) > > This patc

Re: [4/5] wined3d: Merge pshader_hw_map2gl() and vshader_hw_map2gl()

2008-09-23 Thread Henri Verbeet
2008/9/23 Ivan Gyurdiev <[EMAIL PROTECTED]>: > >> This isn't the prettiest way to merge those functions, but it's a start > > Will you be cleaning this up further to get rid of the huge if-else ? > I think at least all the MOV-specific stuff should go in its own instr. > function. > > Ivan > Eventu

Re: [4/5] wined3d: Merge pshader_hw_map2gl() and vshader_hw_map2gl()

2008-09-23 Thread Ivan Gyurdiev
> This isn't the prettiest way to merge those functions, but it's a start Will you be cleaning this up further to get rid of the huge if-else ? I think at least all the MOV-specific stuff should go in its own instr. function. Ivan

Re: wine.inf.in: create default key App Paths (and key for IEXPLORE)

2008-09-23 Thread Alexandre Julliard
"Louis. Lenders" <[EMAIL PROTECTED]> writes: > Hi, the key HKLM//Software\\Microsoft\\Windows\\CurrentVersion\\App Paths is > needed by LexWare installer (bug http://bugs.winehq.org/show_bug.cgi?id=15347) > > This patch creates that key by default, but also creates the key for IEXPLORE > along t

Re: gdi32: "StretchDIBits" with value of zero for "xSrc" and "ySrc"

2008-09-23 Thread Alexandre Julliard
"Juan Lang" <[EMAIL PROTECTED]> writes: > +// Initializing random number generator: > In the first place, such a comment is unnecessary, is it's quite clear > what the following line does. In the second place, C++-style comments > are not allowed in Wine source. More importantly, a test shou

Re: Jacek Caban : jscript: Added with statement implementation.

2008-09-23 Thread Michael Stefaniuc
Hello Jacek, this patch introduces a gcc warning: dlls/jscript/engine.c:954: warning: empty body in an if-statement Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: dfb867af56f4b15986482deef588d33d2458b101 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=dfb867af5