Re: kernel32: fix PROFILE_Load to handle mac line endings (try 3)

2008-09-22 Thread Erik Inge Bolsø
On Sun, 21 Sep 2008, Michael Karcher wrote: > Am Sonntag, den 21.09.2008, 15:13 +0200 schrieb Erik Inge Bolsø: > > Without modifying the test messages, we'll only get > > a line number, and no mention of which data caused the test to fail. > You just look some lines upwards to the trace output. It

Re: kernel32: fix PROFILE_Load to handle mac line endings (try 3)

2008-09-22 Thread Erik Inge Bolsø
On Sun, 21 Sep 2008, Michael Karcher wrote: > Am Sonntag, den 21.09.2008, 02:15 +0200 schrieb Erik Inge Bolsø: > > +ok(1, "%s\n", content); > Please use trace(...) instead of ok(1,...). Also, outputting a string > with newline characters might be irritating, especially as one might > need a hex

Re: Simplify dlls/atl/registrar.c

2008-09-22 Thread Gerald Pfeifer
On Tue, 9 Sep 2008, Rob Shearman wrote: >> -static HRESULT Registrar_create(const IUnknown *pUnkOuter, REFIID riid, >> void **ppvObject) >> +static HRESULT Registrar_create(REFIID riid, void **ppvObject) > A test needs to be added to see whether or not the Registrar class > factory supports aggreg

[Fwd: gdi32: "StretchDIBits" with value of zero for "xSrc" and "ySrc"]

2008-09-22 Thread James McKenzie
+/* This might not work for values of "dwRop" much different than "SRCCOPY". + * Further testing is required. + * mkosch (2008/09/22) + */ Add a test case for this if it is possible and test it, if possible. Then you will know if it

Re: gdi32: "StretchDIBits" with value of zero for "xSrc" and "ySrc"

2008-09-22 Thread Juan Lang
Hi Mathias, + * mkosch (2008/09/22) Please don't put such comments in source files, the source files aren't a changelog. +hProcessHeap = GetProcessHeap(); +assert(hProcessHeap != NULL); This assert is pointless, GetProcessHeap cannot reasonably fail. And more generally..

Re: Curious Behaviour

2008-09-22 Thread Vitaliy Margolen
Chris Ahrendt wrote: > When I turned on the debugging flag +ntdll I noticed a rather strange > behavior in wine. But before I open a bug on it I wanted to understand > how the shared libraries that emulate the various windows dll's are > handled. When I turned on the +ntdll flag I started gettin

Re: configure.ac: add -Werror to default compiler options

2008-09-22 Thread Maarten Lankhorst
Hi All, Rob Shearman schreef: > 2008/9/18 Austin English <[EMAIL PROTECTED]>: > >> Should help avoid bugs like bug 15266 and promote more proper, portable code. >> > > >> Tried compiling Wine with -Werror, got a few interesting results. First one: >> >> [EMAIL PROTECTED]:~/wine-git/dlls

Curious Behaviour

2008-09-22 Thread Chris Ahrendt
When I turned on the debugging flag +ntdll I noticed a rather strange behavior in wine. But before I open a bug on it I wanted to understand how the shared libraries that emulate the various windows dll's are handled. When I turned on the +ntdll flag I started getting several file not found erro

Re: msvcrt: scanf fix a typo

2008-09-22 Thread Austin English
On Mon, Sep 22, 2008 at 5:27 AM, Francois Gouget <[EMAIL PROTECTED]> wrote: > On Sat, 20 Sep 2008, Michael Karcher wrote: > [...] >> Looks like we need to compile with -fno-builtin-sscanf, because gcc >> knows the implementation of glibc's sscanf, and you explicitly have to >> forbid it to use this

Re: What broken in ubuntu Wine packages?

2008-09-22 Thread Chris Robinson
On Monday 22 September 2008 06:23:57 am Vitaliy Margolen wrote: > I'm not talking about debug symbols - those are stripped in all binary > packages. The issue is winedbg can't even start & attach to the process > properly. It's either a race of sorts, or something preventing it from > starting pro

re: msvcrt: scanf fix a typo

2008-09-22 Thread Francois Gouget
On Sat, 20 Sep 2008, Michael Karcher wrote: [...] > Looks like we need to compile with -fno-builtin-sscanf, because gcc > knows the implementation of glibc's sscanf, and you explicitly have to > forbid it to use this knowledge which does not apply perfectly to > Microsofts sscanf. This (of course)

Re: configure.ac: add -Werror to default compiler options

2008-09-22 Thread Francois Gouget
On Fri, 19 Sep 2008, Dan Kegel wrote: [...] > So my alternate suggestion is for patchwatcher to reject patches that > fail with -Werror. > (And work around the couple of bogus errors I listed above.) It does not even have to build with -Werror, just to grep the log for warnings, and warn if there

Re: What broken in ubuntu Wine packages?

2008-09-22 Thread Darragh Bailey
On Mon, Sep 22, 2008 at 07:23:57AM -0600, Vitaliy Margolen wrote: > Darragh Bailey wrote: > > On Sun, Sep 21, 2008 at 04:38:15PM -0600, Vitaliy Margolen wrote: > > Believe that building deb packages will strip debuging symbols from the > > binaries but unlike rpm does not by default create a debug

Re: wine.inf.in: create default key App Paths (and key for IEXPLORE)

2008-09-22 Thread Michael Karcher
Am Montag, den 22.09.2008, 15:42 + schrieb Louis. Lenders: > btw, was there anything wrong with this patch: > http://www.winehq.org/pipermail/wine-patches/attachments/20080918/e269df3c/attachment.txt > ? As you were already told, IIRC, please do not link attachment, but mails. In this case: h

Re: gdi32: "StretchDIBits" with value of zero for "xSrc" and "ySrc"

2008-09-22 Thread Vitaliy Margolen
Mathias Kosch wrote: > This path fixes Bug#13344. > > The function "StretchDIBits" behaves odd in case of "top-down" bitmaps > with values of zero for "xSrc" and "ySrc". Tests using Windows Server > 2003 shew that in this particular case the source rectangle is > selected starting at the upper lef

Re: What broken in ubuntu Wine packages?

2008-09-22 Thread Vitaliy Margolen
Darragh Bailey wrote: > On Sun, Sep 21, 2008 at 04:38:15PM -0600, Vitaliy Margolen wrote: >> Almost all bugs that come from Ubuntu users don't have usable backtraces. >> Instead they have this: >> >> Process of pid=0008 has terminated >> No process loaded, cannot execute 'echo Modules:' >> Cannot g

Re: What broken in ubuntu Wine packages?

2008-09-22 Thread Darragh Bailey
On Sun, Sep 21, 2008 at 04:38:15PM -0600, Vitaliy Margolen wrote: > Almost all bugs that come from Ubuntu users don't have usable backtraces. > Instead they have this: > > Process of pid=0008 has terminated > No process loaded, cannot execute 'echo Modules:' > Cannot get info on module while no pr

Re: What broken in ubuntu Wine packages?

2008-09-22 Thread Roderick Colenbrander
Perhaps debug info is compiled out or so. For example I just saw this bug: http://bugs.winehq.org/show_bug.cgi?id=15368 The game crashes somewhere in ddraw/wined3d but it only shows crap like: Backtrace: =>1 0x7eb1b014 in ddraw (+0xb014) (0x0032f6d4) 2 0x7e5b6c7f in wined3d (+0x36c7f) (0x0032f83