Re: msvcrt: scanf fix a typo

2008-09-19 Thread Austin English
On Fri, Sep 19, 2008 at 5:51 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > Here's the gcc error: >> scanf.c:66: warning: unknown conversion type character `P' in format > > I'm not a programmer, but I play one on TV. And here's what I > came up with in five minutes of typing and not enough thinking:

re: msvcrt: scanf fix a typo

2008-09-19 Thread Dan Kegel
Here's the gcc error: > scanf.c:66: warning: unknown conversion type character `P' in format I'm not a programmer, but I play one on TV. And here's what I came up with in five minutes of typing and not enough thinking: That particular error depends on gcc knowing intimate details of sscanf. Un

Re: msvcrt: scanf fix a typo

2008-09-19 Thread Austin English
On Fri, Sep 19, 2008 at 6:14 PM, Paul Vriens <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: >> >> On Fri, Sep 19, 2008 at 4:59 PM, Austin English <[EMAIL PROTECTED]> >> wrote: >>> >>> Relevant code: >>> /* check %p with no hex digits */ >>> ok( sscanf("1233", "%p", &ptr) == 1, "sscanf failed

Re: msvcrt: scanf fix a typo

2008-09-19 Thread Paul Vriens
James Hawkins wrote: > On Fri, Sep 19, 2008 at 4:59 PM, Austin English <[EMAIL PROTECTED]> wrote: >> Relevant code: >>/* check %p with no hex digits */ >>ok( sscanf("1233", "%p", &ptr) == 1, "sscanf failed\n" ); >>ok( ptr == (void *)0x1233,"sscanf reads %p instead of %x\n", ptr, 0x1233

Re: msvcrt: scanf fix a typo

2008-09-19 Thread Juan Lang
> Relevant code: >/* check %p with no hex digits */ >ok( sscanf("1233", "%p", &ptr) == 1, "sscanf failed\n" ); >ok( ptr == (void *)0x1233,"sscanf reads %p instead of %x\n", ptr, 0x1233 ); > >ok( sscanf("1234", "%P", &ptr) == 1, "sscanf failed\n" ); >ok( ptr == (void *)0x1234,"

Re: msvcrt: scanf fix a typo

2008-09-19 Thread James Hawkins
On Fri, Sep 19, 2008 at 4:59 PM, Austin English <[EMAIL PROTECTED]> wrote: > > Relevant code: >/* check %p with no hex digits */ >ok( sscanf("1233", "%p", &ptr) == 1, "sscanf failed\n" ); >ok( ptr == (void *)0x1233,"sscanf reads %p instead of %x\n", ptr, 0x1233 ); > >ok( sscanf("12

Re: msvcrt: scanf fix a typo

2008-09-19 Thread Austin English
On Fri, Sep 19, 2008 at 4:51 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > On Fri, Sep 19, 2008 at 4:39 PM, Austin English <[EMAIL PROTECTED]> wrote: >> Found using -Werror (strangely, didn't occur on ubuntu, but does on >> PC-BSD)...Must be the gcc version. >> > > @@ -63,7 +63,7 @@ static void te

Re: msvcrt: scanf fix a typo

2008-09-19 Thread James Hawkins
On Fri, Sep 19, 2008 at 4:39 PM, Austin English <[EMAIL PROTECTED]> wrote: > Found using -Werror (strangely, didn't occur on ubuntu, but does on > PC-BSD)...Must be the gcc version. > @@ -63,7 +63,7 @@ static void test_sscanf( void ) ok( sscanf("1233", "%p", &ptr) == 1, "sscanf failed\n" );

Re: PrintDlgEx [2/7]: Add basic dialog.

2008-09-19 Thread Michael Stefaniuc
Detlef Riekenberg wrote: > On Do, 2008-09-18 at 09:58 +0200, Michael Stefaniuc wrote: > >> there is no point in adding new resources in English to the other >> languages rc files. If a resource doesn't exist Win32 will automatically >> fail over to use the en_US version. > > According to julliard

Re: winex11.drv: Make wglShareLists() cope with previously selected destination context (try 3)

2008-09-19 Thread Roderick Colenbrander
> > Resending to the proper email address, this time.. > > And I likewise ;) (I was just thinking, "I swear I hit Reply All"...) > > > The referred to "lists" aren't display lists. > > It's more appropritely (specific > > sets of) resources.. eg. the list of valid textures, the > > list of valid

WebKit vs Gecko and Wine

2008-09-19 Thread Vijay Kiran Kamuju
Hi, I have a nice idea to discuss at wineconf this year. Is it possible to use webkit for mshtml and jscript implementations of wine? Have been hearing a lotta good reviews about performance of webkit and lotta other browsers adopting it. How much work would it be to support webkit as to provide a

Re: PrintDlgEx [2/7]: Add basic dialog.

2008-09-19 Thread Detlef Riekenberg
On Do, 2008-09-18 at 09:58 +0200, Michael Stefaniuc wrote: > there is no point in adding new resources in English to the other > languages rc files. If a resource doesn't exist Win32 will automatically > fail over to use the en_US version. According to julliard a while ago, this is not the case.

Re: [PATCH 6/7] d3dx9/tests: Test D3DXCheckTextureRequirements.

2008-09-19 Thread Philip Nilsson
On Fri, Sep 19, 2008 at 07:07:18PM +0200, Henri Verbeet wrote: > 2008/9/19 Philip Nilsson <[EMAIL PROTECTED]>: > > This one could use some more work, but I think the tests will pass in > > most cases (except in strange environments without support for common > > formats). > > > The tests should pas

Re: [PATCH 7/7] d3dx9/tests: Test D3DXCreateTexture.

2008-09-19 Thread Philip Nilsson
On Fri, Sep 19, 2008 at 07:10:29PM +0200, Henri Verbeet wrote: > I think it would be a good idea to test the parameters (format, width, > height, miplevels) of the created texture. I used to do that, but most of the things you can check are just duplicates of the checks in D3DCheckTextureRequireme

Re: configure.ac: add -Werror to default compiler options

2008-09-19 Thread Dan Kegel
OK, I just ran with -Wall -Werror, and got a grand total of four errors: freetype.c:1051: warning: 'name.string_len' is used uninitialized in this function Looks bogus. engine.c:2128: warning: 'str' may be used uninitialized in this function Bogus. context.c:80: warning: 'update_minfilter' may b

Re: [PATCH 3/7] d3dx9: Implement D3DXCheckTextureRequirements.

2008-09-19 Thread Philip Nilsson
Hi! On Fri, Sep 19, 2008 at 07:04:04PM +0200, Henri Verbeet wrote: > 2008/9/19 Philip Nilsson <[EMAIL PROTECTED]>: > > > +hr = IDirect3DDevice9_GetDirect3D(device, &d3d9); > > +if (hr != D3D_OK || !device) > > +return D3DERR_INVALIDCALL; > > + > > +IDirect3D9_G

Re: configure.ac: add -Werror to default compiler options

2008-09-19 Thread Marcus Meissner
On Fri, Sep 19, 2008 at 04:35:45PM +0200, Alexandre Julliard wrote: > "Dan Kegel" <[EMAIL PROTECTED]> writes: > > > Agreed, to an extent. A user who is trying to compile with a really > > whacky toolchain (say, a C compiler on an Amiga, a mainframe, or a > > wristwatch) > > should expect some e

Re: [PATCH 3/7] d3dx9: Implement D3DXCheckTextureRequirements.

2008-09-19 Thread Henri Verbeet
2008/9/19 Philip Nilsson <[EMAIL PROTECTED]>: > +hr = IDirect3DDevice9_GetDirect3D(device, &d3d9); > +if (hr != D3D_OK || !device) > +return D3DERR_INVALIDCALL; > + > +IDirect3D9_GetAdapterDisplayMode(d3d9, D3DADAPTER_DEFAULT, &d3ddm); > + > +/* TODO: Us

Re: [PATCH 6/7] d3dx9/tests: Test D3DXCheckTextureRequirements.

2008-09-19 Thread Henri Verbeet
2008/9/19 Philip Nilsson <[EMAIL PROTECTED]>: > This one could use some more work, but I think the tests will pass in > most cases (except in strange environments without support for common > formats). > The tests should pass everywhere. I think you should be testing for consistency between CheckDe

Re: [PATCH 7/7] d3dx9/tests: Test D3DXCreateTexture.

2008-09-19 Thread Henri Verbeet
I think it would be a good idea to test the parameters (format, width, height, miplevels) of the created texture.

Re: [PATCH 4/7] d3dx9: Add a D3DXCreateTexture stub.

2008-09-19 Thread Henri Verbeet
2008/9/19 Philip Nilsson <[EMAIL PROTECTED]>: > +if (ret != D3D_OK) > +return ret; > + > +return D3D_OK; This doesn't really make sense.

Re: PrintDlgEx [1/7]: Add common failure checks and a trace.

2008-09-19 Thread Juan Lang
Hi Gal, please bottom post here. > I indeed submitted a set of tests that included these cases. Specifically: > > http://www.nabble.com/PrintDlgEx-tests--7-9-%3A-Add-tests-for-PD_RETURNDEFAULT.-td19293210.html#a19293210 > > http://www.nabble.com/PrintDlgEx-tests--9-9-%3A-Add-a-test-for-PD_RETURND

Re: configure.ac: add -Werror to default compiler options

2008-09-19 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > Agreed, to an extent. A user who is trying to compile with a really > whacky toolchain (say, a C compiler on an Amiga, a mainframe, or a wristwatch) > should expect some errors, and we should not try to avoid those if they > reflect > real problems that

Re: configure.ac: add -Werror to default compiler options

2008-09-19 Thread Dan Kegel
On Fri, Sep 19, 2008 at 1:17 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > A compile failure is a serious bug, and we should do everything > possible to avoid them. Agreed, to an extent. A user who is trying to compile with a really whacky toolchain (say, a C compiler on an Amiga, a mainfr

Re: winex11.drv: Make wglShareLists() cope with previously selected destination context (try 3)

2008-09-19 Thread Jim Cameron
> Resending to the proper email address, this time.. And I likewise ;) (I was just thinking, "I swear I hit Reply All"...) > The referred to "lists" aren't display lists. > It's more appropritely (specific > sets of) resources.. eg. the list of valid textures, the > list of valid shader > objec

Re: winex11.drv: Make wglShareLists() cope with previously selected destination context (try 3)

2008-09-19 Thread Chris Robinson
Resending to the proper email address, this time.. On Friday 19 September 2008 06:37:03 am Jim Cameron wrote: > > MSDN clearly mentions > > that the hglrc2 parameter shouldn't contain any existing > > display lists, so this situation isn't allowed. This > > would mean wglShareLists(dest, source) i

Re: winex11.drv: Make wglShareLists() cope with previously selected destination context (try 3)

2008-09-19 Thread Jim Cameron
> First of all note that glXDestroyContext only destroys a > context after no of the other threads is using it (it is in > the specs of glXDestroyContext). Surely this means we've got to be doubly careful about keeping track of contexts that are current, otherwise we'd end up with WGL contexts ba

Re: configure.ac: add -Werror to default compiler options

2008-09-19 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > On Thu, Sep 18, 2008 at 5:54 PM, Juan Lang <[EMAIL PROTECTED]> wrote: >> If a commit doesn't break on Alexandre's [and patchwatcher's] box, >> and it gets committed, but it does break on some other machine, what >> then? Who fixes it? > > I suppose the an