There's some code sharing between PrintDlg and PrintDlgEx, and a
potential for more, but it's definitely _possible_ to separate them
into two different files. I'm not sure it's the best thing to do
though.
On Thu, Sep 18, 2008 at 1:55 PM, Vitaly Lipatov <[EMAIL PROTECTED]> wrote:
> What about move
Thanks so much. I wish I had that info earlier so that I wouldn't have
had to edit all these resources by hand. :-)
-Gal
On Thu, Sep 18, 2008 at 3:58 AM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote:
> Hello Gal,
>
> there is no point in adding new resources in English to the other
> languages rc
Hi Juan,
I indeed submitted a set of tests that included these cases. Specifically:
http://www.nabble.com/PrintDlgEx-tests--7-9-%3A-Add-tests-for-PD_RETURNDEFAULT.-td19293210.html#a19293210
http://www.nabble.com/PrintDlgEx-tests--9-9-%3A-Add-a-test-for-PD_RETURNDEFAULT-that-is-specific-to-PrintD
On Thu, Sep 18, 2008 at 8:46 PM, Dan Kegel <[EMAIL PROTECTED]> wrote:
> On Thu, Sep 18, 2008 at 5:17 PM, James Hawkins <[EMAIL PROTECTED]> wrote:
>> I think the important thing for Dan's case is that he also used -Wall,
>> which we should never turn on by default, especially not with -Werror.
>> C
> I suppose the answer there is "patchwatcher builds with multiple compilers"
> and/or "affected users with bum compilers turn off -Werror"
> and/or "we disable the errors that have high failure rates on some compilers".
Sure, that makes as much sense as what I suggested. Consider me
mollified, b
On Thu, Sep 18, 2008 at 5:54 PM, Juan Lang <[EMAIL PROTECTED]> wrote:
> If a commit doesn't break on Alexandre's [and patchwatcher's] box,
> and it gets committed, but it does break on some other machine, what
> then? Who fixes it?
I suppose the answer there is "patchwatcher builds with multiple
> You're pretty negative on this idea, aren't you? Let me whittle away at
> it a bit before we reject it as impractical.
Sure, have fun.
I've used -Wall -Werror with success in the past with a medium-sized
code base, and used it as a stick to keep people from checking in
dodgy code. So it's not
On Thu, Sep 18, 2008 at 5:17 PM, James Hawkins <[EMAIL PROTECTED]> wrote:
> I think the important thing for Dan's case is that he also used -Wall,
> which we should never turn on by default, especially not with -Werror.
> Correct me if I've made an incorrect assumption.
Many serious projects alwa
On Thu, Sep 18, 2008 at 5:10 PM, Juan Lang <[EMAIL PROTECTED]> wrote:
>> Are you sure about that? When I configure with -Wall -Werror,
>> I can't even configure properly; one gets the errors
>>
>> configure: libxrandr development files not found, XRandr won't be supported.
>
> This is precisely pa
Juan wrote:
> Since Rob was noncommittal about whether -Werror was a good or a bad
> idea, I'll take a stance: I think it's a bad one. ...
> some warnings are just plain wrong. In some cases the "fix"
> to quiet the warning is uglier than the warning.
In those cases, we can disable the warning.
On Thu, Sep 18, 2008 at 7:20 PM, Juan Lang <[EMAIL PROTECTED]> wrote:
>> I think the important thing for Dan's case is that he also used -Wall,
>> which we should never turn on by default, especially not with -Werror.
>> Correct me if I've made an incorrect assumption.
>
> -Wall is turned by defau
> I think the important thing for Dan's case is that he also used -Wall,
> which we should never turn on by default, especially not with -Werror.
> Correct me if I've made an incorrect assumption.
-Wall is turned by default:
EXTRACFLAGS="-Wall -pipe"
--Juan
On Thu, Sep 18, 2008 at 7:10 PM, Juan Lang <[EMAIL PROTECTED]> wrote:
>> Are you sure about that? When I configure with -Wall -Werror,
>> I can't even configure properly; one gets the errors
>>
>> configure: libxrandr development files not found, XRandr won't be supported.
>> configure: libxineram
> Are you sure about that? When I configure with -Wall -Werror,
> I can't even configure properly; one gets the errors
>
> configure: libxrandr development files not found, XRandr won't be supported.
> configure: libxinerama development files not found, multi-monitor
> setups won't be supported.
>
Andrew Fenn wrote:
> I just submitted a patch to wine patches (Started implementing the
> xinput library for xbox 360 joystick support ) and I believe patch
> watcher failed for a few reasons.
>
>1) Although it applied my patch it didn't build it as
>./tools/make_makefiles isn't called so it isn't
Stefan Dösinger wrote:
> It is getting better, but still not correct.
>
> Look at how the diffuse and specular colors are handled, and create a call
> table texcoord_funcs to handle the different types.
>
>> -Original Message-
>> From: [EMAIL PROTECTED] [mailto:wine-patches-
>> [EMAIL PRO
Markus Hitter a écrit :
> Hello all,
>
> now, as I get better and better on juggling with the various debugger
> options, I'm at a point where I'd like to get advantage of MS' C++
> runtime debug libraries.
>
> Looking at MSDN, they recommend to turn a few switches in the IDE
> and ... but th
Hi,
one very little thing: You could include d3dx9.h (from d3dx9effect.h)
after the #define __D3DX9EFFECT_H__, as this reduces compile time
slightly when included twice or more. No actual reason to resend though,
just an advice for future.
Best regards,
Tony
Hi,
you forgot the WINAPI in front of the function declaration and
implementation.
Maybe you should add a set_mat(_11, _12, _13, ) macro to make the
exp_mat better to read and not that big in size,
However, I think it's better to dynamically calculate the expected
matrix rather than compare
What about move printdlgex related code in standalone file printdlgex.c?
Is it possible? I see printdlg.c too large already.
В сообщении от 18 сентября 2008 Gal Topper написал(a):
> Changes since last attempt:
> 1) Added a comment to explain the rationale behind the CommonChecks
> function. 2) Res
Hi Aric,
On Thu, Sep 18, 2008 at 9:24 AM, Aric Stewart <[EMAIL PROTECTED]> wrote:
> Humm, according to MSDN:
>
> "If dwMode is set to IME_CONFIG_REGISTERWORD, this parameter must
> indicate a REGISTERWORD structure."
I know, yet Office clearly passes NULL: I wrote the patch to fix a crash in it.
Humm, according to MSDN:
"If dwMode is set to IME_CONFIG_REGISTERWORD, this parameter must
indicate a REGISTERWORD structure."
If windows does not crash in this case, then maybe it would involve
checking for the non-presence of the parameter and returning the correct
error.
So it looks like
Hi,
I just submitted a patch to wine patches (Started implementing the
xinput library for xbox 360 joystick support ) and I believe patch
watcher failed for a few reasons.
1) Although it applied my patch it didn't build it as
./tools/make_makefiles isn't called so it isn't built?
2) Patch watche
Hi Gal,
+ * This function is necessary in order to match the behaviour on
+ * Windows, which seems to do all these checks when PrintDlgEx
+ * is called. It is also necessary in order to replicate a bug in
+ * PrintDlgExA, where S_OK is returned for invalid DevMode or DevNames.
A test case would b
Hi Gal,
+WORD locks;
+if ((locks = (GlobalFlags(lppd->hDevMode) & GMEM_LOCKCOUNT))) {
+WARN("hDevMode has %d locks on it. Unlocking it now\n", locks);
+while(locks--) {
+GlobalUnlock(lppd->hDevMode);
+T
> Maybe patchwatcher could detect new warnings (e.g. using git-blame as I
> described before) and either flag the patch outright as incorrect, or
> give it an intermediate state between bad patches (those that don't
> compile or cause test regressions) and good ones (that compile and don't
> cause
It is getting better, but still not correct.
Look at how the diffuse and specular colors are handled, and create a call
table texcoord_funcs to handle the different types.
> -Original Message-
> From: [EMAIL PROTECTED] [mailto:wine-patches-
> [EMAIL PROTECTED] On Behalf Of Chris Ahrendt
>
On Thu, 18 Sep 2008, Rob Shearman wrote:
[...]
> > engine.c:500: warning: 'hres' is used uninitialized in this function
>
> Or it could just be that they had a different compiler version to you
> and so the warning didn't appear for them. This is the trouble with
> using -Werror in an uncontrolled
Hello Gal,
there is no point in adding new resources in English to the other
languages rc files. If a resource doesn't exist Win32 will automatically
fail over to use the en_US version.
Actually its even detrimental to add the new resources as:
a.) http://pf128.krakow.sdi.tpnet.pl/wine-transl/ ca
Hi,
First of all note that glXDestroyContext only destroys a context after no of
the other threads is using it (it is in the specs of glXDestroyContext). Second
there are some more issues in wglShareLists which shouldn't get fixed in your
patch but which I plan to fix at a later stage which you
2008/9/18 David Adam <[EMAIL PROTECTED]>:
> Hello,
>
>
> +// Pool
>
> C++ comment is forbidden
>
2008/9/18 Busquets Pérez Luis C. <[EMAIL PROTECTED]>:
> +// Selecting and setting a technique
...
> +// Using current technique
...
> +// Managing D3D Device
...
> +// Logging devic
2008/9/18 Austin English <[EMAIL PROTECTED]>:
> Should help avoid bugs like bug 15266 and promote more proper, portable code.
> Tried compiling Wine with -Werror, got a few interesting results. First one:
>
> [EMAIL PROTECTED]:~/wine-git/dlls/jscript$ make
> gcc -c -I. -I. -I../../include -I../../
Rob Shearman gmail.com> writes:
>
> That's not acceptable as that change will cause applications that do
> use the returned interface to either crash on a NULL pointer (if you
> set *ppv to NULL and return S_OK) or stack corruption (if you return a
> pointer to the wrong interface). You will b
33 matches
Mail list logo
