Re: kernel32: Test import entries of a core windows DLL (riched20.dll)

2008-09-04 Thread Paul Vriens
Roy Shea wrote: > --- > dlls/kernel32/tests/Makefile.in|1 + > dlls/kernel32/tests/loader_image.c | 80 > > 2 files changed, 81 insertions(+), 0 deletions(-) > create mode 100644 dlls/kernel32/tests/loader_image.c > > > ---

Re: Patch for vertex > 4 shaders

2008-09-04 Thread Chris Ahrendt
Chris Ahrendt wrote: > >Hmm. Does the application use a fixed function texture coordinate > specified > >with D3DECLUSAGE_FLOAT4? > > I don't know I can look in my logs and see if I see it... > but don't remember off the top of my head at the moment. > > >It should be simple to support this.

Re: Recent msi/package tests failures

2008-09-04 Thread Austin English
On Thu, Sep 4, 2008 at 2:07 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > Austin English wrote: >> >> FWIW, my work XP box times out on quite a few tests, but has system >> restore disabled. >> >> -Austin >> > Hi Austin, > > Could you check something for me on your XP box? > > According to > http://

Patch for vertex > 4 shaders

2008-09-04 Thread Chris Ahrendt
>Hmm. Does the application use a fixed function texture coordinate specified >with D3DECLUSAGE_FLOAT4? I don't know I can look in my logs and see if I see it... but don't remember off the top of my head at the moment. >It should be simple to support this. Essentially the "int coordsToUse = >

Re: [PATCH] buffer overflow checking for string functions

2008-09-04 Thread Marcus Meissner
On Thu, Sep 04, 2008 at 11:34:43AM -0700, Dan Kegel wrote: > Hi Marcus, > http://kegel.com/wine/patchwatcher/results/ shows your patch seems > to have caused a test to fail. The full log is at > http://kegel.com/wine/patchwatcher/results/1045.log > Can you check it and see if it's spurious, or if

re: [PATCH] buffer overflow checking for string functions

2008-09-04 Thread Dan Kegel
Hi Marcus, http://kegel.com/wine/patchwatcher/results/ shows your patch seems to have caused a test to fail. The full log is at http://kegel.com/wine/patchwatcher/results/1045.log Can you check it and see if it's spurious, or if this is something you need to fix up, or if it was a lurking bug? Tha

Re: Patchwatcher status

2008-09-04 Thread Dan Kegel
On Thu, Sep 4, 2008 at 10:39 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > Are there any changes compared to the email notification a week ago? > > I've received several emails about a failure with my patches but it turns > out they were marked as "ignore" or "Patch already in git.". I'm not sure I

Re: Patchwatcher status

2008-09-04 Thread Paul Vriens
Dan Kegel wrote: > Patchwatcher is almost recovered from its move > to the new machine. I expect to turn email > notifications back on tomorrow. > Hi Dan, Are there any changes compared to the email notification a week ago? I've received several emails about a failure with my patches but it t

Re: Patchwatcher status

2008-09-04 Thread Jeff Zaroyko
On Fri, Sep 5, 2008 at 2:45 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > Patchwatcher is almost recovered from its move > to the new machine. I expect to turn email > notifications back on tomorrow. > > The old machine could only just barely keep up with > the patch flow. The new machine is two or

Re: [PATCH] buffer overflow checking for string functions

2008-09-04 Thread Marcus Meissner
On Thu, Sep 04, 2008 at 05:37:45PM +0100, Rob Shearman wrote: > 2008/9/4 Marcus Meissner <[EMAIL PROTECTED]>: > > +#ifndef STATUS_STACK_BUFFER_OVERRUN > > +# define STATUS_STACK_BUFFER_OVERRUN 0xC409 > > +#endif > > +#ifndef EH_NONCONTINUABLE > > +# define EH_NONCONTINUABLE 0x01 > > +#endi

Patchwatcher status

2008-09-04 Thread Dan Kegel
Patchwatcher is almost recovered from its move to the new machine. I expect to turn email notifications back on tomorrow. The old machine could only just barely keep up with the patch flow. The new machine is two or so times faster, so it's much, much better at catching up when a patch flood hi

Re: [PATCH] buffer overflow checking for string functions

2008-09-04 Thread Rob Shearman
2008/9/4 Marcus Meissner <[EMAIL PROTECTED]>: > +#ifndef STATUS_STACK_BUFFER_OVERRUN > +# define STATUS_STACK_BUFFER_OVERRUN 0xC409 > +#endif > +#ifndef EH_NONCONTINUABLE > +# define EH_NONCONTINUABLE 0x01 > +#endif These defines are not used. Either use them or remove them, but I would r

Re: oleaut32: Add support for loading typelibs from NE files.

2008-09-04 Thread Huw Davies
On Wed, Sep 03, 2008 at 12:51:36PM +0100, Rob Shearman wrote: > 2008/9/2 Huw Davies <[EMAIL PROTECTED]>: > > --- a/dlls/oleaut32/typelib.c > > +++ b/dlls/oleaut32/typelib.c > > @@ -64,6 +64,7 @@ > > #include "winnls.h" > > #include "winreg.h" > > #include "winuser.h" > > +#include "wine/winbase1

re: [3/10 AcceptEx] Modifies accept_socket, allows it to take sock structures instead of handles

2008-09-04 Thread Dan Kegel
This patch seemed to cause wineserver to crash. See http://kegel.com/wine/patchwatcher/results http://kegel.com/wine/patchwatcher/results/1033.log http://kegel.com/wine/patchwatcher/results/1034.log

RE: Fix for patchwatcher error in my 16 vertex shader type

2008-09-04 Thread Stefan Dösinger
Well, the patch is still wrong conceptually. See my description in the bug report how to fix it properly > -Original Message- > From: [EMAIL PROTECTED] [mailto:wine-patches- > [EMAIL PROTECTED] On Behalf Of Chris Ahrendt > Sent: Thursday, September 04, 2008 7:58 AM > To: [EMAIL PROTECTED

Re: [PATCH 3/6] shell32: add tests for SHAppBarMessage

2008-09-04 Thread Alexandre Julliard
Vincent Povirk <[EMAIL PROTECTED]> writes: > +/* process messages for 1 second */ > +static void do_events(void) > +{ > +MSG msg; > +UINT_PTR timerid; > + > +timerid = SetTimer(NULL, 0, 1000, NULL); > +while (GetMessageW(&msg, NULL, 0, 0) && > +!(msg.message == WM_TIMER

Re: ntdll/file: Add sub-second resolution to NtQueryInformationFile

2008-09-04 Thread Michael Stefaniuc
Francois Gouget wrote: > On Mon, 18 Aug 2008, Detlef Riekenberg wrote: > >> On So, 2008-08-17 at 19:03 +0200, Michael Karcher wrote: >>> --- >>> configure | 303 >>> +++ >> You should never include autogenerated code in a Patch. > > How d

Re: ntdll/file: Add sub-second resolution to NtQueryInformationFile

2008-09-04 Thread Francois Gouget
On Mon, 18 Aug 2008, Detlef Riekenberg wrote: > On So, 2008-08-17 at 19:03 +0200, Michael Karcher wrote: > > --- > > configure | 303 > > +++ > > You should never include autogenerated code in a Patch. How do you do that with Git? When

Re: wineboot: Basic RunOnceEx support

2008-09-04 Thread Johan Dahlin
Dmitry Timoshkov wrote: > "Johan Dahlin" <[EMAIL PROTECTED]> wrote: > >> +typedef HRESULT (*DLLREGISTER) (void); >> +typedef HRESULT (*DLLINSTALL) (BOOL,LPCWSTR); > > Wrong calling convention. I'm not sure I follow here. (This is all quite of new to me) Are you telling me that

Re: [PATCH] annotate with allocation size attribute

2008-09-04 Thread Alexandre Julliard
Marcus Meissner <[EMAIL PROTECTED]> writes: > --- a/include/windef.h > +++ b/include/windef.h > @@ -49,6 +49,12 @@ extern "C" { > #define _WIN64 > #endif > > +#if ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 3)) || (__GNUC__ > 4) > +#define ALLOC_SIZE(x) __attribute__((__alloc_size__(x))) > +#else >

Re: Adding Flawfinder to Patchwatcher

2008-09-04 Thread Kai Blin
On Sunday 31 August 2008 15:03:38 Rob Shearman wrote: > 2008/8/28 Austin English <[EMAIL PROTECTED]>: > > I had a discussion with Dan about adding Flawfinder to the > > patchwatcher. Currently, it's got some pretty generic errors, but it > > seems able to test only patches, so we wouldn't be floode

Re: Recent msi/package tests failures

2008-09-04 Thread Paul Vriens
Austin English wrote: > > FWIW, my work XP box times out on quite a few tests, but has system > restore disabled. > > -Austin > Hi Austin, Could you check something for me on your XP box? According to http://test.winehq.org/data/5e1ac66b258415a33d96bb983c7e2ec3c7eea968/xp_aenglish-xp-sp3/kern