Re: Recent msi/package tests failures

Austin English wrote: > On Tue, Sep 2, 2008 at 12:45 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: >> James Hawkins wrote: >>> On Mon, Sep 1, 2008 at 8:08 PM, James Mckenzie >>> <[EMAIL PROTECTED]> wrote: One file per run is all that should be created, IMHO. >>> No, zero log files should be creat

Re: intermittent ddraw/visual crash

2008/9/4 Dan Kegel <[EMAIL PROTECTED]>: > I'm seeing a crash occasionally in ddraw/tests/visual.c > on hardy, with a cheap PNY 8500 GT 512MB PCIe nvidia card. > (Hrm. http://www.overclockersclub.com/reviews/8500gt/11.htm > has a review that says "stay away from this one", > maybe I shouldn't have

Re: [2/2] WineD3D: Make the srgb write flag bigger

Stefan Dösinger wrote: >> You should add a note to the source about this. Or someone might change >> the >> size of this structure and the old bug will return. > That's probably a good idea > >> However the best way to fix this problem would be to pack this >> structure: >> >> #include >> struct

RE: [2/2] WineD3D: Make the srgb write flag bigger

> You should add a note to the source about this. Or someone might change > the > size of this structure and the old bug will return. That's probably a good idea > However the best way to fix this problem would be to pack this > structure: > > #include > struct ffp_settings { > ... > }; > #incl

Re: wineboot: Basic RunOnceEx support

"Johan Dahlin" <[EMAIL PROTECTED]> wrote: > +typedef HRESULT (*DLLREGISTER) (void); > +typedef HRESULT (*DLLINSTALL) (BOOL,LPCWSTR); Wrong calling convention. > +static int RunDllRegisterServer(WCHAR* strDll) > +{ > +DLLREGISTER pfRegister = NULL; > +HRESULT hr; > +

intermittent ddraw/visual crash

I'm seeing a crash occasionally in ddraw/tests/visual.c on hardy, with a cheap PNY 8500 GT 512MB PCIe nvidia card. (Hrm. http://www.overclockersclub.com/reviews/8500gt/11.htm has a review that says "stay away from this one", maybe I shouldn't have gone for the cheapest card.) Out of 200 runs, I s

Re: AcceptEx Patch set Sep.4

I have tried to make this new patch set as clean as possible. The previous set made numerous changes to many parts of the wineserver. This set attempts to only make modifications to the sock.c functions. Most of it is simply added functionality which is, in my opinion, required to have a correct im

Re: Recent msi/package tests failures

On Tue, Sep 2, 2008 at 12:45 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: >> On Mon, Sep 1, 2008 at 8:08 PM, James Mckenzie >> <[EMAIL PROTECTED]> wrote: >>> One file per run is all that should be created, IMHO. >> >> No, zero log files should be created. This discussion is ab

wineboot: Basic RunOnceEx support

Just enough to make ie6 setup work. I'm not receiving list mail, please CC me when replying. Johan diff --git a/programs/wineboot/Makefile.in b/programs/wineboot/Makefile.in index cdbab2e..3be7e22 100644 --- a/programs/wineboot/Makefile.in +++ b/programs/wineboot/Makefile.in @@ -4,7 +4,7 @@ SRCDI

Re: [2/2] WineD3D: Make the srgb write flag bigger

Stefan Dösinger wrote: > > > > Apparently gcc pads the structure size to DWORD alignment, which > leaves 3 padding bytes which trigger differences in the memset. > This fixes memory "leaks" in the fragment pipeline replaceme

RE: wined3d: fix a memory leak and a performance regression in gen_arbfp_ffp_shader

The real problems are that the ffp description structure still contains 3 uninitialized padding bytes, and that a HeapFree is missing. I'm going to send patches for those

Re: winhttp: Implement some more options.

On Wednesday 03 September 2008 16:37:48 Jacek Caban wrote: > > +static BOOL session_set_option( object_header_t *hdr, DWORD option, LPVOID > > buffer, DWORD buflen ) > > +{ > > +if (hdr->type != WINHTTP_HANDLE_TYPE_SESSION) > > +{ > > +release_object( hdr ); > > +set_last_

Re: winhttp: Implement some more options.

Hi Hans, Hans Leidekker wrote: > > +static BOOL session_set_option( object_header_t *hdr, DWORD option, LPVOID > buffer, DWORD buflen ) > +{ > +if (hdr->type != WINHTTP_HANDLE_TYPE_SESSION) > +{ > +release_object( hdr ); > +set_last_error( ERROR_WINHTTP_INCORRECT_HANDLE_

Re: wined3d: fix a memory leak and a performance regression in gen_arbfp_ffp_shader

"Jeff Zaroyko" <[EMAIL PROTECTED]> writes: > None as such since difference in performance is so large. I can say > that without a doubt using HeapAlloc and HeapFree in this function > causes noticeable delays such that in Battlefield 1942 the framerate > is falls so much that it is unplayable, ch

Re: [PATCH 4/5] wined3d: Remove glDrawBuffer calls in BltOverride.

Henri Verbeet wrote: > 2008/9/2 Alexander Dorofeyev <[EMAIL PROTECTED]>: >> I don't think this is possible yet, the variable is also used for some >> window/screen and upside-down coordinate magic. I do suspect that the code >> doing >> so may need to be fixed or removed, because it looks inconsis

Re: wined3d: fix a memory leak and a performance regression in gen_arbfp_ffp_shader

On Wed, Sep 3, 2008 at 10:25 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: > 2008/9/3 Jeff Zaroyko <[EMAIL PROTECTED]>: >> Please ignore the previous patch sent two days ago, this one fixes a >> performance regression as well as removing the memory leak. >> >> -Jeff >> > Do you have some kind of ben

Re: wined3d: fix a memory leak and a performance regression in gen_arbfp_ffp_shader

2008/9/3 Jeff Zaroyko <[EMAIL PROTECTED]>: > Please ignore the previous patch sent two days ago, this one fixes a > performance regression as well as removing the memory leak. > > -Jeff > Do you have some kind of benchmark data for this change? I don't think allocating relatively large buffers like

Re: oleaut32: Add support for loading typelibs from NE files.

2008/9/2 Huw Davies <[EMAIL PROTECTED]>: > --- a/dlls/oleaut32/typelib.c > +++ b/dlls/oleaut32/typelib.c > @@ -64,6 +64,7 @@ > #include "winnls.h" > #include "winreg.h" > #include "winuser.h" > +#include "wine/winbase16.h" > > #include "wine/unicode.h" > #include "objbase.h" I don't think we

Re: Repeated messages (was Re: Adding Flawfinder to Patchwatcher)

On Tuesday 02 September 2008 07:33, Austin English wrote: > On Sun, Aug 31, 2008 at 6:38 PM, Erik de Castro Lopo > > <[EMAIL PROTECTED]> wrote: > > Austin English wrote: > >> I had a discussion with Dan about adding Flawfinder to the > >> patchwatcher. > > > > Is anyone else getting multiple copies

Re: [9/9] gdiplus: initial GdipFlattenPath implementation

Alexandre Julliard wrote: > Nikolay Sivov <[EMAIL PROTECTED]> writes: > > >> +/* free all nodes including argument */ >> +void free_path_list(path_list_node_t *node) >> +{ >> +path_list_node_t *n = node; >> + >> +while(!n){ >> +GdipFree(node); >> +node = n = n->next; >> +

Re: ntdll: Fix a few failing tests in Vista

"James Hawkins" <[EMAIL PROTECTED]> writes: > @@ -325,13 +327,21 @@ static void read_file_test(void) > iosb.Information = 0xdeadbeef; > offset.QuadPart = strlen(text) + 2; > status = pNtReadFile( handle, event, apc, &apc_count, &iosb, buffer, 2, > &offset, NULL ); > -ok( status

Re: [9/9] gdiplus: initial GdipFlattenPath implementation

Nikolay Sivov <[EMAIL PROTECTED]> writes: > +/* free all nodes including argument */ > +void free_path_list(path_list_node_t *node) > +{ > +path_list_node_t *n = node; > + > +while(!n){ > +GdipFree(node); > +node = n = n->next; > +} This won't do what you want. -- Al

Re: [msxml3/tests 1/2] Use CreateFileA to please win98

James Hawkins wrote: > On Wed, Sep 3, 2008 at 2:54 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: >> Hi, >> >> CreateFileW is not implemented on win98. This fixes the 2 remaining test >> failures for win98. >> >> (This is a replacement for the patch James sent). >> >> Changelog >> Use CreateFileA to p

Re: [msxml3/tests 1/2] Use CreateFileA to please win98

On Wed, Sep 3, 2008 at 2:54 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > Hi, > > CreateFileW is not implemented on win98. This fixes the 2 remaining test > failures for win98. > > (This is a replacement for the patch James sent). > > Changelog > Use CreateFileA to please win98 > Just a nitpick: