Proposal: switch Wine source tree to utf-8

2008-08-29 Thread Dan Kegel
The Chinese resource files are already utf-8, but I suspect lots of other files are in obscure character sets, which complicates patch processing and display. Just how silly would it be for us to bite the bullet and set all source files to utf-8? We'd need to recode a bunch of files once, but afte

Patchwatcher offline

2008-08-29 Thread Dan Kegel
The patchwatcher robot is offline today while I move it to a faster computer and add a timeout to individual tests (since one hangs reliably on the new computer). Here's the timeout patch, if anyone's interested in doing a little prereview. I finally realized the most windows-y way of doing a time

A pat on the back for Wine community

2008-08-29 Thread Dan Kegel
http://www.anthonycargile.com/blog/?p=95 is a blog post that makes it sound like we've hit the promised land already: --- snip --- In addition to multisim 8, I have also successfully installed Microsoft Office 2003 (for the proprietary features not present in OpenOffice required by some classes, m

Re: What does patchwatcher do?

2008-08-29 Thread Dan Kegel
On Fri, Aug 29, 2008 at 1:42 PM, Rico Schüller <[EMAIL PROTECTED]> wrote: > some days ago I've send a patch which broke some other tests, see > http://www.kegel.com/wine/patchwatcher/results/274.txt . But this test got > a "conformance test ok". > I think patchwatcher should also mark patches as b

Re: msvcrt: Don't depend on the system's implementation of acos () & asin().

2008-08-29 Thread Dan Kegel
On Fri, Aug 29, 2008 at 11:15 AM, Henri Verbeet <[EMAIL PROTECTED]> wrote: > 2008/8/29 Michael Stefaniuc <[EMAIL PROTECTED]>: >> Wouldn't it make more sense to put the sane acos and asin >> implementations in libs/port and use them only if the system provided >> versions are broken? It should be po

What does patchwatcher do?

2008-08-29 Thread Rico Schüller
Hi, some days ago I've send a patch which broke some other tests, see http://www.kegel.com/wine/patchwatcher/results/274.txt . But this test got a "conformance test ok". I think patchwatcher should also mark patches as bad when they let crash other tests. Cheers Rico

Re: [4/4] gdiplus: stub for GdipFlattenPath with tests

2008-08-29 Thread Nikolay Sivov
Alexandre Julliard wrote: > Nikolay Sivov <[EMAIL PROTECTED]> writes: > > >> Sorry, start point are the same of course, I'll resend. I have a >> question about running tests programs. When I start >> gdiplus_test.exe.so from dlls/gdiplus/tests using 'wine >> gdiplus_test.exe.so' I never get non-

Re: msvcrt: Don't depend on the system's implementation of acos () & asin().

2008-08-29 Thread Henri Verbeet
2008/8/29 Michael Stefaniuc <[EMAIL PROTECTED]>: > Wouldn't it make more sense to put the sane acos and asin > implementations in libs/port and use them only if the system provided > versions are broken? It should be possible to have configure check that. > That way we can use the probably optimize

RE: Fix for rendering issues when calling GetDepthStencilSurface

2008-08-29 Thread Stefan Dösinger
> When IWineD3DDevice_GetDepthStencilSurface returns WINED3DERR_NOTFOUND > it was setting ppZStencilSurface to null. This was the cause of > rendering issues with the 3d models in spore. Can you write a test for this? I think we have some depth stencil tests in dlls/d3d9/tests/device.c which you c

Re: msvcrt: Don't depend on the system's implementation of acos () & asin().

2008-08-29 Thread Michael Stefaniuc
Henri Verbeet wrote: > 2008/8/29 Dan Kegel <[EMAIL PROTECTED]>: >> Henri wrote: >>> glibc implements acos() as the FPU equivalent of atan2(sqrt(1 - x ^ 2), x). >> I just looked, and there are several implementations of acos >> in glibc, and they all seem to very carefully choose >> how to do it bas

Re: msvcrt: Don't depend on the system's implementation of acos () & asin().

2008-08-29 Thread Dan Kegel
On Fri, Aug 29, 2008 at 7:34 AM, Henri Verbeet <[EMAIL PROTECTED]> wrote: > I tried to create an account on their bugzilla yesterday, but for > some reason I never got the confirmation mail. I'll probably try again > in a few days. http://sources.redhat.com/bugzilla/show_bug.cgi?id=2540 > looks li

Re: kernel32/winerror [try 3]: Add Russian translation

2008-08-29 Thread Vitaliy Margolen
Vladimir Pankratov wrote: > Dear Vitaliy. > You wrote: >> The character encoding is wrong. The patch using cp866 while it should be >> cp1251. > > Yes, I know. But I can't understand that: > If I using cp1251, see wrong_codepage.jpg > else cp866, see right_codepage.jpg. > > Please explain. > > T

Re: msvcrt: Don't depend on the system's implementation of acos () & asin().

2008-08-29 Thread Henri Verbeet
2008/8/29 Dan Kegel <[EMAIL PROTECTED]>: > Henri wrote: >> glibc implements acos() as the FPU equivalent of atan2(sqrt(1 - x ^ 2), x). > > I just looked, and there are several implementations of acos > in glibc, and they all seem to very carefully choose > how to do it based on how close x is to 1.

re: msvcrt: Don't depend on the system's implementation of acos () & asin().

2008-08-29 Thread Dan Kegel
Henri wrote: > glibc implements acos() as the FPU equivalent of atan2(sqrt(1 - x ^ 2), x). I just looked, and there are several implementations of acos in glibc, and they all seem to very carefully choose how to do it based on how close x is to 1. > This should be fixed on the glibc side as well

Re: [advapi32] GetNamedSecurityInfo patch

2008-08-29 Thread Nikolay Sivov
Fenixk19 wrote: > +PSECURITY_DESCRIPTOR local_descriptor; > +if(!descriptor) > + descriptor = &local_descriptor; Why do you try to return anything if a caller doesn't request it passing NULL?

Re: [4/4] gdiplus: stub for GdipFlattenPath with tests

2008-08-29 Thread Alexandre Julliard
Nikolay Sivov <[EMAIL PROTECTED]> writes: > Sorry, start point are the same of course, I'll resend. I have a > question about running tests programs. When I start > gdiplus_test.exe.so from dlls/gdiplus/tests using 'wine > gdiplus_test.exe.so' I never get non-zero number of tests 'marked as > todo

Re: Implementing textures functions of d3dx using an extern library.

2008-08-29 Thread Jérôme Gardou
Henri Verbeet a écrit : 2008/8/29 Jérôme Gardou <[EMAIL PROTECTED]>: If you want, I have an implementation of this same function for png... This one is not commented at all, and need some rework. Get it for comparison. As you said, it needs some cleanup etc, but at least it doesn't loo

Re: ntdll: modify NtDeleteFile to fail on directories (try 2)

2008-08-29 Thread Vincent Povirk
You should add a test that shows that NtDeleteFile fails in this case. Vincent Povirk On Thu, Aug 28, 2008 at 7:40 PM, Jeff Zaroyko <[EMAIL PROTECTED]> wrote: > > > > >

Re: [4/4] gdiplus: stub for GdipFlattenPath with tests

2008-08-29 Thread Nikolay Sivov
Alexandre Julliard wrote: > Nikolay Sivov <[EMAIL PROTECTED]> writes: > > >> Changelog: >> - stub for GdipFlattenPath with tests >> > > This fails here: > > ../../../tools/runtest -q -P wine -M gdiplus.dll -T ../../.. -p > gdiplus_test.exe.so graphicspath.c && touch graphicspath.ok > g

Re: [4/4] gdiplus: stub for GdipFlattenPath with tests

2008-08-29 Thread Alexandre Julliard
Nikolay Sivov <[EMAIL PROTECTED]> writes: > Changelog: > - stub for GdipFlattenPath with tests This fails here: ../../../tools/runtest -q -P wine -M gdiplus.dll -T ../../.. -p gdiplus_test.exe.so graphicspath.c && touch graphicspath.ok graphicspath.c:117: Test succeeded inside todo block: E

Re: cryptuiapi(2/2): Document definitions missing from cryptuiapi.h

2008-08-29 Thread Alexandre Julliard
"Juan Lang" <[EMAIL PROTECTED]> writes: > +/* Definitions missing from PSDK's cryptuiapi.h, but documented on MSDN. */ If they are on MSDN then it's OK to put them in the header, they will most likely end up there in a future PSDK version. -- Alexandre Julliard [EMAIL PROTECTED]

Re: Implementing textures functions of d3dx using an extern library.

2008-08-29 Thread Jérôme Gardou
Henri Verbeet a écrit : > 2008/8/29 Jérôme Gardou <[EMAIL PROTECTED]>: > >> If you want, I have an implementation of this same function for png... This >> one is not commented at all, and need some rework. Get it for comparison. >> >> > As you said, it needs some cleanup etc, but at least i

Re: Fix for rendering issues when calling GetDepthStencilSurface

2008-08-29 Thread Alexander Dorofeyev
Any reason this isn't tested? I don't know about this function in particular, but there have been games that were confused by NOT clearing output to NULL on error (not in GetDepthStencilSurface though). Also regardless of setting or not-setting to NULL, the warning may have its uses when readin

Solution to msi/install test timeouts

2008-08-29 Thread Paul Vriens
Hi, I've been experimenting on my XP and Vista boxes and the only way to make the tests run fast is by stopping 'System Restore'. It makes sense that this has a huge impact on performance, especially with the big number of installations we are doing in these tests. Could people that are curren

Re: appwiz.cpl [try 4]: Add Russian translation

2008-08-29 Thread Nikolay Sivov
Vladimir Pankratov wrote: > + CONTROL "Контактное лицо:", -1, "static", SS_LEFT | WS_CHILD | WS_VISIBLE, > 16, 53, 60, 8 Are you sure about this? This field usually contains e-mail address of support system or something like that, but not a personal contact information. Btw, how is it named in

Re: Spore patch to fix UI and Part descriptions

2008-08-29 Thread Andrew Fenn
I see what you mean now with regards to there always being a ScissorRect value. I tried testing for all kinds of invalid values but there doesn't seem to be any. Also setting ScissorRect to NULL seems to kill the program on windows rather then return invalid so I don't know what should be done in

Re: wined3d/d3d9: Set the initial scissorrect to the dimesions of the backbuffer from the first swapchain of the device

2008-08-29 Thread Andrew Fenn
This works nicely for me. Spore displays correctly now with this patch and latest git. I also tried your test case on XP and it passed. On Sun, Aug 24, 2008 at 1:09 AM, Rico Schüller <[EMAIL PROTECTED]> wrote: > Hi, > > this is the second try for this patch. I've renamed it because the previous >

Re: Recent msi/package tests failures

2008-08-29 Thread Paul Vriens
> I did all kinds of things to try and speed the tests up, to no avail. > > The following patch however seems to help: > > diff --git a/dlls/msi/tests/install.c b/dlls/msi/tests/install.c > index 40fabf8..5c7c10c 100644 > --- a/dlls/msi/tests/install.c > +++ b/dlls/msi/tests/install.c > @@ -5415,