2008/8/29 Jérôme Gardou <[EMAIL PROTECTED]>:
>
> If you want, I have an implementation of this same function for png... This
> one is not commented at all, and need some rework. Get it for comparison.
>
As you said, it needs some cleanup etc, but at least it doesn't look
fundamentally broken to me.
Henri Verbeet wrote:
> 2008/8/29 Chris Ahrendt <[EMAIL PROTECTED]>:
>> This is a patch to correct a vertex shader error that is caused by
>> an error in dlls/wined3d/drawprim.c
>>
>> In the function drawStridedSlow
>>
>> currently it only handles 4 modes with this fix it handles the 16 defined
>>
2008/8/29 Chris Ahrendt <[EMAIL PROTECTED]>:
> This is a patch to correct a vertex shader error that is caused by
> an error in dlls/wined3d/drawprim.c
>
> In the function drawStridedSlow
>
> currently it only handles 4 modes with this fix it handles the 16 defined
> nodes in the win API..
>
It's
On Thu, Aug 28, 2008 at 6:52 PM, Sergey Khodych <[EMAIL PROTECTED]> wrote:
> James Hawkins wrote:
>>
>> There are several things wrong with this patch:
>> * It's way too large. Please split it up.
>> * No tests. You need to write tests to back up these changes.
>
> Are tests necessary for simple
James Hawkins wrote:
> There are several things wrong with this patch:
> * It's way too large. Please split it up.
> * No tests. You need to write tests to back up these changes.
Are tests necessary for simple stubs? I don't know what kind of
tests can be written for stubs, except tests for wrong
I think you should avoid the GetFileAttributes call. It adds extra
steps (including potentially an extra case-insensitive lookup), and
the file attributes could change between that call and NtDeleteFile.
It seems like it should be possible to do this without forcing ntdll
to search for the file mu
On Thursday 28 August 2008 14:32:27 Darragh Bailey wrote:
>
> If it could handle working with GPG signatures, would that be a viable
> way to determine if the new patch is from the same author? I'm sure
> that most people could setup their mail clients to automatically sign
> their emails.
The pro
On Tuesday 26 August 2008 18:15:27 Markus Hitter wrote:
> Am 26.08.2008 um 16:46 schrieb Dan Kegel:
> > I updated http://wiki.winehq.org/SubmittingPatches with that info
> > (and lots more, too)
>
> The git sample commands there differ from the ones given in wiki.winehq.org/GitWine#head-
> f7a29e7
Jérôme Gardou a écrit :
Henri Verbeet a écrit :
2008/8/28 Jérôme Gardou <[EMAIL PROTECTED]>:
D3DX supports a wide range of file types for textures. Instead of
rewriting
everything from scratch, the best would certainly be to use some image
processing library to handle them. As a bonus, this
Henri Verbeet a écrit :
> 2008/8/28 Jérôme Gardou <[EMAIL PROTECTED]>:
>
>> D3DX supports a wide range of file types for textures. Instead of rewriting
>> everything from scratch, the best would certainly be to use some image
>> processing library to handle them. As a bonus, this would allow lig
2008/8/28 Jérôme Gardou <[EMAIL PROTECTED]>:
> D3DX supports a wide range of file types for textures. Instead of rewriting
> everything from scratch, the best would certainly be to use some image
> processing library to handle them. As a bonus, this would allow lighter
> code.
>
I'm not sure it wou
Juan Lang a écrit :
>> Here is an implementation of D3DXGetImageInfoFromFileInMemory using
>> FreeImage.
>>
>
> Is the license compatible? FreeImage is dual-licensed with the GPL
> (which Wine cannot use) and their own license. I'd be surprised if
> their license were LGPL compatible.
> --Ju
> Here is an implementation of D3DXGetImageInfoFromFileInMemory using
> FreeImage.
Is the license compatible? FreeImage is dual-licensed with the GPL
(which Wine cannot use) and their own license. I'd be surprised if
their license were LGPL compatible.
--Juan
Vladimir Pankratov wrote:
> Hello.
>
> Added Russian translation for winerrors.
>
> Added dlls/kernel32/nls/winerror_rus.mc file.
> Changed files:
> dlls/kernel32/kernel.rc
> dlls/kernel32/Makefile.in
>
The character encoding is wrong. The patch using cp866 while it should be
cp1251. Please cor
D3DX supports a wide range of file types for textures. Instead of
rewriting everything from scratch, the best would certainly be to use
some image processing library to handle them. As a bonus, this would
allow lighter code.
Some of those library are :
SDL_Image : easy to use, but loading an i
Hi Dan,
Some clarification...
On Wednesday 27 August 2008 23:51:02 Dan Kegel wrote:
> A few issues to consider [...]
>b) gnu tls is gpl... Does wine currently link against any GPL (as opposed
>to LGPL) libraries?
I believe the situation is slightly more complex. From memory, the core part
of
Thank you for your comments.
> I'd suggest to have an initial buffer of 64 bytes allocated on the stack,
> and allocate a larger buffer only if required. That improves performance.
lpChar and Str are referenced after XmbLookupString() or XLookupString() is
called. If both a buffer on stack and a
James Hawkins wrote:
> On Wed, Aug 27, 2008 at 2:18 PM, Paul Vriens <[EMAIL PROTECTED]> wrote:
>> James Hawkins wrote:
>>> On Wed, Aug 27, 2008 at 11:40 AM, Adam Petaccia <[EMAIL PROTECTED]>
>>> wrote:
On Wed, 2008-08-27 at 10:26 +0200, Paul Vriens wrote:
> Hi,
>
> I was looking in
On Thu, Aug 28, 2008 at 7:47 AM, Paul Millar <[EMAIL PROTECTED]> wrote:
> On Wednesday 27 August 2008 21:15:48 James Hawkins wrote:
>> That's not why the tests are failing. The install tests are timing
>> out, and if the winetest executable kills the child process that it
>> believes is 'hung', th
Hi Paul,
Ok. I will do some tests on XP and find what's wrong.
Paul Vriens a écrit :
>
> Hi Christian,
>
> Could you have a look at the test results on http://test.winehq.org
> for the d3dxof tests? They all (if run) show:
>
> d3dxof.c:84: Test failed: IDirectXFileImpl_RegisterTemplates: 8876036
>
> To be honest, you know more about this than I. I
> wasn't completely sure that it was the Right Way to go
> about things, which is why I left that warning in
> there. But if the Right Way tends to segfault, we may,
> as you say, have to live with fudging it.
>
The warning should absolutely st
On Thu, Aug 28, 2008 at 4:28 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote:
> I put this in, but next time please make sure to include the complete
> git-format-patch output, including the initial "From sha1" signature
> line.
Ouch. Then I'll need to understand how to use git :-)
Jeff Zaroyko wrote:
> Correcting the behaviour of DeleteFile also fixes Wine's
> implementation of _unlink in msvcrt, test included.
>
>
>
>
>
If the msvcrt tests succeed now you should remove the todo_wine's in this patch
On Wednesday 27 August 2008 21:15:48 James Hawkins wrote:
> That's not why the tests are failing. The install tests are timing
> out, and if the winetest executable kills the child process that it
> believes is 'hung', then you're killing the installer process midway
> through an install and thus
On Wed, Aug 27, 2008 at 08:44:05AM -0700, Dan Kegel wrote:
> It would be hard to recognize later versions of the same patch,
> even with the '(try 2)' convention, since they often get split
> and munged while being beaten into submission.
> So Patchwatcher would have to have a way for developers to
--- Roderick Colenbrander <[EMAIL PROTECTED]>
wrote:
> The proper way to emulate wglShareLists is to
> recreate a context and to use glXCopyContext to
> restore all states. glXCopyContexts is not well
> known and for that reason very buggy (the nvidia
> drivers segfault) and dri drivers only offer
"Dan Kegel" <[EMAIL PROTECTED]> writes:
> Add test showing UrlUnEscape should convert the url in place
> when URL_UNESCAPE_INPLACE is set, even if the output buffer is NULL.
> Passes on XP.
> Needed by Lively, http://bugs.winehq.org/show_bug.cgi?id=14381
>
> Changes since originally posted by Loui
Detlef Riekenberg <[EMAIL PROTECTED]> writes:
> +ULONG WINAPI
> +LHashValOfNameSys16(SYSKIND skind, LCID lcid, LPCSTR lpStr)
> +{
> +TRACE("(%d, %d, %s) %s\n", skind, lcid, debugstr_a(lpStr),
> +(skind == SYS_WIN16) ? "SYS_WIN16" : (skind == SYS_WIN32) ?
> "SYS_WIN32" : "");
> +re
Am 27.08.2008 um 11:27 schrieb Nikolay Sivov:
> Markus Hitter wrote:
>> if (!attr || !attr->ObjectName) return STATUS_INVALID_PARAMETER;
> Shouldn't this be splitted? It isn't safe to rely on evaluation order.
> Or is it a default compiler setting for us?
You know, this isn't part of the patch a
Adam Petaccia <[EMAIL PROTECTED]> writes:
> +lfw = font->lfw;
> +memcpy(&lfw, lfa, FIELD_OFFSET(LOGFONTA,lfFaceName));
> +MultiByteToWideChar(CP_ACP, 0, lfa->lfFaceName, -1, lfw.lfFaceName,
> LF_FACESIZE);
The conversion should be the other way around, lfa is the output, and
you don'
2008/8/28 Juan Lang <[EMAIL PROTECTED]>:
>> (Most of gnutls is LGPL, but eg. the OpenSSL compatibility is GPL)
>>
>> If you mean OpenSSL is GPL compatible this is wrong.
>
> No, I believe he means the portion of gnutls that is OpenSSL
> compatible is GPL. See
> http://www.gnu.org/software/gnutls/m
On Wednesday 27 August 2008 23:51:02 Dan Kegel wrote:
> b) gnu tls is gpl... Does wine currently link
> against any GPL (as opposed to LGPL) libraries?
We can't link against GPL libraries without making libwine useless. If we
could, I'd have Wine link against a good bunch of Samba libraries alre
32 matches
Mail list logo
