Re: lsb package for wine thoughts

2008-08-27 Thread Juan Lang
> (Most of gnutls is LGPL, but eg. the OpenSSL compatibility is GPL) > > If you mean OpenSSL is GPL compatible this is wrong. No, I believe he means the portion of gnutls that is OpenSSL compatible is GPL. See http://www.gnu.org/software/gnutls/manual/html_node/Compatibility-with-the-OpenSSL-libr

Re: lsb package for wine thoughts

2008-08-27 Thread Steven Edwards
On Wed, Aug 27, 2008 at 6:28 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: > For what it's worth, I've actually got part of a schannel > implementation on top of gnutls. (Most of gnutls is LGPL, but eg. the > OpenSSL compatibility is GPL) If you mean OpenSSL is GPL compatible this is wrong. It has

Re: lsb package for wine thoughts

2008-08-27 Thread Dan Kegel
On Wed, Aug 27, 2008 at 3:28 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: > For what it's worth, I've actually got part of a schannel > implementation on top of gnutls. (Most of gnutls is LGPL, but eg. the > OpenSSL compatibility is GPL) Bring it on! (Did you end up using the wrapper? It would

Re: [2/3] mshtml: Pass IID_IHTMLBodyElement to the IDispatchEx interface

2008-08-27 Thread Jacek Caban
Alistair Leslie-Hughes wrote: > Hi Jacek, >Thanks for you feedback. > > Jacek Caban wrote: >> Hi Alistair, >> >> You should add >> IHTMLDOMNode_tid, >> IHTMLDOMNode2_tid, >> IHTMLElement_tid, >> IHTMLElement2_tid, > Can you tell me what this list is for? We need to support func

Re: mpr: Improve stubs for WNetGetUniversalName.

2008-08-27 Thread James Hawkins
On Wed, Aug 27, 2008 at 5:32 PM, Sergey Khodych <[EMAIL PROTECTED]> wrote: > > From 1dec9750bed16eaeff97cf88374954d5ebde383c Mon Sep 17 00:00:00 2001 > From: Sergey Khodych <[EMAIL PROTECTED]> > Date: Thu, 28 Aug 2008 01:00:19 +0300 > Subject: mpr: Improve stubs for WNetGetUniversalName. > There a

Re: regedit 1/2: Use unicode strings when updating listview

2008-08-27 Thread Alexander Nicolaysen Sørnes
På Torsdag 28 august 2008 , 00:29:03 skrev Alexander Nicolaysen Sørnes: > Should be applied after Juan's regedit patch > > > Alexander N. Sørnes Sorry, mean't Lei's. No offence intended. :D

Re: lsb package for wine thoughts

2008-08-27 Thread Juan Lang
> Out of curiosity, why not? (I tried looking for past discussions, > didn't find them.) Perhaps I'm mistaken, so forgive me if I'm speaking out of turn. (The only discussions have been brief, and some were on IRC, so it's not surprising you can't turn them up.) Basically, the OpenSSL code was

Re: lsb package for wine thoughts

2008-08-27 Thread Henri Verbeet
2008/8/28 Juan Lang <[EMAIL PROTECTED]>: > Hi Dan, > >> One of my wild dreams is to create an LSB >> package for Wine. One of the many roadblocks >> is OpenSSL. > > The only part of Wine that currently depends on OpenSSL is wininet. > That could change if someone decides to copy that part of winin

Re: lsb package for wine thoughts

2008-08-27 Thread Dan Kegel
On Wed, Aug 27, 2008 at 3:02 PM, Juan Lang <[EMAIL PROTECTED]> wrote: > We need to implement > schannel at some point, as several apps depend on it, and I doubt > Alexandre will accept an implementation that depends on OpenSSL. Out of curiosity, why not? (I tried looking for past discussions, did

Re: winex11.drv: Hack to delete already-created destination context in wglShareLists()

2008-08-27 Thread Roderick Colenbrander
The proper way to emulate wglShareLists is to recreate a context and to use glXCopyContext to restore all states. glXCopyContexts is not well known and for that reason very buggy (the nvidia drivers segfault) and dri drivers only offer it in case of indirect rendering. I hadn't encountered a c

Re: lsb package for wine thoughts

2008-08-27 Thread Juan Lang
Hi Dan, > One of my wild dreams is to create an LSB > package for Wine. One of the many roadblocks > is OpenSSL. The only part of Wine that currently depends on OpenSSL is wininet. That could change if someone decides to copy that part of wininet to winhttp, but it shouldn't spread beyond that.

lsb package for wine thoughts

2008-08-27 Thread Dan Kegel
One of my wild dreams is to create an LSB package for Wine. One of the many roadblocks is OpenSSL. OpenSSL is not standardized, has a very fragile interface, and the openssl devs say they have no time to fix the problem. This leaves an opening for alternative crypto implementations. The way to

Re: Summer of code evaluations

2008-08-27 Thread Dylan Smith
On Tue, Aug 19, 2008 at 7:14 PM, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > I would like to request from the mentors to fill in the final evaluation > form and from the students to give a final write up: What went well? Did > you meet the goals you set? Did you have fun? Is there anything we ca

Re: [2/3] mshtml: Pass IID_IHTMLBodyElement to the IDispatchEx interface

2008-08-27 Thread Alistair Leslie-Hughes
Hi Jacek, Thanks for you feedback. Jacek Caban wrote: > Hi Alistair, > > You should add > IHTMLDOMNode_tid, > IHTMLDOMNode2_tid, > IHTMLElement_tid, > IHTMLElement2_tid, Can you tell me what this list is for? > here. > >> +static dispex_static_data_t HTMLBodyElement_dispex =

Summer of code - thank you Maarten

2008-08-27 Thread Jeremy White
Just as a complete side note, I have been very impressed at how well organized SOC has been this year, and I blame Maarten . I've really appreciated seeing the regular calls for updates, and the follow through that has resulted. Nicely done, and thank you Maarten! Cheers, Jeremy

Re: Recent msi/package tests failures

2008-08-27 Thread James Hawkins
On Wed, Aug 27, 2008 at 2:18 PM, Paul Vriens <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: >> >> On Wed, Aug 27, 2008 at 11:40 AM, Adam Petaccia <[EMAIL PROTECTED]> >> wrote: >>> >>> On Wed, 2008-08-27 at 10:26 +0200, Paul Vriens wrote: Hi, I was looking into the recent test

Re: Recent msi/package tests failures

2008-08-27 Thread Paul Vriens
James Hawkins wrote: > On Wed, Aug 27, 2008 at 11:40 AM, Adam Petaccia <[EMAIL PROTECTED]> wrote: >> On Wed, 2008-08-27 at 10:26 +0200, Paul Vriens wrote: >>> Hi, >>> >>> I was looking into the recent test failures for the msi/package tests on my >>> WinXP box. >>> >>> The reason for most of them w

Re: Recent msi/package tests failures

2008-08-27 Thread James Hawkins
On Wed, Aug 27, 2008 at 11:40 AM, Adam Petaccia <[EMAIL PROTECTED]> wrote: > On Wed, 2008-08-27 at 10:26 +0200, Paul Vriens wrote: >> Hi, >> >> I was looking into the recent test failures for the msi/package tests on my >> WinXP box. >> >> The reason for most of them was a stray MSITEST package tha

Re: improvement to patchwatcher

2008-08-27 Thread Dan Kegel
Paul Vriens <[EMAIL PROTECTED]> wrote: > Next to checking wine-devel, we could also check wine-cvs and just do a > simple compare of everything in the queue to the ones marked as committed in > wine-cvs. Or simply check the git log, which we have handy. A simple match on subject lines would probab

Re: improvement to patchwatcher

2008-08-27 Thread Paul Vriens
Alexandre Julliard wrote: > "James Hawkins" <[EMAIL PROTECTED]> writes: > >> On Tue, Aug 26, 2008 at 6:56 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: >>> Would it be difficult though to once a day do a git fetch and attempt >>> to re-apply all the known (good) patches to see if they've fail wi

Re: improvement to patchwatcher

2008-08-27 Thread Zachary Goldberg
On Wed, Aug 27, 2008 at 11:59 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > On Wed, Aug 27, 2008 at 8:54 AM, Zachary Goldberg <[EMAIL PROTECTED]> >> to simply mark any individual patch as 'already >> applied to the tree' vs not applied isn't so difficult. > > Patches gratefully accepted. The file to

Re: Recent msi/package tests failures

2008-08-27 Thread Adam Petaccia
On Wed, 2008-08-27 at 10:26 +0200, Paul Vriens wrote: > Hi, > > I was looking into the recent test failures for the msi/package tests on my > WinXP box. > > The reason for most of them was a stray MSITEST package that couldn't be > removed > via the 'Add/Remove Programs' (had to remove stuff f

Re: improvement to patchwatcher

2008-08-27 Thread Dan Kegel
On Wed, Aug 27, 2008 at 8:54 AM, Zachary Goldberg <[EMAIL PROTECTED]> > to simply mark any individual patch as 'already > applied to the tree' vs not applied isn't so difficult. Patches gratefully accepted. The file to change is http://code.google.com/p/winezeug/source/browse/trunk/patchwatcher/d

Re: improvement to patchwatcher

2008-08-27 Thread Zachary Goldberg
On Wed, Aug 27, 2008 at 11:44 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > On Wed, Aug 27, 2008 at 2:08 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: >> I think it would be quite useful. For instance it would allow sending a >> nice reminder to the author to rethink/resend their patch if it hasn'

Re: improvement to patchwatcher

2008-08-27 Thread Dan Kegel
On Wed, Aug 27, 2008 at 2:08 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > I think it would be quite useful. For instance it would allow sending a > nice reminder to the author to rethink/resend their patch if it hasn't > been applied after a week or so. It would also enable me (and other > r

Re: Winscard: Correct the declaration of SCardReleaseStartedEvent to match MSDN

2008-08-27 Thread Mounir IDRASSI
Hi, You're right: I have done a small test and MSDN is indeed wrong on the definition of this function. Sorry for my erroneous patch. -- Mounir IDRASSI IDRIX http://www.idrix.fr On Wed, August 27, 2008 4:43 am, Dmitry Timoshkov wrote: > "Mounir IDRASSI" <[EMAIL PROTECTED]> wrote: > >> This patc

Re: user32: Some changes in minimizing MDI windows (bug #1719)

2008-08-27 Thread Dmitry Timoshkov
"Ilya Shpigor" <[EMAIL PROTECTED]> wrote: These all changes need separate patches with test cases along with explanations why each of them is needed. > --- a/dlls/user32/icontitle.c > +++ b/dlls/user32/icontitle.c > @@ -217,6 +217,7 @@ LRESULT WINAPI IconTitleWndProc( HWND hWnd, UINT msg, > cas

Re: msi/automation tests on win9x

2008-08-27 Thread James Hawkins
On Wed, Aug 27, 2008 at 2:46 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > Hi, > > Every time these tests run I get a message box on win9x stating that the > service > can't be created. Makes sense as we don't have services on win9x. > > Can we skip all tests if we are on win9x (check for OpenSCMan

Re: [2/2] user32/tests: Test case for "Fixed bug in loading .cur files"

2008-08-27 Thread Paul Vriens
JIM CAMERON wrote: > The patch for cursor loading caused some existing > tests to succeed inside todo blocks. This patch > removes those todo and adds a regression test for CreateIconFromResource(). > > > > > Hi, That mea

Re: ntdll/file.c: Fix a possible NULL dereferencing.

2008-08-27 Thread Nikolay Sivov
Rob Shearman wrote: > 2008/8/27 Nikolay Sivov <[EMAIL PROTECTED]>: > >> Henri Verbeet wrote: >> >>> 2008/8/27 Nikolay Sivov <[EMAIL PROTECTED]>: >>> >>> Markus Hitter wrote: > if (!attr || !attr->ObjectName) return STATUS_INVALID_PARAMETER; > >

Re: ntdll/file.c: Fix a possible NULL dereferencing.

2008-08-27 Thread Rob Shearman
2008/8/27 Nikolay Sivov <[EMAIL PROTECTED]>: > Henri Verbeet wrote: >> 2008/8/27 Nikolay Sivov <[EMAIL PROTECTED]>: >> >>> Markus Hitter wrote: >>> if (!attr || !attr->ObjectName) return STATUS_INVALID_PARAMETER; >>> Shouldn't this be splitted? It isn't safe to rely on evaluation order. >

Re: [ntdll/tests] Fix the SystemHandleInformation tests

2008-08-27 Thread Alexandre Julliard
Paul Vriens <[EMAIL PROTECTED]> writes: > The last changes introduced an error on anything but Vista and skipped > the test for the number of handles on all platforms. This is breaking it on Vista again: info.c:411: Test failed: Unexpected ReturnLength : 32 info.c:424: Test failed: Expected STAT

Re: ntdll/file.c: Fix a possible NULL dereferencing.

2008-08-27 Thread Nikolay Sivov
Henri Verbeet wrote: > 2008/8/27 Nikolay Sivov <[EMAIL PROTECTED]>: > >> Markus Hitter wrote: >> >>> if (!attr || !attr->ObjectName) return STATUS_INVALID_PARAMETER; >>> >> Shouldn't this be splitted? It isn't safe to rely on evaluation order. >> Or is it a default compiler setting f

Re: ntdll/file.c: Fix a possible NULL dereferencing.

2008-08-27 Thread Henri Verbeet
2008/8/27 Nikolay Sivov <[EMAIL PROTECTED]>: > Markus Hitter wrote: >> if (!attr || !attr->ObjectName) return STATUS_INVALID_PARAMETER; > Shouldn't this be splitted? It isn't safe to rely on evaluation order. > Or is it a default compiler setting for us? > This is well defined in C. !attr will be e

Re: regedit: Fix concat handling for ANSI files (try2)

2008-08-27 Thread Alexandre Julliard
Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> writes: > +if(c == EOF) > fprintf(stderr,"%s: ERROR - invalid continuation.\n", > getAppName()); > + > +*s = c; > +s++; It's better, but I don't think

Re: ntdll/file.c: Allow to TRACE NtCreateFile return

2008-08-27 Thread Dmitry Timoshkov
"Markus Hitter" <[EMAIL PROTECTED]> wrote: >> We all are in the same boat. It seems you didn't get the message. > Next time, please try to speak up earlier and more clearly. Four > reviews, three patch reworks were done and about 20 messages were > written, just to find out _any_ change is n

Re: ntdll/file.c: Allow to TRACE NtCreateFile return

2008-08-27 Thread Markus Hitter
Am 27.08.2008 um 11:40 schrieb Dmitry Timoshkov: > We all are in the same boat. Next time, please try to speak up earlier and more clearly. Four reviews, three patch reworks were done and about 20 messages were written, just to find out _any_ change is not welcome. MarKus - - - - - - - -

Re: taskmgr [try 6] [1/2]: Converted some functions and variables to Unicode

2008-08-27 Thread Alexandre Julliard
Vladimir Pankratov <[EMAIL PROTECTED]> writes: > @@ -93,7 +100,7 @@ > ULONGIdx, Idx2; > HANDLEhProcess; > HANDLEhProcessToken; > -TCHARszTemp[MAX_PATH]; > +WCHAR

Re: ntdll/file.c: Allow to TRACE NtCreateFile return

2008-08-27 Thread Dmitry Timoshkov
"Markus Hitter" <[EMAIL PROTECTED]> wrote: > If you think this way, you should get rid of all the TRACE()s in this > source file. > > For me, it makes a difference, wether I can focus on file operations > or if I have to wade through gigabyte-sized (no joke) log files. We all are in the same

Re: ntdll/file.c: Allow to TRACE NtCreateFile return

2008-08-27 Thread Markus Hitter
Am 27.08.2008 um 10:14 schrieb Dmitry Timoshkov: > "Markus Hitter" <[EMAIL PROTECTED]> wrote: > >> Providing the file handle allows to map >> read/write requests to the corresponding file name. > > As pointed out by Alexander, you can use an appropriate debug > channel for that, +relay or +server

Re: ntdll/file.c: Fix a possible NULL dereferencing.

2008-08-27 Thread Nikolay Sivov
Markus Hitter wrote: > if (!attr || !attr->ObjectName) return STATUS_INVALID_PARAMETER; Shouldn't this be splitted? It isn't safe to rely on evaluation order. Or is it a default compiler setting for us?

Re: rpcrt4: Fix format specifier warning in NdrAllocate when size_t is typedef'd to unsigned long.

2008-08-27 Thread Alexandre Julliard
"Rob Shearman" <[EMAIL PROTECTED]> writes: > @@ -373,7 +373,8 @@ void * WINAPI NdrAllocate(MIDL_STUB_MESSAGE *pStubMsg, > size_t len) > /* check for overflow */ > if (adjusted_len < len) > { > -ERR("overflow of adjusted_len %d, len %d\n", adjusted_len, len); > +ERR(

Re: improvement to patchwatcher

2008-08-27 Thread Alexandre Julliard
"James Hawkins" <[EMAIL PROTECTED]> writes: > On Tue, Aug 26, 2008 at 6:56 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: >> >> Would it be difficult though to once a day do a git fetch and attempt >> to re-apply all the known (good) patches to see if they've fail with >> patch errors (==been com

Re: [3/3] mshtml: Add IHTMLBodyElement test

2008-08-27 Thread Jacek Caban
Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Add IHTMLBodyElement test > These tests should go to script.c. Also take a look at elem_type_infos table. It would help you to avoid a mistake in previous patch. Jacek

Re: [2/3] mshtml: Pass IID_IHTMLBodyElement to the IDispatchEx interface

2008-08-27 Thread Jacek Caban
Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Pass IID_IHTMLBodyElement to the IDispatchEx interface Look at other elements implementation how to do it properly. Your patch will break scripts that use body element. > +static const tid_t HTMLBodyElement_iface_tid

Recent msi/package tests failures

2008-08-27 Thread Paul Vriens
Hi, I was looking into the recent test failures for the msi/package tests on my WinXP box. The reason for most of them was a stray MSITEST package that couldn't be removed via the 'Add/Remove Programs' (had to remove stuff from the registry). Any one else seeing this? (Adam Petaccia's XP box

Re: improvement to patchwatcher

2008-08-27 Thread Henri Verbeet
2008/8/27 Zachary Goldberg <[EMAIL PROTECTED]>: > I may be remembering incorrectly, but If i recall wasn't there > developer requests for some sort of tracking mechanism to see if their > own patches had been committed? I recall some complicated discussion > about using different hashes and such a

Re: ntdll/file.c: Allow to TRACE NtCreateFile return

2008-08-27 Thread Dmitry Timoshkov
"Markus Hitter" <[EMAIL PROTECTED]> wrote: > Providing the file handle allows to map > read/write requests to the corresponding file name. As pointed out by Alexander, you can use an appropriate debug channel for that, +relay or +server. There is no need to pollute the source with additional trac

msi/automation tests on win9x

2008-08-27 Thread Paul Vriens
Hi, Every time these tests run I get a message box on win9x stating that the service can't be created. Makes sense as we don't have services on win9x. Can we skip all tests if we are on win9x (check for OpenSCManager being not implemented)? -- Cheers, Paul.