Re: advapi32:service failing tests

2008-08-26 Thread Paul Vriens
James Hawkins wrote: > Hi Paul, > > Tests you added in the following commit cause failures in NT4, 2000, > and Vista. Can you have a look please? > > commit 0539b463e65b386f4aa4c4235bf83d7f1d003e48 > Author: Paul Vriens <[EMAIL PROTECTED]> > Date: Thu Aug 21 16:14:45 2008 +0200 > > advapi

Re: Header file locations

2008-08-26 Thread John Klehm
On Tue, Aug 26, 2008 at 11:38 PM, chengas123 <[EMAIL PROTECTED]> wrote: > > Hi, > I'm new to WINE and a bit rusty with C, so forgive me if my questions are a > bit basic. > I'm having trouble finding header files. For example, take a look at > http://source.winehq.org/source/dlls/secur32/schannel.

Header file locations

2008-08-26 Thread chengas123
Hi, I'm new to WINE and a bit rusty with C, so forgive me if my questions are a bit basic. I'm having trouble finding header files. For example, take a look at http://source.winehq.org/source/dlls/secur32/schannel.c There's a line that says '#include "schannel.h"', but I'm not sure where that fi

Re: (resend)systray: keep systray hidden when requested by moving itoff screen

2008-08-26 Thread Dmitry Timoshkov
"Aric Stewart" <[EMAIL PROTECTED]> wrote: > diff --git a/programs/explorer/systray.c b/programs/explorer/systray.c > index 8b82d9a..4a7e57e 100644 > --- a/programs/explorer/systray.c > +++ b/programs/explorer/systray.c > @@ -437,6 +437,19 @@ static LRESULT WINAPI tray_wndproc( HWND hwnd, UINT msg,

Re: kernel32/winerr: Add Russian translation

2008-08-26 Thread Dmitry Timoshkov
"Vladimir Pankratov" <[EMAIL PROTECTED]> wrote: > Added Russian translation. > > Changed files: > dlls/kernel32/nls/winerr_rus.mc > dlls/kernel32/kernel.rc > dlls/kernel32/Makefile.in No one of my concerns have been addressed in this version of the patch. -- Dmitry.

Re: Winscard: Correct the declaration of SCardReleaseStartedEvent to match MSDN

2008-08-26 Thread Dmitry Timoshkov
"Mounir IDRASSI" <[EMAIL PROTECTED]> wrote: > This patch corrects the declaration of the function > SCardReleaseStartedEvent of Winscard to match its definition in MSDN found > in the following link : > > http://msdn.microsoft.com/en-us/library/aa379799(VS.85).aspx > -voidWINAPI SCardRel

Re: [Take 2] winex11.drv: Fix buffer overflow bug in X11DRV_KeyEvent()and X11DRV_ToUnicodeEx()

2008-08-26 Thread Dmitry Timoshkov
"Muneyuki Noguchi" <[EMAIL PROTECTED]> wrote: >> I'd suggest to have an initial buffer of 64 bytes allocated on the stack, >> and allocate a larger buffer only if required. That improves performance. > > lpChar and Str are referenced after XmbLookupString() or XLookupString() > is called. If both

Re: improvement to patchwatcher

2008-08-26 Thread Zachary Goldberg
On Tue, Aug 26, 2008 at 8:15 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > On Tue, Aug 26, 2008 at 5:10 PM, James Hawkins <[EMAIL PROTECTED]> wrote: >> question still stands. How is that useful at all, especially for a >> developer? > > It's of limited use, IMHO. If you care about keeping patches >

Re: improvement to patchwatcher

2008-08-26 Thread Dan Kegel
On Tue, Aug 26, 2008 at 5:10 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > question still stands. How is that useful at all, especially for a > developer? It's of limited use, IMHO. If you care about keeping patches up to date, you'll just use git or quilt or something. If you want to know when

Re: improvement to patchwatcher

2008-08-26 Thread James Hawkins
On Tue, Aug 26, 2008 at 7:03 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: > > I may be remembering incorrectly, but If i recall wasn't there > developer requests for some sort of tracking mechanism to see if their > own patches had been committed? I recall some complicated discussion > about us

Re: improvement to patchwatcher

2008-08-26 Thread Zachary Goldberg
On Tue, Aug 26, 2008 at 8:02 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > On Tue, Aug 26, 2008 at 6:56 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: >> >> Would it be difficult though to once a day do a git fetch and attempt >> to re-apply all the known (good) patches to see if they've fail wit

Re: improvement to patchwatcher

2008-08-26 Thread James Hawkins
On Tue, Aug 26, 2008 at 6:56 PM, Zachary Goldberg <[EMAIL PROTECTED]> wrote: > > Would it be difficult though to once a day do a git fetch and attempt > to re-apply all the known (good) patches to see if they've fail with > patch errors (==been committed)? That seems like it might be useful. > T

Re: improvement to patchwatcher

2008-08-26 Thread Zachary Goldberg
On Tue, Aug 26, 2008 at 4:39 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > On Tue, Aug 26, 2008 at 3:28 PM, Vijay Kiran Kamuju <[EMAIL PROTECTED]> wrote: >> Hi, >> >> Is it possible to add column to the patchwatcher, whether the patch >> has been rejected/accepted/pending into git. >> > > This is

Re: Opengl32: add a WGL_ARB_create_context / OpenGL 3.0 test

2008-08-26 Thread Chris Robinson
On Tuesday 26 August 2008 01:17:18 pm Roderick Colenbrander wrote: > +int attribs[] = {WGL_CONTEXT_MAJOR_VERSION_ARB, 3, > WGL_CONTEXT_MINOR_VERSION_ARB, 0, 0}; > +HGLRC gl3Ctx = > pwglCreateContextAttribsARB(hdc, 0, attribs); > +ok(gl3Ctx != NULL, > "Creation of an OpenGL

advapi32:service failing tests

2008-08-26 Thread James Hawkins
Hi Paul, Tests you added in the following commit cause failures in NT4, 2000, and Vista. Can you have a look please? commit 0539b463e65b386f4aa4c4235bf83d7f1d003e48 Author: Paul Vriens <[EMAIL PROTECTED]> Date: Thu Aug 21 16:14:45 2008 +0200 advapi32/tests: Add tests for EnumServicesStatu

Re: improvement to patchwatcher

2008-08-26 Thread James Hawkins
On Tue, Aug 26, 2008 at 3:28 PM, Vijay Kiran Kamuju <[EMAIL PROTECTED]> wrote: > Hi, > > Is it possible to add column to the patchwatcher, whether the patch > has been rejected/accepted/pending into git. > This is extending patchwatcher too far, and it puts an unnecessary burden on Alexandre to re

Re: improvement to patchwatcher

2008-08-26 Thread Dan Kegel
On Tue, Aug 26, 2008 at 1:28 PM, Vijay Kiran Kamuju <[EMAIL PROTECTED]> wrote: > Is it possible to add column to the patchwatcher, whether the patch > has been rejected/accepted/pending into git. Maybe. I could probably recognize cases like http://kegel.com/wine/patchwatcher/results/358.log and

improvement to patchwatcher

2008-08-26 Thread Vijay Kiran Kamuju
Hi, Is it possible to add column to the patchwatcher, whether the patch has been rejected/accepted/pending into git. Also please skip the mail entries if they do have "Re:" in the subject and do not have any patch. Mark the corresponding patch to rejected/needs more work. Thanks, VJ -

Re: [NJS#80597] Re: How should I name the Traditional Chinese resource file ?

2008-08-26 Thread Hongbo Ni
At 04:00 AM 2008-08-26, Alexandre Julliardwrote: >Hongbo Ni <[EMAIL PROTECTED]> writes: > >> 1. name it Zh_tw.rc, (but Alexandre seems not like it) >> 2. name it Tw.rc >> 3. rename all Zh.rc to Cn.rc, then name traditional as Zh.rc >> 4. just put both simplified and traditional Chinese in Zh.rc >>

Re: [3/3] d3dxof: Add basic tests.

2008-08-26 Thread Paul Vriens
Hi Christian, Could you have a look at the test results on http://test.winehq.org for the d3dxof tests? They all (if run) show: d3dxof.c:84: Test failed: IDirectXFileImpl_RegisterTemplates: 88760362 Whereas on Wine the tests succeed ! -- Cheers, Paul.

Patch workflow recommendations (was: Re: shlwapi ...)

2008-08-26 Thread Markus Hitter
Am 26.08.2008 um 16:46 schrieb Dan Kegel: > I updated http://wiki.winehq.org/SubmittingPatches with that info > (and lots more, too) The git sample commands there differ from the ones given in by the --keep-subject flag. Which one would be the better one? Citing the web page: > If your

RE: [10/10] WineX11: add a run-total fps counter to the fps debug channel

2008-08-26 Thread Stefan Dösinger
> Much more Important is the last fps report. The tests usually run for 2-3 minutes, so I think the last report isn't too important. The first report isn't crucial either, so I prefered to keep the code simple.

Re: shlwapi/tests: test UrlUnEscape inplace behavior (1/2) (try 2)

2008-08-26 Thread Dan Kegel
On Tue, Aug 26, 2008 at 6:48 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > It should be in the body of the message, in the same format as it would > have been on the original mail. > > The best way is to commit the patch to your tree with the correct > authorship information, and then send th

Re: shlwapi/tests: test UrlUnEscape inplace behavior (1/2) (try 2)

2008-08-26 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > On Tue, Aug 26, 2008 at 2:42 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: >> If you are resending a patch written by someone else you need to include >> a From: line with the complete attribution. Alternatively if you have >> made significant changes

Re: shlwapi/tests: test UrlUnEscape inplace behavior (1/2) (try 2)

2008-08-26 Thread Dan Kegel
On Tue, Aug 26, 2008 at 2:42 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > If you are resending a patch written by someone else you need to include > a From: line with the complete attribution. Alternatively if you have > made significant changes you need to add a "Based on a patch by" note i

Re: Add TRACEs to NtCreateFile returns (second try)

2008-08-26 Thread Alexandre Julliard
Markus Hitter <[EMAIL PROTECTED]> writes: > It's returned, but won't show up in the console. I thought the idea > of TRACE()s is to allow some sort of cheap printf()-style debugging > and should be complete. It can't be complete, that would make it totally unmanageable, and make the code unre

Re: [10/10] WineX11: add a run-total fps counter to the fps debug channel

2008-08-26 Thread Detlef Riekenberg
On Mo, 2008-08-25 at 09:32 -0500, Stefan Dösinger wrote: > @@ -3486,15 +3486,19 @@ BOOL X11DRV_SwapBuffers(X11DRV_PDEVICE > *physDev) >/* FPS support */ >if (TRACE_ON(fps)) >{ > - static long prev_time, frames; > + static long prev_time, start_time; > + static unsigned lo

Re: [crypt32/tests] Use CryptAcquireContextA instead of CryptAcquireContextW

2008-08-26 Thread Paul Vriens
Detlef Riekenberg wrote: > On Mo, 2008-08-25 at 22:16 +0200, Paul Vriens wrote: > >> static BOOL (WINAPI * pCryptAcquireContextA) >> (HCRYPTPROV *, LPCSTR, LPCSTR, DWORD, DWORD); >> -static BOOL (WINAPI * pCryptAcquireContextW) >> -(HCRYPTPROV *, L

Re: Add TRACEs to NtCreateFile returns (second try)

2008-08-26 Thread Markus Hitter
Am 26.08.2008 um 01:33 schrieb Juan Lang: > It seems your tolerance for reworking patches is rather low. Currently, yes. I'll have to take a breath. > -if (!attr || !attr->ObjectName) return STATUS_INVALID_PARAMETER; > +if (!attr || !attr->ObjectName) > +{ > +TRACE("returni

Re: [crypt32/tests] Use CryptAcquireContextA instead of CryptAcquireContextW

2008-08-26 Thread Detlef Riekenberg
On Mo, 2008-08-25 at 22:16 +0200, Paul Vriens wrote: > static BOOL (WINAPI * pCryptAcquireContextA) > (HCRYPTPROV *, LPCSTR, LPCSTR, DWORD, DWORD); > -static BOOL (WINAPI * pCryptAcquireContextW) > -(HCRYPTPROV *, LPCWSTR, LPCWSTR, DWORD, > DWORD);

Re: shlwapi/tests: test UrlUnEscape inplace behavior (1/2) (try 2)

2008-08-26 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > Add test showing UrlUnEscape should convert the url in place > when URL_UNESCAPE_INPLACE is set, even if the output buffer is NULL. > Passes on XP. > > Changes since originally posted by Louis Lenders as > http://www.winehq.org/pipermail/wine-patches/2008-

Re: regedit: Fix concat handling for ANSI files

2008-08-26 Thread Alexandre Julliard
Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> writes: > +do > +{ > +*s = fgetc(in); > +} while(*s == ' ' || *s == '\t'); > + > +if(*s == EOF) > fprintf(stderr,"%s: ERROR - invalid continuatio

Re: shlwapi: [PATCH 3/4] Fix results for UrlApplyScheme

2008-08-26 Thread Dmitry Timoshkov
"Detlef Riekenberg" <[EMAIL PROTECTED]> wrote: > Subject: [PATCH 2/4] shlwapi: Fix results for UrlApplyScheme This subject doesn't match the e-mail subject line, and may confuse things. > in = HeapAlloc(GetProcessHeap(), 0, > - (2*INTERNET_MAX_URL_LENGTH) * sizeof(WCHAR)); > +

Re: comdlg32: Update Japanese translation

2008-08-26 Thread Alexandre Julliard
"Muneyuki Noguchi" <[EMAIL PROTECTED]> writes: > +// > +/* Japanese neutral resources > +// > + > +LANGUAGE LANG_JAPANESE, SUBLANG_NEUTRAL You shouldn't need neutral res

Re: [2/3] d3dx9: Add d3dx9effect.h

2008-08-26 Thread Alexandre Julliard
Busquets Pérez Luis C. <[EMAIL PROTECTED]> writes: > +/*** ID3DXEffect ***/ > +STDMETHOD(GetPool)(THIS_ LPD3DXEFFECTPOOL* ppPool) PURE; > +STDMETHOD(SetTechnique)(THIS_ D3DXHANDLE hTechnique) PURE; > +STDMETHOD_(D3DXHANDLE, GetCurrentTechnique)(THIS) PURE; > +STDMETHOD(Validate

Re: [NJS#80597] Re: How should I name the Traditional Chinese resource file ?

2008-08-26 Thread Alexandre Julliard
Hongbo Ni <[EMAIL PROTECTED]> writes: > Thanks for your answer. But UTF-8 does not work for Chinese resource file. > /tools/wrc requires the Chinese strings in codepage 936(GB) or 950(big5). You have to add a #pragma codepage, look at how this is done in other files. -- Alexandre Julliard [EMAI